101879 2012-11-11 18:35:46 -0800 text-overflow:ellipsis is not applied when the block contains nested blocks 2013-03-13 02:09:47 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 phiw2 bjonesbe 7raivis bjonesbe eric esprehn+autocc hyatt mitz ojan.autocc webkit.review.bot oldest_to_newest 763964 0 phiw2 2012-11-11 18:35:46 -0800 WebKit falls back to text-overflow: clip (the default). Firefox and Opera handle this correctly. Example: 4th example in the spec; http://www.w3.org/TR/css3-ui/#text-overflow http://dev.w3.org/csswg/css3-ui/#text-overflow Sample markup <div style="text-overflow:ellipsis; overflow:hidden"> NESTED <p>PARAGRAPH</p> WON'T ELLIPSE. </div> 763966 1 173534 phiw2 2012-11-11 18:38:04 -0800 Created attachment 173534 test case from the spec Expected results: an ellipsis after the words:'nested', 'won't and 'ellipse'. Actual results: no ellipsis is shown. 832624 2 188244 bjonesbe 2013-02-13 18:03:35 -0800 Created attachment 188244 Patch Fix for bug 833160 3 188244 eric 2013-02-14 09:41:04 -0800 Comment on attachment 188244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188244&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1828 > // FIXME: CSS3 says that descendants that are clipped must also know how to truncate. This is insanely > // difficult to figure out (especially in the middle of doing layout), and is really an esoteric pile of nonsense > // anyway, so we won't worry about following the draft here. It looks like you're partially implementing this FIXME. Do we care about the multiple-nested anonymous block case? > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1830 > + bool hasTextOverflow = (style()->textOverflow() && hasOverflowClip()) > + || (isAnonymousBlock() && parent() && parent()->isRenderBlock() && parent()->style()->textOverflow() && parent()->hasOverflowClip()); Since textOverflow is the uncommon case, this will always hit the second part of the branch, but will exit quickly with the isAnonymousBlock check. I dno't think this code is super-hot, but it's on a common path. 833171 4 bjonesbe 2013-02-14 09:49:36 -0800 (In reply to comment #3) > (From update of attachment 188244 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=188244&action=review > > > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1828 > > // FIXME: CSS3 says that descendants that are clipped must also know how to truncate. This is insanely > > // difficult to figure out (especially in the middle of doing layout), and is really an esoteric pile of nonsense > > // anyway, so we won't worry about following the draft here. > > It looks like you're partially implementing this FIXME. Do we care about the multiple-nested anonymous block case? Can you explain to me when this case happens (or link to the spec that describes this behavior)? It is possible that it makes the most sense to just update the FIXME saying that it doesn't work in the multiple nested anonymous block case and file a bug for that. > > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1830 > > + bool hasTextOverflow = (style()->textOverflow() && hasOverflowClip()) > > + || (isAnonymousBlock() && parent() && parent()->isRenderBlock() && parent()->style()->textOverflow() && parent()->hasOverflowClip()); > > Since textOverflow is the uncommon case, this will always hit the second part of the branch, but will exit quickly with the isAnonymousBlock check. I dno't think this code is super-hot, but it's on a common path. I'm not sure I understand what needs to be changed here. Are you suggesting that I flip around the order of the conditions in the or expression? 838517 5 189547 bjonesbe 2013-02-21 09:40:38 -0800 Created attachment 189547 Patch Updated FIXME comment to reflect that this change fixes part of what it is referring to. 839726 6 189547 eric 2013-02-22 10:47:38 -0800 Comment on attachment 189547 Patch This seems reasonable to me. Mitz and Hyatt are CC'd and can scream if they disagree. 839742 7 189547 webkit.review.bot 2013-02-22 11:00:05 -0800 Comment on attachment 189547 Patch Clearing flags on attachment: 189547 Committed r143754: <http://trac.webkit.org/changeset/143754> 839743 8 webkit.review.bot 2013-02-22 11:00:09 -0800 All reviewed patches have been landed. Closing bug. 173534 2012-11-11 18:38:04 -0800 2012-11-11 18:38:04 -0800 test case from the spec ov-el2.html text/html 332 phiw2 PCFkb2N0eXBlIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CjxtZXRhIGNoYXJzZXQ9InV0 Zi04Ij4KPHRpdGxlPnRlc3Q6IG92ZXJmbG93OiBlbGxpcGlzPC90aXRsZT4KPHN0eWxlPgpkaXYg eyBib3JkZXI6IDFweCBzb2xpZDsgd2lkdGg6IDUwcHg7IHRleHQtb3ZlcmZsb3c6ZWxsaXBzaXM7 IG92ZXJmbG93OmhpZGRlbjsgfQo8L3N0eWxlPgo8L2hlYWQ+Cgo8Ym9keT4KCjxkaXYgc3R5bGU9 InRleHQtb3ZlcmZsb3c6ZWxsaXBzaXM7IG92ZXJmbG93OmhpZGRlbiI+IE5FU1RFRCA8cD5QQVJB R1JBUEg8L3A+IFdPTidUIEVMTElQU0UuIDwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4= 188244 2013-02-13 18:03:35 -0800 2013-02-21 09:40:36 -0800 Patch bug-101879-20130213180003.patch text/plain 5696 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyODM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRkOTU0ZjAxZjk0ZjA4 ODBjZjJjNGUzNGQ5OWI3MzVmY2IxMDQ0Zi4uZDAyMmI4MWZhNTI1Y2Y4ZTNkZTMxNjVhYzlmNDUw MTg1ZmM1ZWU3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTEzICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIHRleHQtb3ZlcmZsb3c6 ZWxsaXBzaXMgaXMgbm90IGFwcGxpZWQgd2hlbiB0aGUgYmxvY2sgY29udGFpbnMgbmVzdGVkIGJs b2NrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx ODc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2lu Y2UgdGV4dC1vdmVyZmxvdyBpcyBub3QgYW4gaW5oZXJpdGVkIHByb3BlcnR5LCB0aGUgYW5vbnlt b3VzIGJsb2NrcworICAgICAgICBkb24ndCBrbm93IHRoZXkgc2hvdWxkIGVsbGlwc2UuIFRoaXMg Y2F1c2VzIHRoZSBhbm9ueW1vdXMgYmxvY2tzCisgICAgICAgIGNyZWF0ZWQgaW4gdGhlIG5lc3Rl ZCBibG9jayBzaXR1YXRpb24gdG8gY2hlY2sgdGhlaXIgcGFyZW50IHRvIGZpbmQKKyAgICAgICAg b3V0IGlmIHRoZXkgc2hvdWxkIGVsbGlwc2UuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvdGV4 dC1vdmVyZmxvdy1lbGxpcHNpcy1hbm9ueW1vdXMtYmxvY2tzLmh0bWwKKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQmxvY2s6OmxheW91dElubGluZUNoaWxkcmVuKToKKwogMjAxMy0wMi0xMyAgS2VudGFybyBI YXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBSZW5hbWUgWFhYQWNj ZXNzb3JHZXR0ZXIoKSB0byBYWFhBdHRyR2V0dGVyQ3VzdG9tKCksCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCmluZGV4IDBlM2MwYzgx NzcwMDc4N2QxNWZkNmMzMWMzODZmYjY5NjU0YzNkYWQuLjgxMzZiMWRlMGVjYWExN2U5YmJjOTUz MWM0YTg2MTNmMDU2MjU4ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCkBAIC0xODIwLDEyICsxODIwLDE0IEBAIHZvaWQgUmVu ZGVyQmxvY2s6OmxheW91dElubGluZUNoaWxkcmVuKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgTGF5 b3V0VW5pdCYgcmVwYWluCiAgICAgaWYgKGlzRnVsbExheW91dCkKICAgICAgICAgbGluZUJveGVz KCktPmRlbGV0ZUxpbmVCb3hlcyhyZW5kZXJBcmVuYSgpKTsKIAotICAgIC8vIFRleHQgdHJ1bmNh dGlvbiBvbmx5IGtpY2tzIGluIGlmIHlvdXIgb3ZlcmZsb3cgaXNuJ3QgdmlzaWJsZSBhbmQgeW91 ciB0ZXh0LW92ZXJmbG93LW1vZGUgaXNuJ3QKLSAgICAvLyBjbGlwLgorICAgIC8vIFRleHQgdHJ1 bmNhdGlvbiBraWNrcyBpbiBpbiB0d28gY2FzZXM6CisgICAgLy8gICAgIDEpIElmIHlvdXIgb3Zl cmZsb3cgaXNuJ3QgdmlzaWJsZSBhbmQgeW91ciB0ZXh0LW92ZXJmbG93LW1vZGUgaXNuJ3QgY2xp cC4KKyAgICAvLyAgICAgMikgSWYgeW91J3JlIGFuIGFub255bW91cyBibG9jayB3aXRoIGEgYmxv Y2sgcGFyZW50IHRoYXQgc2F0aXNmaWVzICMxLgogICAgIC8vIEZJWE1FOiBDU1MzIHNheXMgdGhh dCBkZXNjZW5kYW50cyB0aGF0IGFyZSBjbGlwcGVkIG11c3QgYWxzbyBrbm93IGhvdyB0byB0cnVu Y2F0ZS4gIFRoaXMgaXMgaW5zYW5lbHkKICAgICAvLyBkaWZmaWN1bHQgdG8gZmlndXJlIG91dCAo ZXNwZWNpYWxseSBpbiB0aGUgbWlkZGxlIG9mIGRvaW5nIGxheW91dCksIGFuZCBpcyByZWFsbHkg YW4gZXNvdGVyaWMgcGlsZSBvZiBub25zZW5zZQogICAgIC8vIGFueXdheSwgc28gd2Ugd29uJ3Qg d29ycnkgYWJvdXQgZm9sbG93aW5nIHRoZSBkcmFmdCBoZXJlLgotICAgIGJvb2wgaGFzVGV4dE92 ZXJmbG93ID0gc3R5bGUoKS0+dGV4dE92ZXJmbG93KCkgJiYgaGFzT3ZlcmZsb3dDbGlwKCk7Cisg ICAgYm9vbCBoYXNUZXh0T3ZlcmZsb3cgPSAoc3R5bGUoKS0+dGV4dE92ZXJmbG93KCkgJiYgaGFz T3ZlcmZsb3dDbGlwKCkpCisgICAgICAgIHx8IChpc0Fub255bW91c0Jsb2NrKCkgJiYgcGFyZW50 KCkgJiYgcGFyZW50KCktPmlzUmVuZGVyQmxvY2soKSAmJiBwYXJlbnQoKS0+c3R5bGUoKS0+dGV4 dE92ZXJmbG93KCkgJiYgcGFyZW50KCktPmhhc092ZXJmbG93Q2xpcCgpKTsKIAogICAgIC8vIFdh bGsgYWxsIHRoZSBsaW5lcyBhbmQgZGVsZXRlIG91ciBlbGxpcHNpcyBsaW5lIGJveGVzIGlmIHRo ZXkgZXhpc3QuCiAgICAgaWYgKGhhc1RleHRPdmVyZmxvdykKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjMDE0MTk1NGE3OWY5 MmFmNzZjODczMzRiMTYxOWU4NTQ4NWY3MTdkLi5lYmRiYjgwOWI4NzQ5OTQ4OTBlYTExNjBlOTc4 YWNjN2I0YzFmMWQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDItMTMgIEJlbSBKb25l cy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAgICAgICAgdGV4dC1vdmVyZmxvdzplbGxp cHNpcyBpcyBub3QgYXBwbGllZCB3aGVuIHRoZSBibG9jayBjb250YWlucyBuZXN0ZWQgYmxvY2tz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE4NzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhl IHRlc3QgZnJvbSB0aGUgc3BlY2lmaWNhdGlvbiB0aGF0IGlzIHN1cHBsaWVkIGFzIHBhcnQgb2Yg dGhlCisgICAgICAgIGJ1Zy4KKworICAgICAgICAqIGZhc3QvY3NzL3RleHQtb3ZlcmZsb3ctZWxs aXBzaXMtYW5vbnltb3VzLWJsb2Nrcy1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L2Nzcy90ZXh0LW92ZXJmbG93LWVsbGlwc2lzLWFub255bW91cy1ibG9ja3MuaHRtbDogQWRk ZWQuCisKIDIwMTMtMDItMTMgICBWaW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNv bT4KIAogICAgICAgICBIVE1MQ29sbGVjdGlvbnMgbmFtZWRJdGVtKCkgbWV0aG9kcyBzaG91bGQg cmV0dXJuIG51bGwgdGhhbiB1bmRlZmluZWQgZm9yIGVtcHR5IGNvbGxlY3Rpb25zLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGV4dC1vdmVyZmxvdy1lbGxpcHNpcy1hbm9ueW1v dXMtYmxvY2tzLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90ZXh0LW92ZXJm bG93LWVsbGlwc2lzLWFub255bW91cy1ibG9ja3MtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4w OTZlYTgwMzczMjhkODk3OTdkMjdjMzU3ZGU5NmJkN2Y0MmQxZGYyCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGV4dC1vdmVyZmxvdy1lbGxpcHNpcy1hbm9ueW1vdXMt YmxvY2tzLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxNSBAQAorPCFkb2N0eXBlIGh0bWw+Cis8 aHRtbCBsYW5nPSJlbiI+Cis8aGVhZD4KKzxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzx0aXRsZT50 ZXN0OiBvdmVyZmxvdzogZWxsaXBpczwvdGl0bGU+Cis8c3R5bGU+CitkaXYgeyB3aWR0aDogNTBw eDsgdGV4dC1vdmVyZmxvdzplbGxpcHNpczsgb3ZlcmZsb3c6aGlkZGVuOyB9Cis8L3N0eWxlPgor PC9oZWFkPgorCis8Ym9keT4KKzxwPjxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDE4NzkiPkJ1ZyAxMDE4Nzk8L2E+OiBUaGlzIGlzIGEgdGVzdCBmcm9t IHRoZSA8YSBocmVmPSJodHRwOi8vd3d3LnczLm9yZy9UUi9jc3MzLXVpLyN0ZXh0LW92ZXJmbG93 Ij5DU1MgMyB1aSBzcGVjPC9hPiB0aGF0IGRlbW9uc3RhdGVzIHByb3BlciBiZWhhdmlvciBmb3Ig YSBuZXN0ZWQgYmxvY2sgaW5zaWRlIG9mIGEgYmxvY2sgdGhhdCBoYXMgdGV4dC1vdmVyZmxvdzog ZWxsaXBzaXMuIFRoZSBvbmx5IHN0cmluZyBiZWxvdyB0aGF0IHNob3VsZG4ndCBoYXZlIGVsbGlw ZXNlcyBpcyB0aGUgIlBBUkFHUkFQSCIgc3RyaW5nLiAoQnV0IGl0IHNob3VsZCBiZSB0cnVuY2F0 ZWQgYmVjYXVzZSBvZiBvdmVyZmxvdzogaGlkZGVuKS48L3A+Cis8ZGl2IHN0eWxlPSJib3JkZXI6 IDFweCBzb2xpZCI+IDxkaXY+TkVTVEVEPC9kaXY+IDxwPlBBUkFHUkFQSDwvcD4gPGRpdj5XT04n VDwvZGl2PiA8ZGl2PkVMTElQU0UuPC9kaXY+IDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGV4dC1vdmVyZmxvdy1lbGxpcHNpcy1hbm9u eW1vdXMtYmxvY2tzLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90ZXh0LW92ZXJmbG93LWVs bGlwc2lzLWFub255bW91cy1ibG9ja3MuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNjQ0YjE3ZTYyNGJhM2Zj MTcyMzg3NGRhNGM1OWQyNTQ0OGE0N2E4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvdGV4dC1vdmVyZmxvdy1lbGxpcHNpcy1hbm9ueW1vdXMtYmxvY2tzLmh0bWwKQEAg LTAsMCArMSwxNSBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbCBsYW5nPSJlbiI+Cis8aGVhZD4K KzxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzx0aXRsZT50ZXN0OiBvdmVyZmxvdzogZWxsaXBpczwv dGl0bGU+Cis8c3R5bGU+CitkaXYgeyB3aWR0aDogNTBweDsgdGV4dC1vdmVyZmxvdzplbGxpcHNp czsgb3ZlcmZsb3c6aGlkZGVuOyB9Cis8L3N0eWxlPgorPC9oZWFkPgorCis8Ym9keT4KKzxwPjxh IGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE4NzkiPkJ1 ZyAxMDE4Nzk8L2E+OiBUaGlzIGlzIGEgdGVzdCBmcm9tIHRoZSA8YSBocmVmPSJodHRwOi8vd3d3 LnczLm9yZy9UUi9jc3MzLXVpLyN0ZXh0LW92ZXJmbG93Ij5DU1MgMyB1aSBzcGVjPC9hPiB0aGF0 IGRlbW9uc3RhdGVzIHByb3BlciBiZWhhdmlvciBmb3IgYSBuZXN0ZWQgYmxvY2sgaW5zaWRlIG9m IGEgYmxvY2sgdGhhdCBoYXMgdGV4dC1vdmVyZmxvdzogZWxsaXBzaXMuIFRoZSBvbmx5IHN0cmlu ZyBiZWxvdyB0aGF0IHNob3VsZG4ndCBoYXZlIGVsbGlwZXNlcyBpcyB0aGUgIlBBUkFHUkFQSCIg c3RyaW5nLiAoQnV0IGl0IHNob3VsZCBiZSB0cnVuY2F0ZWQgYmVjYXVzZSBvZiBvdmVyZmxvdzog aGlkZGVuKS48L3A+Cis8ZGl2IHN0eWxlPSJib3JkZXI6IDFweCBzb2xpZCI+IE5FU1RFRCA8cD5Q QVJBR1JBUEg8L3A+IFdPTidUIEVMTElQU0UuIDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo= 189547 2013-02-21 09:40:38 -0800 2013-02-22 11:00:05 -0800 Patch bug-101879-20130221093704.patch text/plain 5836 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzNjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZlODE5NzBlYjYyYjE4 NjcxOTBjZGE3NzQwNjJiY2JjNzg0YmQ3ZS4uNDZkMjkzMWM4MjkwM2M3YmU1YjJmZjdmNjhjMWU2 ZTAwYmUyYzMzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTIxICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIHRleHQtb3ZlcmZsb3c6 ZWxsaXBzaXMgaXMgbm90IGFwcGxpZWQgd2hlbiB0aGUgYmxvY2sgY29udGFpbnMgbmVzdGVkIGJs b2NrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx ODc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2lu Y2UgdGV4dC1vdmVyZmxvdyBpcyBub3QgYW4gaW5oZXJpdGVkIHByb3BlcnR5LCB0aGUgYW5vbnlt b3VzIGJsb2NrcworICAgICAgICBkb24ndCBrbm93IHRoZXkgc2hvdWxkIGVsbGlwc2UuIFRoaXMg Y2F1c2VzIHRoZSBhbm9ueW1vdXMgYmxvY2tzCisgICAgICAgIGNyZWF0ZWQgaW4gdGhlIG5lc3Rl ZCBibG9jayBzaXR1YXRpb24gdG8gY2hlY2sgdGhlaXIgcGFyZW50IHRvIGZpbmQKKyAgICAgICAg b3V0IGlmIHRoZXkgc2hvdWxkIGVsbGlwc2UuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvdGV4 dC1vdmVyZmxvdy1lbGxpcHNpcy1hbm9ueW1vdXMtYmxvY2tzLmh0bWwKKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQmxvY2s6OmxheW91dElubGluZUNoaWxkcmVuKToKKwogMjAxMy0wMi0yMSAgWGFuIExvcGV6 ICA8eGxvcGV6QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIExheWVyRmlsdGVyUmVu ZGVyZXI6IGZpeCBpbmNsdXNpb24gb2YgVmVjdG9yLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKaW5kZXggZjk0OWI2NGQ4N2JjMDVm NGQwOGUxNjhiZTc5YmRhOTMyNTVkYmE1NC4uNzllZDJhNzZjOGIzYmMxY2U5ZTMxNjRiZGUxMGU4 YzA5OTcyN2M0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrTGluZUxheW91dC5jcHAKQEAgLTE4MzAsMTIgKzE4MzAsMTQgQEAgdm9pZCBSZW5kZXJCbG9j azo6bGF5b3V0SW5saW5lQ2hpbGRyZW4oYm9vbCByZWxheW91dENoaWxkcmVuLCBMYXlvdXRVbml0 JiByZXBhaW4KICAgICBpZiAoaXNGdWxsTGF5b3V0KQogICAgICAgICBsaW5lQm94ZXMoKS0+ZGVs ZXRlTGluZUJveGVzKHJlbmRlckFyZW5hKCkpOwogCi0gICAgLy8gVGV4dCB0cnVuY2F0aW9uIG9u bHkga2lja3MgaW4gaWYgeW91ciBvdmVyZmxvdyBpc24ndCB2aXNpYmxlIGFuZCB5b3VyIHRleHQt b3ZlcmZsb3ctbW9kZSBpc24ndAotICAgIC8vIGNsaXAuCisgICAgLy8gVGV4dCB0cnVuY2F0aW9u IGtpY2tzIGluIGluIHR3byBjYXNlczoKKyAgICAvLyAgICAgMSkgSWYgeW91ciBvdmVyZmxvdyBp c24ndCB2aXNpYmxlIGFuZCB5b3VyIHRleHQtb3ZlcmZsb3ctbW9kZSBpc24ndCBjbGlwLgorICAg IC8vICAgICAyKSBJZiB5b3UncmUgYW4gYW5vbnltb3VzIGJsb2NrIHdpdGggYSBibG9jayBwYXJl bnQgdGhhdCBzYXRpc2ZpZXMgIzEuCiAgICAgLy8gRklYTUU6IENTUzMgc2F5cyB0aGF0IGRlc2Nl bmRhbnRzIHRoYXQgYXJlIGNsaXBwZWQgbXVzdCBhbHNvIGtub3cgaG93IHRvIHRydW5jYXRlLiAg VGhpcyBpcyBpbnNhbmVseQotICAgIC8vIGRpZmZpY3VsdCB0byBmaWd1cmUgb3V0IChlc3BlY2lh bGx5IGluIHRoZSBtaWRkbGUgb2YgZG9pbmcgbGF5b3V0KSwgYW5kIGlzIHJlYWxseSBhbiBlc290 ZXJpYyBwaWxlIG9mIG5vbnNlbnNlCi0gICAgLy8gYW55d2F5LCBzbyB3ZSB3b24ndCB3b3JyeSBh Ym91dCBmb2xsb3dpbmcgdGhlIGRyYWZ0IGhlcmUuCi0gICAgYm9vbCBoYXNUZXh0T3ZlcmZsb3cg PSBzdHlsZSgpLT50ZXh0T3ZlcmZsb3coKSAmJiBoYXNPdmVyZmxvd0NsaXAoKTsKKyAgICAvLyBk aWZmaWN1bHQgdG8gZmlndXJlIG91dCBpbiBnZW5lcmFsIChlc3BlY2lhbGx5IGluIHRoZSBtaWRk bGUgb2YgZG9pbmcgbGF5b3V0KSwgc28gd2Ugb25seSBoYW5kbGUgdGhlCisgICAgLy8gc2ltcGxl IGNhc2Ugb2YgYW4gYW5vbnltb3VzIGJsb2NrIHRydW5jYXRpbmcgd2hlbiBpdCdzIHBhcmVudCBp cyBjbGlwcGVkLgorICAgIGJvb2wgaGFzVGV4dE92ZXJmbG93ID0gKHN0eWxlKCktPnRleHRPdmVy ZmxvdygpICYmIGhhc092ZXJmbG93Q2xpcCgpKQorICAgICAgICB8fCAoaXNBbm9ueW1vdXNCbG9j aygpICYmIHBhcmVudCgpICYmIHBhcmVudCgpLT5pc1JlbmRlckJsb2NrKCkgJiYgcGFyZW50KCkt PnN0eWxlKCktPnRleHRPdmVyZmxvdygpICYmIHBhcmVudCgpLT5oYXNPdmVyZmxvd0NsaXAoKSk7 CiAKICAgICAvLyBXYWxrIGFsbCB0aGUgbGluZXMgYW5kIGRlbGV0ZSBvdXIgZWxsaXBzaXMgbGlu ZSBib3hlcyBpZiB0aGV5IGV4aXN0LgogICAgIGlmIChoYXNUZXh0T3ZlcmZsb3cpCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg ODc4NDUxYjhlNThkMzQ2MWQzZjg1OTU2ZjI4Y2EyZmRlNmU2MzQxZi4uYzQwOGM2NGRlMTM5ZmIy MDU3Y2EzMWRjZjVjY2VjMGFjMzRjN2ZmNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAy LTIxICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIHRleHQt b3ZlcmZsb3c6ZWxsaXBzaXMgaXMgbm90IGFwcGxpZWQgd2hlbiB0aGUgYmxvY2sgY29udGFpbnMg bmVzdGVkIGJsb2NrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAxODc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNlIHRoZSB0ZXN0IGZyb20gdGhlIHNwZWNpZmljYXRpb24gdGhhdCBpcyBzdXBwbGll ZCBhcyBwYXJ0IG9mIHRoZQorICAgICAgICBidWcuCisKKyAgICAgICAgKiBmYXN0L2Nzcy90ZXh0 LW92ZXJmbG93LWVsbGlwc2lzLWFub255bW91cy1ibG9ja3MtZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogZmFzdC9jc3MvdGV4dC1vdmVyZmxvdy1lbGxpcHNpcy1hbm9ueW1vdXMtYmxv Y2tzLmh0bWw6IEFkZGVkLgorCiAyMDEzLTAyLTIxICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxl LmNvbT4KIAogICAgICAgICBbTmV3IE11bHRpY29sdW1uXSBBZGQgYSBwb3NpdGlvbmVkIG9iamVj dCBwYWdpbmF0aW9uIHRlc3QuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90ZXh0 LW92ZXJmbG93LWVsbGlwc2lzLWFub255bW91cy1ibG9ja3MtZXhwZWN0ZWQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvY3NzL3RleHQtb3ZlcmZsb3ctZWxsaXBzaXMtYW5vbnltb3VzLWJsb2Nrcy1l eHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA5NmVhODAzNzMyOGQ4OTc5N2QyN2MzNTdkZTk2YmQ3 ZjQyZDFkZjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90ZXh0LW92 ZXJmbG93LWVsbGlwc2lzLWFub255bW91cy1ibG9ja3MtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsx LDE1IEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorPG1ldGEg Y2hhcnNldD0idXRmLTgiPgorPHRpdGxlPnRlc3Q6IG92ZXJmbG93OiBlbGxpcGlzPC90aXRsZT4K KzxzdHlsZT4KK2RpdiB7IHdpZHRoOiA1MHB4OyB0ZXh0LW92ZXJmbG93OmVsbGlwc2lzOyBvdmVy ZmxvdzpoaWRkZW47IH0KKzwvc3R5bGU+Cis8L2hlYWQ+CisKKzxib2R5PgorPHA+PGEgaHJlZj0i aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTg3OSI+QnVnIDEwMTg3 OTwvYT46IFRoaXMgaXMgYSB0ZXN0IGZyb20gdGhlIDxhIGhyZWY9Imh0dHA6Ly93d3cudzMub3Jn L1RSL2NzczMtdWkvI3RleHQtb3ZlcmZsb3ciPkNTUyAzIHVpIHNwZWM8L2E+IHRoYXQgZGVtb25z dGF0ZXMgcHJvcGVyIGJlaGF2aW9yIGZvciBhIG5lc3RlZCBibG9jayBpbnNpZGUgb2YgYSBibG9j ayB0aGF0IGhhcyB0ZXh0LW92ZXJmbG93OiBlbGxpcHNpcy4gVGhlIG9ubHkgc3RyaW5nIGJlbG93 IHRoYXQgc2hvdWxkbid0IGhhdmUgZWxsaXBlc2VzIGlzIHRoZSAiUEFSQUdSQVBIIiBzdHJpbmcu IChCdXQgaXQgc2hvdWxkIGJlIHRydW5jYXRlZCBiZWNhdXNlIG9mIG92ZXJmbG93OiBoaWRkZW4p LjwvcD4KKzxkaXYgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIj4gPGRpdj5ORVNURUQ8L2Rpdj4g PHA+UEFSQUdSQVBIPC9wPiA8ZGl2PldPTidUPC9kaXY+IDxkaXY+RUxMSVBTRS48L2Rpdj4gPC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90 ZXh0LW92ZXJmbG93LWVsbGlwc2lzLWFub255bW91cy1ibG9ja3MuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzL3RleHQtb3ZlcmZsb3ctZWxsaXBzaXMtYW5vbnltb3VzLWJsb2Nrcy5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjI2NDRiMTdlNjI0YmEzZmMxNzIzODc0ZGE0YzU5ZDI1NDQ4YTQ3YTgKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90ZXh0LW92ZXJmbG93LWVsbGlwc2lz LWFub255bW91cy1ibG9ja3MuaHRtbApAQCAtMCwwICsxLDE1IEBACis8IWRvY3R5cGUgaHRtbD4K KzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorPG1ldGEgY2hhcnNldD0idXRmLTgiPgorPHRpdGxl PnRlc3Q6IG92ZXJmbG93OiBlbGxpcGlzPC90aXRsZT4KKzxzdHlsZT4KK2RpdiB7IHdpZHRoOiA1 MHB4OyB0ZXh0LW92ZXJmbG93OmVsbGlwc2lzOyBvdmVyZmxvdzpoaWRkZW47IH0KKzwvc3R5bGU+ Cis8L2hlYWQ+CisKKzxib2R5PgorPHA+PGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMTg3OSI+QnVnIDEwMTg3OTwvYT46IFRoaXMgaXMgYSB0ZXN0IGZy b20gdGhlIDxhIGhyZWY9Imh0dHA6Ly93d3cudzMub3JnL1RSL2NzczMtdWkvI3RleHQtb3ZlcmZs b3ciPkNTUyAzIHVpIHNwZWM8L2E+IHRoYXQgZGVtb25zdGF0ZXMgcHJvcGVyIGJlaGF2aW9yIGZv ciBhIG5lc3RlZCBibG9jayBpbnNpZGUgb2YgYSBibG9jayB0aGF0IGhhcyB0ZXh0LW92ZXJmbG93 OiBlbGxpcHNpcy4gVGhlIG9ubHkgc3RyaW5nIGJlbG93IHRoYXQgc2hvdWxkbid0IGhhdmUgZWxs aXBlc2VzIGlzIHRoZSAiUEFSQUdSQVBIIiBzdHJpbmcuIChCdXQgaXQgc2hvdWxkIGJlIHRydW5j YXRlZCBiZWNhdXNlIG9mIG92ZXJmbG93OiBoaWRkZW4pLjwvcD4KKzxkaXYgc3R5bGU9ImJvcmRl cjogMXB4IHNvbGlkIj4gTkVTVEVEIDxwPlBBUkFHUkFQSDwvcD4gV09OJ1QgRUxMSVBTRS4gPC9k aXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==