101870 2012-11-11 15:54:30 -0800 DFG register allocation should be greedy rather than round-robin 2012-11-11 18:09:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 763903 0 fpizlo 2012-11-11 15:54:30 -0800 This will simplify the code, reduce some code duplication, and possibly have some slight benefits since lower-numered registers also typically have smaller encodings. 763909 1 173522 fpizlo 2012-11-11 16:06:47 -0800 Created attachment 173522 the patch 763913 2 173522 ggaren 2012-11-11 16:10:08 -0800 Comment on attachment 173522 the patch r=me 763949 3 fpizlo 2012-11-11 18:09:02 -0800 Landed in http://trac.webkit.org/changeset/134182 173522 2012-11-11 16:06:47 -0800 2012-11-11 16:10:08 -0800 the patch greedy.patch text/plain 4317 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM0MTc1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEyLTExLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHJlZ2lzdGVyIGFsbG9jYXRpb24gc2hvdWxkIGJlIGdyZWVkeSByYXRoZXIgdGhhbiByb3Vu ZC1yb2JpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAxODcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyBzaW1wbGlmaWVzIHRoZSBjb2RlLCByZWR1Y2VzIHNvbWUgY29kZSBkdXBsaWNhdGlvbiwg YW5kIHNob3dzIHNvbWUgc2xpZ2h0CisgICAgICAgIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50cyBp biBhIGZldyBwbGFjZXMsIGxpa2VseSBkdWUgdG8gdGhlIGZhY3QgdGhhdCBsb3dlci1udW1lcmVk CisgICAgICAgIHJlZ2lzdGVycyBhbHNvIHR5cGljYWxseSBoYXZlIHNtYWxsZXIgZW5jb2Rpbmdz LgorCisgICAgICAgICogZGZnL0RGR1JlZ2lzdGVyQmFuay5oOgorICAgICAgICAoSlNDOjpERkc6 OlJlZ2lzdGVyQmFuazo6UmVnaXN0ZXJCYW5rKToKKyAgICAgICAgKEpTQzo6REZHOjpSZWdpc3Rl ckJhbms6OnRyeUFsbG9jYXRlKToKKyAgICAgICAgKEpTQzo6REZHOjpSZWdpc3RlckJhbms6OmFs bG9jYXRlKToKKyAgICAgICAgKEpTQzo6REZHOjpSZWdpc3RlckJhbms6OmFsbG9jYXRlSW50ZXJu YWwpOgorICAgICAgICAoUmVnaXN0ZXJCYW5rKToKKwogMjAxMi0xMS0xMSAgS2VuaWNoaSBJc2hp YmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV1RGU3RyaW5nOjp1dGY4KCkg c2hvdWxkIGhhdmUgYSBtb2RlIG9mIGNvbnZlcnNpb24gdG8gdXNlIHJlcGxhY2VtZW50IGNoYXJh Y3RlcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdSZWdpc3RlckJhbmsuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1JlZ2lzdGVyQmFuay5o CShyZXZpc2lvbiAxMzQxNjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1JlZ2lz dGVyQmFuay5oCSh3b3JraW5nIGNvcHkpCkBAIC03NSw3ICs3NSw2IEBAIGNsYXNzIFJlZ2lzdGVy QmFuayB7CiAKIHB1YmxpYzoKICAgICBSZWdpc3RlckJhbmsoKQotICAgICAgICA6IG1fbGFzdEFs bG9jYXRlZChOVU1fUkVHUyAtIDEpCiAgICAgewogICAgIH0KIApAQCAtODYsMTIgKzg1LDcgQEAg cHVibGljOgogICAgIHsKICAgICAgICAgVmlydHVhbFJlZ2lzdGVyIGlnbm9yZWQ7CiAgICAgICAg IAotICAgICAgICBmb3IgKHVpbnQzMl90IGkgPSBtX2xhc3RBbGxvY2F0ZWQgKyAxOyBpIDwgTlVN X1JFR1M7ICsraSkgewotICAgICAgICAgICAgaWYgKCFtX2RhdGFbaV0ubG9ja0NvdW50ICYmIG1f ZGF0YVtpXS5uYW1lID09IEludmFsaWRWaXJ0dWFsUmVnaXN0ZXIpCi0gICAgICAgICAgICAgICAg cmV0dXJuIGFsbG9jYXRlSW50ZXJuYWwoaSwgaWdub3JlZCk7Ci0gICAgICAgIH0KLSAgICAgICAg Ly8gTG9vcCBvdmVyIHRoZSByZW1haW5pbmcgZW50cmllcy4KLSAgICAgICAgZm9yICh1aW50MzJf dCBpID0gMDsgaSA8PSBtX2xhc3RBbGxvY2F0ZWQ7ICsraSkgeworICAgICAgICBmb3IgKHVpbnQz Ml90IGkgPSAwOyBpIDwgTlVNX1JFR1M7ICsraSkgewogICAgICAgICAgICAgaWYgKCFtX2RhdGFb aV0ubG9ja0NvdW50ICYmIG1fZGF0YVtpXS5uYW1lID09IEludmFsaWRWaXJ0dWFsUmVnaXN0ZXIp CiAgICAgICAgICAgICAgICAgcmV0dXJuIGFsbG9jYXRlSW50ZXJuYWwoaSwgaWdub3JlZCk7CiAg ICAgICAgIH0KQEAgLTExNSw5ICsxMDksNiBAQCBwdWJsaWM6CiAgICAgICAgIHVpbnQzMl90IGN1 cnJlbnRMb3dlc3QgPSBOVU1fUkVHUzsKICAgICAgICAgU3BpbGxIaW50IGN1cnJlbnRTcGlsbE9y ZGVyID0gU3BpbGxIaW50SW52YWxpZDsKIAotICAgICAgICAvLyBTY2FuIHRocm91Z2ggYWxsIHJl Z2lzdGVyLCBzdGFydGluZyBhdCB0aGUgbGFzdCBhbGxvY2F0ZWQgJiBsb29waW5nIGFyb3VuZC4K LSAgICAgICAgQVNTRVJUKG1fbGFzdEFsbG9jYXRlZCA8IE5VTV9SRUdTKTsKLQogICAgICAgICAv LyBUaGlzIGxvb3AgaXMgYnJva2VuIGludG8gdHdvIGhhbHZlcywgbG9vcGluZyBmcm9tIHRoZSBs YXN0IGFsbG9jYXRlZAogICAgICAgICAvLyByZWdpc3RlciAodGhlIHJlZ2lzdGVyIHJldHVybmVk IGxhc3QgdGltZSB0aGlzIG1ldGhvZCB3YXMgY2FsbGVkKSB0bwogICAgICAgICAvLyB0aGUgbWF4 aW11bSByZWdpc3RlciB2YWx1ZSwgdGhlbiBmcm9tIDAgdG8gdGhlIGxhc3QgYWxsb2NhdGVkLgpA QCAtMTI1LDcgKzExNiw3IEBAIHB1YmxpYzoKICAgICAgICAgLy8gdGhyYXNoLCBhbmQgbWluaW1p emUgdGltZSBzcGVudCBzY2FubmluZyBsb2NrZWQgcmVnaXN0ZXJzIGluIGFsbG9jYXRpb24uCiAg ICAgICAgIC8vIElmIGEgdW5sb2NrZWQgYW5kIHVubmFtZWQgcmVnaXN0ZXIgaXMgZm91bmQgcmV0 dXJuIGl0IGltbWVkaWF0ZWx5LgogICAgICAgICAvLyBPdGhlcndpc2UsIGZpbmQgdGhlIGZpcnN0 IHVubG9ja2VkIHJlZ2lzdGVyIHdpdGggdGhlIGxvd2VzdCBzcGlsbE9yZGVyLgotICAgICAgICBm b3IgKHVpbnQzMl90IGkgPSBtX2xhc3RBbGxvY2F0ZWQgKyAxOyBpIDwgTlVNX1JFR1M7ICsraSkg eworICAgICAgICBmb3IgKHVpbnQzMl90IGkgPSAwIDsgaSA8IE5VTV9SRUdTOyArK2kpIHsKICAg ICAgICAgICAgIC8vICgxKSBJZiB0aGUgY3VycmVudCByZWdpc3RlciBpcyBsb2NrZWQsIGl0IGlz IG5vdCBhIGNhbmRpZGF0ZS4KICAgICAgICAgICAgIGlmIChtX2RhdGFbaV0ubG9ja0NvdW50KQog ICAgICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMTQwLDE4ICsxMzEsNiBAQCBwdWJsaWM6CiAg ICAgICAgICAgICAgICAgY3VycmVudExvd2VzdCA9IGk7CiAgICAgICAgICAgICB9CiAgICAgICAg IH0KLSAgICAgICAgLy8gTG9vcCBvdmVyIHRoZSByZW1haW5pbmcgZW50cmllcy4KLSAgICAgICAg Zm9yICh1aW50MzJfdCBpID0gMDsgaSA8PSBtX2xhc3RBbGxvY2F0ZWQ7ICsraSkgewotICAgICAg ICAgICAgaWYgKG1fZGF0YVtpXS5sb2NrQ291bnQpCi0gICAgICAgICAgICAgICAgY29udGludWU7 Ci0gICAgICAgICAgICBTcGlsbEhpbnQgc3BpbGxPcmRlciA9IG1fZGF0YVtpXS5zcGlsbE9yZGVy OwotICAgICAgICAgICAgaWYgKHNwaWxsT3JkZXIgPT0gU3BpbGxIaW50SW52YWxpZCkKLSAgICAg ICAgICAgICAgICByZXR1cm4gYWxsb2NhdGVJbnRlcm5hbChpLCBzcGlsbE1lKTsKLSAgICAgICAg ICAgIGlmIChzcGlsbE9yZGVyIDwgY3VycmVudFNwaWxsT3JkZXIpIHsKLSAgICAgICAgICAgICAg ICBjdXJyZW50U3BpbGxPcmRlciA9IHNwaWxsT3JkZXI7Ci0gICAgICAgICAgICAgICAgY3VycmVu dExvd2VzdCA9IGk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KIAogICAgICAgICAvLyBEZWFk bG9jayBjaGVjayAtIHRoaXMgY291bGQgb25seSBvY2N1ciBpcyBhbGwgcmVnaXN0ZXJzIGFyZSBs b2NrZWQhCiAgICAgICAgIEFTU0VSVChjdXJyZW50TG93ZXN0ICE9IE5VTV9SRUdTICYmIGN1cnJl bnRTcGlsbE9yZGVyICE9IFNwaWxsSGludEludmFsaWQpOwpAQCAtMzU0LDcgKzMzMyw2IEBAIHBy aXZhdGU6CiAgICAgICAgIC8vIE1hcmsgdGhlIHJlZ2lzdGVyIGFzIGxvY2tlZCAod2l0aCBhIGxv Y2sgY291bnQgb2YgMSkuCiAgICAgICAgIG1fZGF0YVtpXS5sb2NrQ291bnQgPSAxOwogCi0gICAg ICAgIG1fbGFzdEFsbG9jYXRlZCA9IGk7CiAgICAgICAgIHJldHVybiBCYW5rSW5mbzo6dG9SZWdp c3RlcihpKTsKICAgICB9CiAKQEAgLTM3OCw4ICszNTYsNiBAQCBwcml2YXRlOgogCiAgICAgLy8g SG9sZHMgdGhlIGN1cnJlbnQgc3RhdHVzIG9mIGFsbCByZWdpc3RlcnMuCiAgICAgTWFwRW50cnkg bV9kYXRhW05VTV9SRUdTXTsKLSAgICAvLyBVc2VkIHRvIHRvIGltcGxlbWVudCBhIHNpbXBsZSBy b3VuZC1yb2JpbiBsaWtlIGFsbG9jYXRpb24gc2NoZW1lLgotICAgIHVpbnQzMl90IG1fbGFzdEFs bG9jYXRlZDsKIH07CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpERkcK