101862 2012-11-11 10:24:56 -0800 [CSSRegions] Incorrect computed height for content with region-break-before 2012-11-13 03:39:50 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 1 mihnea mihnea eric hyatt jchaffraix WebkitBugTracker webkit.review.bot oldest_to_newest 763863 0 mihnea 2012-11-11 10:24:56 -0800 When content to be flowed into an auto-height region has a -webkit-region-break-before: always, the height for the auto-height region (first in region chain) is computed incorrectly. 763875 1 173514 mihnea 2012-11-11 12:20:05 -0800 Created attachment 173514 Patch 764494 2 173514 jchaffraix 2012-11-12 09:33:25 -0800 Comment on attachment 173514 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173514&action=review r=me > LayoutTests/ChangeLog:13 > + * fast/regions/autoheight-breakbefore-wrongheight-expected.html: Added. > + * fast/regions/autoheight-breakbefore-wrongheight.html: Added. I would prefer this test to be a check-layout.js test as it would convey the intent better, on top of being faster to run. > Source/WebCore/rendering/RenderFlowThread.cpp:879 > + > + // If the current offset if greater than the break offset, bail out and skip the current region. > + if (currentRegionOffsetInFlowThread >= offsetBreakInFlowThread) { > + ++regionIter; > + break; > + } Note that if you don't change the for loop's end condition, this could also be pulled out of the loop and written: if (regionIter != m_regionList.end()) ++regionIter; The upside of that being that it is guaranteed to run (even if you refactor the inner loop), on top of being run only once instead of once per loop iteration. The downside being that it's a bit less clear so I don't have a strong preference for either form. 765370 3 173845 mihnea 2012-11-13 00:56:37 -0800 Created attachment 173845 Patch for landing 765448 4 173845 webkit.review.bot 2012-11-13 03:39:46 -0800 Comment on attachment 173845 Patch for landing Clearing flags on attachment: 173845 Committed r134395: <http://trac.webkit.org/changeset/134395> 765449 5 webkit.review.bot 2012-11-13 03:39:50 -0800 All reviewed patches have been landed. Closing bug. 173514 2012-11-11 12:20:05 -0800 2012-11-13 00:56:31 -0800 Patch 101862.patch text/plain 6932 mihnea ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNDdiOWUzLi42MTY3Nzk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTEt MTEgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTU1Jl Z2lvbnNdIEluY29ycmVjdCBjb21wdXRlZCBoZWlnaHQgZm9yIGNvbnRlbnQgd2l0aCByZWdpb24t YnJlYWstYmVmb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDE4NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgYSB0ZXN0IHNob3dpbmcgdGhhdCB3aGVuIGNvbnRlbnQgaGF2aW5nIC13ZWJraXQt cmVnaW9uLWJyZWFrLWJlZm9yZTphbHdheXMgaXMgZmxvd2VkCisgICAgICAgIGludG8gYSByZWdp b24gY2hhaW4gd2l0aCB0aGUgZmlyc3QgcmVnaW9uIGJlaW5nIGFuIGF1dG8taGVpZ2h0IHJlZ2lv biwgdGhlIGF1dG8taGVpZ2h0IHJlZ2lvbgorICAgICAgICBoYXMgYSBjb21wdXRlZCBoZWlnaHQg b2YgMCBhbmQgdGhlIGNvbnRlbnQgaXMgZmxvd2VkIGludG8gdGhlIHNlY29uZCByZWdpb24gaW4g dGhlIGNoYWluLgorCisgICAgICAgICogZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWtiZWZv cmUtd3JvbmdoZWlnaHQtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZWdp b25zL2F1dG9oZWlnaHQtYnJlYWtiZWZvcmUtd3JvbmdoZWlnaHQuaHRtbDogQWRkZWQuCisKIDIw MTItMTEtMTAgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBNdWx0aXBsZSAnJWMnIGZvcm1hdHRpbmcgb3B0aW9ucyBzaG91bGQgYWxsIGhh dmUgZWZmZWN0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2F1dG9oZWln aHQtYnJlYWtiZWZvcmUtd3JvbmdoZWlnaHQtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3JlLXdyb25naGVpZ2h0LWV4cGVjdGVkLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYjkyZDg2NwotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3Jl LXdyb25naGVpZ2h0LWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPCFkb2N0eXBlIGh0 bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHN0eWxlPgorICAgICAgICAgICAgLmdy ZWVuQm94IHsgcG9zaXRpb246IGFic29sdXRlOyB0b3A6IDIwMHB4OyBoZWlnaHQ6IDUwcHg7IHdp ZHRoOiA1MHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsgfQorICAgICAgICA8L3N0eWxlPgor ICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICAgICAgPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTg2MiI+IFtDU1NSZWdpb25z XSBJbmNvcnJlY3QgY29tcHV0ZWQgaGVpZ2h0IGZvciBjb250ZW50IHdpdGggcmVnaW9uLWJyZWFr LWJlZm9yZTwvYT4uPC9wPgorICAgICAgICA8cD5UaGUgZmxvdyBoYXMgMiByZWdpb24sIHRoZSBm aXJzdCByZWdpb24gaGFzIGhlaWdodCBhdXRvLiBUaGUgcmVnaW9uLWJyZWFrIGJlZm9yZSB0aGUg Y29udGVudCBzZXRzIHRoZSBoZWlnaHQgZm9yIHRoZSBhdXRvIGhlaWdodCByZWdpb24gdG8gMC48 L3A+CisgICAgICAgIDxwPk9uIHN1Y2Nlc3MsIHlvdSBzaG91bGQgbm90IHNlZSBhIHJlZCByZWN0 YW5nbGUgYmVsb3cuPC9wPgorICAgICAgICA8ZGl2IGNsYXNzPSJncmVlbkJveCI+PC9kaXY+Cisg ICAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25z L2F1dG9oZWlnaHQtYnJlYWtiZWZvcmUtd3JvbmdoZWlnaHQuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3JlLXdyb25naGVpZ2h0Lmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNWY3YzNmZQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3JlLXdyb25naGVp Z2h0Lmh0bWwKQEAgLTAsMCArMSwyNiBAQAorPCFkb2N0eXBlIGh0bWw+Cis8aHRtbD4KKyAgICA8 aGVhZD4KKyAgICAgICAgPHN0eWxlPgorICAgICAgICAgICAgLmZsb3dDb250ZW50U2l6ZSAgeyB3 aWR0aDogNTBweDsgaGVpZ2h0OiA1MHB4OyB9CisgICAgICAgICAgICAjYXJ0aWNsZSB7IC13ZWJr aXQtZmxvdy1pbnRvOiBmbG93OyBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsgfQorCisgICAgICAg ICAgICAucmVnaW9uIHsgLXdlYmtpdC1mbG93LWZyb206IGZsb3c7IHBvc2l0aW9uOiBhYnNvbHV0 ZTsgYmFja2dyb3VuZC1jb2xvcjogcmVkOyB9CisgICAgICAgICAgICAucmVnaW9uU2l6ZSB7IHdp ZHRoOiA1MHB4OyB9CisgICAgICAgICAgICAucmVnaW9uU2l6ZTIgeyB3aWR0aDogNTBweDsgaGVp Z2h0OiA1MHB4OyB9CisKKyAgICAgICAgICAgICNyZWdpb24xIHsgdG9wOiAxNTBweDsgfQorICAg ICAgICAgICAgI3JlZ2lvbjIgeyB0b3A6IDIwMHB4OyB9CisKKyAgICAgICAgICAgICNhcnRpY2xl IHsgLXdlYmtpdC1yZWdpb24tYnJlYWstYmVmb3JlOiBhbHdheXM7IH0KKyAgICAgICAgPC9zdHls ZT4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxwPlRlc3QgZm9yIDxhIGhyZWY9 Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE4NjIiPiBbQ1NTUmVn aW9uc10gSW5jb3JyZWN0IGNvbXB1dGVkIGhlaWdodCBmb3IgY29udGVudCB3aXRoIHJlZ2lvbi1i cmVhay1iZWZvcmU8L2E+LjwvcD4KKyAgICAgICAgPHA+VGhlIGZsb3cgaGFzIDIgcmVnaW9uLCB0 aGUgZmlyc3QgcmVnaW9uIGhhcyBoZWlnaHQgYXV0by4gVGhlIHJlZ2lvbi1icmVhayBiZWZvcmUg dGhlIGNvbnRlbnQgc2V0cyB0aGUgaGVpZ2h0IGZvciB0aGUgYXV0byBoZWlnaHQgcmVnaW9uIHRv IDAuPC9wPgorICAgICAgICA8cD5PbiBzdWNjZXNzLCB5b3Ugc2hvdWxkIG5vdCBzZWUgYSByZWQg cmVjdGFuZ2xlIGJlbG93LjwvcD4KKyAgICAgICAgPGRpdiBpZD0iYXJ0aWNsZSIgY2xhc3M9ImZs b3dDb250ZW50U2l6ZSI+PC9kaXY+CisgICAgICAgIDxkaXYgaWQ9InJlZ2lvbjEiIGNsYXNzPSJy ZWdpb24gcmVnaW9uU2l6ZSI+PC9kaXY+CisgICAgICAgIDxkaXYgaWQ9InJlZ2lvbjIiIGNsYXNz PSJyZWdpb24gcmVnaW9uU2l6ZTIiPjwvZGl2PgorICAgIDwvYm9keT4KKzwvaHRtbD4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAzYjNkMGYwLi45ODcyODMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIw MTItMTEtMTEgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAg W0NTU1JlZ2lvbnNdIEluY29ycmVjdCBjb21wdXRlZCBoZWlnaHQgZm9yIGNvbnRlbnQgd2l0aCBy ZWdpb24tYnJlYWstYmVmb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDE4NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaGVuIHByb2Nlc3NpbmcgdGhlIHJlZ2lvbiBicmVha3MgZm9yIGF1dG8taGVp Z2h0IHJlZ2lvbnMsIHdlIHNraXBwZWQgdGhlIGNhc2UKKyAgICAgICAgd2hlbiB0aGUgcmVnaW9u LWJyZWFrLWJlZm9yZSBvY2N1cnJlZCBpbiB0aGUgZmlyc3QgcmVnaW9uIGluIHRoZSBjaGFpbiB3 aGljaCB3YXMKKyAgICAgICAgYW4gYXV0by1oZWlnaHQgcmVnaW9uLiBCZWNhdXNlIG9mIHRoYXQs IHRoZSByZWdpb24gY29tcHV0ZWQgaGVpZ2h0IHdhcyBub3QgMAorICAgICAgICBhcyBpdCB3YXMg c3VwcG9zZWQgdG8gYmUsIGJ1dCByYXRoZXIgTGF5b3V0VW5pdDo6bWF4KCkgLyAyLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3JlLXdyb25naGVpZ2h0 Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckZsb3dUaHJlYWQ6OmFkZEZvcmNlZFJlZ2lvbkJyZWFrKToKKyAg ICAgICAgTWFrZSBzdXJlIHdlIHByb2Nlc3MgYWxzbyB0aGUgY2FzZSB3aGVuIHRoZSByZWdpb24t YnJlYWsgb2NjdXJzIGF0IG9mZnNldCAwIGluIHRoZSBmbG93IHRocmVhZAorICAgICAgICBhbmQg dGhlIGZpcnN0IHJlZ2lvbiBpbiBjaGFpbiBpcyBhbiBhdXRvLWhlaWdodCByZWdpb24uCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJSZWdpb246OnVwZGF0ZUxvZ2ljYWxIZWlnaHQpOgorICAgICAgICBBZGQgYW4gYXNzZXJ0IHRv IG1ha2Ugc3VyZSB0aGF0IHRoZSBjb21wdXRlZCBoZWlnaHQgZm9yIGF1dG8taGVpZ2h0IHJlZ2lv bnMgaXMgYWx3YXlzIGxlc3MgdGhhbiBMYXlvdXRVbml0OjptYXgoKSAvIDIuCisKIDIwMTItMTEt MTAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgU2F2 ZSBvbmUgY2FsbCB0byBjb250YWluZXJGb3JSZXBhaW50KCkgd2hlbiB1cGRhdGluZyBsYXllciBw b3NpdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93 VGhyZWFkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNw cAppbmRleCBjZTE4MmNkLi4xMzgwOWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRmxvd1RocmVhZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZsb3dUaHJlYWQuY3BwCkBAIC04NTYsNyArODU2LDcgQEAgYm9vbCBSZW5kZXJGbG93 VGhyZWFkOjphZGRGb3JjZWRSZWdpb25CcmVhayhMYXlvdXRVbml0IG9mZnNldEJyZWFrSW5GbG93 VGhyZWFkLAogCiAgICAgUmVuZGVyUmVnaW9uTGlzdDo6aXRlcmF0b3IgcmVnaW9uSXRlciA9IG1f cmVnaW9uTGlzdC5maW5kKHJlZ2lvbik7CiAgICAgQVNTRVJUKHJlZ2lvbkl0ZXIgIT0gbV9yZWdp b25MaXN0LmVuZCgpKTsKLSAgICBmb3IgKDsgKHJlZ2lvbkl0ZXIgIT0gbV9yZWdpb25MaXN0LmVu ZCgpKSAmJiAoY3VycmVudFJlZ2lvbk9mZnNldEluRmxvd1RocmVhZCA8IG9mZnNldEJyZWFrSW5G bG93VGhyZWFkKTsgKytyZWdpb25JdGVyKSB7CisgICAgZm9yICg7IHJlZ2lvbkl0ZXIgIT0gbV9y ZWdpb25MaXN0LmVuZCgpOyArK3JlZ2lvbkl0ZXIpIHsKICAgICAgICAgUmVuZGVyUmVnaW9uKiBy ZWdpb24gPSAqcmVnaW9uSXRlcjsKICAgICAgICAgaWYgKHJlZ2lvbi0+bmVlZHNPdmVycmlkZUxv Z2ljYWxDb250ZW50SGVpZ2h0Q29tcHV0YXRpb24oKSkgewogICAgICAgICAgICAgbWFwVG9Vc2Uu c2V0KGJyZWFrQ2hpbGQsIHJlZ2lvbik7CkBAIC04NzEsNiArODcxLDEyIEBAIGJvb2wgUmVuZGVy Rmxvd1RocmVhZDo6YWRkRm9yY2VkUmVnaW9uQnJlYWsoTGF5b3V0VW5pdCBvZmZzZXRCcmVha0lu Rmxvd1RocmVhZCwKICAgICAgICAgICAgIGN1cnJlbnRSZWdpb25PZmZzZXRJbkZsb3dUaHJlYWQg Kz0gcmVnaW9uT3ZlcnJpZGVMb2dpY2FsQ29udGVudEhlaWdodDsKICAgICAgICAgfSBlbHNlCiAg ICAgICAgICAgICBjdXJyZW50UmVnaW9uT2Zmc2V0SW5GbG93VGhyZWFkICs9IGlzSG9yaXpvbnRh bFdyaXRpbmdNb2RlKCkgPyByZWdpb24tPmZsb3dUaHJlYWRQb3J0aW9uUmVjdCgpLmhlaWdodCgp IDogcmVnaW9uLT5mbG93VGhyZWFkUG9ydGlvblJlY3QoKS53aWR0aCgpOworCisgICAgICAgIC8v IElmIHRoZSBjdXJyZW50IG9mZnNldCBpZiBncmVhdGVyIHRoYW4gdGhlIGJyZWFrIG9mZnNldCwg YmFpbCBvdXQgYW5kIHNraXAgdGhlIGN1cnJlbnQgcmVnaW9uLgorICAgICAgICBpZiAoY3VycmVu dFJlZ2lvbk9mZnNldEluRmxvd1RocmVhZCA+PSBvZmZzZXRCcmVha0luRmxvd1RocmVhZCkgewor ICAgICAgICAgICAgKytyZWdpb25JdGVyOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0K ICAgICB9CiAKICAgICAvLyBUaGUgcmVtYWluaW5nIGF1dG8gbG9naWNhbCBoZWlnaHQgcmVnaW9u cyBpbiB0aGUgY2hhaW4gdGhhdCB3ZXJlIHVuYWJsZSB0byByZWNlaXZlIGNvbnRlbnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKaW5kZXggOWVmNjQ5ZC4uY2UwYjlk NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKQEAgLTYwNyw2 ICs2MDcsNyBAQCB2b2lkIFJlbmRlclJlZ2lvbjo6dXBkYXRlTG9naWNhbEhlaWdodCgpCiAgICAg ICAgIHJldHVybjsKIAogICAgIExheW91dFVuaXQgbmV3TG9naWNhbEhlaWdodCA9IG92ZXJyaWRl TG9naWNhbENvbnRlbnRIZWlnaHQoKSArIGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCk7 CisgICAgQVNTRVJUKG5ld0xvZ2ljYWxIZWlnaHQgPCBMYXlvdXRVbml0OjptYXgoKSAvIDIpOwog ICAgIGlmIChuZXdMb2dpY2FsSGVpZ2h0ID4gbG9naWNhbEhlaWdodCgpKQogICAgICAgICBzZXRM b2dpY2FsSGVpZ2h0KG5ld0xvZ2ljYWxIZWlnaHQpOwogfQo= 173845 2012-11-13 00:56:37 -0800 2012-11-13 03:39:46 -0800 Patch for landing bug-101862-20121113105437.patch text/plain 6985 mihnea U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEzMzY5NjIwNmI1MzFk Mjk1MThmNTE2YjQwOTA2MWM4YzZkZjdlOC4uYWI2ZjdmMzkzMTBlMzRkZWFhNjAxNjliZTg2Nzky ZDFjZjJkMjgxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTExLTEzICBNaWhu ZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1NSZWdpb25zXSBJ bmNvcnJlY3QgY29tcHV0ZWQgaGVpZ2h0IGZvciBjb250ZW50IHdpdGggcmVnaW9uLWJyZWFrLWJl Zm9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx ODYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSnVsaWVuIENoYWZmcmFpeC4KKworICAgICAgICBX aGVuIHByb2Nlc3NpbmcgdGhlIHJlZ2lvbiBicmVha3MgZm9yIGF1dG8taGVpZ2h0IHJlZ2lvbnMs IHdlIHNraXBwZWQgdGhlIGNhc2UKKyAgICAgICAgd2hlbiB0aGUgcmVnaW9uLWJyZWFrLWJlZm9y ZSBvY2N1cnJlZCBpbiB0aGUgZmlyc3QgcmVnaW9uIGluIHRoZSBjaGFpbiB3aGljaCB3YXMKKyAg ICAgICAgYW4gYXV0by1oZWlnaHQgcmVnaW9uLiBCZWNhdXNlIG9mIHRoYXQsIHRoZSByZWdpb24g Y29tcHV0ZWQgaGVpZ2h0IHdhcyBub3QgMAorICAgICAgICBhcyBpdCB3YXMgc3VwcG9zZWQgdG8g YmUsIGJ1dCByYXRoZXIgTGF5b3V0VW5pdDo6bWF4KCkgLyAyLgorCisgICAgICAgIFRlc3Q6IGZh c3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3JlLXdyb25naGVpZ2h0Lmh0bWwKKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckZsb3dUaHJlYWQ6OmFkZEZvcmNlZFJlZ2lvbkJyZWFrKToKKyAgICAgICAgTWFrZSBz dXJlIHdlIHByb2Nlc3MgYWxzbyB0aGUgY2FzZSB3aGVuIHRoZSByZWdpb24tYnJlYWsgb2NjdXJz IGF0IG9mZnNldCAwIGluIHRoZSBmbG93IHRocmVhZAorICAgICAgICBhbmQgdGhlIGZpcnN0IHJl Z2lvbiBpbiBjaGFpbiBpcyBhbiBhdXRvLWhlaWdodCByZWdpb24uCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclJlZ2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJSZWdpb246OnVw ZGF0ZUxvZ2ljYWxIZWlnaHQpOgorICAgICAgICBBZGQgYW4gYXNzZXJ0IHRvIG1ha2Ugc3VyZSB0 aGF0IHRoZSBjb21wdXRlZCBoZWlnaHQgZm9yIGF1dG8taGVpZ2h0IHJlZ2lvbnMgaXMgYWx3YXlz IGxlc3MgdGhhbiBMYXlvdXRVbml0OjptYXgoKSAvIDIuCisKIDIwMTItMTEtMTIgIEpvZSBNYXNv biAgPGptYXNvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBOZXR3b3JrSm9iIHNo b3VsZCBub3QgY2hlY2sgaWYgZGF0YSBpcyByZWNlaXZlZCB3aXRoIEhFQUQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcAppbmRleCBjZTE4MmNkMDY4YmYz Mzg4Nzk5NTI5OThjMWRkNGUzMzE1OGQ0MTcyLi4xMzgwOWIwMGQ5YzFmNzVjM2YyN2U4YTBhNzM3 NTQ4M2RjYmM3MmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Rmxvd1RocmVhZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dU aHJlYWQuY3BwCkBAIC04NTYsNyArODU2LDcgQEAgYm9vbCBSZW5kZXJGbG93VGhyZWFkOjphZGRG b3JjZWRSZWdpb25CcmVhayhMYXlvdXRVbml0IG9mZnNldEJyZWFrSW5GbG93VGhyZWFkLAogCiAg ICAgUmVuZGVyUmVnaW9uTGlzdDo6aXRlcmF0b3IgcmVnaW9uSXRlciA9IG1fcmVnaW9uTGlzdC5m aW5kKHJlZ2lvbik7CiAgICAgQVNTRVJUKHJlZ2lvbkl0ZXIgIT0gbV9yZWdpb25MaXN0LmVuZCgp KTsKLSAgICBmb3IgKDsgKHJlZ2lvbkl0ZXIgIT0gbV9yZWdpb25MaXN0LmVuZCgpKSAmJiAoY3Vy cmVudFJlZ2lvbk9mZnNldEluRmxvd1RocmVhZCA8IG9mZnNldEJyZWFrSW5GbG93VGhyZWFkKTsg KytyZWdpb25JdGVyKSB7CisgICAgZm9yICg7IHJlZ2lvbkl0ZXIgIT0gbV9yZWdpb25MaXN0LmVu ZCgpOyArK3JlZ2lvbkl0ZXIpIHsKICAgICAgICAgUmVuZGVyUmVnaW9uKiByZWdpb24gPSAqcmVn aW9uSXRlcjsKICAgICAgICAgaWYgKHJlZ2lvbi0+bmVlZHNPdmVycmlkZUxvZ2ljYWxDb250ZW50 SGVpZ2h0Q29tcHV0YXRpb24oKSkgewogICAgICAgICAgICAgbWFwVG9Vc2Uuc2V0KGJyZWFrQ2hp bGQsIHJlZ2lvbik7CkBAIC04NzEsNiArODcxLDEyIEBAIGJvb2wgUmVuZGVyRmxvd1RocmVhZDo6 YWRkRm9yY2VkUmVnaW9uQnJlYWsoTGF5b3V0VW5pdCBvZmZzZXRCcmVha0luRmxvd1RocmVhZCwK ICAgICAgICAgICAgIGN1cnJlbnRSZWdpb25PZmZzZXRJbkZsb3dUaHJlYWQgKz0gcmVnaW9uT3Zl cnJpZGVMb2dpY2FsQ29udGVudEhlaWdodDsKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBj dXJyZW50UmVnaW9uT2Zmc2V0SW5GbG93VGhyZWFkICs9IGlzSG9yaXpvbnRhbFdyaXRpbmdNb2Rl KCkgPyByZWdpb24tPmZsb3dUaHJlYWRQb3J0aW9uUmVjdCgpLmhlaWdodCgpIDogcmVnaW9uLT5m bG93VGhyZWFkUG9ydGlvblJlY3QoKS53aWR0aCgpOworCisgICAgICAgIC8vIElmIHRoZSBjdXJy ZW50IG9mZnNldCBpZiBncmVhdGVyIHRoYW4gdGhlIGJyZWFrIG9mZnNldCwgYmFpbCBvdXQgYW5k IHNraXAgdGhlIGN1cnJlbnQgcmVnaW9uLgorICAgICAgICBpZiAoY3VycmVudFJlZ2lvbk9mZnNl dEluRmxvd1RocmVhZCA+PSBvZmZzZXRCcmVha0luRmxvd1RocmVhZCkgeworICAgICAgICAgICAg KytyZWdpb25JdGVyOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KICAgICB9CiAKICAg ICAvLyBUaGUgcmVtYWluaW5nIGF1dG8gbG9naWNhbCBoZWlnaHQgcmVnaW9ucyBpbiB0aGUgY2hh aW4gdGhhdCB3ZXJlIHVuYWJsZSB0byByZWNlaXZlIGNvbnRlbnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKaW5kZXggYTU5Y2JhMzU0MDRiYTk5YzU3OTRkYjQ4MDll ZjlmMDVlNzJhYzhmMi4uNzUzYTUzY2U0YzE1MmNmOGE1MDdhZGU3MWY0MTZiNzg0NDE5Zjk4NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKQEAgLTYzMSw2ICs2 MzEsNyBAQCB2b2lkIFJlbmRlclJlZ2lvbjo6dXBkYXRlTG9naWNhbEhlaWdodCgpCiAgICAgICAg IHJldHVybjsKIAogICAgIExheW91dFVuaXQgbmV3TG9naWNhbEhlaWdodCA9IG92ZXJyaWRlTG9n aWNhbENvbnRlbnRIZWlnaHQoKSArIGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCk7Cisg ICAgQVNTRVJUKG5ld0xvZ2ljYWxIZWlnaHQgPCBMYXlvdXRVbml0OjptYXgoKSAvIDIpOwogICAg IGlmIChuZXdMb2dpY2FsSGVpZ2h0ID4gbG9naWNhbEhlaWdodCgpKQogICAgICAgICBzZXRMb2dp Y2FsSGVpZ2h0KG5ld0xvZ2ljYWxIZWlnaHQpOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJmMzRiZTQ4NDcyZDNiMzYz ZDIxMDU4ODU5MTcxOWU2MzVjZjMwODQuLjNjOTNkMDQzOGM3MmNkN2E5ZmFmOTIzNTA0NDZjZTk5 ZjdjNzZmZTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMS0xMyAgTWlobmVhIE92aWRl bmllICA8bWlobmVhQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTUmVnaW9uc10gSW5jb3JyZWN0 IGNvbXB1dGVkIGhlaWdodCBmb3IgY29udGVudCB3aXRoIHJlZ2lvbi1icmVhay1iZWZvcmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTg2MgorCisg ICAgICAgIFJldmlld2VkIGJ5IEp1bGllbiBDaGFmZnJhaXguCisKKyAgICAgICAgQWRkIGEgdGVz dCBzaG93aW5nIHRoYXQgd2hlbiBjb250ZW50IGhhdmluZyAtd2Via2l0LXJlZ2lvbi1icmVhay1i ZWZvcmU6YWx3YXlzIGlzIGZsb3dlZAorICAgICAgICBpbnRvIGEgcmVnaW9uIGNoYWluIHdpdGgg dGhlIGZpcnN0IHJlZ2lvbiBiZWluZyBhbiBhdXRvLWhlaWdodCByZWdpb24sIHRoZSBhdXRvLWhl aWdodCByZWdpb24KKyAgICAgICAgaGFzIGEgY29tcHV0ZWQgaGVpZ2h0IG9mIDAgYW5kIHRoZSBj b250ZW50IGlzIGZsb3dlZCBpbnRvIHRoZSBzZWNvbmQgcmVnaW9uIGluIHRoZSBjaGFpbi4KKwor ICAgICAgICAqIGZhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3JlLXdyb25naGVpZ2h0 LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQt YnJlYWtiZWZvcmUtd3JvbmdoZWlnaHQuaHRtbDogQWRkZWQuCisKIDIwMTItMTEtMTAgIERpcmsg U2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9yZz4KIAogICAgICAgICBCYXNpY1NoYXBlcyAnY2lyY2xl JywgJ3JlY3RhbmdsZScsICdlbGxpcHNlJyBzaG91bGQgYmUgYW5pbWF0YWJsZSB3aXRoIHRoZW1z ZWx2ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRvaGVpZ2h0LWJy ZWFrYmVmb3JlLXdyb25naGVpZ2h0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvcmVn aW9ucy9hdXRvaGVpZ2h0LWJyZWFrYmVmb3JlLXdyb25naGVpZ2h0LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi43MmYxNDRiYmI4NmYzYzIyYTdmNjk2ZTBmZjI1Mzg1ZmI1YmQ0ZjVlCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWtiZWZv cmUtd3JvbmdoZWlnaHQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNiBAQAorVGVzdCBmb3IgW0NT U1JlZ2lvbnNdIEluY29ycmVjdCBjb21wdXRlZCBoZWlnaHQgZm9yIGNvbnRlbnQgd2l0aCByZWdp b24tYnJlYWstYmVmb3JlLgorCitUaGUgZmxvdyBoYXMgdHdvIHJlZ2lvbnMsIHRoZSBmaXJzdCBy ZWdpb24gaGFzIGhlaWdodCBhdXRvLiBUaGUgcmVnaW9uLWJyZWFrIGJlZm9yZSB0aGUgY29udGVu dCBzaG91bGQgc2V0IHRoZSBoZWlnaHQgZm9yIHRoZSBhdXRvIGhlaWdodCByZWdpb24gdG8gMC4K KworUEFTUworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYXV0b2hlaWdo dC1icmVha2JlZm9yZS13cm9uZ2hlaWdodC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25z L2F1dG9oZWlnaHQtYnJlYWtiZWZvcmUtd3JvbmdoZWlnaHQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iZDgx NTg4ODZiNDJhNmUzODRmMTBmMmRlNjIyNTgzZWQzNWJkMjEzCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2F1dG9oZWlnaHQtYnJlYWtiZWZvcmUtd3JvbmdoZWln aHQuaHRtbApAQCAtMCwwICsxLDIzIEBACis8IWRvY3R5cGUgaHRtbD4KKzxodG1sPgorICAgIDxo ZWFkPgorICAgICAgICA8c3R5bGU+CisgICAgICAgICAgICAuZmxvd0NvbnRlbnRTaXplICB7IHdp ZHRoOiA1MHB4OyBoZWlnaHQ6IDUwcHg7IH0KKyAgICAgICAgICAgICNhcnRpY2xlIHsgLXdlYmtp dC1mbG93LWludG86IGZsb3c7IGJhY2tncm91bmQtY29sb3I6IGdyZWVuOyB9CisKKyAgICAgICAg ICAgIC5yZWdpb24geyAtd2Via2l0LWZsb3ctZnJvbTogZmxvdzsgcG9zaXRpb246IGFic29sdXRl OyBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7IH0KKyAgICAgICAgICAgIC5yZWdpb25TaXplIHsgd2lk dGg6IDUwcHg7IG1heC1oZWlnaHQ6IDUwcHg7IHRvcDogMjAwcHg7IH0KKyAgICAgICAgICAgIC5y ZWdpb25TaXplMiB7IHdpZHRoOiA1MHB4OyBoZWlnaHQ6IDUwcHg7IHRvcDogMjAwcHg7IGxlZnQ6 IDEwMHB4OyB9CisKKyAgICAgICAgICAgICNhcnRpY2xlIHsgLXdlYmtpdC1yZWdpb24tYnJlYWst YmVmb3JlOiBhbHdheXM7IH0KKyAgICAgICAgPC9zdHlsZT4KKyAgICA8L2hlYWQ+CisgICAgPHNj cmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9jaGVjay1sYXlvdXQuanMiPjwvc2NyaXB0PgorICAg IDxib2R5IG9ubG9hZD0iY2hlY2tMYXlvdXQoJyNyZWdpb25aZXJvSGVpZ2h0JykiPgorICAgICAg ICA8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAxODYyIj4gW0NTU1JlZ2lvbnNdIEluY29ycmVjdCBjb21wdXRlZCBoZWlnaHQgZm9y IGNvbnRlbnQgd2l0aCByZWdpb24tYnJlYWstYmVmb3JlPC9hPi48L3A+CisgICAgICAgIDxwPlRo ZSBmbG93IGhhcyB0d28gcmVnaW9ucywgdGhlIGZpcnN0IHJlZ2lvbiBoYXMgaGVpZ2h0IGF1dG8u IFRoZSByZWdpb24tYnJlYWsgYmVmb3JlIHRoZSBjb250ZW50IHNob3VsZCBzZXQgdGhlIGhlaWdo dCBmb3IgdGhlIGF1dG8gaGVpZ2h0IHJlZ2lvbiB0byAwLjwvcD4KKyAgICAgICAgPGRpdiBpZD0i YXJ0aWNsZSIgY2xhc3M9ImZsb3dDb250ZW50U2l6ZSI+PC9kaXY+CisgICAgICAgIDxkaXYgaWQ9 InJlZ2lvblplcm9IZWlnaHQiIGNsYXNzPSJyZWdpb24gcmVnaW9uU2l6ZSIgZGF0YS1leHBlY3Rl ZC1oZWlnaHQ9MD48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0icmVnaW9uIHJlZ2lvblNpemUy Ij48L2Rpdj4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==