101836 2012-11-10 05:14:37 -0800 [Qt] Flash-plugin starts with wrong width 2012-11-12 06:33:58 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abecsi webkit.review.bot oldest_to_newest 763634 0 allan.jensen 2012-11-10 05:14:37 -0800 On a number of pages, flash videos start with wrong width. For instance on videos on thatguywiththeglasses.com videos start with correct height but a width of 300px, where it is supposed to be 640px. The problem seems to be that for some reason initial width is 300px, and we do not allow resize events. Fortunately this specific problem can be solved by postponing the first setWindow call when we disallow setting it more than once. 763640 1 173449 allan.jensen 2012-11-10 06:05:05 -0800 Created attachment 173449 Patch 763641 2 webkit.review.bot 2012-11-10 06:10:11 -0800 Attachment 173449 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 764158 3 173589 allan.jensen 2012-11-12 01:56:39 -0800 Created attachment 173589 Patch 764353 4 173589 webkit.review.bot 2012-11-12 06:33:55 -0800 Comment on attachment 173589 Patch Clearing flags on attachment: 173589 Committed r134222: <http://trac.webkit.org/changeset/134222> 764354 5 webkit.review.bot 2012-11-12 06:33:58 -0800 All reviewed patches have been landed. Closing bug. 173449 2012-11-10 06:05:05 -0800 2012-11-12 01:56:36 -0800 Patch Patch text/plain 1416 allan.jensen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZw0KaW5kZXggOWUwZjcwYS4uZDE2NzBmMCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZw0KKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQpAQCAtMSwzICsx LDE1IEBADQorMjAxMi0xMS0xMCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8c2FuZGZlbGRAa2Rl Lm9yZz4NCisNCisJW1F0XSBGbGFzaC1wbHVnaW4gc3RhcnRzIHdpdGggd3Jvbmcgd2lkdGgNCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE4MzYNCisN CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgRGVmZXIg dGhlIHNldFdpbmRvdyBjYWxsLCBzbyB0aGF0IHRoZSBvbmUgdGltZSBpdCBpcyBjYWxsZWQgaXQg d2lsbCBoYXZlIGl0cyBmaW5hbCBzaXplLg0KKw0KKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblBh Y2thZ2UuY3BwOg0KKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1 aXJrcyk6DQorDQogMjAxMi0xMS0wNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPg0K IA0KICAgICAgICAgW1Y4XSBXZSBzaG91bGQgaGlkZSB0aGUgRE9NV3JhcHBlck1hcHMgaW5zaWRl IERPTURhdGFTdG9yZQ0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2lu UGFja2FnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwDQpp bmRleCBmZmNlNzZkLi43OGU4YmRiIDEwMDY0NA0KLS0tIGEvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5QYWNrYWdlLmNwcA0KKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5Q YWNrYWdlLmNwcA0KQEAgLTIwNSw3ICsyMDUsOSBAQCB2b2lkIFBsdWdpblBhY2thZ2U6OmRldGVy bWluZVF1aXJrcyhjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQ0KICAgICAgICAgfQ0KIA0KICNpZiBQ TEFURk9STShRVCkNCi0gICAgICAgIC8vIEZsYXNoIHdpbGwgY3Jhc2ggb24gcmVwZWF0ZWQgY2Fs bHMgdG8gU2V0V2luZG93IGluIHdpbmRvd2VkIG1vZGUNCisgICAgICAgIC8vIEZsYXNoIHdpbGwg Y3Jhc2ggb24gcmVwZWF0ZWQgY2FsbHMgdG8gU2V0V2luZG93IGluIHdpbmRvd2VkIG1vZGUuDQor ICAgICAgICAvLyBEZWZlciB0aGUgc2V0V2luZG93LCBzbyB3ZSBkb24ndCBzZXQgaXQgdG8gdGhl IHdyb25nIHNpemUgdG9vIGVhcmx5Lg0KKyAgICAgICAgbV9xdWlya3MuYWRkKFBsdWdpblF1aXJr RGVmZXJGaXJzdFNldFdpbmRvd0NhbGwpOw0KICAgICAgICAgbV9xdWlya3MuYWRkKFBsdWdpblF1 aXJrRG9udENhbGxTZXRXaW5kb3dNb3JlVGhhbk9uY2UpOw0KICNlbmRpZg0KIA0K 173589 2012-11-12 01:56:39 -0800 2012-11-12 06:33:55 -0800 Patch bug-101836-20121112105417.patch text/plain 1603 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVkMjljNDkwYTMyMDNj ZWZkZDI1MDIyMWJlYmEzZDY5ZWI4YThiNi4uMDEzYjZkNTU1MmMwMWU0MzU5NjJlOGE3NjhmMjFl MTM3ZDExZTU1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTEyICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxzYW5kZmVsZEBrZGUub3JnPgorCisgICAgICAgIFtRdF0gRmxh c2gtcGx1Z2luIHN0YXJ0cyB3aXRoIHdyb25nIHdpZHRoCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE4MzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWZlciB0aGUgc2V0V2luZG93IGNhbGwsIHNvIHRo YXQgdGhlIG9uZSB0aW1lIGl0IGlzIGNhbGxlZCBpdCB3aWxsIGhhdmUgaXRzIGZpbmFsIHNpemUu CisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UGx1Z2luUGFja2FnZTo6ZGV0ZXJtaW5lUXVpcmtzKToKKwogMjAxMi0xMS0xMiAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjEz NDE5MS4gVHVybnMgb3V0IHRoYXQgRnJhbWVWaWV3OjpwZXJmb3JtUG9zdExheW91dFRhc2tzIGNh bGxzIEZyYW1lU2VsZWN0aW9uOjp1cGRhdGVBcHBlYXJhbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5QYWNrYWdlLmNwcAppbmRleCBmZmNlNzZkN2FjYjhhZmNmMTIyZGE5M2Y4NTA2MDE3 OThlYzAwODliLi43OGU4YmRiNDE2ODMzY2UyMmFhNTBlNzA3NDQ3NzhjNzRmMGU2OGE1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZS5jcHAKQEAgLTIwNSw3ICsyMDUsOSBA QCB2b2lkIFBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyhjb25zdCBTdHJpbmcmIG1pbWVU eXBlKQogICAgICAgICB9CiAKICNpZiBQTEFURk9STShRVCkKLSAgICAgICAgLy8gRmxhc2ggd2ls bCBjcmFzaCBvbiByZXBlYXRlZCBjYWxscyB0byBTZXRXaW5kb3cgaW4gd2luZG93ZWQgbW9kZQor ICAgICAgICAvLyBGbGFzaCB3aWxsIGNyYXNoIG9uIHJlcGVhdGVkIGNhbGxzIHRvIFNldFdpbmRv dyBpbiB3aW5kb3dlZCBtb2RlLgorICAgICAgICAvLyBEZWZlciB0aGUgc2V0V2luZG93LCBzbyB3 ZSBkb24ndCBzZXQgaXQgdG8gdGhlIHdyb25nIHNpemUgdG9vIGVhcmx5LgorICAgICAgICBtX3F1 aXJrcy5hZGQoUGx1Z2luUXVpcmtEZWZlckZpcnN0U2V0V2luZG93Q2FsbCk7CiAgICAgICAgIG1f cXVpcmtzLmFkZChQbHVnaW5RdWlya0RvbnRDYWxsU2V0V2luZG93TW9yZVRoYW5PbmNlKTsKICNl bmRpZgogCg==