101833 2012-11-10 00:53:46 -0800 Change build congratulation message in EFL 2012-11-11 23:25:01 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kangil.han kangil.han dbates gyuyoung.kim laszlo.gombos lucas.de.marchi ryuan.choi webkit.review.bot oldest_to_newest 763620 0 kangil.han 2012-11-10 00:53:46 -0800 Adopt WK2 launcher name. 763621 1 173440 kangil.han 2012-11-10 00:55:21 -0800 Created attachment 173440 Patch 763954 2 173440 laszlo.gombos 2012-11-11 18:13:42 -0800 Comment on attachment 173440 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review > Tools/Scripts/build-webkit:457 > + } I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally. > Tools/Scripts/build-webkit:467 > + } Ditto. 763962 3 173533 kangil.han 2012-11-11 18:34:14 -0800 Created attachment 173533 Patch 763963 4 kangil.han 2012-11-11 18:35:34 -0800 (In reply to comment #2) > (From update of attachment 173440 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review > > > Tools/Scripts/build-webkit:457 > > + } > > I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally. > > > Tools/Scripts/build-webkit:467 > > + } > > Ditto. Done. :) 764094 5 173533 webkit.review.bot 2012-11-11 23:24:57 -0800 Comment on attachment 173533 Patch Clearing flags on attachment: 173533 Committed r134192: <http://trac.webkit.org/changeset/134192> 764095 6 webkit.review.bot 2012-11-11 23:25:01 -0800 All reviewed patches have been landed. Closing bug. 173440 2012-11-10 00:55:21 -0800 2012-11-11 18:34:08 -0800 Patch bug-101833-20121110175326.patch text/plain 2362 kangil.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDk0YWJlNTlhZjcyZDg4ZmNlNjllM2UxOWM4ODM0ODc0 YTE5MTM0Ni4uNmM2NDZjM2Y3NjE5OGM1MmJmM2E3NTRjOGJhY2Y5YzU5MzFlZDk1YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTExLTEwICBLYW5naWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXSBDaGFuZ2UgYnVpbGQgY29uZ3JhdHVsYXRpb24gbWVzc2FnZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxODMzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRvcHQgV0syIGxhdW5j aGVyIG5hbWUuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKHdy aXRlQ29uZ3JhdHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAg KGxhdW5jaGVyTmFtZSk6CisKIDIwMTItMTEtMDkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUGVvcGxlIHdpdGggZGljaHJvbWFjeSBjYW4ndCB0ZWxsIGNyYXNo ZXMgYW5kIHBhc3NlcyBvbiBmbGFraW5lc3MgZGFzaGJvYXJkCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IGYz NmFiZWY5MDJlZTdhNmY4NDYwYzQ1MDVmNzM0YjAwMjE1MjY4Y2MuLmY2NDhhOGZlMDJiNjQwYzRl NDczZWRmNjkzYTdhODM2MDBjZjA2Y2QgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQt d2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC00NTAsMTEgKzQ1MCwx OSBAQCBzdWIgd3JpdGVDb25ncmF0cygpCiAgICAgbXkgJGJ1aWxkVGltZSA9IGZvcm1hdEJ1aWxk VGltZSgkZW5kVGltZSAtICRzdGFydFRpbWUpOwogCiAgICAgcHJpbnQgIlxuIjsKLSAgICBwcmlu dCAiPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT1cbiI7CisgICAgaWYgKGlzRWZsKCkpIHsKKyAgICAgICAgcHJpbnQgIj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 XG4iOworICAgIH0gZWxzZSB7CisgICAgICAgIHByaW50ICI9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PVxuIjsKKyAgICB9CiAgICAgcHJp bnQgIiBXZWJLaXQgaXMgbm93IGJ1aWx0ICgkYnVpbGRUaW1lKS4gXG4iOwogICAgIGlmICghaXND aHJvbWl1bSgpKSB7CiAgICAgICAgIHByaW50ICIgVG8gcnVuICRsYXVuY2hlck5hbWUgd2l0aCB0 aGlzIG5ld2x5LWJ1aWx0IGNvZGUsIHVzZSB0aGVcbiI7CiAgICAgICAgIHByaW50ICIgXCIkbGF1 bmNoZXJQYXRoXCIgc2NyaXB0LlxuIjsKICAgICB9Ci0gICAgcHJpbnQgIj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09XG4iOworICAgIGlm IChpc0VmbCgpKSB7CisgICAgICAgIHByaW50ICI9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PVxuIjsKKyAgICB9IGVsc2Ug eworICAgICAgICBwcmludCAiPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT1cbiI7CisgICAgfQogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGU4 YzZjYWIzMDQ3OWVhZWEyOTM1MGQ4NzUwMzI5OWRkOTJlMmU2NDQuLmI3Nzk4YTMyMmM2NzVlMGFk NzEzMTQ4ZTgwM2FmZDAzZTk2NmYyMDQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE1MTQsNyArMTUx NCw3IEBAIHN1YiBsYXVuY2hlck5hbWUoKQogICAgIH0gZWxzaWYgKGlzQXBwbGVXZWJLaXQoKSkg ewogICAgICAgICByZXR1cm4gIlNhZmFyaSI7CiAgICAgfSBlbHNpZiAoaXNFZmwoKSkgewotICAg ICAgICByZXR1cm4gIkVXZWJMYXVuY2hlciI7CisgICAgICAgIHJldHVybiAiRVdlYkxhdW5jaGVy L01pbmlCcm93c2VyIjsKICAgICB9IGVsc2lmIChpc1dpbkNFKCkpIHsKICAgICAgICAgcmV0dXJu ICJXaW5DRUxhdW5jaGVyIjsKICAgICB9Cg== 173533 2012-11-11 18:34:14 -0800 2012-11-11 23:24:57 -0800 Patch bug-101833-20121112113217.patch text/plain 2466 kangil.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDk0YWJlNTlhZjcyZDg4ZmNlNjllM2UxOWM4ODM0ODc0 YTE5MTM0Ni4uNjM5N2FiZmRkN2M2YmUwZTMyYzYyYWY3YTY5ZjM3NTRkZWZmYWRiNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTExLTExICBLYW5naWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBDaGFuZ2UgYnVpbGQgY29uZ3JhdHVsYXRpb24gbWVzc2FnZSBpbiBFRkwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTgzMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVGTCBwb3J0IGlzIGN1 cnJlbnRseSBzdXBwb3J0aW5nIGJvdGggV0sxIGFuZCBXSzIuCisgICAgICAgIEJ1dCwgYnVpbGQg Y29uZ3JhdHVsYXRpb24gbWVzc2FnZSBzdGlsbCBzaG93cyBXSzEoRVdlYkxhdW5jaGVyKSBvbmx5 LgorICAgICAgICBUaGVyZWZvcmUsIHRoaXMgcGF0Y2ggYWRvcHRzIFdLMiByZWZlcmVuY2UgZXhl Y3V0aW9uKE1pbmlCcm93c2VyKSBpbiBpdHMgbWVzc2FnZS4KKworICAgICAgICBGcm9tICdUbyBy dW4gRVdlYkxhdW5jaGVyIHdpdGggdGhpcyBuZXdseS1idWlsdCBjb2RlLCB1c2UgdGhlJworICAg ICAgICB0byAnVG8gcnVuIEVXZWJMYXVuY2hlci9NaW5pQnJvd3NlciB3aXRoIHRoaXMgbmV3bHkt YnVpbHQgY29kZSwgdXNlIHRoZScuCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoK KyAgICAgICAgKHdyaXRlQ29uZ3JhdHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKGxhdW5jaGVyTmFtZSk6CisKIDIwMTItMTEtMDkgIFJ5b3N1a2UgTml3YSAg PHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUGVvcGxlIHdpdGggZGljaHJvbWFjeSBjYW4n dCB0ZWxsIGNyYXNoZXMgYW5kIHBhc3NlcyBvbiBmbGFraW5lc3MgZGFzaGJvYXJkCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CmluZGV4IGYzNmFiZWY5MDJlZTdhNmY4NDYwYzQ1MDVmNzM0YjAwMjE1MjY4Y2MuLjNlNTNm YTI2ZGExZDg5MmM0ZWM1MWU2NDllNzBiNTQ0M2RlM2NjODkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBAIC00 NTAsMTEgKzQ1MCwxMSBAQCBzdWIgd3JpdGVDb25ncmF0cygpCiAgICAgbXkgJGJ1aWxkVGltZSA9 IGZvcm1hdEJ1aWxkVGltZSgkZW5kVGltZSAtICRzdGFydFRpbWUpOwogCiAgICAgcHJpbnQgIlxu IjsKLSAgICBwcmludCAiPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT1cbiI7CisgICAgcHJpbnQgIj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09XG4iOwogICAgIHBy aW50ICIgV2ViS2l0IGlzIG5vdyBidWlsdCAoJGJ1aWxkVGltZSkuIFxuIjsKICAgICBpZiAoIWlz Q2hyb21pdW0oKSkgewogICAgICAgICBwcmludCAiIFRvIHJ1biAkbGF1bmNoZXJOYW1lIHdpdGgg dGhpcyBuZXdseS1idWlsdCBjb2RlLCB1c2UgdGhlXG4iOwogICAgICAgICBwcmludCAiIFwiJGxh dW5jaGVyUGF0aFwiIHNjcmlwdC5cbiI7CiAgICAgfQotICAgIHByaW50ICI9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PVxuIjsKKyAgICBw cmludCAiPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT1cbiI7CiB9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZThjNmNhYjMwNDc5 ZWFlYTI5MzUwZDg3NTAzMjk5ZGQ5MmUyZTY0NC4uYjc3OThhMzIyYzY3NWUwYWQ3MTMxNDhlODAz YWZkMDNlOTY2ZjIwNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMTUxNCw3ICsxNTE0LDcgQEAgc3Vi IGxhdW5jaGVyTmFtZSgpCiAgICAgfSBlbHNpZiAoaXNBcHBsZVdlYktpdCgpKSB7CiAgICAgICAg IHJldHVybiAiU2FmYXJpIjsKICAgICB9IGVsc2lmIChpc0VmbCgpKSB7Ci0gICAgICAgIHJldHVy biAiRVdlYkxhdW5jaGVyIjsKKyAgICAgICAgcmV0dXJuICJFV2ViTGF1bmNoZXIvTWluaUJyb3dz ZXIiOwogICAgIH0gZWxzaWYgKGlzV2luQ0UoKSkgewogICAgICAgICByZXR1cm4gIldpbkNFTGF1 bmNoZXIiOwogICAgIH0K