101824 2012-11-09 18:06:40 -0800 REGRESSION (r126157): Setting volume before load does not persist after load 2012-11-12 11:26:31 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 101954 P2 Normal --- 87304 1 jer.noble jer.noble darin eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 763516 0 jer.noble 2012-11-09 18:06:40 -0800 Preserve the state of m_muted and m_volume across MediaPlayerPrivate instances during load. 763522 1 173421 jer.noble 2012-11-09 18:10:45 -0800 Created attachment 173421 Patch 763528 2 173421 darin 2012-11-09 18:13:52 -0800 Comment on attachment 173421 Patch Is there a good way to regression-test this? 763534 3 jer.noble 2012-11-09 18:20:17 -0800 It would be a mac specific test, as it would require loading a piece of media which AVFoundation cannot load but QuickTime can. To my knowledge, no other port has multiple MediaPlayerPrivate implementations. I can see what I can come up with. 763609 4 jer.noble 2012-11-09 23:25:57 -0800 After making a test case, it looks like the breakage is more significant. It doesn't require two media engines in order to trigger. (Though that helps.) With the regressing changeset in place, the following test fails: video.volume = 0; video.src = foo.mov; video.load(); /* wait for loadedmetadata */ assert(video.volume == 0) // Fails, volume is 1. 763610 5 jer.noble 2012-11-09 23:30:25 -0800 Regressed in http://trac.webkit.org/changeset/126157. 763616 6 jer.noble 2012-11-10 00:32:33 -0800 Drat. My testcase will fail, because it can only test what HTMLMediaElement thinks the volume is, not what the volume on the MediaPlayerPrivate actually is. However, I have verified that on WebKit Mac ToT, setting the video.volume = 0 before load() is ignored, and the video plays at full volume. 763617 7 jer.noble 2012-11-10 00:33:55 -0800 Looks like it's not going to be possible to write a testcase for this, as there's no way to query the actual volume of the media engine from JavaScript. 764611 8 jer.noble 2012-11-12 11:26:31 -0800 Regressing revision rolled out by bug #101954. *** This bug has been marked as a duplicate of bug 101954 *** 173421 2012-11-09 18:10:45 -0800 2012-11-09 23:26:06 -0800 Patch bug-101824-20121109180847.patch text/plain 1733 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTc0MGI5NTNjOTVmMWVk MmIwNzU0N2U3NTkzMjljMDc2YWU4NjcxNi4uZDhlNGIyZTE3YzQwNTUxYWE4ZDI4NzQ3YjdmNGYz MmFiNzU4ZmNiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTA5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFByZXNlcnZlIHRoZSBzdGF0 ZSBvZiBtX211dGVkIGFuZCBtX3ZvbHVtZSBhY3Jvc3MgTWVkaWFQbGF5ZXJQcml2YXRlICBpbnN0 YW5jZXMgZHVyaW5nIGxvYWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDE4MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaGlsZSBsb2FkaW5nLCBwcmVzZXJ2ZSB0aGUgbV9tdXRlZCBhbmQgbV92b2x1 bWUgdmFsdWVzIGJ5IHNldHRpbmcgdGhlbSBvbiBuZXdseSBjcmVhdGVkIAorICAgICAgICBNZWRp YVBsYXllclByaXZhdGUgaW5zdGFuY2VzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv TWVkaWFQbGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXI6OmxvYWRXaXRo TmV4dE1lZGlhRW5naW5lKToKKwogMjAxMi0xMC0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFw cGxlLmNvbT4KIAogICAgICAgICBEaXNhbGxvdyBmdWxsIHNjcmVlbiBtb2RlIGtleWJvYXJkIGFj Y2VzcyBieSBkZWZhdWx0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvTWVkaWFQbGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv TWVkaWFQbGF5ZXIuY3BwCmluZGV4IGZhMGRjNjgwMGYyMzQ3MDg1OWM4N2MwYTc0MjFkZWQxOGZh YmJjYzYuLmQ5NzAyZDA3ZDcxZjQ2MWJmMmI0ZjVjZGE2OTk3ZmVjOWZjYTNiN2QgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKQEAgLTQw OCw2ICs0MDgsMTIgQEAgdm9pZCBNZWRpYVBsYXllcjo6bG9hZFdpdGhOZXh0TWVkaWFFbmdpbmUo TWVkaWFQbGF5ZXJGYWN0b3J5KiBjdXJyZW50KQogICAgICAgICBtX3ByaXZhdGUtPnNldFByZWxv YWQobV9wcmVsb2FkKTsKICAgICAgICAgbV9wcml2YXRlLT5zZXRQcmVzZXJ2ZXNQaXRjaChwcmVz ZXJ2ZXNQaXRjaCgpKTsKICAgICAgICAgbV9wcml2YXRlLT5zZXRSYXRlKG1fcmF0ZSk7CisgICAg ICAgIGlmIChtX3ByaXZhdGUtPnN1cHBvcnRzTXV0aW5nKCkpIHsKKyAgICAgICAgICAgIG1fcHJp dmF0ZS0+c2V0TXV0ZWQobV9tdXRlZCk7CisgICAgICAgICAgICBtX3ByaXZhdGUtPnNldFZvbHVt ZShtX3ZvbHVtZSk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgbV9wcml2YXRlLT5zZXRW b2x1bWUobV9tdXRlZCA/IDAgOiBtX3ZvbHVtZSk7CisgICAgICAgICAgICAKICAgICAgICAgaWYg KG1fc2hvdWxkUHJlcGFyZVRvUmVuZGVyKQogICAgICAgICAgICAgbV9wcml2YXRlLT5wcmVwYXJl Rm9yUmVuZGVyaW5nKCk7CiAgICAgfQo=