101817 2012-11-09 17:05:23 -0800 [Mac] Guard WebCore PageVisibility Symbol Export 2012-11-10 08:11:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned webkit.review.bot oldest_to_newest 763473 0 joepeck 2012-11-09 17:05:23 -0800 shell> c++filt __ZN7WebCore4Page18setVisibilityStateENS_19PageVisibilityStateEb WebCore::Page::setVisibilityState(WebCore::PageVisibilityState, bool) shell> ack -C 5 setVisibilityState page/Page.h #if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) void setVisibilityState(PageVisibilityState, bool); #endif This symbol is only used guarded by these ifdefs, so it should only be exported guarded by these ifdefs. Fix to follow. 763476 1 173408 joepeck 2012-11-09 17:07:10 -0800 Created attachment 173408 [PATCH] Proposed Fix 763660 2 173408 webkit.review.bot 2012-11-10 08:11:34 -0800 Comment on attachment 173408 [PATCH] Proposed Fix Clearing flags on attachment: 173408 Committed r134158: <http://trac.webkit.org/changeset/134158> 763661 3 webkit.review.bot 2012-11-10 08:11:37 -0800 All reviewed patches have been landed. Closing bug. 173408 2012-11-09 17:07:10 -0800 2012-11-10 08:11:34 -0800 [PATCH] Proposed Fix guarded-export.patch text/plain 1733 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YTliZDZmLi44NTI3ZWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMTEtMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBbTWFjXSBHdWFyZCBXZWJDb3JlIFBhZ2VWaXNpYmlsaXR5IFN5bWJvbCBFeHBvcnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTgxNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEd1YXJkIHRo ZSBleHBvcnQgd2l0aCB0aGUgc2FtZSBFTkFCTEUgZ3VhcmRzIGFyb3VuZCBpdHMgZGVmaW5pdGlv bgorICAgICAgICBhbmQgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5p bjoKKwogMjAxMi0xMS0wNiAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5l dD4KIAogICAgICAgICBCdWlsZCBmaXguIHIxMzM2MDEgYnJva2UgdGhlIFdpbmRvd3MgYnVpbGQu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbiBiL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUuZXhwLmluCmluZGV4IDlmMDA2MjAuLjU2ZDgwZmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZXhwLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUu ZXhwLmluCkBAIC03MjEsNyArNzIxLDYgQEAgX19aTjdXZWJDb3JlNFBhZ2UxNnNldERlZmVyc0xv YWRpbmdFYgogX19aTjdXZWJDb3JlNFBhZ2UxN3dpbGxNb3ZlT2Zmc2NyZWVuRXYKIF9fWk43V2Vi Q29yZTRQYWdlMThyZW1vdmVTY2hlZHVsZVBhaXJFTjNXVEYxMFBhc3NSZWZQdHJJTlNfMTJTY2hl ZHVsZVBhaXJFRUUKIF9fWk43V2ViQ29yZTRQYWdlMThzZXRQYWdlU2NhbGVGYWN0b3JFZlJLTlNf OEludFBvaW50RQotX19aTjdXZWJDb3JlNFBhZ2UxOHNldFZpc2liaWxpdHlTdGF0ZUVOU18xOVBh Z2VWaXNpYmlsaXR5U3RhdGVFYgogX19aTjdXZWJDb3JlNFBhZ2UxOWFkZExheW91dE1pbGVzdG9u ZXNFagogX19aTjdXZWJDb3JlNFBhZ2UxOXZpc2l0ZWRTdGF0ZUNoYW5nZWRFUE5TXzlQYWdlR3Jv dXBFeQogX19aTjdXZWJDb3JlNFBhZ2UyMHNldERldmljZVNjYWxlRmFjdG9yRWYKQEAgLTI0Mjgs NiArMjQyNywxMCBAQCBfX1pON1dlYkNvcmUxMk5vdGlmaWNhdGlvbjE2cGVybWlzc2lvblN0cmlu Z0VOU18xOE5vdGlmaWNhdGlvbkNsaWVudDEwUGVybWlzc2lvbgogX19aTjdXZWJDb3JlNUZyYW1l MjZzZW5kT3JpZW50YXRpb25DaGFuZ2VFdmVudEVpCiAjZW5kaWYKIAorI2lmIEVOQUJMRShQQUdF X1ZJU0lCSUxJVFlfQVBJKSB8fCBFTkFCTEUoSElEREVOX1BBR0VfRE9NX1RJTUVSX1RIUk9UVExJ TkcpCitfX1pON1dlYkNvcmU0UGFnZTE4c2V0VmlzaWJpbGl0eVN0YXRlRU5TXzE5UGFnZVZpc2li aWxpdHlTdGF0ZUViCisjZW5kaWYKKwogI2lmIFVTRShQTFVHSU5fSE9TVF9QUk9DRVNTKQogX19a TjNKU0MxM1J1bnRpbWVNZXRob2QxMWdldENhbGxEYXRhRVBOU182SlNDZWxsRVJOU184Q2FsbERh dGFFCiBfX1pOM0pTQzEzUnVudGltZU1ldGhvZDE0ZmluaXNoQ3JlYXRpb25FUk5TXzEySlNHbG9i YWxEYXRhRVJLTjNXVEY2U3RyaW5nRQo=