101813 2012-11-09 16:29:56 -0800 [GTK] add libsecret to jhbuild system 2013-02-12 09:43:46 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 109195 P2 Normal --- 1 a.renevier a.renevier alex gustavo joone mrobinson pnormand oldest_to_newest 763447 0 a.renevier 2012-11-09 16:29:56 -0800 Hi, libsecret is now a dependency of Webkit. But some linux distributions do not have libsecrets package (ubuntu 12.04 for example). So, it would be nice to include libsecret in the jhbuild system. 763455 1 173401 a.renevier 2012-11-09 16:43:30 -0800 Created attachment 173401 Patch patch proposal 764449 2 mrobinson 2012-11-12 08:22:11 -0800 Typically we do not put dependencies that do not affect test result into the jhbuild. We aren't really using it as a mechanism to satisfy dependencies. Instead it's to ensure that when, for instance, only one specific version of Cairo produces perfect pixel results, we use that one. Making the jhbuild as light-weight as possible is useful, because it's a lot faster building the first time. 764988 3 joone 2012-11-12 17:04:55 -0800 (In reply to comment #2) > Typically we do not put dependencies that do not affect test result into the jhbuild. We aren't really using it as a mechanism to satisfy dependencies. Instead it's to ensure that when, for instance, only one specific version of Cairo produces perfect pixel results, we use that one. Making the jhbuild as light-weight as possible is useful, because it's a lot faster building the first time. I think we need a default jhbuild module file for WEBKIT_EXTRA_MODULES that allows us to build WebKitGtk+ more easily on any Linux distributions. 765057 4 mrobinson 2012-11-12 17:59:51 -0800 I'm not sure I understand. Isn't WEBKIT_EXTRA_MODULES a way to inject other modules into the WebKit jhbuild? 765208 5 joone 2012-11-12 21:35:07 -0800 (In reply to comment #4) > I'm not sure I understand. Isn't WEBKIT_EXTRA_MODULES a way to inject other modules into the WebKit jhbuild? Yes, but there is no an extra module file now so we can include an extra module file in order to add libsecret for satisfying dependencies. 767877 6 pnormand 2012-11-15 02:51:49 -0800 I thought the plan was to instead make this dependency optional? There's even a bug about it, bug 101594 768130 7 mrobinson 2012-11-15 08:50:34 -0800 (In reply to comment #6) > I thought the plan was to instead make this dependency optional? There's even a bug about it, bug 101594 We were waiting on that decision to see how much of a pain it is for people. I feel that if possible, we shouldn't make it optional since it's basic functionality. 809359 8 gustavo 2013-01-17 08:35:58 -0800 I think that having a default extra module file goes against its purpose. I also think this should not be made optional. Do we have enough info to decide if this is painful enough now? =) 831026 9 mrobinson 2013-02-12 09:43:46 -0800 *** This bug has been marked as a duplicate of bug 109195 *** 173401 2012-11-09 16:43:30 -0800 2013-01-15 17:29:44 -0800 Patch bug-101813-20121109164136.patch text/plain 1610 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTA1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDk0YWJlNTlhZjcyZDg4ZmNlNjllM2UxOWM4ODM0ODc0 YTE5MTM0Ni4uNjZkNDE0ZDg0NWNmMTE1MTlmYjI4ZjViYWU4ODIxNDA2YjBhMGNhMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTExLTA5ICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0dUS10gYWRkIGxpYnNjcmV0IHRvIGpoYnVpbGQgc3lzdGVtCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE4MTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGlic2Vj cmV0IGRlcGVuZGVuY3kgdG8gamhidWlsZCBzeXN0ZW0uCisKKyAgICAgICAgKiBndGsvamhidWls ZC5tb2R1bGVzOgorCiAyMDEyLTExLTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFBlb3BsZSB3aXRoIGRpY2hyb21hY3kgY2FuJ3QgdGVsbCBjcmFzaGVzIGFu ZCBwYXNzZXMgb24gZmxha2luZXNzIGRhc2hib2FyZApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2po YnVpbGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggMGFiZjE0NTA3 YWEzODNiYWY3YjMzOGE2ZWI3ZGZkZWZlOTQwNmNkZC4uZTc4YWMxYjhhMWQyMmQ5YjA2ZjkwZDIy MjI5NjllNzJlN2Y1ZDQyZCAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwor KysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC0yMCw2ICsyMCw3IEBACiAgICAgICA8 ZGVwIHBhY2thZ2U9ImxpYnNvdXAiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iYXQtc3BpMi1jb3Jl Ii8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImF0LXNwaTItYXRrIi8+CisgICAgICA8ZGVwIHBhY2th Z2U9ImxpYnNlY3JldCIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgogICA8L21ldGFtb2R1bGU+CiAK QEAgLTIzNCw0ICsyMzUsMTQgQEAKICAgICAgICAgICAgIG1kNXN1bT0iYzYyMTA2ZjAyZWUwMGI2 NDM3ZjBmYjlkMzcwYzEwOTMiLz4KICAgPC9hdXRvdG9vbHM+CiAKKyAgPGF1dG90b29scyBpZD0i bGlic2VjcmV0IiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiPgorICAgIDxkZXBlbmRlbmNpZXM+Cisg ICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICA8L2RlcGVuZGVuY2llcz4KKyAgICA8YnJh bmNoIG1vZHVsZT0iL3B1Yi9HTk9NRS9zb3VyY2VzL2xpYnNlY3JldC8wLjExL2xpYnNlY3JldC0w LjExLnRhci54eiIgdmVyc2lvbj0iMC4xMSIKKyAgICAgICAgICAgIHJlcG89ImZ0cC5nbm9tZS5v cmciCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZTUzOTlkZmI2MTM3NmE3NTAwZDIwY2IyMjcx NTE1Mjc4MGFhM2EyYzhhNjQyODFlYzZiYzhmMGViZWI4YjY4OSIKKyAgICAgICAgICAgIG1kNXN1 bT0iOGU4YjcyZmRiZGFmYmI1NDM4MWI3YTAwODViZTliMGMiLz4KKyAgPC9hdXRvdG9vbHM+CisK IDwvbW9kdWxlc2V0Pgo=