<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>101795</bug_id>
          
          <creation_ts>2012-11-09 14:00:42 -0800</creation_ts>
          <short_desc>[chromium] Define WEBKIT_IMPLEMENTATION everywhere inside WebCore</short_desc>
          <delta_ts>2012-11-09 14:07:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dana Jansens">danakj</reporter>
          <assigned_to name="Dana Jansens">danakj</assigned_to>
          <cc>jamesr</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>763294</commentid>
    <comment_count>0</comment_count>
    <who name="Dana Jansens">danakj</who>
    <bug_when>2012-11-09 14:00:42 -0800</bug_when>
    <thetext>[chromium] Define WEBKIT_IMPLEMENTATION everywhere inside WebCore</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763295</commentid>
    <comment_count>1</comment_count>
      <attachid>173359</attachid>
    <who name="Dana Jansens">danakj</who>
    <bug_when>2012-11-09 14:01:01 -0800</bug_when>
    <thetext>Created attachment 173359
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763298</commentid>
    <comment_count>2</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2012-11-09 14:05:57 -0800</bug_when>
    <thetext>We should be able to use Platform/chromium/public/ headers anywhere in WebCore, so this has to be set.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763301</commentid>
    <comment_count>3</comment_count>
    <who name="Dana Jansens">danakj</who>
    <bug_when>2012-11-09 14:07:31 -0800</bug_when>
    <thetext>Committed r134111: &lt;http://trac.webkit.org/changeset/134111&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>173359</attachid>
            <date>2012-11-09 14:01:01 -0800</date>
            <delta_ts>2012-11-09 14:05:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-101795-20121109165908.patch</filename>
            <type>text/plain</type>
            <size>2303</size>
            <attacher name="Dana Jansens">danakj</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFlZDAwYTQzOWU3ZGY1
NjM2MTkyNTE3ODUyYmYyMmU4Nzg0NTZkYy4uOTg2ZDk2YjUyZDA2Y2RkZmJmNzg1OTkzODVkMGFh
ZDk2YmM2ZTMzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTExLTA5ICBEYW5h
IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRGVm
aW5lIFdFQktJVF9JTVBMRU1FTlRBVElPTiBldmVyeXdoZXJlIGluc2lkZSBXZWJDb3JlCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE3OTUKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUuZ3lw
L1dlYkNvcmUuZ3lwOgorCiAyMDEyLTExLTA5ICBNaWhuZWEgT3ZpZGVuaWUgIDxtaWhuZWFAYWRv
YmUuY29tPgogCiAgICAgICAgIFtDU1NSZWdpb25zXSBSZWdpb24gc3R5bGluZyBwcm9wZXJ0aWVz
IGFyZSBub3QgZmlsdGVyZWQgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9X
ZWJDb3JlLmd5cC9XZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNv
cmUuZ3lwCmluZGV4IGVkMjk0NTM4MzU0Yjc4Yzc3MmMyYjk3ZjRiMTg2Y2RjZWZkMjcwNGEuLjBk
ZmQyNzcwOTkxYzU4MTAwZjk0ODYzYjk0NTA4NTg2YmViNDI3ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dl
YkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCkBAIC0xNDAwLDYgKzE0MDAsNyBAQAogICAgICAgJ2RpcmVj
dF9kZXBlbmRlbnRfc2V0dGluZ3MnOiB7CiAgICAgICAgICdkZWZpbmVzJzogWwogICAgICAgICAg
ICdXRUJDT1JFX05BVklHQVRPUl9WRU5ET1I9Ikdvb2dsZSBJbmMuIicsCisgICAgICAgICAgJ1dF
QktJVF9JTVBMRU1FTlRBVElPTj0xJywKICAgICAgICAgXSwKICAgICAgICAgJ2luY2x1ZGVfZGly
cyc6IFsKICAgICAgICAgICAnLi4vLi4vUGxhdGZvcm0vY2hyb21pdW0nLApAQCAtMTYzOSw5ICsx
NjQwLDYgQEAKICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICd3ZWJjb3JlX3ByZXJl
cXVpc2l0ZXMnLAogICAgICAgXSwKLSAgICAgICdkZWZpbmVzJzogWwotICAgICAgICAnV0VCS0lU
X0lNUExFTUVOVEFUSU9OPTEnLAotICAgICAgXSwKICAgICAgICMgVGhpcyBpcyBuZWVkZWQgZm9y
IG1hYyBiZWNhdXNlIG9mIHdlYmtpdF9zeXN0ZW1faW50ZXJmYWNlLiBJdCdkIGJlIG5pY2UKICAg
ICAgICMgaWYgdGhpcyBoYXJkIGRlcGVuZGVuY3kgY291bGQgYmUgc3BsaXQgb2ZmIHRoZSByZXN0
LgogICAgICAgJ2hhcmRfZGVwZW5kZW5jeSc6IDEsCkBAIC0xOTE3LDkgKzE5MTUsNiBAQAogICAg
ICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgJ3dlYmNvcmVfcHJlcmVxdWlzaXRlcycsCiAg
ICAgICBdLAotICAgICAgJ2RlZmluZXMnOiBbCi0gICAgICAgICdXRUJLSVRfSU1QTEVNRU5UQVRJ
T049MScsCi0gICAgICBdLAogICAgICAgJ3NvdXJjZXMnOiBbCiAgICAgICAgICc8QCh3ZWJjb3Jl
X3BsYXRmb3JtX2dlb21ldHJ5X2ZpbGVzKScsCiAgICAgICBdLApAQCAtMTk2MCw5ICsxOTU1LDYg
QEAKICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICd3ZWJjb3JlX3ByZXJlcXVpc2l0
ZXMnLAogICAgICAgXSwKLSAgICAgICdkZWZpbmVzJzogWwotICAgICAgICAnV0VCS0lUX0lNUExF
TUVOVEFUSU9OPTEnLAotICAgICAgXSwKICAgICAgICdzb3VyY2VzJzogWwogICAgICAgICAnPEAo
d2ViY29yZV9wcml2YXRlaGVhZGVyX2ZpbGVzKScsCiAgICAgICAgICc8QCh3ZWJjb3JlX2ZpbGVz
KScsCkBAIC0yMDI5LDkgKzIwMjEsNiBAQAogICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICd3
ZWJjb3JlX3JlbWFpbmluZycsCiAgICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCi0gICAg
ICAnZGVmaW5lcyc6IFsKLSAgICAgICAgJ1dFQktJVF9JTVBMRU1FTlRBVElPTj0xJywKLSAgICAg
IF0sCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGly
KS90aGlyZF9wYXJ0eS92OC1pMThuL2J1aWxkL2FsbC5neXA6djgtaTE4bicsCiAgICAgICAgICd3
ZWJjb3JlX3ByZXJlcXVpc2l0ZXMnLAo=
</data>
<flag name="review"
          id="188028"
          type_id="1"
          status="+"
          setter="jamesr"
    />
          </attachment>
      

    </bug>

</bugzilla>