101781 2012-11-09 11:47:56 -0800 HTML Attributes names and values should be created as 8 bit string where possible 2012-11-09 14:33:22 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 763207 0 msaboff 2012-11-09 11:47:56 -0800 HTML Attribute keys and values are most likely going to be lower case ASCII, therefore we should try to create them as 8 bit strings. 763253 1 173348 msaboff 2012-11-09 13:00:50 -0800 Created attachment 173348 Patch 763329 2 173348 webkit.review.bot 2012-11-09 14:33:19 -0800 Comment on attachment 173348 Patch Clearing flags on attachment: 173348 Committed r134116: <http://trac.webkit.org/changeset/134116> 763330 3 webkit.review.bot 2012-11-09 14:33:22 -0800 All reviewed patches have been landed. Closing bug. 173348 2012-11-09 13:00:50 -0800 2012-11-09 14:33:19 -0800 Patch 101781.patch text/plain 3810 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNDA5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTA5ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUwgQXR0cmlidXRlcyBu YW1lcyBhbmQgdmFsdWVzIHNob3VsZCBiZSBjcmVhdGVkIGFzIDggYml0IHN0cmluZyB3aGVyZSBw b3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAxNzgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg R2l2ZW4gdGhhdCBhbG1vc3QgYWxsIGF0dHJpYnV0ZSBuYW1lcyBhbmQgdmFsdWVzIGFyZSBsb3dl ciBjYXNlIEFTQ0lJLCB3ZSBzaG91bGQgdHJ5IHRvCisgICAgICAgIGNyZWF0ZSA4IGJpdCBzdHJp bmdzIHRvIHByb2Nlc3MgdGhlbS4gIENyZWF0aW5nIGFuIEF0b21pY1N0cmluZyBhbHJlYWR5IHRy aWVzIHRvIG1ha2UKKyAgICAgICAgYW4gOCBiaXQgc3RyaW5nLCBzbyB0aGF0IGRpZG4ndCBuZWVk IHRvIGNoYW5nZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGZ1bmN0aW9uYWxpdHkgY292ZXJl ZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIGh0bWwvSFRNTFZpZXdTb3VyY2VEb2N1 bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlld1NvdXJjZURvY3VtZW50Ojpwcm9j ZXNzVGFnVG9rZW4pOgorICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxNZXRhQ2hhcnNldFBhcnNl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWV0YUNoYXJzZXRQYXJzZXI6OnByb2Nlc3NN ZXRhKToKKyAgICAgICAgKiBodG1sL3BhcnNlci9IVE1MUHJlbG9hZFNjYW5uZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UHJlbG9hZFRhc2s6OnByb2Nlc3NBdHRyaWJ1dGVzKToKKwogMjAxMi0x MS0wOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvQHdlYmtpdC5vcmc+CiAKICAgICAgICAg W0dUS10gSXNvbGF0ZSB0aGUgR1RLL0dhaWwvUGFuZ28gc3BlY2lmaWMgY29kZSBpbiBhY2Nlc3Np YmlsaXR5L2d0awpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlld1NvdXJjZURvY3Vt ZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWV3U291cmNl RG9jdW1lbnQuY3BwCShyZXZpc2lvbiAxMzQwODUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxWaWV3U291cmNlRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDgsNyArMTQ4LDcg QEAgdm9pZCBIVE1MVmlld1NvdXJjZURvY3VtZW50Ojpwcm9jZXNzVGFnVAogICAgICAgICB9CiAK ICAgICAgICAgQXRvbWljU3RyaW5nIG5hbWUoaXRlci0+bV9uYW1lLmRhdGEoKSwgaXRlci0+bV9u YW1lLnNpemUoKSk7Ci0gICAgICAgIFN0cmluZyB2YWx1ZShpdGVyLT5tX3ZhbHVlLmRhdGEoKSwg aXRlci0+bV92YWx1ZS5zaXplKCkpOyAKKyAgICAgICAgU3RyaW5nIHZhbHVlID0gU3RyaW5nSW1w bDo6Y3JlYXRlOEJpdElmUG9zc2libGUoaXRlci0+bV92YWx1ZS5kYXRhKCksIGl0ZXItPm1fdmFs dWUuc2l6ZSgpKTsgCiAKICAgICAgICAgaW5kZXggPSBhZGRSYW5nZShzb3VyY2UsIGluZGV4LCBp dGVyLT5tX25hbWVSYW5nZS5tX3N0YXJ0IC0gdG9rZW4uc3RhcnRJbmRleCgpLCAiIik7CiAgICAg ICAgIGluZGV4ID0gYWRkUmFuZ2Uoc291cmNlLCBpbmRleCwgaXRlci0+bV9uYW1lUmFuZ2UubV9l bmQgLSB0b2tlbi5zdGFydEluZGV4KCksICJ3ZWJraXQtaHRtbC1hdHRyaWJ1dGUtbmFtZSIpOwpJ bmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTE1ldGFDaGFyc2V0UGFyc2VyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MTWV0YUNoYXJz ZXRQYXJzZXIuY3BwCShyZXZpc2lvbiAxMzQwODUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3Bh cnNlci9IVE1MTWV0YUNoYXJzZXRQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDUsOCAr MTA1LDggQEAgYm9vbCBIVE1MTWV0YUNoYXJzZXRQYXJzZXI6OnByb2Nlc3NNZXRhKAogICAgIGNv bnN0IEhUTUxUb2tlbjo6QXR0cmlidXRlTGlzdCYgdG9rZW5BdHRyaWJ1dGVzID0gbV90b2tlbi5h dHRyaWJ1dGVzKCk7CiAgICAgQXR0cmlidXRlTGlzdCBhdHRyaWJ1dGVzOwogICAgIGZvciAoSFRN TFRva2VuOjpBdHRyaWJ1dGVMaXN0Ojpjb25zdF9pdGVyYXRvciBpdGVyID0gdG9rZW5BdHRyaWJ1 dGVzLmJlZ2luKCk7IGl0ZXIgIT0gdG9rZW5BdHRyaWJ1dGVzLmVuZCgpOyArK2l0ZXIpIHsKLSAg ICAgICAgU3RyaW5nIGF0dHJpYnV0ZU5hbWUoaXRlci0+bV9uYW1lLmRhdGEoKSwgaXRlci0+bV9u YW1lLnNpemUoKSk7Ci0gICAgICAgIFN0cmluZyBhdHRyaWJ1dGVWYWx1ZShpdGVyLT5tX3ZhbHVl LmRhdGEoKSwgaXRlci0+bV92YWx1ZS5zaXplKCkpOworICAgICAgICBTdHJpbmcgYXR0cmlidXRl TmFtZSA9IFN0cmluZ0ltcGw6OmNyZWF0ZThCaXRJZlBvc3NpYmxlKGl0ZXItPm1fbmFtZS5kYXRh KCksIGl0ZXItPm1fbmFtZS5zaXplKCkpOworICAgICAgICBTdHJpbmcgYXR0cmlidXRlVmFsdWUg PSBTdHJpbmdJbXBsOjpjcmVhdGU4Qml0SWZQb3NzaWJsZShpdGVyLT5tX3ZhbHVlLmRhdGEoKSwg aXRlci0+bV92YWx1ZS5zaXplKCkpOwogICAgICAgICBhdHRyaWJ1dGVzLmFwcGVuZChzdGQ6Om1h a2VfcGFpcihhdHRyaWJ1dGVOYW1lLCBhdHRyaWJ1dGVWYWx1ZSkpOwogICAgIH0KIApJbmRleDog U291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFByZWxvYWRTY2FubmVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MUHJlbG9hZFNjYW5uZXIuY3Bw CShyZXZpc2lvbiAxMzQwODUpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MUHJl bG9hZFNjYW5uZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Niw3ICs2Niw3IEBAIHB1YmxpYzoK ICAgICAgICAgZm9yIChIVE1MVG9rZW46OkF0dHJpYnV0ZUxpc3Q6OmNvbnN0X2l0ZXJhdG9yIGl0 ZXIgPSBhdHRyaWJ1dGVzLmJlZ2luKCk7CiAgICAgICAgICAgICAgaXRlciAhPSBhdHRyaWJ1dGVz LmVuZCgpOyArK2l0ZXIpIHsKICAgICAgICAgICAgIEF0b21pY1N0cmluZyBhdHRyaWJ1dGVOYW1l KGl0ZXItPm1fbmFtZS5kYXRhKCksIGl0ZXItPm1fbmFtZS5zaXplKCkpOwotICAgICAgICAgICAg U3RyaW5nIGF0dHJpYnV0ZVZhbHVlKGl0ZXItPm1fdmFsdWUuZGF0YSgpLCBpdGVyLT5tX3ZhbHVl LnNpemUoKSk7CisgICAgICAgICAgICBTdHJpbmcgYXR0cmlidXRlVmFsdWUgPSBTdHJpbmdJbXBs OjpjcmVhdGU4Qml0SWZQb3NzaWJsZShpdGVyLT5tX3ZhbHVlLmRhdGEoKSwgaXRlci0+bV92YWx1 ZS5zaXplKCkpOwogCiAgICAgICAgICAgICBpZiAoYXR0cmlidXRlTmFtZSA9PSBjaGFyc2V0QXR0 cikKICAgICAgICAgICAgICAgICBtX2NoYXJzZXQgPSBhdHRyaWJ1dGVWYWx1ZTsK