101778 2012-11-09 11:27:31 -0800 [BlackBerry] When opening an image it does not scale to fit our window 2012-11-13 07:32:14 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jkjiang jkjiang kpiascik manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 763190 0 jkjiang 2012-11-09 11:27:31 -0800 PR: 230935. 764788 1 173716 jkjiang 2012-11-12 13:55:35 -0800 Created attachment 173716 Patch 764798 2 173716 rwlbuis 2012-11-12 14:01:45 -0800 Comment on attachment 173716 Patch LGTM. 764852 3 jkjiang 2012-11-12 14:51:36 -0800 Committed r134308: <http://trac.webkit.org/changeset/134308> 765496 4 kpiascik 2012-11-13 05:18:41 -0800 (In reply to comment #3) > Committed r134308: <http://trac.webkit.org/changeset/134308> It's actually http://trac.webkit.org/changeset/134304 765580 5 jkjiang 2012-11-13 07:32:14 -0800 (In reply to comment #4) > (In reply to comment #3) > > Committed r134308: <http://trac.webkit.org/changeset/134308> > > It's actually http://trac.webkit.org/changeset/134304 Yeah, thanks! The mark-bug-fixed script didn't work as expected... 173716 2012-11-12 13:55:35 -0800 2012-11-12 14:01:45 -0800 Patch bug-101778-20121112165337.patch text/plain 3340 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5YjRmY2ZiNWE3NDc5ZDMzNDM3MWEwYzU5M2ZiZWY4MmVkOTJlMmNmLi4xMTI5OTQ2NTY5 NGIxOTg4Mjc2ZmRhNzA2M2E3ZTc2NWJlZWNkNDU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMS0xMiAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBXaGVuIG9wZW5pbmcgYW4gaW1hZ2Ug aXQgZG9lcyBub3Qgc2NhbGUgdG8gZml0IG91ciB3aW5kb3cKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTc3OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEtvbnJhZCBQ aWFzY2lrLgorCisgICAgICAgIFBSOiAyMzA5MzUKKyAgICAgICAgRm9yIGltYWdlIGRvY3VtZW50 LCB0aGUgYWN0dWFsIGltYWdlIHNpemUgY2FuIGJlIGRpZmZlcmVudCB3aXRoIHRoZQorICAgICAg ICBjb250ZW50cyBzaXplLiBab29tIHRoZSBkb2N1bWVudCBiYXNlZCBvbiB0aGUgaW1hZ2Ugd2lk dGggc28gdGhhdAorICAgICAgICBpbWFnZXMgY2FuIGZpdCB0aGUgc2NyZWVuIGhvcml6b250YWxs eS4gU2V0IDIuMCBhcyB0aGUgbWF4aW11bSB6b29tIHRvCisgICAgICAgIGZpdCBzY2FsZSBmb3Ig aW1hZ2UgZG9jdW1lbnQgc28gdGhhdCB2ZXJ5IHNtYWxsIGltYWdlcyB3b24ndCBnZXQKKyAgICAg ICAgcmlkaWN1bG91cyBsYXJnZSBzY2FsZXMgZHVyaW5nIHRoZSBpbml0aWFsIGxvYWQuCisKKyAg ICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6em9vbVRvRml0U2NhbGUpOgorCiAyMDEy LTExLTEyICBSb2IgQnVpcyAgPHJidWlzQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnld IENyYXNoIGluIEluUmVnaW9uU2Nyb2xsZXJQcml2YXRlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggYWNhODNmMmVjZjQ0NzU4ZjQ0YjVkZTFjOTNkOWU5NWIz NjlkNjc4ZS4uMjMzZjIxNDRmMDU4MjMwMTA3Mjk1ODQzYjJlOWVlYWExMGMwYjBhNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC03Miw2ICs3Miw3IEBACiAj aW5jbHVkZSAiSFRUUFBhcnNlcnMuaCIKICNpbmNsdWRlICJIaXN0b3J5SXRlbS5oIgogI2luY2x1 ZGUgIkljb25EYXRhYmFzZUNsaWVudEJsYWNrQmVycnkuaCIKKyNpbmNsdWRlICJJbWFnZURvY3Vt ZW50LmgiCiAjaW5jbHVkZSAiSW5QYWdlU2VhcmNoTWFuYWdlci5oIgogI2luY2x1ZGUgIkluUmVn aW9uU2Nyb2xsYWJsZUFyZWEuaCIKICNpbmNsdWRlICJJblJlZ2lvblNjcm9sbGVyX3AuaCIKQEAg LTIyMiw2ICsyMjMsNyBAQCBjb25zdCBJbnRTaXplIG1pbmltdW1MYXlvdXRTaXplKDEwLCAxMCk7 IC8vIE5lZWRzIHRvIGJlIGEgc21hbGwgc2l6ZSwgZ3JlYXRlciB0aAogY29uc3QgZG91YmxlIG1p bmltdW1FeHBhbmRpbmdSYXRpbyA9IDAuMTU7CiAKIGNvbnN0IGRvdWJsZSBtaW5pbXVtWm9vbVRv Rml0U2NhbGUgPSAwLjI1OworY29uc3QgZG91YmxlIG1heGltdW1JbWFnZURvY3VtZW50Wm9vbVRv Rml0U2NhbGUgPSAyOwogCiAvLyBIZWxwZXIgZnVuY3Rpb24gdG8gcGFyc2UgYSBVUkwgYW5kIGZp bGwgaW4gbWlzc2luZyBwYXJ0cy4KIHN0YXRpYyBLVVJMIHBhcnNlVXJsKGNvbnN0IFN0cmluZyYg dXJsKQpAQCAtMTY2MiwxMiArMTY2NCwyNCBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjp6b29tVG9J bml0aWFsU2NhbGVPbkxvYWQoKQogZG91YmxlIFdlYlBhZ2VQcml2YXRlOjp6b29tVG9GaXRTY2Fs ZSgpIGNvbnN0CiB7CiAgICAgaW50IGNvbnRlbnRXaWR0aCA9IGNvbnRlbnRzU2l6ZSgpLndpZHRo KCk7Ci0gICAgaW50IGNvbnRlbnRIZWlnaHQgPSBjb250ZW50c1NpemUoKS5oZWlnaHQoKTsKKwor ICAgIC8vIEZvciBpbWFnZSBkb2N1bWVudCwgem9vbSB0byBmaXQgdGhlIHNjcmVlbiBiYXNlZCBv biB0aGUgYWN0dWFsIGltYWdlIHdpZHRoCisgICAgLy8gaW5zdGVhZCBvZiB0aGUgY29udGVudHMg d2lkdGggd2l0aGluIGEgbWF4aW11bSBzY2FsZSAuCisgICAgRG9jdW1lbnQqIGRvYyA9IG1fcGFn ZS0+bWFpbkZyYW1lKCktPmRvY3VtZW50KCk7CisgICAgYm9vbCBpc0ltYWdlRG9jdW1lbnQgPSBk b2MgJiYgZG9jLT5pc0ltYWdlRG9jdW1lbnQoKTsKKyAgICBpZiAoaXNJbWFnZURvY3VtZW50KQor ICAgICAgICBjb250ZW50V2lkdGggPSBzdGF0aWNfY2FzdDxJbWFnZURvY3VtZW50Kj4oZG9jKS0+ aW1hZ2VTaXplKCkud2lkdGgoKTsKKwogICAgIGRvdWJsZSB6b29tVG9GaXRTY2FsZSA9IGNvbnRl bnRXaWR0aCA+IDAuMCA/IHN0YXRpY19jYXN0PGRvdWJsZT4obV9hY3R1YWxWaXNpYmxlV2lkdGgp IC8gY29udGVudFdpZHRoIDogMS4wOworICAgIGludCBjb250ZW50SGVpZ2h0ID0gY29udGVudHNT aXplKCkuaGVpZ2h0KCk7CiAgICAgaWYgKGNvbnRlbnRIZWlnaHQgKiB6b29tVG9GaXRTY2FsZSA8 IHN0YXRpY19jYXN0PGRvdWJsZT4obV9kZWZhdWx0TGF5b3V0U2l6ZS5oZWlnaHQoKSkpCiAgICAg ICAgIHpvb21Ub0ZpdFNjYWxlID0gY29udGVudEhlaWdodCA+IDAgPyBzdGF0aWNfY2FzdDxkb3Vi bGU+KG1fZGVmYXVsdExheW91dFNpemUuaGVpZ2h0KCkpIC8gY29udGVudEhlaWdodCA6IDEuMDsK KyAgICB6b29tVG9GaXRTY2FsZSA9IHN0ZDo6bWF4KHpvb21Ub0ZpdFNjYWxlLCBtaW5pbXVtWm9v bVRvRml0U2NhbGUpOworCisgICAgaWYgKCFpc0ltYWdlRG9jdW1lbnQpCisgICAgICAgIHJldHVy biB6b29tVG9GaXRTY2FsZTsKIAotICAgIHJldHVybiBzdGQ6Om1heCh6b29tVG9GaXRTY2FsZSwg bWluaW11bVpvb21Ub0ZpdFNjYWxlKTsKKyAgICByZXR1cm4gc3RkOjptaW4oem9vbVRvRml0U2Nh bGUsIG1heGltdW1JbWFnZURvY3VtZW50Wm9vbVRvRml0U2NhbGUpOwogfQogCiBkb3VibGUgV2Vi UGFnZVByaXZhdGU6OmluaXRpYWxTY2FsZSgpIGNvbnN0Cg==