101769 2012-11-09 09:05:04 -0800 Use device scale factor instead of physical screen DPI for screen DPI 2012-11-19 08:42:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101767 101772 102566 1 skyostil skyostil abarth dglazkov fsamuel gyuyoung.kim jkjiang johnme kpiascik mifenton peter+ews rakuco rwlbuis tonikitoo webkit.review.bot oldest_to_newest 763064 0 skyostil 2012-11-09 09:05:04 -0800 Use device scale factor instead of physical screen DPI for screen DPI 763075 1 173322 skyostil 2012-11-09 09:16:32 -0800 Created attachment 173322 Patch 763094 2 skyostil 2012-11-09 09:36:03 -0800 Thanks Adam. I'll land this once all the prerequisites are in place. 763118 3 173322 webkit.review.bot 2012-11-09 10:01:31 -0800 Comment on attachment 173322 Patch Attachment 173322 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14790157 763399 4 173322 peter+ews 2012-11-09 15:41:02 -0800 Comment on attachment 173322 Patch Attachment 173322 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14785335 764463 5 173322 johnme 2012-11-12 08:50:08 -0800 Comment on attachment 173322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173322&action=review Nice cleanup - looks good! > Source/WebCore/page/Screen.cpp:NaN > unsigned Screen::verticalDPI() const Screen::horizontalDPI and Screen::verticalDPI are now redundant. Could we remove one of them, and rename the other to Screen::cssDPI (to emphasize that it computes the CSS dpi unit, not the true physical dpi of the screen)? > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:-32 > - FloatSize currentPPI = BlackBerry::Platform::Graphics::Screen::primaryScreen()->pixelsPerInch(-1); Seems like blackberry implemented this too. Might want to ping them on the review. 764531 6 skyostil 2012-11-12 10:06:15 -0800 (In reply to comment #5) > Screen::horizontalDPI and Screen::verticalDPI are now redundant. Could we remove one of them, and rename the other to Screen::cssDPI (to emphasize that it computes the CSS dpi unit, not the true physical dpi of the screen)? Good idea. Let me try to see how that works out. > > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:-32 > > - FloatSize currentPPI = BlackBerry::Platform::Graphics::Screen::primaryScreen()->pixelsPerInch(-1); > > Seems like blackberry implemented this too. Might want to ping them on the review. Antonio, any thoughts about this one? 769732 7 jkjiang 2012-11-16 15:49:27 -0800 (In reply to comment #6) > (In reply to comment #5) > > > Source/WebCore/platform/blackberry/PlatformScreenBlackBerry.cpp:-32 > > > - FloatSize currentPPI = BlackBerry::Platform::Graphics::Screen::primaryScreen()->pixelsPerInch(-1); > > > > Seems like blackberry implemented this too. Might want to ping them on the review. > > Antonio, any thoughts about this one? Looks good to me. 769794 8 173322 webkit.review.bot 2012-11-16 17:21:05 -0800 Comment on attachment 173322 Patch Rejecting attachment 173322 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: j.target/webkit/Source/WebKit/chromium/src/DatabaseObserver.o Source/WebKit/chromium/src/ChromeClientImpl.cpp: In member function 'virtual void WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange(const WebCore::ViewportArguments&) const': Source/WebKit/chromium/src/ChromeClientImpl.cpp:625: error: 'screenHorizontalDPI' was not declared in this scope make: *** [out/Release/obj.target/webkit/Source/WebKit/chromium/src/ChromeClientImpl.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/14872336 770787 9 173322 webkit.review.bot 2012-11-19 08:42:27 -0800 Comment on attachment 173322 Patch Clearing flags on attachment: 173322 Committed r135165: <http://trac.webkit.org/changeset/135165> 770788 10 webkit.review.bot 2012-11-19 08:42:32 -0800 All reviewed patches have been landed. Closing bug. 173322 2012-11-09 09:16:32 -0800 2012-11-19 08:42:27 -0800 Patch bug-101769-20121109171439.patch text/plain 9143 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzMjY1OWNlYjEzZjg2 MTc1NmE1NTkzYzhlMDFlZGRkMjljMGIwMS4uOTQ4ZjU2NDE3ODVlNDQ5YjU3N2RkODEyMGVkZDU3 MTdkOTdiMWQ4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTExLTA5ICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFVzZSBkZXZpY2Ug c2NhbGUgZmFjdG9yIGluc3RlYWQgb2YgcGh5c2ljYWwgc2NyZWVuIERQSSBmb3Igc2NyZWVuIERQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNzY5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWVkaWEg cXVlcmllcyBjYWxsIFdlYkNvcmU6OlNjcmVlbjo6e2hvcml6b250YWwsdmVydGljYWx9RFBJKCkg dG8gZGV0ZXJtaW5lCisgICAgICAgIHRoZSBkb3RzIHBlciBDU1MgaW5jaFsxXSB2YWx1ZSBmb3Ig dGhlICJzY3JlZW4iIG1lZGlhIHR5cGUuIE9uIENocm9taXVtIHRoZXNlCisgICAgICAgIGZ1bmN0 aW9ucyBjdXJyZW50bHkgcmV0dXJuIHRoZSBwaHlzaWNhbCBzY3JlZW4gRFBJLCB3aGljaCBpcyB3 cm9uZy4gVG8gZml4CisgICAgICAgIHRoaXMsIHdlIHJlbW92ZSBib3RoIG9mIHRoZXNlIGZ1bmN0 aW9ucyBlbnRpcmVseSBhbmQgbWFrZSBtZWRpYSBxdWVyaWVzIHVzZQorICAgICAgICB0aGUgZGV2 aWNlIHNjYWxlIGZhY3RvciBtdWx0aXBsaWVkIGJ5IDk2IG9uIGFsbCBwb3J0cy4KKworICAgICAg ICBbMV0gaHR0cDovL3d3dy53My5vcmcvVFIvY3NzMy1tZWRpYXF1ZXJpZXMvI3Jlc29sdXRpb24w CisKKyAgICAgICAgKiBwYWdlL1NjcmVlbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JlZW46 Omhvcml6b250YWxEUEkpOgorICAgICAgICAoV2ViQ29yZTo6U2NyZWVuOjp2ZXJ0aWNhbERQSSk6 CisgICAgICAgICogcGxhdGZvcm0vUGxhdGZvcm1TY3JlZW4uaDoKKyAgICAgICAgKFdlYkNvcmUp OgorICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZvcm1TY3JlZW5CbGFja0JlcnJ5 LmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVNjcmVlbkNocm9taXVt LmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUGxhdGZvcm1TY3JlZW5FZmwuY3BwOgorICAg ICAgICAqIHBsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHA6CisgICAgICAgICogcGxh dGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tOgorICAgICAgICAqIHBsYXRmb3JtL3F0L1Bs YXRmb3JtU2NyZWVuUXQuY3BwOgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9QbGF0Zm9ybVNjcmVl bldpbi5jcHA6CisgICAgICAgICogcGxhdGZvcm0vd3gvU2NyZWVuV3guY3BwOgorCiAyMDEyLTEx LTA5ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW5kZXhlZERC IHNob3VsZCB1c2UgbW9zdGx5IFNjcmlwdFdyYXBwYWJsZSBET00gb2JqZWN0cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9TY3JlZW4uY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9T Y3JlZW4uY3BwCmluZGV4IGMwODgwYzhkZTFmMTlkM2U3MzNmZGE4ODFkN2NmNTRmM2Q5ZDU5MzYu LmU2MzlhOWMxMzAwYjZhY2RmNmVkNjUwODZiODJhMDMxMjA2ZThhMWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvU2NyZWVuLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Nj cmVlbi5jcHAKQEAgLTU1LDEyICs1NSw2IEBAIHVuc2lnbmVkIFNjcmVlbjo6aG9yaXpvbnRhbERQ SSgpIGNvbnN0CiAgICAgaWYgKCFvdmVycmlkZS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBv dmVycmlkZS53aWR0aCgpOwogCi0gICAgLy8gVGhlc2Ugd2VyZSBhZGRlZCBpbiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA1NTYgZm9yIENocm9taXVtCi0gICAgLy8g YnV0IHNlZW1zIHVudXNlZC4gUGxlYXNlIHJlbW92ZSBhZnRlciB2YXJpZnlpbmcgdGhhdCB0aGlz IGlzIGluZGVlZCB0aGUgY2FzZS4KLSAgICBpbnQgcGxhdGZvcm1WYWx1ZSA9IHN0YXRpY19jYXN0 PHVuc2lnbmVkPihzY3JlZW5Ib3Jpem9udGFsRFBJKG1fZnJhbWUtPnZpZXcoKSkpOwotICAgIGlm IChwbGF0Zm9ybVZhbHVlID4gMCkKLSAgICAgICAgcmV0dXJuIHBsYXRmb3JtVmFsdWU7Ci0KICAg ICAvLyBUaGUgRFBJIGlzIGRlZmluZWQgYXMgZG90cyBwZXIgQ1NTIGluY2ggYW5kIHRodXMgbm90 IGRldmljZSBpbmNoLgogICAgIHJldHVybiBtX2ZyYW1lLT5wYWdlKCktPmRldmljZVNjYWxlRmFj dG9yKCkgKiA5NjsKIH0KQEAgLTc2LDEyICs3MCw2IEBAIHVuc2lnbmVkIFNjcmVlbjo6dmVydGlj YWxEUEkoKSBjb25zdAogICAgIGlmICghb3ZlcnJpZGUuaXNFbXB0eSgpKQogICAgICAgICByZXR1 cm4gb3ZlcnJpZGUuaGVpZ2h0KCk7CiAKLSAgICAvLyBUaGVzZSB3ZXJlIGFkZGVkIGluIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MDU1NiBmb3IgQ2hyb21pdW0KLSAg ICAvLyBidXQgc2VlbXMgdW51c2VkLiBQbGVhc2UgcmVtb3ZlIGFmdGVyIHZhcmlmeWluZyB0aGF0 IHRoaXMgaXMgaW5kZWVkIHRoZSBjYXNlLgotICAgIGludCBwbGF0Zm9ybVZhbHVlID0gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KHNjcmVlblZlcnRpY2FsRFBJKG1fZnJhbWUtPnZpZXcoKSkpOwotICAg IGlmIChwbGF0Zm9ybVZhbHVlID4gMCkKLSAgICAgICAgcmV0dXJuIHBsYXRmb3JtVmFsdWU7Ci0K ICAgICAvLyBUaGUgRFBJIGlzIGRlZmluZWQgYXMgZG90cyBwZXIgQ1NTIGluY2ggYW5kIHRodXMg bm90IGRldmljZSBpbmNoLgogICAgIHJldHVybiBtX2ZyYW1lLT5wYWdlKCktPmRldmljZVNjYWxl RmFjdG9yKCkgKiA5NjsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Bs YXRmb3JtU2NyZWVuLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybVNjcmVlbi5o CmluZGV4IDExMTFmOWQ2YTlkNGUxMTYyN2Y4ODlmN2E1YzdlZDMwZjZiOGRkZDIuLjRmYWM1NGEw NDRhY2NjYWQ2YWI1N2NhNTg1MGYzZTU1ZmRhNDVhNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1BsYXRmb3JtU2NyZWVuLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vUGxhdGZvcm1TY3JlZW4uaApAQCAtNDQsOCArNDQsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAgICAgY2xhc3MgRmxvYXRSZWN0OwogICAgIGNsYXNzIFdpZGdldDsKIAotICAgIGludCBzY3Jl ZW5Ib3Jpem9udGFsRFBJKFdpZGdldCopOwotICAgIGludCBzY3JlZW5WZXJ0aWNhbERQSShXaWRn ZXQqKTsKICAgICBpbnQgc2NyZWVuRGVwdGgoV2lkZ2V0Kik7CiAgICAgaW50IHNjcmVlbkRlcHRo UGVyQ29tcG9uZW50KFdpZGdldCopOwogICAgIGJvb2wgc2NyZWVuSXNNb25vY2hyb21lKFdpZGdl dCopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0 Zm9ybVNjcmVlbkJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2ti ZXJyeS9QbGF0Zm9ybVNjcmVlbkJsYWNrQmVycnkuY3BwCmluZGV4IDFkODcwMzE1NjQyOGJlZGNm Mjc3YTE5MzU5MzEwMGI4YzA0N2U2M2IuLmQ1M2FkYWJkOTUzYTQxYjVkYWMwZTRmMTA2YjM4YzE1 Yzk4ZTU2ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkv UGxhdGZvcm1TY3JlZW5CbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ibGFja2JlcnJ5L1BsYXRmb3JtU2NyZWVuQmxhY2tCZXJyeS5jcHAKQEAgLTI3LDE4ICsyNyw2 IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotaW50IHNjcmVlbkhvcml6b250YWxEUEkoV2lk Z2V0KikKLXsKLSAgICBGbG9hdFNpemUgY3VycmVudFBQSSA9IEJsYWNrQmVycnk6OlBsYXRmb3Jt OjpHcmFwaGljczo6U2NyZWVuOjpwcmltYXJ5U2NyZWVuKCktPnBpeGVsc1BlckluY2goLTEpOwot ICAgIHJldHVybiBjdXJyZW50UFBJLndpZHRoKCk7Ci19Ci0KLWludCBzY3JlZW5WZXJ0aWNhbERQ SShXaWRnZXQqKQotewotICAgIEZsb2F0U2l6ZSBjdXJyZW50UFBJID0gQmxhY2tCZXJyeTo6UGxh dGZvcm06OkdyYXBoaWNzOjpTY3JlZW46OnByaW1hcnlTY3JlZW4oKS0+cGl4ZWxzUGVySW5jaCgt MSk7Ci0gICAgcmV0dXJuIGN1cnJlbnRQUEkuaGVpZ2h0KCk7Ci19Ci0KIGJvb2wgc2NyZWVuSXNN b25vY2hyb21lKFdpZGdldCopCiB7CiAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1TY3JlZW5DaHJvbWl1bS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVNjcmVlbkNocm9taXVt LmNwcAppbmRleCAwMmYwOTg4ODgyN2IzYjZiN2FiODljM2UzODRlMzA4ODkzMTM5YjUzLi40ZmI2 OTE1YTQ2OWE2ODc3ZGI2NWI2YmMxNjg5NTFjMDVhNmJmMGU3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVNjcmVlbkNocm9taXVtLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVNjcmVlbkNocm9taXVt LmNwcApAQCAtNTMsMjIgKzUzLDYgQEAgc3RhdGljIFBsYXRmb3JtUGFnZUNsaWVudCB0b1BsYXRm b3JtUGFnZUNsaWVudChXaWRnZXQqIHdpZGdldCkKICAgICByZXR1cm4gaG9zdFdpbmRvdy0+cGxh dGZvcm1QYWdlQ2xpZW50KCk7CiB9CiAKLWludCBzY3JlZW5Ib3Jpem9udGFsRFBJKFdpZGdldCog d2lkZ2V0KQotewotICAgIFBsYXRmb3JtUGFnZUNsaWVudCBjbGllbnQgPSB0b1BsYXRmb3JtUGFn ZUNsaWVudCh3aWRnZXQpOwotICAgIGlmICghY2xpZW50KQotICAgICAgICByZXR1cm4gMDsKLSAg ICByZXR1cm4gY2xpZW50LT5zY3JlZW5JbmZvKCkuaG9yaXpvbnRhbERQSTsKLX0KLQotaW50IHNj cmVlblZlcnRpY2FsRFBJKFdpZGdldCogd2lkZ2V0KQotewotICAgIFBsYXRmb3JtUGFnZUNsaWVu dCBjbGllbnQgPSB0b1BsYXRmb3JtUGFnZUNsaWVudCh3aWRnZXQpOwotICAgIGlmICghY2xpZW50 KQotICAgICAgICByZXR1cm4gMDsKLSAgICByZXR1cm4gY2xpZW50LT5zY3JlZW5JbmZvKCkudmVy dGljYWxEUEk7Ci19Ci0KIGludCBzY3JlZW5EZXB0aChXaWRnZXQqIHdpZGdldCkKIHsKICAgICBQ bGF0Zm9ybVBhZ2VDbGllbnQgY2xpZW50ID0gdG9QbGF0Zm9ybVBhZ2VDbGllbnQod2lkZ2V0KTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9QbGF0Zm9ybVNjcmVlbkVm bC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUGxhdGZvcm1TY3JlZW5FZmwuY3Bw CmluZGV4IDBlMjA3YWExMGRmMjRhN2MyZDU1ZmVlOTdhMDUxYzliZDBkMTRmNWIuLjFjYjFkZWNk ZWNmNDdkYzMzZThlMmNlODgyNDY4Njk3Mjk3Y2FmZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2VmbC9QbGF0Zm9ybVNjcmVlbkVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL1BsYXRmb3JtU2NyZWVuRWZsLmNwcApAQCAtNDgsMTggKzQ4LDYgQEAK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1pbnQgc2NyZWVuSG9yaXpvbnRhbERQSShXaWRnZXQq KQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIDA7Ci19Ci0KLWludCBzY3Jl ZW5WZXJ0aWNhbERQSShXaWRnZXQqKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0 dXJuIDA7Ci19Ci0KIGludCBzY3JlZW5EZXB0aChXaWRnZXQqKQogewogI2lmZGVmIEhBVkVfRUNP UkVfWApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1BsYXRmb3JtU2Ny ZWVuR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0 ay5jcHAKaW5kZXggNzEyNTQwMzU2OWU0MmJkZDdkMzczOGMwMDAxMjg3OTFlYmQ1MjRiZC4uMTJj Nzg4MjJlNjNjOTBkYWEzMjExYmE2MTcyMzI0YTBjNWY5MTZjOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1BsYXRmb3JtU2NyZWVuR3RrLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwCkBAIC02MCwxOCArNjAs NiBAQCBzdGF0aWMgR2RrVmlzdWFsKiBnZXRWaXN1YWwoV2lkZ2V0KiB3aWRnZXQpCiAgICAgcmV0 dXJuIGNvbnRhaW5lciA/IGdka193aW5kb3dfZ2V0X3Zpc3VhbChndGtfd2lkZ2V0X2dldF93aW5k b3coY29udGFpbmVyKSkgOiAwOwogfQogCi1pbnQgc2NyZWVuSG9yaXpvbnRhbERQSShXaWRnZXQq IHdpZGdldCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiAwOwotfQotCi1p bnQgc2NyZWVuVmVydGljYWxEUEkoV2lkZ2V0KiB3aWRnZXQpCi17Ci0gICAgbm90SW1wbGVtZW50 ZWQoKTsKLSAgICByZXR1cm4gMDsKLX0KLQogaW50IHNjcmVlbkRlcHRoKFdpZGdldCogd2lkZ2V0 KQogewogICAgIEdka1Zpc3VhbCogdmlzdWFsID0gZ2V0VmlzdWFsKHdpZGdldCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0KaW5kZXggNzFj YzRhMTQ5YWE5MzhkNDRiNWE4NDgxZWZkZWNiM2RiYmM5MDk3NC4uMGM3NTU5Yjk4NmJjMTU3MmQ4 ZjRlZjJkNTI4ODdiNTI1ZGI4NTQyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQpAQCAtMzQsMTggKzM0LDYgQEAKIAogbmFtZXNwYWNl IFdlYkNvcmUgewogCi1pbnQgc2NyZWVuSG9yaXpvbnRhbERQSShXaWRnZXQqKQotewotICAgIG5v dEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIDA7Ci19Ci0KLWludCBzY3JlZW5WZXJ0aWNhbERQ SShXaWRnZXQqKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIDA7Ci19Ci0K IGludCBzY3JlZW5EZXB0aChXaWRnZXQqKQogewogICAgIHJldHVybiBOU0JpdHNQZXJQaXhlbEZy b21EZXB0aChbW05TU2NyZWVuIGRlZXBlc3RTY3JlZW5dIGRlcHRoXSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybVNjcmVlblF0LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtU2NyZWVuUXQuY3BwCmluZGV4IGQwODIzMDI5OTVj YmE0YmQ2NzJiZWYzZWM1ZjA5OWM0ZWJiMDYxZGIuLmNlNDVhZjRkODNjMGQwNjVjZjEzYTMzZmFh ZTZlNmE2MjQxYzAxMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Bs YXRmb3JtU2NyZWVuUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRm b3JtU2NyZWVuUXQuY3BwCkBAIC00MywxOCArNDMsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKLWludCBzY3JlZW5Ib3Jpem9udGFsRFBJKFdpZGdldCogd2lkZ2V0KQotewotICAgIG5vdElt cGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIDA7Ci19Ci0KLWludCBzY3JlZW5WZXJ0aWNhbERQSShX aWRnZXQqIHdpZGdldCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiAwOwot fQotCiBzdGF0aWMgaW50IHNjcmVlbk51bWJlcihXaWRnZXQqIHcpCiB7CiAgICAgaWYgKCF3KQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1BsYXRmb3JtU2NyZWVuV2lu LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9QbGF0Zm9ybVNjcmVlbldpbi5jcHAK aW5kZXggNWVhMjRiNDE0YTc1NjJmYzc3NjE3ZGZmY2IzZjVkNDQ0ZGZlMzVlMC4uYmIxYmNiMDY5 YmE4MmM1OGM3M2IzOWQ1ZTgyMTJhMmIyOGRlZTdlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vd2luL1BsYXRmb3JtU2NyZWVuV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vUGxhdGZvcm1TY3JlZW5XaW4uY3BwCkBAIC02NiwxOCArNjYsNiBAQCBz dGF0aWMgREVWTU9ERSBkZXZpY2VJbmZvRm9yV2lkZ2V0KFdpZGdldCogd2lkZ2V0KQogICAgIHJl dHVybiBkZXZpY2VJbmZvOwogfQogCi1pbnQgc2NyZWVuSG9yaXpvbnRhbERQSShXaWRnZXQqIHdp ZGdldCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiAwOwotfQotCi1pbnQg c2NyZWVuVmVydGljYWxEUEkoV2lkZ2V0KiB3aWRnZXQpCi17Ci0gICAgbm90SW1wbGVtZW50ZWQo KTsKLSAgICByZXR1cm4gMDsKLX0KLQogaW50IHNjcmVlbkRlcHRoKFdpZGdldCogd2lkZ2V0KQog ewogICAgIERFVk1PREUgZGV2aWNlSW5mbyA9IGRldmljZUluZm9Gb3JXaWRnZXQod2lkZ2V0KTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3d4L1NjcmVlbld4LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3d4L1NjcmVlbld4LmNwcAppbmRleCA0MWVkZjE1NjE2OWQ1 MGY2MzI3NWE1Y2VjN2M5ZWRiMTg0NWM3NmVlLi4yOWIwYWE1ZTYxNjZkNzc4MTI1MGU2YWM5MTk1 ZWVhNjBhNGYzNDUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93eC9TY3Jl ZW5XeC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd3gvU2NyZWVuV3guY3BwCkBA IC0zNywxNyArMzcsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgCi1pbnQgc2NyZWVu SG9yaXpvbnRhbERQSShXaWRnZXQqKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0 dXJuIDA7Ci19Ci1pbnQgc2NyZWVuVmVydGljYWxEUEkoV2lkZ2V0KikKLXsKLSAgICBub3RJbXBs ZW1lbnRlZCgpOwotICAgIHJldHVybiAwOwotfQotICAgIAogRmxvYXRSZWN0IHNjcmVlblJlY3Qo V2lkZ2V0KiB3aWRnZXQpCiB7CiAvKgo=