101762 2012-11-09 07:54:26 -0800 [EFL] Turn on errors on warnings for WebKit1 and WebKit2 libraries 2012-11-12 22:55:46 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102038 1 laszlo.gombos ktf.kim gyuyoung.kim jinwoo7.song ktf.kim lucas.de.marchi rakuco ryuan.choi webkit.review.bot oldest_to_newest 763020 0 laszlo.gombos 2012-11-09 07:54:26 -0800 Introduce the following change and fix the resulting build failures... Index: Source/CMakeLists.txt IF (ENABLE_WEBKIT) - WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME}) + WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit_LIBRARY_NAME} ${ADDITIONAL_FLAGS}) ENDIF () IF (ENABLE_WEBKIT2) - WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME}) + WEBKIT_SET_EXTRA_COMPILER_FLAGS(${WebKit2_LIBRARY_NAME} ${ADDITIONAL_FLAGS}) ENDIF () 763037 1 laszlo.gombos 2012-11-09 08:10:25 -0800 Would be great to look into this as well. /build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized] /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized] 764153 2 ktf.kim 2012-11-12 01:46:28 -0800 The 2 warnings are false alarms. In ewk_tiled_backing_store.cpp:1857, Eina_Tile_Grid_Slicer slicer is defined, and is initialized through eina_tile_grid_slicer_setup but eina_tile_grid_slicer_next doesn't know it is initialized. I wonder whether additional initialization is needed here for fixing build warning. WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x: In function 'bool ewk_tiled_backing_store_pre_render_region(Evas_Object*, Evas_Coord, Evas_Coord, Evas_Coord, Evas_Coord, float)': WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::tile_w' may be used uninitialized in this function [-Wuninitialized] Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::tile_w' was declared here WebKitBuild/Dependencies/Root/include/eina-1/eina/eina_inline_tiler.x:82:4: warning: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' may be used uninitialized in this function [-Wuninitialized] Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1857:27: note: 'slicer._Eina_Tile_Grid_Slicer::w2_rel' was declared here 764271 3 173619 ktf.kim 2012-11-12 04:42:57 -0800 Created attachment 173619 Patch 764273 4 173619 ktf.kim 2012-11-12 04:46:17 -0800 Comment on attachment 173619 Patch It can make build error on 32bit build bot until the 2 warnings issue (that warnings are only occurred on 32bit build bot now) is resolved. 765200 5 173619 gyuyoung.kim 2012-11-12 21:26:54 -0800 Comment on attachment 173619 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173619&action=review > ChangeLog:3 > + [EFL]Turn on errors on warnings for WebKit1 and WebKit2 libraries Add a space between [EFL] and Turn. 765211 6 173813 ktf.kim 2012-11-12 21:40:39 -0800 Created attachment 173813 Patch 765275 7 173813 webkit.review.bot 2012-11-12 22:55:41 -0800 Comment on attachment 173813 Patch Clearing flags on attachment: 173813 Committed r134368: <http://trac.webkit.org/changeset/134368> 765276 8 webkit.review.bot 2012-11-12 22:55:46 -0800 All reviewed patches have been landed. Closing bug. 173619 2012-11-12 04:42:57 -0800 2012-11-12 21:40:33 -0800 Patch bug-101762-20121112214105.patch text/plain 1400 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvQ01ha2VMaXN0 cy50eHQgYi9Tb3VyY2UvQ01ha2VMaXN0cy50eHQKaW5kZXggYzg0M2YwYTIyNGY0NDBjNjA3ZTAz ZjM4MDlhNTIyMTRlZWUxNzlkYi4uODAwNDdjMTJmMjA4YmIyNmIyMDlmYWQ0YjIwZTEyZjJkODRm ZDJhNSAxMDA2NDQKLS0tIGEvU291cmNlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9DTWFr ZUxpc3RzLnR4dApAQCAtMzksMTEgKzM5LDExIEBAIElGIChFTkFCTEVfV0VCQ09SRSkKIEVORElG ICgpCiAKIElGIChFTkFCTEVfV0VCS0lUKQotICAgIFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJf RkxBR1MoJHtXZWJLaXRfTElCUkFSWV9OQU1FfSkKKyAgICBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJ TEVSX0ZMQUdTKCR7V2ViS2l0X0xJQlJBUllfTkFNRX0gJHtBRERJVElPTkFMX0ZMQUdTfSkKIEVO RElGICgpCiAKIElGIChFTkFCTEVfV0VCS0lUMikKLSAgICBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJ TEVSX0ZMQUdTKCR7V2ViS2l0Ml9MSUJSQVJZX05BTUV9KQorICAgIFdFQktJVF9TRVRfRVhUUkFf Q09NUElMRVJfRkxBR1MoJHtXZWJLaXQyX0xJQlJBUllfTkFNRX0gJHtBRERJVElPTkFMX0ZMQUdT fSkKIEVORElGICgpCiAKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCA0NzViODRkNmU1NzBjY2VlODNjZjA4ZTU0N2JkMmNlMDIx M2U1MjhjLi4xMmM5NjgwMmQ2YWRlMzE4Y2UzMDVmNmNkZWYxNGFkNjkxZGNiOWZkIDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTEt MTIgIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1U dXJuIG9uIGVycm9ycyBvbiB3YXJuaW5ncyBmb3IgV2ViS2l0MSBhbmQgV2ViS2l0MiBsaWJyYXJp ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTc2 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGNh c2Ugb2YgRUZMLCBhZGQgRU5BQkxFX1dFUlJPUiB0byBFWFRSQV9DT01QSUxFUl9GTEFHUyBmb3Ig V0VCS0lUIGFuZCBXRUJLSVQyCisKKyAgICAgICAgKiBTb3VyY2UvQ01ha2VMaXN0cy50eHQ6CisK IDIwMTItMTEtMTEgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtTaGFkb3ddIEVsZW1lbnRTaGFkb3cgc2hvdWxkIGhhdmUgUnVsZUZlYXR1cmVTZXQg Zm9yIHNlbGVjdCBhdHRyaWJ1dGUgc2VsZWN0b3JzLgo= 173813 2012-11-12 21:40:39 -0800 2012-11-12 22:55:41 -0800 Patch bug-101762-20121113143840.patch text/plain 1418 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvQ01ha2VMaXN0 cy50eHQgYi9Tb3VyY2UvQ01ha2VMaXN0cy50eHQKaW5kZXggYzg0M2YwYTIyNGY0NDBjNjA3ZTAz ZjM4MDlhNTIyMTRlZWUxNzlkYi4uODAwNDdjMTJmMjA4YmIyNmIyMDlmYWQ0YjIwZTEyZjJkODRm ZDJhNSAxMDA2NDQKLS0tIGEvU291cmNlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9DTWFr ZUxpc3RzLnR4dApAQCAtMzksMTEgKzM5LDExIEBAIElGIChFTkFCTEVfV0VCQ09SRSkKIEVORElG ICgpCiAKIElGIChFTkFCTEVfV0VCS0lUKQotICAgIFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJf RkxBR1MoJHtXZWJLaXRfTElCUkFSWV9OQU1FfSkKKyAgICBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJ TEVSX0ZMQUdTKCR7V2ViS2l0X0xJQlJBUllfTkFNRX0gJHtBRERJVElPTkFMX0ZMQUdTfSkKIEVO RElGICgpCiAKIElGIChFTkFCTEVfV0VCS0lUMikKLSAgICBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJ TEVSX0ZMQUdTKCR7V2ViS2l0Ml9MSUJSQVJZX05BTUV9KQorICAgIFdFQktJVF9TRVRfRVhUUkFf Q09NUElMRVJfRkxBR1MoJHtXZWJLaXQyX0xJQlJBUllfTkFNRX0gJHtBRERJVElPTkFMX0ZMQUdT fSkKIEVORElGICgpCiAKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiZDdhNjhjNDFhNWJjZDFjY2M2NzQ1NzE0ZTJmYWEzZmQ3 ODg4ODhkLi4xOWJkOTA5OGQ2YmE2NTE3ZDMyNjNmZmJkYTg3M2FmNjE4ZDgzNWIwIDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTItMTEt MTIgIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF0g VHVybiBvbiBlcnJvcnMgb24gd2FybmluZ3MgZm9yIFdlYktpdDEgYW5kIFdlYktpdDIgbGlicmFy aWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE3 NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBj YXNlIG9mIEVGTCwgYWRkIEVOQUJMRV9XRVJST1IgdG8gRVhUUkFfQ09NUElMRVJfRkxBR1MgZm9y IFdFQktJVCBhbmQgV0VCS0lUMgorCisgICAgICAgICogU291cmNlL0NNYWtlTGlzdHMudHh0Ogor CisyMDEyLTExLTEyICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCiAgICAg ICAgIFtFRkxdIFR1cm4gb24gZXJyb3Igb24gd2FybmluZ3MgZm9yICJzd2l0Y2giCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE3NjAKIAo=