<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>101761</bug_id>
          
          <creation_ts>2012-11-09 07:51:12 -0800</creation_ts>
          <short_desc>[EFL] Turn on error on warnings for &quot;sign-compare&quot;</short_desc>
          <delta_ts>2012-11-14 01:58:28 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>101458</dependson>
    
    <dependson>102061</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="KyungTae Kim">ktf.kim</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>jinwoo7.song</cc>
    
    <cc>ktf.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>763019</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2012-11-09 07:51:12 -0800</bug_when>
    <thetext>Remove &quot;-Wno-error=sign-compare&quot; from Source/cmake/WebKitHelpers.cmake and fix the remaining build errors - if any.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763036</commentid>
    <comment_count>1</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2012-11-09 08:09:27 -0800</bug_when>
    <thetext>WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:110:130: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

WebCore/platform/posix/SharedBufferPOSIX.cpp:55:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>764063</commentid>
    <comment_count>2</comment_count>
    <who name="KyungTae Kim">ktf.kim</who>
    <bug_when>2012-11-11 22:46:23 -0800</bug_when>
    <thetext>There&apos;s an argue related with the below bug on 101458 now.
WebCore/platform/posix/SharedBufferPOSIX.cpp:55:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766087</commentid>
    <comment_count>3</comment_count>
      <attachid>173998</attachid>
    <who name="KyungTae Kim">ktf.kim</who>
    <bug_when>2012-11-13 15:01:53 -0800</bug_when>
    <thetext>Created attachment 173998
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766156</commentid>
    <comment_count>4</comment_count>
      <attachid>173998</attachid>
    <who name="EFL EWS Bot">eflews.bot</who>
    <bug_when>2012-11-13 16:19:08 -0800</bug_when>
    <thetext>Comment on attachment 173998
Patch

Attachment 173998 did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14826351</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766452</commentid>
    <comment_count>5</comment_count>
      <attachid>174079</attachid>
    <who name="KyungTae Kim">ktf.kim</who>
    <bug_when>2012-11-13 22:39:16 -0800</bug_when>
    <thetext>Created attachment 174079
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766562</commentid>
    <comment_count>6</comment_count>
      <attachid>174079</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-14 00:38:23 -0800</bug_when>
    <thetext>Comment on attachment 174079
Patch

Rejecting attachment 174079 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
(content): Merge conflict in LayoutTests/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 After r134205 was rolled out in http://trac.webkit.org/changeset/134425,

When you have resolved this problem run &quot;git rebase --continue&quot;.
If you would prefer to skip this patch, instead run &quot;git rebase --skip&quot;.
To restore the original branch and stop rebasing run &quot;git rebase --abort&quot;.

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14831256</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766591</commentid>
    <comment_count>7</comment_count>
      <attachid>174101</attachid>
    <who name="KyungTae Kim">ktf.kim</who>
    <bug_when>2012-11-14 01:07:44 -0800</bug_when>
    <thetext>Created attachment 174101
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766644</commentid>
    <comment_count>8</comment_count>
      <attachid>174101</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-14 01:58:24 -0800</bug_when>
    <thetext>Comment on attachment 174101
Patch

Clearing flags on attachment: 174101

Committed r134578: &lt;http://trac.webkit.org/changeset/134578&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766645</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-14 01:58:28 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>173998</attachid>
            <date>2012-11-13 15:01:53 -0800</date>
            <delta_ts>2012-11-13 22:39:11 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-101761-20121114075953.patch</filename>
            <type>text/plain</type>
            <size>1354</size>
            <attacher name="KyungTae Kim">ktf.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4
IGEzNTA0YjNmNTNlOGQ0ZjdjOTdlNWVlNTgxOGY1ZjQ2NmJkMzBiMjguLmRhYjU4MDdmYjQ4MDcz
NDJiODA4M2EwMmY5Zjc2YTdkNjI0N2Y2YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL
aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA
IC00Miw3ICs0Miw3IEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3Rh
cmdldCkKIAogICAgICMgRW5hYmxlIGVycm9ycyBvbiB3YXJuaW5nCiAgICAgSUYgKE9QVElPTl9F
TkFCTEVfV0VSUk9SKQotICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJ
TEVfRkxBR1N9IC1XZXJyb3IgLVduby1lcnJvcj11bnVzZWQtcGFyYW1ldGVyIC1Xbm8tZXJyb3I9
c2lnbi1jb21wYXJlIikKKyAgICAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICIke09MRF9DT01Q
SUxFX0ZMQUdTfSAtV2Vycm9yIC1Xbm8tZXJyb3I9dW51c2VkLXBhcmFtZXRlciIpCiAgICAgRU5E
SUYgKCkKIAogICAgICMgRGlzYWJsZSBDKysweCBjb21wYXQgd2FybmluZ3MgZm9yIEdDQyA+PSA0
LjYuMCB1bnRpbCB3ZSBidWlsZApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmlu
ZGV4IDU2YTQ5OTNhNmU0OThiZDg1N2Y1NzI0NDI4NDY3Mjk1MDFkMTQ0YmUuLmU3YzJlN2Q1MWQ0
ZThhM2RkZmU5OTI4NDRiYmNjZjRhNGZiNTFiMzQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg
Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMS0xMyAgS3l1bmdUYWUgS2ltICA8
a3RmLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBUdXJuIG9uIGVycm9yIG9uIHdh
cm5pbmdzIGZvciAic2lnbi1jb21wYXJlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgUmVtb3ZlICItV25vLWVycm9yPXNpZ24tY29tcGFyZSIgZm9yIHR1
cm5pbmcgb24gZXJyb3Igb24gd2FybmluZ3MgZm9yICJzaWduLWNvbXBhcmUiCisKKyAgICAgICAg
KiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxMi0xMS0xMyAgSHVnbyBQ
YXJlbnRlIExpbWEgIDxodWdvLmxpbWFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBGaW5kR0xJ
Qi5jbWFrZSBmYWlscyBkbyBmaW5kIGdsaWIgZ21vZHVsZSBtb2R1bGUuCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>174079</attachid>
            <date>2012-11-13 22:39:16 -0800</date>
            <delta_ts>2012-11-14 01:07:37 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-101761-20121114153716.patch</filename>
            <type>text/plain</type>
            <size>1350</size>
            <attacher name="KyungTae Kim">ktf.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4
IGEzNTA0YjNmNTNlOGQ0ZjdjOTdlNWVlNTgxOGY1ZjQ2NmJkMzBiMjguLmRhYjU4MDdmYjQ4MDcz
NDJiODA4M2EwMmY5Zjc2YTdkNjI0N2Y2YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL
aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA
IC00Miw3ICs0Miw3IEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3Rh
cmdldCkKIAogICAgICMgRW5hYmxlIGVycm9ycyBvbiB3YXJuaW5nCiAgICAgSUYgKE9QVElPTl9F
TkFCTEVfV0VSUk9SKQotICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJ
TEVfRkxBR1N9IC1XZXJyb3IgLVduby1lcnJvcj11bnVzZWQtcGFyYW1ldGVyIC1Xbm8tZXJyb3I9
c2lnbi1jb21wYXJlIikKKyAgICAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICIke09MRF9DT01Q
SUxFX0ZMQUdTfSAtV2Vycm9yIC1Xbm8tZXJyb3I9dW51c2VkLXBhcmFtZXRlciIpCiAgICAgRU5E
SUYgKCkKIAogICAgICMgRGlzYWJsZSBDKysweCBjb21wYXQgd2FybmluZ3MgZm9yIEdDQyA+PSA0
LjYuMCB1bnRpbCB3ZSBidWlsZApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmlu
ZGV4IDU2YTQ5OTNhNmU0OThiZDg1N2Y1NzI0NDI4NDY3Mjk1MDFkMTQ0YmUuLjgyYjE4ZTZlNjhi
YTE0YjYxZmQ1Njk1ZTk0Y2ZmMzg1MTJlNmQyMGEgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg
Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMS0xMyAgS3l1bmdUYWUgS2ltICA8
a3RmLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBUdXJuIG9uIGVycm9yIG9uIHdh
cm5pbmdzIGZvciAic2lnbi1jb21wYXJlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgUmVtb3ZlICItV25vLWVycm9yPXNpZ24tY29tcGFyZSIgdG8gdHVy
biBvbiBlcnJvciBvbiB3YXJuaW5ncyBmb3IgInNpZ24tY29tcGFyZSIKKworICAgICAgICAqIFNv
dXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlOgorCiAyMDEyLTExLTEzICBIdWdvIFBhcmVu
dGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEZpbmRHTElCLmNt
YWtlIGZhaWxzIGRvIGZpbmQgZ2xpYiBnbW9kdWxlIG1vZHVsZS4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>174101</attachid>
            <date>2012-11-14 01:07:44 -0800</date>
            <delta_ts>2012-11-14 01:58:24 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-101761-20121114180543.patch</filename>
            <type>text/plain</type>
            <size>1348</size>
            <attacher name="KyungTae Kim">ktf.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi
S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4
IGEzNTA0YjNmNTNlOGQ0ZjdjOTdlNWVlNTgxOGY1ZjQ2NmJkMzBiMjguLmRhYjU4MDdmYjQ4MDcz
NDJiODA4M2EwMmY5Zjc2YTdkNjI0N2Y2YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL
aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA
IC00Miw3ICs0Miw3IEBAIE1BQ1JPKFdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MgX3Rh
cmdldCkKIAogICAgICMgRW5hYmxlIGVycm9ycyBvbiB3YXJuaW5nCiAgICAgSUYgKE9QVElPTl9F
TkFCTEVfV0VSUk9SKQotICAgICAgICBTRVQoT0xEX0NPTVBJTEVfRkxBR1MgIiR7T0xEX0NPTVBJ
TEVfRkxBR1N9IC1XZXJyb3IgLVduby1lcnJvcj11bnVzZWQtcGFyYW1ldGVyIC1Xbm8tZXJyb3I9
c2lnbi1jb21wYXJlIikKKyAgICAgICAgU0VUKE9MRF9DT01QSUxFX0ZMQUdTICIke09MRF9DT01Q
SUxFX0ZMQUdTfSAtV2Vycm9yIC1Xbm8tZXJyb3I9dW51c2VkLXBhcmFtZXRlciIpCiAgICAgRU5E
SUYgKCkKIAogICAgICMgRGlzYWJsZSBDKysweCBjb21wYXQgd2FybmluZ3MgZm9yIEdDQyA+PSA0
LjYuMCB1bnRpbCB3ZSBidWlsZApkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmlu
ZGV4IDU2YTQ5OTNhNmU0OThiZDg1N2Y1NzI0NDI4NDY3Mjk1MDFkMTQ0YmUuLmU2MjhlNjQyNGQ4
YTY5Y2EzOTRiYzNmOTM5N2U0MDUxYWNlNDAxNDIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysg
Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMS0xNCAgS3l1bmdUYWUgS2ltICA8
a3RmLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBUdXJuIG9uIGVycm9yIG9uIHdh
cm5pbmdzIGZvciAic2lnbi1jb21wYXJlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNzYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR3l1eW91bmcg
S2ltLgorCisgICAgICAgIFJlbW92ZSAiLVduby1lcnJvcj1zaWduLWNvbXBhcmUiIHRvIHR1cm4g
b24gZXJyb3Igb24gd2FybmluZ3MgZm9yICJzaWduLWNvbXBhcmUiCisKKyAgICAgICAgKiBTb3Vy
Y2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToKKwogMjAxMi0xMS0xMyAgSHVnbyBQYXJlbnRl
IExpbWEgIDxodWdvLmxpbWFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBGaW5kR0xJQi5jbWFr
ZSBmYWlscyBkbyBmaW5kIGdsaWIgZ21vZHVsZSBtb2R1bGUuCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>