101737 2012-11-09 03:15:15 -0800 Web Inspector: Timeline: fix test expectations 2012-11-12 04:40:37 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eustas.bug eustas.bug apavlov caseq eustas.bug keishi loislo ossy pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 762785 0 eustas.bug 2012-11-09 03:15:15 -0800 The expected order of timeline records of specific types has been changed: https://bugs.webkit.org/show_bug.cgi?id=101544 This change fixes test expectations. 762790 1 173255 eustas.bug 2012-11-09 03:19:16 -0800 Created attachment 173255 Patch 762808 2 173255 yurys 2012-11-09 03:52:29 -0800 Comment on attachment 173255 Patch You may want to update TestExpectations as well. 762820 3 eustas.bug 2012-11-09 04:24:03 -0800 (In reply to comment #2) > (From update of attachment 173255 [details]) > You may want to update TestExpectations as well. OK. Test was marked as text-flaky on 03'Jul but reason wasn't specified. 762829 4 173264 eustas.bug 2012-11-09 04:34:26 -0800 Created attachment 173264 Patch 762857 5 yurys 2012-11-09 05:06:58 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 173255 [details] [details]) > > You may want to update TestExpectations as well. > > OK. > > Test was marked as text-flaky on 03'Jul but reason wasn't specified. What about Mac and Wind bots, does it pass there? If so then the expectations will be wrong for those platforms after this change. 762873 6 eustas.bug 2012-11-09 05:22:23 -0800 (In reply to comment #5) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 173255 [details] [details] [details]) > > > You may want to update TestExpectations as well. > > > > OK. > > > > Test was marked as text-flaky on 03'Jul but reason wasn't specified. > > What about Mac and Wind bots, does it pass there? If so then the expectations will be wrong for those platforms after this change. This expectations should work for all platforms. Before the change we got "Send Request" arriving in timeline before enclosing record. The tested scenario is: cause "send request", when data arrives, cause second "send request" from within notification event. So, before the change "send request" record arrived before second "function call" and before the first (notification) "event". That resulted the following sequence: function call, send request A ->, function call A, send request B ->, event B, event After change "send request" should arrive after enclosing record. As a result we get: function call, function call A, <- send request A, event B, <- send request B, event This order should be platform independent, because all events are explicitly chained (except first function call). I believe Mac and Win bots will be happy. 764267 7 173264 ossy 2012-11-12 04:40:31 -0800 Comment on attachment 173264 Patch Clearing flags on attachment: 173264 Committed r134212: <http://trac.webkit.org/changeset/134212> 764268 8 ossy 2012-11-12 04:40:37 -0800 All reviewed patches have been landed. Closing bug. 173255 2012-11-09 03:19:16 -0800 2012-11-09 04:34:21 -0800 Patch bug-101737-20121109151723.patch text/plain 1709 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDAzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODFiMDI4YTA2MmZiMjc3NzExYzA4 MjMzZmE2NWQyZmU0MmNkMzU4NC4uMTYxZjYwZjBiNmMzMjYxOTg4ZmQ3OTNiYzBmMjgyNmNmODhh OTkxNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA5ICBFdWdlbmUgS2x5dWNobmlr b3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBUaW1l bGluZTogZml4IHRlc3QgZXhwZWN0YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgZXhwZWN0ZWQgb3JkZXIgb2YgdGltZWxpbmUgcmVjb3Jk cyBvZiBzcGVjaWZpYyB0eXBlcworICAgICAgICBoYXZlIGJlZW4gY2hhbmdlZDogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU0NAorCisgICAgICAgIFRoaXMgY2hh bmdlIGZpeGVzIHRlc3QgZXhwZWN0YXRpb25zLgorCisgICAgICAgICogaW5zcGVjdG9yL3RpbWVs aW5lL3RpbWVsaW5lLXJlY2VpdmUtcmVzcG9uc2UtZXZlbnQtZXhwZWN0ZWQudHh0OgorCiAyMDEy LTExLTA4ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkLCB1cGRhdGUgY2hyb21pdW0gZXhwZWN0YXRpb25zIGZvciB0YWJsZXMvLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3RpbWVsaW5lL3RpbWVsaW5lLXJlY2VpdmUtcmVz cG9uc2UtZXZlbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3RpbWVsaW5l L3RpbWVsaW5lLXJlY2VpdmUtcmVzcG9uc2UtZXZlbnQtZXhwZWN0ZWQudHh0CmluZGV4IDc1ZmIw NDM2YmQ3ZjlmOTBkOWFhMjJmYWQyMjVjM2I3ZjViMDZkZTEuLmFkOWZhNmMzMmI2NGU2NGM1MzFm ZGFkOTg0ZGYzNTFmNjU2Y2RjMGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci90 aW1lbGluZS90aW1lbGluZS1yZWNlaXZlLXJlc3BvbnNlLWV2ZW50LWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdGltZWxpbmUvdGltZWxpbmUtcmVjZWl2ZS1yZXNwb25z ZS1ldmVudC1leHBlY3RlZC50eHQKQEAgLTEsMTcgKzEsMTcgQEAKIFRlc3RzIHRoZSBUaW1lbGlu ZSBBUEkgaW5zdHJ1bWVudGF0aW9uIG9mIGEgU2VuZFJlcXVlc3QsIFJlY2VpdmVSZXNwb25zZSBl dGMuCiAKIEZ1bmN0aW9uQ2FsbAorRnVuY3Rpb25DYWxsCiBSZXNvdXJjZVNlbmRSZXF1ZXN0CiAg ICAgUmVzb3VyY2VSZWNlaXZlUmVzcG9uc2UKICAgICBSZXNvdXJjZVJlY2VpdmVkRGF0YQogICAg IFJlc291cmNlRmluaXNoCi1GdW5jdGlvbkNhbGwKK0V2ZW50RGlzcGF0Y2gKKyAgICBGdW5jdGlv bkNhbGwKIFJlc291cmNlU2VuZFJlcXVlc3QKICAgICBSZXNvdXJjZVJlY2VpdmVSZXNwb25zZQog ICAgIFJlc291cmNlUmVjZWl2ZWREYXRhCiAgICAgUmVzb3VyY2VGaW5pc2gKIEV2ZW50RGlzcGF0 Y2gKICAgICBGdW5jdGlvbkNhbGwKLUV2ZW50RGlzcGF0Y2gKLSAgICBGdW5jdGlvbkNhbGwKIAo= 173264 2012-11-09 04:34:26 -0800 2012-11-12 04:40:31 -0800 Patch bug-101737-20121109163233.patch text/plain 2686 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDAzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODFiMDI4YTA2MmZiMjc3NzExYzA4 MjMzZmE2NWQyZmU0MmNkMzU4NC4uZmY4MDNiMGI5NzJhZTllOTdjMzM4YWQ5MzlmOTE3ODE3YjYw ZDdmYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTA5ICBFdWdlbmUgS2x5dWNobmlr b3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBUaW1l bGluZTogZml4IHRlc3QgZXhwZWN0YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgZXhwZWN0ZWQgb3JkZXIgb2YgdGltZWxpbmUgcmVjb3Jk cyBvZiBzcGVjaWZpYyB0eXBlcworICAgICAgICBoYXZlIGJlZW4gY2hhbmdlZDogaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU0NAorCisgICAgICAgIFRoaXMgY2hh bmdlIGZpeGVzIHRlc3QgZXhwZWN0YXRpb25zLgorICAgICAgICBBbHNvIHJlbW92ZWQgZXhwZWN0 YXRpb24gdGhhdCB0ZXN0IGNhbiBmYWlsLgorCisgICAgICAgICogaW5zcGVjdG9yL3RpbWVsaW5l L3RpbWVsaW5lLXJlY2VpdmUtcmVzcG9uc2UtZXZlbnQtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IHBsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6IFJlbW92ZWQgImZhaWwiIGV4cGVj dGF0aW9uLgorCiAyMDEyLTExLTA4ICBIYXlhdG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCB1cGRhdGUgY2hyb21pdW0gZXhwZWN0YXRpb25zIGZvciB0 YWJsZXMvLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3RpbWVsaW5lL3RpbWVs aW5lLXJlY2VpdmUtcmVzcG9uc2UtZXZlbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL3RpbWVsaW5lL3RpbWVsaW5lLXJlY2VpdmUtcmVzcG9uc2UtZXZlbnQtZXhwZWN0ZWQu dHh0CmluZGV4IDc1ZmIwNDM2YmQ3ZjlmOTBkOWFhMjJmYWQyMjVjM2I3ZjViMDZkZTEuLmFkOWZh NmMzMmI2NGU2NGM1MzFmZGFkOTg0ZGYzNTFmNjU2Y2RjMGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2luc3BlY3Rvci90aW1lbGluZS90aW1lbGluZS1yZWNlaXZlLXJlc3BvbnNlLWV2ZW50LWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdGltZWxpbmUvdGltZWxpbmUt cmVjZWl2ZS1yZXNwb25zZS1ldmVudC1leHBlY3RlZC50eHQKQEAgLTEsMTcgKzEsMTcgQEAKIFRl c3RzIHRoZSBUaW1lbGluZSBBUEkgaW5zdHJ1bWVudGF0aW9uIG9mIGEgU2VuZFJlcXVlc3QsIFJl Y2VpdmVSZXNwb25zZSBldGMuCiAKIEZ1bmN0aW9uQ2FsbAorRnVuY3Rpb25DYWxsCiBSZXNvdXJj ZVNlbmRSZXF1ZXN0CiAgICAgUmVzb3VyY2VSZWNlaXZlUmVzcG9uc2UKICAgICBSZXNvdXJjZVJl Y2VpdmVkRGF0YQogICAgIFJlc291cmNlRmluaXNoCi1GdW5jdGlvbkNhbGwKK0V2ZW50RGlzcGF0 Y2gKKyAgICBGdW5jdGlvbkNhbGwKIFJlc291cmNlU2VuZFJlcXVlc3QKICAgICBSZXNvdXJjZVJl Y2VpdmVSZXNwb25zZQogICAgIFJlc291cmNlUmVjZWl2ZWREYXRhCiAgICAgUmVzb3VyY2VGaW5p c2gKIEV2ZW50RGlzcGF0Y2gKICAgICBGdW5jdGlvbkNhbGwKLUV2ZW50RGlzcGF0Y2gKLSAgICBG dW5jdGlvbkNhbGwKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0v VGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggMTZiNjFlMGI4OGUxNWFjMjVjMzk0MGNlMzliNmZiOTI3ZWIzMjUwNC4u OGFjYTFmMjI5ZmUyMDc3N2NmY2ZiMTFlZDMzMGVkNjlhYzZkYjhhNyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCkBAIC0zNTYwLDcgKzM1NjAs NyBAQCB3ZWJraXQub3JnL2IvOTAyMDcgWyBXaW4gUmVsZWFzZSBdIGZhc3QvZm9ybXMvc2VsZWN0 L3NlbGVjdC1zdGF0ZS1yZXN0b3JlLmh0bWwgWwogd2Via2l0Lm9yZy9iLzkwMjA3IFsgTWFjIERl YnVnIF0gZmFzdC9mb3Jtcy9zZWxlY3Qvc2VsZWN0LXN0YXRlLXJlc3RvcmUuaHRtbCBbIFBhc3Mg VGltZW91dCBdCiAKICMgRmxha3kKLXdlYmtpdC5vcmcvYi85MDQzMCBpbnNwZWN0b3IvdGltZWxp bmUvdGltZWxpbmUtcmVjZWl2ZS1yZXNwb25zZS1ldmVudC5odG1sIFsgRmFpbHVyZSBQYXNzIFRp bWVvdXQgXQord2Via2l0Lm9yZy9iLzkwNDMwIGluc3BlY3Rvci90aW1lbGluZS90aW1lbGluZS1y ZWNlaXZlLXJlc3BvbnNlLWV2ZW50Lmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogCiBjcmJ1Zy5jb20v MTM1NzA5IHBsYXRmb3JtL2Nocm9taXVtL2NvbXBvc2l0aW5nL3Njcm9sbGJhcnMvY3VzdG9tLWNv bXBvc2l0ZWQtZGlmZmVyZW50LXRyYWNrLXBhcnRzLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBh c3MgXQogCg==