101733 2012-11-09 02:33:59 -0800 MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level 2012-11-12 08:35:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw eric.carlson feature-media-reviews hta webkit.review.bot oldest_to_newest 762760 0 tommyw 2012-11-09 02:33:59 -0800 MediaStream API: Make sure that MediaConstraints only has optional and mandatory at the top level 762762 1 173249 tommyw 2012-11-09 02:41:32 -0800 Created attachment 173249 Patch 764351 2 173249 jochen 2012-11-12 06:30:05 -0800 Comment on attachment 173249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173249&action=review > Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp:70 > + Vector<String>::iterator it = names.begin(); why don't you put the definition of "it" inside the for ()? 764356 3 173249 tommyw 2012-11-12 06:38:31 -0800 Comment on attachment 173249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173249&action=review >> Source/WebCore/Modules/mediastream/MediaConstraintsImpl.cpp:70 >> + Vector<String>::iterator it = names.begin(); > > why don't you put the definition of "it" inside the for ()? It makes it more readable imho, I guess you prefer it all in one line? Will fix. 764367 4 173640 tommyw 2012-11-12 06:46:54 -0800 Created attachment 173640 Patch 764370 5 173640 jochen 2012-11-12 06:50:59 -0800 Comment on attachment 173640 Patch Looks good, thanks 764457 6 173640 webkit.review.bot 2012-11-12 08:35:18 -0800 Comment on attachment 173640 Patch Clearing flags on attachment: 173640 Committed r134245: <http://trac.webkit.org/changeset/134245> 764458 7 webkit.review.bot 2012-11-12 08:35:22 -0800 All reviewed patches have been landed. Closing bug. 173249 2012-11-09 02:41:32 -0800 2012-11-12 06:46:50 -0800 Patch bug-101733-20121109113939.patch text/plain 5340 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQwNGNhNjI0OWJiOWNj OGRmODg5YTRkYTFjYzU2NDIwYjNkOTBkZi4uMTZjZmMyMzBjY2U0NGVlOGM3Nzc5OTY2ZmY2N2E2 NWM4MTIyMDRhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA5ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogTWFrZSBzdXJlIHRoYXQgTWVkaWFDb25zdHJhaW50cyBvbmx5IGhhcyBvcHRpb25hbCBh bmQgbWFuZGF0b3J5IGF0IHRoZSB0b3AgbGV2ZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTczMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBiZXR0ZXIgdmVyaWZpY2F0aW9u IHRvIE1lZGlhQ29uc3RyYWludHNJbXBsLgorCisgICAgICAgIEV4aXN0aW5nIHRlc3RzIGV4cGFu ZGVkIHRvIGNvdmVyIHRoaXMgY2hhbmdlLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVh bS9NZWRpYUNvbnN0cmFpbnRzSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnN0 cmFpbnRzSW1wbDo6aW5pdGlhbGl6ZSk6CisKIDIwMTItMTEtMDggIEV1Z2VuZSBLbHl1Y2huaWtv diAgPGV1c3Rhcy5idWdAZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVs aW5lOiAiU2VuZCBSZXF1ZXN0IiBldmVudHMgYXJlIHNob3duIG91dCBvZiBvcmRlci4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFDb25zdHJhaW50 c0ltcGwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUNvbnN0 cmFpbnRzSW1wbC5jcHAKaW5kZXggZWMyZDM0YTk2OGU3NmZhZjA1ZjBhYTNhODIwMGZiOTViNWY2 MDM5NC4uMjQwZWZhZDg3NGQ1ZjQ0OTQzNmIzMDA5NmI3M2VmOTlhYmNmM2RhYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUNvbnN0cmFpbnRzSW1w bC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUNvbnN0 cmFpbnRzSW1wbC5jcHAKQEAgLTY1LDYgKzY1LDE0IEBAIGJvb2wgTWVkaWFDb25zdHJhaW50c0lt cGw6OmluaXRpYWxpemUoY29uc3QgRGljdGlvbmFyeSYgY29uc3RyYWludHMpCiAgICAgY29uc3Ry YWludHMuZ2V0T3duUHJvcGVydHlOYW1lcyhuYW1lcyk7CiAKICAgICBTdHJpbmcgbWFuZGF0b3J5 ID0gQVNDSUlMaXRlcmFsKCJtYW5kYXRvcnkiKTsKKyAgICBTdHJpbmcgb3B0aW9uYWwgPSBBU0NJ SUxpdGVyYWwoIm9wdGlvbmFsIik7CisKKyAgICBWZWN0b3I8U3RyaW5nPjo6aXRlcmF0b3IgaXQg PSBuYW1lcy5iZWdpbigpOworICAgIGZvciAoOyBpdCAhPSBuYW1lcy5lbmQoKTsgKytpdCkgewor ICAgICAgICBpZiAoKml0ICE9IG1hbmRhdG9yeSAmJiAqaXQgIT0gb3B0aW9uYWwpCisgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCiAgICAgaWYgKG5hbWVzLmNvbnRhaW5zKG1hbmRh dG9yeSkpIHsKICAgICAgICAgRGljdGlvbmFyeSBtYW5kYXRvcnlDb25zdHJhaW50czsKICAgICAg ICAgYm9vbCBvayA9IGNvbnN0cmFpbnRzLmdldChtYW5kYXRvcnksIG1hbmRhdG9yeUNvbnN0cmFp bnRzKTsKQEAgLTc2LDcgKzg0LDYgQEAgYm9vbCBNZWRpYUNvbnN0cmFpbnRzSW1wbDo6aW5pdGlh bGl6ZShjb25zdCBEaWN0aW9uYXJ5JiBjb25zdHJhaW50cykKICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKICAgICB9CiAKLSAgICBTdHJpbmcgb3B0aW9uYWwgPSBBU0NJSUxpdGVyYWwoIm9wdGlv bmFsIik7CiAgICAgaWYgKG5hbWVzLmNvbnRhaW5zKG9wdGlvbmFsKSkgewogICAgICAgICBBcnJh eVZhbHVlIG9wdGlvbmFsQ29uc3RyYWludHM7CiAgICAgICAgIGJvb2wgb2sgPSBjb25zdHJhaW50 cy5nZXQob3B0aW9uYWwsIG9wdGlvbmFsQ29uc3RyYWludHMpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGI5ZmE3NTI5YjJh YjBmZTdmNjE2OWZlNjUzMThkMDk4YWI3NDQ3MTMuLjI3Y2VhMjE4ZTY5NTY3ZWE3Y2M0NTUyMjY0 YjY0YTA1ZDQxYTljNDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0wOSAgVG9tbXkg V2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KKworICAgICAgICBNZWRpYVN0cmVhbSBB UEk6IE1ha2Ugc3VyZSB0aGF0IE1lZGlhQ29uc3RyYWludHMgb25seSBoYXMgb3B0aW9uYWwgYW5k IG1hbmRhdG9yeSBhdCB0aGUgdG9wIGxldmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE3MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgbW9yZSB0ZXN0cyBmb3IgTWVkaWFD b25zdHJhaW50cy4KKworICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rp b24tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5l Y3Rpb24uaHRtbDoKKwogMjAxMi0xMS0wOCAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRlIGNocm9taXVtLW1hYyBiYXNlbGluZXMu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0 aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNv bm5lY3Rpb24tZXhwZWN0ZWQudHh0CmluZGV4IGJiNGRhN2YxMDUwNTdlM2Q3NTA3YzIzMWMwYjM0 ZTgxMzI3MzFjNjYuLmM3YTM4MWZlYTk0MWM1OTQ0NmFiNzgwYzQ0YmZmZGI3MDk5MjcwOTAgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24t ZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNv bm5lY3Rpb24tZXhwZWN0ZWQudHh0CkBAIC0zMSw2ICszMSw5IEBAIFBBU1MgbmV3IHdlYmtpdFJU Q1BlZXJDb25uZWN0aW9uKG51bGwsIHttYW5kYXRvcnk6e3ZhbGlkX2J1dF91bnN1cHBvcnRlZF8x OjEsIHZhCiBQQVNTIG5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbihudWxsLCB7b3B0aW9uYWw6 e3ZhbGlkX2FuZF9zdXBwb3J0ZWRfMTowfX0pOyB0aHJldyBleGNlcHRpb24gRXJyb3I6IFRZUEVf TUlTTUFUQ0hfRVJSOiBET00gRXhjZXB0aW9uIDE3LgogUEFTUyBuZXcgd2Via2l0UlRDUGVlckNv bm5lY3Rpb24obnVsbCwge29wdGlvbmFsOlt7dmFsaWRfYW5kX3N1cHBvcnRlZF8xOjAsdmFsaWRf YW5kX3N1cHBvcnRlZF8yOjB9XX0pOyB0aHJldyBleGNlcHRpb24gRXJyb3I6IFRZUEVfTUlTTUFU Q0hfRVJSOiBET00gRXhjZXB0aW9uIDE3LgogUEFTUyBuZXcgd2Via2l0UlRDUGVlckNvbm5lY3Rp b24obnVsbCwge29wdGlvbmFsOlt7aW52YWxpZDowfV19KTsgdGhyZXcgZXhjZXB0aW9uIEVycm9y OiBOT1RfU1VQUE9SVEVEX0VSUjogRE9NIEV4Y2VwdGlvbiA5LgorUEFTUyBuZXcgd2Via2l0UlRD UGVlckNvbm5lY3Rpb24obnVsbCwge3ZhbGlkX2FuZF9zdXBwb3J0ZWRfMToxfSk7IHRocmV3IGV4 Y2VwdGlvbiBFcnJvcjogVFlQRV9NSVNNQVRDSF9FUlI6IERPTSBFeGNlcHRpb24gMTcuCitQQVNT IG5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbihudWxsLCB7dmFsaWRfYnV0X3Vuc3VwcG9ydGVk XzE6MX0pOyB0aHJldyBleGNlcHRpb24gRXJyb3I6IFRZUEVfTUlTTUFUQ0hfRVJSOiBET00gRXhj ZXB0aW9uIDE3LgorUEFTUyBuZXcgd2Via2l0UlRDUGVlckNvbm5lY3Rpb24obnVsbCwge3ZhbGlk X2FuZF9zdXBwb3J0ZWRfMjoxLCBtYW5kYXRvcnk6e3ZhbGlkX2FuZF9zdXBwb3J0ZWRfMToxfX0p OyB0aHJldyBleGNlcHRpb24gRXJyb3I6IFRZUEVfTUlTTUFUQ0hfRVJSOiBET00gRXhjZXB0aW9u IDE3LgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9u Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmh0 bWwKaW5kZXggNTFiYzE2NzU2N2I2MWNhNGY3NTY4YzQ1NDQ0N2Q3OTkyNmY3MjIwNy4uMWVkNzhk NWQzYjRmZjFlYmFkZmY3MDk2YTE0Y2UzOTg3ODk0ZTZlOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5odG1sCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaHRtbApAQCAtMzcsNiArMzcs OSBAQCBzaG91bGRUaHJvdygibmV3IHdlYmtpdFJUQ1BlZXJDb25uZWN0aW9uKG51bGwsIHttYW5k YXRvcnk6e3ZhbGlkX2J1dF91bnN1cHBvcnRlZAogc2hvdWxkVGhyb3coIm5ldyB3ZWJraXRSVENQ ZWVyQ29ubmVjdGlvbihudWxsLCB7b3B0aW9uYWw6e3ZhbGlkX2FuZF9zdXBwb3J0ZWRfMTowfX0p OyIpOwogc2hvdWxkVGhyb3coIm5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbihudWxsLCB7b3B0 aW9uYWw6W3t2YWxpZF9hbmRfc3VwcG9ydGVkXzE6MCx2YWxpZF9hbmRfc3VwcG9ydGVkXzI6MH1d fSk7Iik7CiBzaG91bGRUaHJvdygibmV3IHdlYmtpdFJUQ1BlZXJDb25uZWN0aW9uKG51bGwsIHtv cHRpb25hbDpbe2ludmFsaWQ6MH1dfSk7Iik7CitzaG91bGRUaHJvdygibmV3IHdlYmtpdFJUQ1Bl ZXJDb25uZWN0aW9uKG51bGwsIHt2YWxpZF9hbmRfc3VwcG9ydGVkXzE6MX0pOyIpOworc2hvdWxk VGhyb3coIm5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbihudWxsLCB7dmFsaWRfYnV0X3Vuc3Vw cG9ydGVkXzE6MX0pOyIpOworc2hvdWxkVGhyb3coIm5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlv bihudWxsLCB7dmFsaWRfYW5kX3N1cHBvcnRlZF8yOjEsIG1hbmRhdG9yeTp7dmFsaWRfYW5kX3N1 cHBvcnRlZF8xOjF9fSk7Iik7CiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KIDwvYm9keT4K 173640 2012-11-12 06:46:54 -0800 2012-11-12 08:35:18 -0800 Patch bug-101733-20121112154456.patch text/plain 5326 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRjZWI2YmI3NjM5YmRk NDQ3MDZmN2ZlODk0MTExNDJjZjMxYTY1Ni4uOTA0OGVkZjc5Y2M0ZGI0ZDljYzllOWRhYTZkMGVi N2M1NzViNmE0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA5ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogTWFrZSBzdXJlIHRoYXQgTWVkaWFDb25zdHJhaW50cyBvbmx5IGhhcyBvcHRpb25hbCBh bmQgbWFuZGF0b3J5IGF0IHRoZSB0b3AgbGV2ZWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTczMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBiZXR0ZXIgdmVyaWZpY2F0aW9u IHRvIE1lZGlhQ29uc3RyYWludHNJbXBsLgorCisgICAgICAgIEV4aXN0aW5nIHRlc3RzIGV4cGFu ZGVkIHRvIGNvdmVyIHRoaXMgY2hhbmdlLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVh bS9NZWRpYUNvbnN0cmFpbnRzSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnN0 cmFpbnRzSW1wbDo6aW5pdGlhbGl6ZSk6CisKIDIwMTItMTEtMTIgIFRvbW15IFdpZGVuZmx5Y2h0 ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBWOCBjdXN0b20gY29k ZSBmb3IgV2ViU29ja2V0cyBjb25zdHJ1Y3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYUNvbnN0cmFpbnRzSW1wbC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhQ29uc3RyYWludHNJbXBsLmNwcAppbmRleCBl YzJkMzRhOTY4ZTc2ZmFmMDVmMGFhM2E4MjAwZmI5NWI1ZjYwMzk0Li43MzlhMDQyNDIwZjM3ZjMw Y2JhNjAwNmY4ZTcyZDllYTg1ZjVkMmZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL01lZGlhQ29uc3RyYWludHNJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01lZGlhQ29uc3RyYWludHNJbXBsLmNwcApAQCAtNjUs NiArNjUsMTMgQEAgYm9vbCBNZWRpYUNvbnN0cmFpbnRzSW1wbDo6aW5pdGlhbGl6ZShjb25zdCBE aWN0aW9uYXJ5JiBjb25zdHJhaW50cykKICAgICBjb25zdHJhaW50cy5nZXRPd25Qcm9wZXJ0eU5h bWVzKG5hbWVzKTsKIAogICAgIFN0cmluZyBtYW5kYXRvcnkgPSBBU0NJSUxpdGVyYWwoIm1hbmRh dG9yeSIpOworICAgIFN0cmluZyBvcHRpb25hbCA9IEFTQ0lJTGl0ZXJhbCgib3B0aW9uYWwiKTsK KworICAgIGZvciAoVmVjdG9yPFN0cmluZz46Oml0ZXJhdG9yIGl0ID0gbmFtZXMuYmVnaW4oKTsg aXQgIT0gbmFtZXMuZW5kKCk7ICsraXQpIHsKKyAgICAgICAgaWYgKCppdCAhPSBtYW5kYXRvcnkg JiYgKml0ICE9IG9wdGlvbmFsKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwog ICAgIGlmIChuYW1lcy5jb250YWlucyhtYW5kYXRvcnkpKSB7CiAgICAgICAgIERpY3Rpb25hcnkg bWFuZGF0b3J5Q29uc3RyYWludHM7CiAgICAgICAgIGJvb2wgb2sgPSBjb25zdHJhaW50cy5nZXQo bWFuZGF0b3J5LCBtYW5kYXRvcnlDb25zdHJhaW50cyk7CkBAIC03Niw3ICs4Myw2IEBAIGJvb2wg TWVkaWFDb25zdHJhaW50c0ltcGw6OmluaXRpYWxpemUoY29uc3QgRGljdGlvbmFyeSYgY29uc3Ry YWludHMpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgU3RyaW5nIG9w dGlvbmFsID0gQVNDSUlMaXRlcmFsKCJvcHRpb25hbCIpOwogICAgIGlmIChuYW1lcy5jb250YWlu cyhvcHRpb25hbCkpIHsKICAgICAgICAgQXJyYXlWYWx1ZSBvcHRpb25hbENvbnN0cmFpbnRzOwog ICAgICAgICBib29sIG9rID0gY29uc3RyYWludHMuZ2V0KG9wdGlvbmFsLCBvcHRpb25hbENvbnN0 cmFpbnRzKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCAzOTZmYTdlZTczNGY4MmQ0ZjUyY2JhNmJhMTcxZGRhZjRkZGYzZWJj Li44N2U5MzA4OTFhYmNlOWFlZGUyZjcyMTQyOThmOTAxNjdiYzZiMWY3IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTItMTEtMDkgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5j b20+CisKKyAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBNYWtlIHN1cmUgdGhhdCBNZWRpYUNvbnN0 cmFpbnRzIG9ubHkgaGFzIG9wdGlvbmFsIGFuZCBtYW5kYXRvcnkgYXQgdGhlIHRvcCBsZXZlbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNzMzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRj aCBhZGRzIG1vcmUgdGVzdHMgZm9yIE1lZGlhQ29uc3RyYWludHMuCisKKyAgICAgICAgKiBmYXN0 L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBm YXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmh0bWw6CisKIDIwMTItMTEtMTIgIFRv bW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHRo ZSBWOCBjdXN0b20gY29kZSBmb3IgV2ViU29ja2V0cyBjb25zdHJ1Y3RvcgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWV4cGVj dGVkLnR4dAppbmRleCBiYjRkYTdmMTA1MDU3ZTNkNzUwN2MyMzFjMGIzNGU4MTMyNzMxYzY2Li5j N2EzODFmZWE5NDFjNTk0NDZhYjc4MGM0NGJmZmRiNzA5OTI3MDkwIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWV4cGVjdGVkLnR4dAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWV4cGVj dGVkLnR4dApAQCAtMzEsNiArMzEsOSBAQCBQQVNTIG5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlv bihudWxsLCB7bWFuZGF0b3J5Ont2YWxpZF9idXRfdW5zdXBwb3J0ZWRfMToxLCB2YQogUEFTUyBu ZXcgd2Via2l0UlRDUGVlckNvbm5lY3Rpb24obnVsbCwge29wdGlvbmFsOnt2YWxpZF9hbmRfc3Vw cG9ydGVkXzE6MH19KTsgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBUWVBFX01JU01BVENIX0VSUjog RE9NIEV4Y2VwdGlvbiAxNy4KIFBBU1MgbmV3IHdlYmtpdFJUQ1BlZXJDb25uZWN0aW9uKG51bGws IHtvcHRpb25hbDpbe3ZhbGlkX2FuZF9zdXBwb3J0ZWRfMTowLHZhbGlkX2FuZF9zdXBwb3J0ZWRf MjowfV19KTsgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBUWVBFX01JU01BVENIX0VSUjogRE9NIEV4 Y2VwdGlvbiAxNy4KIFBBU1MgbmV3IHdlYmtpdFJUQ1BlZXJDb25uZWN0aW9uKG51bGwsIHtvcHRp b25hbDpbe2ludmFsaWQ6MH1dfSk7IHRocmV3IGV4Y2VwdGlvbiBFcnJvcjogTk9UX1NVUFBPUlRF RF9FUlI6IERPTSBFeGNlcHRpb24gOS4KK1BBU1MgbmV3IHdlYmtpdFJUQ1BlZXJDb25uZWN0aW9u KG51bGwsIHt2YWxpZF9hbmRfc3VwcG9ydGVkXzE6MX0pOyB0aHJldyBleGNlcHRpb24gRXJyb3I6 IFRZUEVfTUlTTUFUQ0hfRVJSOiBET00gRXhjZXB0aW9uIDE3LgorUEFTUyBuZXcgd2Via2l0UlRD UGVlckNvbm5lY3Rpb24obnVsbCwge3ZhbGlkX2J1dF91bnN1cHBvcnRlZF8xOjF9KTsgdGhyZXcg ZXhjZXB0aW9uIEVycm9yOiBUWVBFX01JU01BVENIX0VSUjogRE9NIEV4Y2VwdGlvbiAxNy4KK1BB U1MgbmV3IHdlYmtpdFJUQ1BlZXJDb25uZWN0aW9uKG51bGwsIHt2YWxpZF9hbmRfc3VwcG9ydGVk XzI6MSwgbWFuZGF0b3J5Ont2YWxpZF9hbmRfc3VwcG9ydGVkXzE6MX19KTsgdGhyZXcgZXhjZXB0 aW9uIEVycm9yOiBUWVBFX01JU01BVENIX0VSUjogRE9NIEV4Y2VwdGlvbiAxNy4KIFBBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5odG1sCmluZGV4IDUxYmMx Njc1NjdiNjFjYTRmNzU2OGM0NTQ0NDdkNzk5MjZmNzIyMDcuLjFlZDc4ZDVkM2I0ZmYxZWJhZGZm NzA5NmExNGNlMzk4Nzg5NGU2ZTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFz dHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlh c3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmh0bWwKQEAgLTM3LDYgKzM3LDkgQEAgc2hvdWxkVGhy b3coIm5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbihudWxsLCB7bWFuZGF0b3J5Ont2YWxpZF9i dXRfdW5zdXBwb3J0ZWQKIHNob3VsZFRocm93KCJuZXcgd2Via2l0UlRDUGVlckNvbm5lY3Rpb24o bnVsbCwge29wdGlvbmFsOnt2YWxpZF9hbmRfc3VwcG9ydGVkXzE6MH19KTsiKTsKIHNob3VsZFRo cm93KCJuZXcgd2Via2l0UlRDUGVlckNvbm5lY3Rpb24obnVsbCwge29wdGlvbmFsOlt7dmFsaWRf YW5kX3N1cHBvcnRlZF8xOjAsdmFsaWRfYW5kX3N1cHBvcnRlZF8yOjB9XX0pOyIpOwogc2hvdWxk VGhyb3coIm5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbihudWxsLCB7b3B0aW9uYWw6W3tpbnZh bGlkOjB9XX0pOyIpOworc2hvdWxkVGhyb3coIm5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbihu dWxsLCB7dmFsaWRfYW5kX3N1cHBvcnRlZF8xOjF9KTsiKTsKK3Nob3VsZFRocm93KCJuZXcgd2Vi a2l0UlRDUGVlckNvbm5lY3Rpb24obnVsbCwge3ZhbGlkX2J1dF91bnN1cHBvcnRlZF8xOjF9KTsi KTsKK3Nob3VsZFRocm93KCJuZXcgd2Via2l0UlRDUGVlckNvbm5lY3Rpb24obnVsbCwge3ZhbGlk X2FuZF9zdXBwb3J0ZWRfMjoxLCBtYW5kYXRvcnk6e3ZhbGlkX2FuZF9zdXBwb3J0ZWRfMToxfX0p OyIpOwogPC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+CiA8L2JvZHk+Cg==