101706 2012-11-08 21:53:56 -0800 [Qt] r133953 broke the ARM_TRADITIONAL build 2012-11-11 22:42:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 101757 101832 98606 1 ossy webkit-unassigned fpizlo gaborb galpeter loki milian.wolff oliver ossy rgabor webkit.review.bot zherczeg oldest_to_newest 762549 0 ossy 2012-11-08 21:53:56 -0800 http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Build%29/builds/14679/steps/compile-webkit/logs/stdio from /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:35: /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: In member function 'JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Call JSC::DFG::SpeculativeJIT::callOperation(JSC::DFG::J_DFGOperation_EDA, JSC::DFG::GPRReg, JSC::DFG::GPRReg, JSC::DFG::FPRReg, JSC::DFG::GPRReg)': /mnt/raptor2/slaves/qt5-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1676:53: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::FPRReg&, JSC::DFG::GPRReg&)' ... and 1686:90, 1844:59, 1854:96 762645 1 173221 gaborb 2012-11-09 00:12:51 -0800 Created attachment 173221 Fix 762830 2 milian.wolff 2012-11-09 04:34:47 -0800 Thanks, that works for me. 762832 3 173221 ossy 2012-11-09 04:37:27 -0800 Comment on attachment 173221 Fix LGTM, rs=me 762835 4 173221 webkit.review.bot 2012-11-09 04:41:56 -0800 Comment on attachment 173221 Fix Clearing flags on attachment: 173221 Committed r134051: <http://trac.webkit.org/changeset/134051> 762836 5 webkit.review.bot 2012-11-09 04:42:00 -0800 All reviewed patches have been landed. Closing bug. 762970 6 ossy 2012-11-09 06:47:20 -0800 (In reply to comment #4) > (From update of attachment 173221 [details]) > Clearing flags on attachment: 173221 > > Committed r134051: <http://trac.webkit.org/changeset/134051> The build still fails: http://build.webkit.sed.hu/builders/ARMv7%20Linux%20Qt5%20Release%20%28Build%29/builds/14736/steps/compile-webkit/logs/stdio 762972 7 webkit.review.bot 2012-11-09 06:47:33 -0800 Re-opened since this is blocked by bug 101757 762987 8 ossy 2012-11-09 07:13:31 -0800 build error with the patch: /home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1676:53: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::FPRReg&, JSC::DFG::GPRReg&)' /home/oszi/WebKit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1844:59: error: no matching function for call to 'JSC::DFG::JITCompiler::setupArgumentsWithExecState(JSC::DFG::GPRReg&, JSC::DFG::GPRReg&, JSC::DFG::FPRReg&)' 763026 9 173310 gaborb 2012-11-09 07:57:47 -0800 Created attachment 173310 Patch Fix for both hardfp and softfp. 763027 10 173310 ossy 2012-11-09 07:59:16 -0800 Comment on attachment 173310 Patch LGTM, r=me. I'll land it manually. 763030 11 173310 ossy 2012-11-09 08:03:21 -0800 Comment on attachment 173310 Patch Clearing flags on attachment: 173310 Committed r134071: <http://trac.webkit.org/changeset/134071> 763032 12 ossy 2012-11-09 08:03:29 -0800 All reviewed patches have been landed. Closing bug. 173221 2012-11-09 00:12:51 -0800 2012-11-09 07:57:47 -0800 Fix fix-with-changelog.patch text/plain 1885 gaborb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM5MDQyNGMuLmU1MDhjMjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTA5ICBHYWJvciBCYWxsYWJh cyAgPGdhYm9yYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSByMTMzOTUzIGJyb2tl IHRoZSBBUk1fVFJBRElUSU9OQUwgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMTcwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgQVJNX1RSQURJVElPTkFMIGJ1aWxkIGFmdGVyIHIx MzM5NTMKKworICAgICAgICAqIGRmZy9ERkdDQ2FsbEhlbHBlcnMuaDoKKyAgICAgICAgKEpTQzo6 REZHOjpDQ2FsbEhlbHBlcnM6OnNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZSk6CisgICAgICAg IChDQ2FsbEhlbHBlcnMpOgorCiAyMDEyLTExLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgQXJyYXlQcm90b3R5cGUuaCBzaG91bGQgaGF2ZSBjb3JyZWN0IGlu ZGVudGF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NDYWxs SGVscGVycy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDQ2FsbEhlbHBlcnMuaApp bmRleCAzMDhkZGU1Li5hYTE0MTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0NDYWxsSGVscGVycy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH Q0NhbGxIZWxwZXJzLmgKQEAgLTg1Nyw2ICs4NTcsMTIgQEAgcHVibGljOgogICAgICAgICBzZXR1 cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnMyk7CiAgICAgfQogCisgICAg QUxXQVlTX0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShUcnVzdGVkSW1t MzIgYXJnMSwgR1BSUmVnIGFyZzIsIFRydXN0ZWRJbW0zMiBhcmczLCBHUFJSZWcgYXJnNCkKKyAg ICB7CisgICAgICAgIHBva2UoYXJnNCk7CisgICAgICAgIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNT dGF0ZShhcmcxLCBhcmcyLCBhcmczKTsKKyAgICB9CisKICAgICBBTFdBWVNfSU5MSU5FIHZvaWQg c2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKEdQUlJlZyBhcmcxLCBHUFJSZWcgYXJnMiwgVHJ1 c3RlZEltbTMyIGFyZzMsIEdQUlJlZyBhcmc0LCBHUFJSZWcgYXJnNSkKICAgICB7CiAgICAgICAg IHBva2UoYXJnNSwgMSk7CkBAIC04NjQsNiArODcwLDEzIEBAIHB1YmxpYzoKICAgICAgICAgc2V0 dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKGFyZzEsIGFyZzIsIGFyZzMpOwogICAgIH0KIAorICAg IEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoR1BSUmVnIGFy ZzEsIEdQUlJlZyBhcmcyLCBUcnVzdGVkSW1tMzIgYXJnMywgR1BSUmVnIGFyZzQsIFRydXN0ZWRJ bW0zMiBhcmc1KQorICAgIHsKKyAgICAgICAgcG9rZShhcmc1LCAxKTsKKyAgICAgICAgcG9rZShh cmc0KTsKKyAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKGFyZzEsIGFyZzIsIGFy ZzMpOworICAgIH0KKwogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhF eGVjU3RhdGUoVHJ1c3RlZEltbTMyIGFyZzEsIEdQUlJlZyBhcmcyLCBHUFJSZWcgYXJnMywgR1BS UmVnIGFyZzQsIFRydXN0ZWRJbW1QdHIgYXJnNSkKICAgICB7CiAgICAgICAgIHBva2UoYXJnNSwg MSk7Cg== 173310 2012-11-09 07:57:47 -0800 2012-11-09 08:03:21 -0800 Patch hardandsoftupstream.patch text/plain 2565 gaborb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNjNDkzOTUuLjY1OTVkZTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTA5ICBHYWJvciBCYWxsYWJh cyAgPGdhYm9yYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSByMTMzOTUzIGJyb2tl IHRoZSBBUk1fVFJBRElUSU9OQUwgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMTcwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgYm90aCBoYXJkZnAgYW5kIHNvZnRmcC4KKworICAg ICAgICAqIGRmZy9ERkdDQ2FsbEhlbHBlcnMuaDoKKyAgICAgICAgKENDYWxsSGVscGVycyk6Cisg ICAgICAgIChKU0M6OkRGRzo6Q0NhbGxIZWxwZXJzOjpzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3Rh dGUpOgorCiAyMDEyLTExLTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTM0MDUxLgpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDQ2FsbEhlbHBlcnMuaCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ0NhbGxIZWxwZXJzLmgKaW5kZXggMzA4ZGRlNS4uOGFk ZGUwNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDQ2FsbEhlbHBl cnMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NDYWxsSGVscGVycy5oCkBA IC01MzUsNiArNTM1LDIwIEBAIHB1YmxpYzoKICAgICAgICAgICAgIG1vdmVEb3VibGUoQVJNUmVn aXN0ZXJzOjpkMiwgRlBSSW5mbzo6YXJndW1lbnRGUFIxKTsKICAgICAgICAgfQogICAgIH0KKwor ICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoRlBSUmVn IGFyZzEsIEdQUlJlZyBhcmcyKQorICAgIHsKKyAgICAgICAgbW92ZURvdWJsZShhcmcxLCBGUFJJ bmZvOjphcmd1bWVudEZQUjApOworICAgICAgICBtb3ZlKGFyZzIsIEdQUkluZm86OmFyZ3VtZW50 R1BSMSk7CisgICAgICAgIG1vdmUoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86 OmFyZ3VtZW50R1BSMCk7CisgICAgfQorCisgICAgQUxXQVlTX0lOTElORSB2b2lkIHNldHVwQXJn dW1lbnRzV2l0aEV4ZWNTdGF0ZShHUFJSZWcgYXJnMSwgR1BSUmVnIGFyZzIsIEZQUlJlZyBhcmcz KQorICAgIHsKKyAgICAgICAgbW92ZURvdWJsZShhcmczLCBGUFJJbmZvOjphcmd1bWVudEZQUjAp OworICAgICAgICBzZXR1cFN0dWJBcmd1bWVudHMoYXJnMSwgYXJnMik7CisgICAgICAgIG1vdmUo R1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3VtZW50R1BSMCk7CisgICAg fQogI2Vsc2UKICAgICBBTFdBWVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVudHMoRlBSUmVnIGFy ZzEpCiAgICAgewpAQCAtODU3LDYgKzg3MSwxMiBAQCBwdWJsaWM6CiAgICAgICAgIHNldHVwQXJn dW1lbnRzV2l0aEV4ZWNTdGF0ZShhcmcxLCBhcmcyLCBhcmczKTsKICAgICB9CiAKKyAgICBBTFdB WVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW0zMiBh cmcxLCBHUFJSZWcgYXJnMiwgVHJ1c3RlZEltbTMyIGFyZzMsIEdQUlJlZyBhcmc0KQorICAgIHsK KyAgICAgICAgcG9rZShhcmc0KTsKKyAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRl KGFyZzEsIGFyZzIsIGFyZzMpOworICAgIH0KKwogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1 cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoR1BSUmVnIGFyZzEsIEdQUlJlZyBhcmcyLCBUcnVzdGVk SW1tMzIgYXJnMywgR1BSUmVnIGFyZzQsIEdQUlJlZyBhcmc1KQogICAgIHsKICAgICAgICAgcG9r ZShhcmc1LCAxKTsKQEAgLTg2NCw2ICs4ODQsMTMgQEAgcHVibGljOgogICAgICAgICBzZXR1cEFy Z3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnMyk7CiAgICAgfQogCisgICAgQUxX QVlTX0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShHUFJSZWcgYXJnMSwg R1BSUmVnIGFyZzIsIFRydXN0ZWRJbW0zMiBhcmczLCBHUFJSZWcgYXJnNCwgVHJ1c3RlZEltbTMy IGFyZzUpCisgICAgeworICAgICAgICBwb2tlKGFyZzUsIDEpOworICAgICAgICBwb2tlKGFyZzQp OworICAgICAgICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnMyk7 CisgICAgfQorCiAgICAgQUxXQVlTX0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNT dGF0ZShUcnVzdGVkSW1tMzIgYXJnMSwgR1BSUmVnIGFyZzIsIEdQUlJlZyBhcmczLCBHUFJSZWcg YXJnNCwgVHJ1c3RlZEltbVB0ciBhcmc1KQogICAgIHsKICAgICAgICAgcG9rZShhcmc1LCAxKTsK