101696 2012-11-08 20:23:11 -0800 Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty() 2012-11-15 16:14:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson allan.jensen cmarcelo kling koivisto macpherson menard tony webkit.review.bot oldest_to_newest 762492 0 macpherson 2012-11-08 20:23:11 -0800 Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty() 762493 1 173187 macpherson 2012-11-08 20:27:15 -0800 Created attachment 173187 Patch 765737 2 173187 tony 2012-11-13 10:07:02 -0800 Comment on attachment 173187 Patch This looks correct, but I'm curious about the other use of m_parentStyle in StyleResolver::applyProperty. In the CSSPropertyContent case, we use m_parentStyle. I wonder if that's safe? 768592 3 macpherson 2012-11-15 15:57:02 -0800 I see what you mean. It's hard to reason about the initialization state of StyleResolver right now to give a hard answer to that question. 768609 4 173187 webkit.review.bot 2012-11-15 16:14:04 -0800 Comment on attachment 173187 Patch Clearing flags on attachment: 173187 Committed r134846: <http://trac.webkit.org/changeset/134846> 768610 5 webkit.review.bot 2012-11-15 16:14:08 -0800 All reviewed patches have been landed. Closing bug. 173187 2012-11-08 20:27:15 -0800 2012-11-15 16:14:04 -0800 Patch bug-101696-20121109152524.patch text/plain 2639 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjMxNmFkMTNlY2E5OTc3 MThmMWZmZDBmOGFjNjE0YTIyMDM3ZTNjNy4uNTBkYmNhYjMyYmVjYWNlMjM2NjM1NjE0ZDUzNWNh OGM2ZmRmZDY1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTA4ICBMdWtl IE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSBh c3N1bXB0aW9ucyBhYm91dCBtX3BhcmVudFN0eWxlIGNvbnNpc3RlbnQgd2l0aGluIFN0eWxlUmVz b2x2ZXI6OmFwcGx5UHJvcGVydHkoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAxNjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTW9zdCBvZiB0aGUgY29kZSBpbiBTdHlsZVJlc29sdmVyOjphcHBseVBy b3BlcnR5IGFzc3VtZXMgdGhhdCBpc0luaGVyaXQgaW1wbGllcyB0aGF0IG1fcGFyZW50U3R5bGUg aXMgYXZhaWxhYmxlLgorICAgICAgICBUaGlzIHBhdGNoIEFTU0VSVHMgdGhhdCB0aGlzIGFzc3Vt cHRpb24gaXMgY29ycmVjdCwgYW5kIHJlbW92ZXMgdGhlIGZldyBleGlzdGluZyBjaGVja3MgdG8g bWFpbnRhaW4gY29uc2lzdGVuY3kuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC8gY292ZXJlZCBi eSBhbGwgZXhpc3RpbmcgQ1NTIHRlc3RzLgorCisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVSZXNvbHZlcjo6YXBwbHlQcm9wZXJ0eSk6CisK IDIwMTItMTEtMDcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVwYWludCBpc3N1ZXMgd2l0aCAtd2Via2l0LXN2Zy1zaGFkb3cgdXNlZCBvbiBhIGNv bnRhaW5lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCmluZGV4IDdjY2RmZmZkNzA2 NDViNjFmMTZjNmM3MTRmNGNjMmUwNzQxZjBjZTcuLjI5MjcxNTRjNDVjNTQwMjZjNjQ2MGE0NDc4 NDVhYmMyYzVhNWM0MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29s dmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKQEAgLTI4 MTcsMTMgKzI4MTcsMTQgQEAgdm9pZCBTdHlsZVJlc29sdmVyOjphcHBseVByb3BlcnR5KENTU1By b3BlcnR5SUQgaWQsIENTU1ZhbHVlKiB2YWx1ZSkKICAgICBib29sIGlzSW5pdGlhbCA9IHZhbHVl LT5pc0luaXRpYWxWYWx1ZSgpIHx8ICghbV9wYXJlbnROb2RlICYmIHZhbHVlLT5pc0luaGVyaXRl ZFZhbHVlKCkpOwogCiAgICAgQVNTRVJUKCFpc0luaGVyaXQgfHwgIWlzSW5pdGlhbCk7IC8vIGlz SW5oZXJpdCAtPiAhaXNJbml0aWFsICYmIGlzSW5pdGlhbCAtPiAhaXNJbmhlcml0CisgICAgQVNT RVJUKCFpc0luaGVyaXQgfHwgKG1fcGFyZW50Tm9kZSAmJiBtX3BhcmVudFN0eWxlKSk7IC8vIGlz SW5oZXJpdCAtPiAobV9wYXJlbnROb2RlICYmIG1fcGFyZW50U3R5bGUpCiAKICAgICBpZiAoIWFw cGx5UHJvcGVydHlUb1JlZ3VsYXJTdHlsZSgpICYmICghYXBwbHlQcm9wZXJ0eVRvVmlzaXRlZExp bmtTdHlsZSgpIHx8ICFpc1ZhbGlkVmlzaXRlZExpbmtQcm9wZXJ0eShpZCkpKSB7CiAgICAgICAg IC8vIExpbWl0IHRoZSBwcm9wZXJ0aWVzIHRoYXQgY2FuIGJlIGFwcGxpZWQgdG8gb25seSB0aGUg b25lcyBob25vcmVkIGJ5IDp2aXNpdGVkLgogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAg aWYgKGlzSW5oZXJpdCAmJiBtX3BhcmVudFN0eWxlICYmICFtX3BhcmVudFN0eWxlLT5oYXNFeHBs aWNpdGx5SW5oZXJpdGVkUHJvcGVydGllcygpICYmICFDU1NQcm9wZXJ0eTo6aXNJbmhlcml0ZWRQ cm9wZXJ0eShpZCkpCisgICAgaWYgKGlzSW5oZXJpdCAmJiAhbV9wYXJlbnRTdHlsZS0+aGFzRXhw bGljaXRseUluaGVyaXRlZFByb3BlcnRpZXMoKSAmJiAhQ1NTUHJvcGVydHk6OmlzSW5oZXJpdGVk UHJvcGVydHkoaWQpKQogICAgICAgICBtX3BhcmVudFN0eWxlLT5zZXRIYXNFeHBsaWNpdGx5SW5o ZXJpdGVkUHJvcGVydGllcygpOwogCiAjaWYgRU5BQkxFKENTU19WQVJJQUJMRVMpCkBAIC0yOTUz LDggKzI5NTQsNyBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OmFwcGx5UHJvcGVydHkoQ1NTUHJvcGVy dHlJRCBpZCwgQ1NTVmFsdWUqIHZhbHVlKQogICAgICAgICB9CiAgICAgY2FzZSBDU1NQcm9wZXJ0 eVF1b3RlczoKICAgICAgICAgaWYgKGlzSW5oZXJpdCkgewotICAgICAgICAgICAgaWYgKG1fcGFy ZW50U3R5bGUpCi0gICAgICAgICAgICAgICAgbV9zdHlsZS0+c2V0UXVvdGVzKG1fcGFyZW50U3R5 bGUtPnF1b3RlcygpKTsKKyAgICAgICAgICAgIG1fc3R5bGUtPnNldFF1b3RlcyhtX3BhcmVudFN0 eWxlLT5xdW90ZXMoKSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAg aWYgKGlzSW5pdGlhbCkgewo=