101695 2012-11-08 20:17:19 -0800 Uninitialized fields in class JSLock 2012-11-13 09:17:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ctruta webkit-unassigned ap dglazkov mark.lam mhahnenberg webkit.review.bot yong.li.webkit oldest_to_newest 762482 0 ctruta 2012-11-08 20:17:19 -0800 Valgrind reported that JSLock::m_ownerThread is not initialized. The report indicates a legitimate issue. A fix will follow. 762490 1 173186 ctruta 2012-11-08 20:22:40 -0800 Created attachment 173186 Patch 763342 2 173186 mhahnenberg 2012-11-09 14:39:35 -0800 Comment on attachment 173186 Patch I think we should also initialize m_lockDropDepth, no? 763773 3 173484 ctruta 2012-11-10 21:12:33 -0800 Created attachment 173484 Patch (In reply to comment #2) > I think we should also initialize m_lockDropDepth, no? You're right. Done. 763780 4 173484 webkit.review.bot 2012-11-10 22:04:43 -0800 Comment on attachment 173484 Patch Attachment 173484 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14786720 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 763891 5 173484 ctruta 2012-11-11 14:54:20 -0800 Comment on attachment 173484 Patch Setting back "cq?". Something seems to be wrong with the Chrome-Linux build. 765635 6 mhahnenberg 2012-11-13 08:31:20 -0800 (In reply to comment #5) > (From update of attachment 173484 [details]) > Setting back "cq?". Something seems to be wrong with the Chrome-Linux build. I think that's just a flaky test. Chrome doesn't use JSC and therefore doesn't depend on JSLock in any way. 765637 7 173484 mhahnenberg 2012-11-13 08:33:19 -0800 Comment on attachment 173484 Patch r=me 765681 8 173484 webkit.review.bot 2012-11-13 09:17:41 -0800 Comment on attachment 173484 Patch Clearing flags on attachment: 173484 Committed r134430: <http://trac.webkit.org/changeset/134430> 765682 9 webkit.review.bot 2012-11-13 09:17:44 -0800 All reviewed patches have been landed. Closing bug. 173186 2012-11-08 20:22:40 -0800 2012-11-10 21:12:33 -0800 Patch patch.diff text/plain 1001 ctruta ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFiMzAxYjY4Yi4uODJjOTBlY2NjIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0wOCAgQ29zbWluIFRy dXRhICA8Y3RydXRhQHJpbS5jb20+CisKKyAgICAgICAgVW5pbml0aWFsaXplZCBmaWVsZCBpbiBj bGFzcyBKU0xvY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMTY5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEluaXRpYWxpemUgSlNMb2NrOjptX293bmVyVGhyZWFkLgorCisgICAgICAgICogcnVudGlt ZS9KU0xvY2suY3BwOgorICAgICAgICAoSlNDOjpKU0xvY2s6OkpTTG9jayk6CisKIDIwMTItMTEt MDQgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRd IHVkaXM4Nl9pdGFiLmMgaXMgYWx3YXlzIHJlZ2VuZXJhdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0xvY2suY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNMb2NrLmNwcAppbmRleCA4NWRiZGZlZGIuLmJmZTZkYzI1NyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNMb2NrLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0xvY2suY3BwCkBAIC03NCw3ICs3NCw4IEBAIEpTTG9j a0hvbGRlcjo6fkpTTG9ja0hvbGRlcigpCiB9CiAKIEpTTG9jazo6SlNMb2NrKCkKLSAgICA6IG1f bG9ja0NvdW50KDApCisgICAgOiBtX293bmVyVGhyZWFkKDApCisgICAgLCBtX2xvY2tDb3VudCgw KQogewogICAgIG1fc3BpbkxvY2suSW5pdCgpOwogfQo= 173484 2012-11-10 21:12:33 -0800 2012-11-13 09:17:41 -0800 Patch jslock-submit.diff text/plain 1127 ctruta ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdhMDYxYmY0Ny4uODBmYjg4M2NhIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0xMCAgQ29zbWluIFRy dXRhICA8Y3RydXRhQHJpbS5jb20+CisKKyAgICAgICAgVW5pbml0aWFsaXplZCBmaWVsZHMgaW4g Y2xhc3MgSlNMb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDE2OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbml0aWFsaXplIEpTTG9jazo6bV9vd25lclRocmVhZCBhbmQgSlNMb2NrOjptX2xvY2tE cm9wRGVwdGguCisKKyAgICAgICAgKiBydW50aW1lL0pTTG9jay5jcHA6CisgICAgICAgIChKU0M6 OkpTTG9jazo6SlNMb2NrKToKKwogMjAxMi0xMS0xMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBw bGUuY29tPgogCiAgICAgICAgIERGRyBzaG91bGQgb3B0aW1pemUgb3V0IHRoZSBOYU4gY2hlY2sg b24gbG9hZHMgZnJvbSBkb3VibGUgYXJyYXlzIGlmIHRoZSBhcnJheSBwcm90b3R5cGUgY2hhaW4g aXMgaGF2aW5nIGEgZ3JlYXQgdGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNMb2NrLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTTG9j ay5jcHAKaW5kZXggODVkYmRmZWRiLi41ZTNkMTJjOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTTG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNMb2NrLmNwcApAQCAtNzQsNyArNzQsOSBAQCBKU0xvY2tIb2xkZXI6On5KU0xv Y2tIb2xkZXIoKQogfQogCiBKU0xvY2s6OkpTTG9jaygpCi0gICAgOiBtX2xvY2tDb3VudCgwKQor ICAgIDogbV9vd25lclRocmVhZCgwKQorICAgICwgbV9sb2NrQ291bnQoMCkKKyAgICAsIG1fbG9j a0Ryb3BEZXB0aCgwKQogewogICAgIG1fc3BpbkxvY2suSW5pdCgpOwogfQo=