101693 2012-11-08 19:44:56 -0800 Web Inspector: Always use textured window for the Web Inspector 2012-11-08 22:47:23 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 762465 0 timothy 2012-11-08 19:44:56 -0800 Use textured window for the Web Inspector window. 762467 1 173180 timothy 2012-11-08 19:47:55 -0800 Created attachment 173180 Proposed Change 762476 2 173180 joepeck 2012-11-08 20:09:20 -0800 Comment on attachment 173180 Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=173180&action=review > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:344 > + [window setContentBorderThickness:55. forEdge:NSMaxYEdge]; Nit: "55." isn't normal number style. You can fix this, or just cq+ since its not changing from the old code. 762591 3 173180 webkit.review.bot 2012-11-08 22:47:20 -0800 Comment on attachment 173180 Proposed Change Clearing flags on attachment: 173180 Committed r134015: <http://trac.webkit.org/changeset/134015> 762592 4 webkit.review.bot 2012-11-08 22:47:23 -0800 All reviewed patches have been landed. Closing bug. 173180 2012-11-08 19:47:55 -0800 2012-11-08 22:47:20 -0800 Proposed Change 0001-Always-use-a-textured-window-for-the-Web-Inspector.patch text/plain 5632 timothy RnJvbSBhODZlZWMxMWVhY2MyNjc5NmFmYWNmZDY3MmUxOTNkNDQ3MmYyMTEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUaHUsIDggTm92IDIwMTIgMTk6NDU6MTQgLTA4MDAKU3ViamVjdDogW1BBVENIXSBBbHdh eXMgdXNlIGEgdGV4dHVyZWQgd2luZG93IGZvciB0aGUgV2ViIEluc3BlY3Rvci4KCmh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2OTMKClJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgoKU291cmNlL1dlYktpdC9tYWM6CgoqIFdlYkNvcmVTdXBwb3J0L1dlYkluc3Bl Y3RvckNsaWVudC5tbToKKC1bV2ViSW5zcGVjdG9yV2luZG93Q29udHJvbGxlciB3aW5kb3ddKTog UmVtb3ZlZCB0aGUgY29uZGl0aW9uYWwgZm9yIGEgdGV4dHVyZWQgd2luZG93LgoKU291cmNlL1dl YktpdDI6CgoqIFVJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW06CihXZWJLaXQ6 OldlYkluc3BlY3RvclByb3h5OjpjcmVhdGVJbnNwZWN0b3JXaW5kb3cpOiBSZW1vdmVkIHRoZSBj b25kaXRpb25hbCBmb3IgYSB0ZXh0dXJlZCB3aW5kb3cuCi0tLQogU291cmNlL1dlYktpdC9tYWMv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrCiAu Li4vV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0gICB8ICAg MTcgKysrKy0tLS0tLS0tLS0tLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbSAgfCAgIDE2ICsrKystLS0tLS0tLS0t LS0KIDQgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9t YWMvQ2hhbmdlTG9nCmluZGV4IDI2Y2Y0NTIuLmRmYjc0YjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMi0xMS0wOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBs ZS5jb20+CisKKyAgICAgICAgQWx3YXlzIHVzZSBhIHRleHR1cmVkIHdpbmRvdyBmb3IgdGhlIFdl YiBJbnNwZWN0b3IuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwMTY5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tOgorICAgICAgICAo LVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIHdpbmRvd10pOiBSZW1vdmVkIHRoZSBjb25k aXRpb25hbCBmb3IgYSB0ZXh0dXJlZCB3aW5kb3cuCisKIDIwMTItMTEtMDYgIEFuZHJleSBMdXNo bmlrb3YgIDxsdXNobmlrb3ZAZ29vZ2xlLmNvbT4KIAogICAgICAgICBBZGRlZCBjb25zb2xlLmNs ZWFyKCkgbWV0aG9kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9y dC9XZWJJbnNwZWN0b3JDbGllbnQubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9y dC9XZWJJbnNwZWN0b3JDbGllbnQubW0KaW5kZXggZjQzMmNkNS4uMGI5MDQxZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1t CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVu dC5tbQpAQCAtMzM2LDIyICszMzYsMTMgQEAgLSAoTlNXaW5kb3cgKil3aW5kb3cKICAgICBpZiAo d2luZG93KQogICAgICAgICByZXR1cm4gd2luZG93OwogCi0gICAgYm9vbCB1c2VUZXh0dXJlZFdp bmRvdyA9IHVzZVdlYktpdFdlYkluc3BlY3RvcigpOwotCi0gICAgTlNVSW50ZWdlciBzdHlsZU1h c2sgPSAoTlNUaXRsZWRXaW5kb3dNYXNrIHwgTlNDbG9zYWJsZVdpbmRvd01hc2sgfCBOU01pbmlh dHVyaXphYmxlV2luZG93TWFzayB8IE5TUmVzaXphYmxlV2luZG93TWFzayk7Ci0KLSAgICBpZiAo dXNlVGV4dHVyZWRXaW5kb3cpCi0gICAgICAgIHN0eWxlTWFzayB8PSBOU1RleHR1cmVkQmFja2dy b3VuZFdpbmRvd01hc2s7Ci0KKyAgICBOU1VJbnRlZ2VyIHN0eWxlTWFzayA9IChOU1RpdGxlZFdp bmRvd01hc2sgfCBOU0Nsb3NhYmxlV2luZG93TWFzayB8IE5TTWluaWF0dXJpemFibGVXaW5kb3dN YXNrIHwgTlNSZXNpemFibGVXaW5kb3dNYXNrIHwgTlNUZXh0dXJlZEJhY2tncm91bmRXaW5kb3dN YXNrKTsKICAgICB3aW5kb3cgPSBbW05TV2luZG93IGFsbG9jXSBpbml0V2l0aENvbnRlbnRSZWN0 Ok5TTWFrZVJlY3QoNjAuMCwgMjAwLjAsIDc1MC4wLCA2NTAuMCkgc3R5bGVNYXNrOnN0eWxlTWFz ayBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dOwogICAgIFt3aW5kb3cg c2V0RGVsZWdhdGU6c2VsZl07CiAgICAgW3dpbmRvdyBzZXRNaW5TaXplOk5TTWFrZVNpemUoNDAw LjAsIDQwMC4wKV07Ci0KLSAgICBpZiAodXNlVGV4dHVyZWRXaW5kb3cpIHsKLSAgICAgICAgW3dp bmRvdyBzZXRBdXRvcmVjYWxjdWxhdGVzQ29udGVudEJvcmRlclRoaWNrbmVzczpOTyBmb3JFZGdl Ok5TTWF4WUVkZ2VdOwotICAgICAgICBbd2luZG93IHNldENvbnRlbnRCb3JkZXJUaGlja25lc3M6 NTUuIGZvckVkZ2U6TlNNYXhZRWRnZV07Ci0gICAgICAgIFdLTlNXaW5kb3dNYWtlQm90dG9tQ29y bmVyc1NxdWFyZSh3aW5kb3cpOwotICAgIH0KKyAgICBbd2luZG93IHNldEF1dG9yZWNhbGN1bGF0 ZXNDb250ZW50Qm9yZGVyVGhpY2tuZXNzOk5PIGZvckVkZ2U6TlNNYXhZRWRnZV07CisgICAgW3dp bmRvdyBzZXRDb250ZW50Qm9yZGVyVGhpY2tuZXNzOjU1LiBmb3JFZGdlOk5TTWF4WUVkZ2VdOwor ICAgIFdLTlNXaW5kb3dNYWtlQm90dG9tQ29ybmVyc1NxdWFyZSh3aW5kb3cpOwogCiAgICAgW3Nl bGYgc2V0V2luZG93OndpbmRvd107CiAgICAgW3dpbmRvdyByZWxlYXNlXTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRl eCA2NDFjOTAzLi43MDdkM2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTEt MDggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIEFsd2F5 cyB1c2UgYSB0ZXh0dXJlZCB3aW5kb3cgZm9yIHRoZSBXZWIgSW5zcGVjdG9yLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2OTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMv V2ViSW5zcGVjdG9yUHJveHlNYWMubW06CisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclBy b3h5OjpjcmVhdGVJbnNwZWN0b3JXaW5kb3cpOiBSZW1vdmVkIHRoZSBjb25kaXRpb25hbCBmb3Ig YSB0ZXh0dXJlZCB3aW5kb3cuCisKIDIwMTItMTEtMDYgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5i ZWNzaUBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XVtXSzJdIEZpdC10by13aWR0aCBicm9rZW4g b24gcGFnZXMgd2l0aCB2aWV3cG9ydCBtZXRhIHRhZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KaW5kZXggMGEyYjliMC4uMzlj YzdiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0 b3JQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3Bl Y3RvclByb3h5TWFjLm1tCkBAIC0xMzksMjIgKzEzOSwxNCBAQCB2b2lkIFdlYkluc3BlY3RvclBy b3h5OjpjcmVhdGVJbnNwZWN0b3JXaW5kb3coKQogewogICAgIEFTU0VSVCghbV9pbnNwZWN0b3JX aW5kb3cpOwogCi0gICAgYm9vbCB1c2VUZXh0dXJlZFdpbmRvdyA9IGluc3BlY3RvclJlYWxseVVz ZXNXZWJLaXRVc2VySW50ZXJmYWNlKHBhZ2UoKS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCkp OwotCi0gICAgTlNVSW50ZWdlciBzdHlsZU1hc2sgPSAoTlNUaXRsZWRXaW5kb3dNYXNrIHwgTlND bG9zYWJsZVdpbmRvd01hc2sgfCBOU01pbmlhdHVyaXphYmxlV2luZG93TWFzayB8IE5TUmVzaXph YmxlV2luZG93TWFzayk7Ci0gICAgaWYgKHVzZVRleHR1cmVkV2luZG93KQotICAgICAgICBzdHls ZU1hc2sgfD0gTlNUZXh0dXJlZEJhY2tncm91bmRXaW5kb3dNYXNrOwotCisgICAgTlNVSW50ZWdl ciBzdHlsZU1hc2sgPSAoTlNUaXRsZWRXaW5kb3dNYXNrIHwgTlNDbG9zYWJsZVdpbmRvd01hc2sg fCBOU01pbmlhdHVyaXphYmxlV2luZG93TWFzayB8IE5TUmVzaXphYmxlV2luZG93TWFzayB8IE5T VGV4dHVyZWRCYWNrZ3JvdW5kV2luZG93TWFzayk7CiAgICAgTlNXaW5kb3cgKndpbmRvdyA9IFtb TlNXaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29udGVudFJlY3Q6TlNNYWtlUmVjdCgwLCAwLCBpbml0 aWFsV2luZG93V2lkdGgsIGluaXRpYWxXaW5kb3dIZWlnaHQpIHN0eWxlTWFzazpzdHlsZU1hc2sg YmFja2luZzpOU0JhY2tpbmdTdG9yZUJ1ZmZlcmVkIGRlZmVyOk5PXTsKICAgICBbd2luZG93IHNl dERlbGVnYXRlOm1faW5zcGVjdG9yUHJveHlPYmpDQWRhcHRlci5nZXQoKV07CiAgICAgW3dpbmRv dyBzZXRNaW5TaXplOk5TTWFrZVNpemUobWluaW11bVdpbmRvd1dpZHRoLCBtaW5pbXVtV2luZG93 SGVpZ2h0KV07CiAgICAgW3dpbmRvdyBzZXRSZWxlYXNlZFdoZW5DbG9zZWQ6Tk9dOwotCi0gICAg aWYgKHVzZVRleHR1cmVkV2luZG93KSB7Ci0gICAgICAgIFt3aW5kb3cgc2V0QXV0b3JlY2FsY3Vs YXRlc0NvbnRlbnRCb3JkZXJUaGlja25lc3M6Tk8gZm9yRWRnZTpOU01heFlFZGdlXTsKLSAgICAg ICAgW3dpbmRvdyBzZXRDb250ZW50Qm9yZGVyVGhpY2tuZXNzOndpbmRvd0NvbnRlbnRCb3JkZXJU aGlja25lc3MgZm9yRWRnZTpOU01heFlFZGdlXTsKLSAgICAgICAgV0tOU1dpbmRvd01ha2VCb3R0 b21Db3JuZXJzU3F1YXJlKHdpbmRvdyk7Ci0gICAgfQorICAgIFt3aW5kb3cgc2V0QXV0b3JlY2Fs Y3VsYXRlc0NvbnRlbnRCb3JkZXJUaGlja25lc3M6Tk8gZm9yRWRnZTpOU01heFlFZGdlXTsKKyAg ICBbd2luZG93IHNldENvbnRlbnRCb3JkZXJUaGlja25lc3M6d2luZG93Q29udGVudEJvcmRlclRo aWNrbmVzcyBmb3JFZGdlOk5TTWF4WUVkZ2VdOworICAgIFdLTlNXaW5kb3dNYWtlQm90dG9tQ29y bmVyc1NxdWFyZSh3aW5kb3cpOwogCiAgICAgTlNWaWV3ICpjb250ZW50VmlldyA9IFt3aW5kb3cg Y29udGVudFZpZXddOwogICAgIFttX2luc3BlY3RvclZpZXcuZ2V0KCkgc2V0RnJhbWU6W2NvbnRl bnRWaWV3IGJvdW5kc11dOwotLSAKMS43LjEwLjIgKEFwcGxlIEdpdC0zMykKCg==