101691 2012-11-08 19:22:30 -0800 [V8] Clean up header includes and ifdefs in V8GCController 2012-11-10 10:25:45 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet levin+threading webkit.review.bot oldest_to_newest 762452 0 abarth 2012-11-08 19:22:30 -0800 [V8] Clean up header includes and ifdefs in V8GCController 762454 1 173178 abarth 2012-11-08 19:23:08 -0800 Created attachment 173178 Patch 762732 2 173178 haraken 2012-11-09 02:01:49 -0800 Comment on attachment 173178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173178&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:-298 > -#if PLATFORM(CHROMIUM) What's the rationale to remove this macro? 763147 3 abarth 2012-11-09 10:30:19 -0800 > What's the rationale to remove this macro? Qt and GTK used to have an option to build with V8. These ifdefs were added to support that, but they no longer have that option. 763566 4 173178 haraken 2012-11-09 20:15:21 -0800 Comment on attachment 173178 Patch > Qt and GTK used to have an option to build with V8. These ifdefs were added to support that, but they no longer have that option. OK. BTW, then it seems that UseV8.cmake is no longer needed. UseV8.cmake already lacks a bunch of V8 binding files and it looks like they have not been maintained. 763675 5 173178 abarth 2012-11-10 10:20:42 -0800 Comment on attachment 173178 Patch Ok. We should delete it so we don't spend energy maintaining it. 763676 6 173178 webkit.review.bot 2012-11-10 10:25:41 -0800 Comment on attachment 173178 Patch Clearing flags on attachment: 173178 Committed r134159: <http://trac.webkit.org/changeset/134159> 763677 7 webkit.review.bot 2012-11-10 10:25:45 -0800 All reviewed patches have been landed. Closing bug. 173178 2012-11-08 19:23:08 -0800 2012-11-10 10:25:41 -0800 Patch bug-101691-20121108192117.patch text/plain 3614 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDNkYjI4M2VhODNkMmEw NTVjN2I2NTMyMTNiNTdhOTI1MjllOTdmMy4uYTI4NjRmNDc3NzVjODljZWM3OTk2Njc4YjY5NTU1 NTI4M2YwYzNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTExLTA4ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBDbGVhbiB1cCBoZWFk ZXIgaW5jbHVkZXMgYW5kIGlmZGVmcyBpbiBWOEdDQ29udHJvbGxlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjkxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBmaWxlIGRvZXNuJ3QgbmVlZCB0 byBpbmNsdWRlIGFsbCB0aGVzZSBoZWFkZXJzIGFueW1vcmUuCisKKyAgICAgICAgKiBiaW5kaW5n cy92OC9WOEdDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3b3JraW5nU2V0RXN0 aW1hdGVNQk11dGV4KToKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjptYWpvckdD RXBpbG9ndWUpOgorICAgICAgICAoV2ViQ29yZTo6VjhHQ0NvbnRyb2xsZXI6OmNoZWNrTWVtb3J5 VXNhZ2UpOgorCisyMDEyLTExLTA4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK ICAgICAgICAgW1Y4XSBSZW1vdmUgYSBsZXZlbCBvZiBpbmRpcmVjdGlvbiBpbiBET01EYXRhU3Rv cmUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTY5 MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKaW5k ZXggM2Q0NDBlZWU3NjJkNWI3ZjdlYWJjNzMzYTRlYzE1ZDJhNWI2NjBhMS4uZTU4MGQ2ZmM4YTBk ZTkxZDdiZDc5NjBmY2M4NDExYTkwNDExMWFjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApAQCAtMzEsMzkgKzMxLDE3IEBACiAjaW5jbHVkZSAi Y29uZmlnLmgiCiAjaW5jbHVkZSAiVjhHQ0NvbnRyb2xsZXIuaCIKIAotI2luY2x1ZGUgIkFjdGl2 ZURPTU9iamVjdC5oIgogI2luY2x1ZGUgIkF0dHIuaCIKLSNpbmNsdWRlICJET01EYXRhU3RvcmUu aCIKLSNpbmNsdWRlICJET01JbXBsZW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgIkhUTUxJbWFnZUVs ZW1lbnQuaCIKLSNpbmNsdWRlICJIVE1MTmFtZXMuaCIKICNpbmNsdWRlICJNZW1vcnlVc2FnZVN1 cHBvcnQuaCIKLSNpbmNsdWRlICJNZXNzYWdlUG9ydC5oIgotI2luY2x1ZGUgIlJldGFpbmVkRE9N SW5mby5oIgotI2luY2x1ZGUgIlJldGFpbmVkT2JqZWN0SW5mby5oIgorI2luY2x1ZGUgIlRyYWNl RXZlbnQuaCIKICNpbmNsdWRlICJWOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5oIgogI2luY2x1ZGUg IlY4QmluZGluZy5oIgotI2luY2x1ZGUgIlY4Q1NTUnVsZS5oIgotI2luY2x1ZGUgIlY4Q1NTUnVs ZUxpc3QuaCIKLSNpbmNsdWRlICJWOENTU1N0eWxlRGVjbGFyYXRpb24uaCIKLSNpbmNsdWRlICJW OERPTUltcGxlbWVudGF0aW9uLmgiCiAjaW5jbHVkZSAiVjhNZXNzYWdlUG9ydC5oIgogI2luY2x1 ZGUgIlY4Tm9kZS5oIgogI2luY2x1ZGUgIlY4UmVjdXJzaW9uU2NvcGUuaCIKLSNpbmNsdWRlICJW OFN0eWxlU2hlZXQuaCIKLSNpbmNsdWRlICJWOFN0eWxlU2hlZXRMaXN0LmgiCiAjaW5jbHVkZSAi V3JhcHBlclR5cGVJbmZvLmgiCi0KICNpbmNsdWRlIDxhbGdvcml0aG0+Ci0jaW5jbHVkZSA8dXRp bGl0eT4KLSNpbmNsdWRlIDx2OC1kZWJ1Zy5oPgotI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+Ci0j aW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgotI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5o PgotCi0jaWYgUExBVEZPUk0oQ0hST01JVU0pCi0jaW5jbHVkZSAiVHJhY2VFdmVudC5oIgotI2Vu ZGlmCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMjU2LDcgKzIzNCw2IEBAIHZvaWQgVjhH Q0NvbnRyb2xsZXI6Om1ham9yR0NQcm9sb2d1ZSgpCiAgICAgZGF0YS0+c3RyaW5nQ2FjaGUoKS0+ Y2xlYXJPbkdDKCk7CiB9CiAKLSNpZiBQTEFURk9STShDSFJPTUlVTSkKIHN0YXRpYyBpbnQgd29y a2luZ1NldEVzdGltYXRlTUIgPSAwOwogCiBzdGF0aWMgTXV0ZXgmIHdvcmtpbmdTZXRFc3RpbWF0 ZU1CTXV0ZXgoKQpAQCAtMjY0LDcgKzI0MSw2IEBAIHN0YXRpYyBNdXRleCYgd29ya2luZ1NldEVz dGltYXRlTUJNdXRleCgpCiAgICAgQXRvbWljYWxseUluaXRpYWxpemVkU3RhdGljKE11dGV4Jiwg bXV0ZXggPSAqbmV3IE11dGV4KTsKICAgICByZXR1cm4gbXV0ZXg7CiB9Ci0jZW5kaWYKIAogdm9p ZCBWOEdDQ29udHJvbGxlcjo6Z2NFcGlsb2d1ZSh2ODo6R0NUeXBlIHR5cGUsIHY4OjpHQ0NhbGxi YWNrRmxhZ3MgZmxhZ3MpCiB7CkBAIC0yODIsMjAgKzI1OCwxNyBAQCB2b2lkIFY4R0NDb250cm9s bGVyOjptYWpvckdDRXBpbG9ndWUoKQogewogICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKIAot I2lmIFBMQVRGT1JNKENIUk9NSVVNKQogICAgIC8vIFRoZSBHQyBjYW4gaGFwcGVuIG9uIG11bHRp cGxlIHRocmVhZHMgaW4gY2FzZSBvZiBkZWRpY2F0ZWQgd29ya2VycyB3aGljaCBydW4gaW4tcHJv Y2Vzcy4KICAgICB7CiAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcih3b3JraW5nU2V0RXN0aW1h dGVNQk11dGV4KCkpOwogICAgICAgICB3b3JraW5nU2V0RXN0aW1hdGVNQiA9IE1lbW9yeVVzYWdl U3VwcG9ydDo6YWN0dWFsTWVtb3J5VXNhZ2VNQigpOwogICAgIH0KLSNlbmRpZgogCiAgICAgVFJB Q0VfRVZFTlRfRU5EMCgidjgiLCAiR0MiKTsKIH0KIAogdm9pZCBWOEdDQ29udHJvbGxlcjo6Y2hl Y2tNZW1vcnlVc2FnZSgpCiB7Ci0jaWYgUExBVEZPUk0oQ0hST01JVU0pCiAgICAgY29uc3QgaW50 IGxvd01lbW9yeVVzYWdlTUIgPSBNZW1vcnlVc2FnZVN1cHBvcnQ6Omxvd01lbW9yeVVzYWdlTUIo KTsKICAgICBjb25zdCBpbnQgaGlnaE1lbW9yeVVzYWdlTUIgPSBNZW1vcnlVc2FnZVN1cHBvcnQ6 OmhpZ2hNZW1vcnlVc2FnZU1CKCk7CiAgICAgY29uc3QgaW50IGhpZ2hVc2FnZURlbHRhTUIgPSBN ZW1vcnlVc2FnZVN1cHBvcnQ6OmhpZ2hVc2FnZURlbHRhTUIoKTsKQEAgLTMxOSw3ICsyOTIsNiBA QCB2b2lkIFY4R0NDb250cm9sbGVyOjpjaGVja01lbW9yeVVzYWdlKCkKICAgICAgICAgLy8gV2Ug YXJlIGFwcHJvYWNoaW5nIE9PTSBhbmQgbWVtb3J5IHVzYWdlIGluY3JlYXNlZCBieSBoaWdoVXNh Z2VEZWx0YU1CIHNpbmNlIHRoZSBsYXN0IEdDLgogICAgICAgICB2ODo6Vjg6Okxvd01lbW9yeU5v dGlmaWNhdGlvbigpOwogICAgIH0KLSNlbmRpZgogfQogCiB2b2lkIFY4R0NDb250cm9sbGVyOjpo aW50Rm9yQ29sbGVjdEdhcmJhZ2UoKQo=