101690 2012-11-08 19:16:51 -0800 [V8] Remove a level of indirection in DOMDataStore 2012-11-09 10:55:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 762449 0 abarth 2012-11-08 19:16:51 -0800 [V8] Remove a level of indirection in DOMDataStore 762450 1 173177 abarth 2012-11-08 19:18:19 -0800 Created attachment 173177 Patch 762729 2 173177 haraken 2012-11-09 02:00:36 -0800 Comment on attachment 173177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173177&action=review > Source/WebCore/bindings/v8/DOMDataStore.h:-63 > - inline v8::Handle<v8::Object> get(T* object) const You need to remove const? 763144 3 abarth 2012-11-09 10:28:18 -0800 > You need to remove const? Yeah, it didn't compile otherwise. 763160 4 173177 webkit.review.bot 2012-11-09 10:55:47 -0800 Comment on attachment 173177 Patch Clearing flags on attachment: 173177 Committed r134086: <http://trac.webkit.org/changeset/134086> 763161 5 webkit.review.bot 2012-11-09 10:55:51 -0800 All reviewed patches have been landed. Closing bug. 173177 2012-11-08 19:18:19 -0800 2012-11-09 10:55:47 -0800 Patch bug-101690-20121108191627.patch text/plain 3647 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ExMTM4NmJmMDllMmFi MDVkMjQxMmQ2MzIxNjE4N2MzYjI5YTk2OC4uZDNkYjI4M2VhODNkMmEwNTVjN2I2NTMyMTNiNTdh OTI1MjllOTdmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTA4ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBSZW1vdmUgYSBsZXZl bCBvZiBpbmRpcmVjdGlvbiBpbiBET01EYXRhU3RvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTY5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG5vIGxvbmdlciBhbnkgcmVhc29uIGZv ciB0aGUgRE9NRGF0YVN0b3JlIHRvIGhvbGQgdGhlIHdyYXBwZXIKKyAgICAgICAgbWFwIHZpYSBh IHBvaW50ZXIuIEl0IGNhbiBqdXN0IGhvbGQgdGhlIHdyYXBwZXIgbWFwIGRpcmVjdGx5LCBzYXZp bmcgYQorICAgICAgICBsZXZlbCBvZiBpbmRpcmVjdGlvbi4gSSBkb3VidCB0aGlzIGhhcyBhbnkg bWVhc3VyYWJsZSBwZXJmb3JtYW5jZSBnYWluLgorCisgICAgICAgICogYmluZGluZ3MvdjgvRE9N RGF0YVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6RE9NRGF0YVN0 b3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6fkRPTURhdGFTdG9yZSk6Cisg ICAgICAgIChXZWJDb3JlOjpET01EYXRhU3RvcmU6OnJlcG9ydE1lbW9yeVVzYWdlKToKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9ET01EYXRhU3RvcmUuaDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTURh dGFTdG9yZTo6Z2V0KToKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGFTdG9yZTo6c2V0KToKKyAg ICAgICAgKERPTURhdGFTdG9yZSk6CisKIDIwMTItMTEtMDggIEFsZWMgRmxldHQgIDxhbGVjZmxl dHRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogc3dpdGNoIGZyb250ZW5kIHRv IHVzZSBpbnQ2NF90LWJhc2VkIHJlZmVyZW5jZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9ET01EYXRhU3RvcmUuY3BwCmluZGV4IDU5N2UzMTQzNDNmY2Q5ZjZhOGM3ZTQ5NGViOWZkZDJj NGE0MzAzYjguLmRjNTFhYTZlYWFmZDUyNDJjODJhOThhNmFlYWI1ZDc5YTJlNmViNDkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmNwcApAQCAtNDEsNyArNDEs NiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBET01EYXRhU3RvcmU6OkRPTURhdGFTdG9yZShUeXBl IHR5cGUpCiAgICAgOiBtX3R5cGUodHlwZSkKIHsKLSAgICBtX2RvbU9iamVjdE1hcCA9IGFkb3B0 UHRyKG5ldyBET01XcmFwcGVyTWFwPHZvaWQ+KTsKICAgICBWOFBlcklzb2xhdGVEYXRhOjpjdXJy ZW50KCktPnJlZ2lzdGVyRE9NRGF0YVN0b3JlKHRoaXMpOwogfQogCkBAIC00OSw3ICs0OCw3IEBA IERPTURhdGFTdG9yZTo6fkRPTURhdGFTdG9yZSgpCiB7CiAgICAgQVNTRVJUKG1fdHlwZSAhPSBN YWluV29ybGQpOyAvLyBXZSBuZXZlciBhY3R1YWxseSBkZXN0cnVjdCB0aGUgbWFpbiB3b3JsZCdz IERPTURhdGFTdG9yZS4KICAgICBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCktPnVucmVnaXN0 ZXJET01EYXRhU3RvcmUodGhpcyk7Ci0gICAgbV9kb21PYmplY3RNYXAtPmNsZWFyKCk7CisgICAg bV93cmFwcGVyTWFwLmNsZWFyKCk7CiB9CiAKIERPTURhdGFTdG9yZSogRE9NRGF0YVN0b3JlOjpj dXJyZW50KHY4OjpJc29sYXRlKiBpc29sYXRlKQpAQCAtNjcsNyArNjYsNyBAQCBET01EYXRhU3Rv cmUqIERPTURhdGFTdG9yZTo6Y3VycmVudCh2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHZvaWQgRE9N RGF0YVN0b3JlOjpyZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmpl Y3RJbmZvKSBjb25zdAogewogICAgIE1lbW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9iamVjdElu Zm8sIHRoaXMsIFdlYkNvcmVNZW1vcnlUeXBlczo6QmluZGluZyk7Ci0gICAgaW5mby5hZGRNZW1i ZXIobV9kb21PYmplY3RNYXApOworICAgIGluZm8uYWRkTWVtYmVyKG1fd3JhcHBlck1hcCk7CiB9 CiAKIHZvaWQgRE9NRGF0YVN0b3JlOjp3ZWFrQ2FsbGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6OlZh bHVlPiB2YWx1ZSwgdm9pZCogY29udGV4dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9N RGF0YVN0b3JlLmgKaW5kZXggODY0NmRiNDNjZDU0MDEyMzk0NDkzYzIyYmQ4NTkwZWU1MWI2YmY0 Zi4uNGFmOWNlMDFjYTE5NGU5ZDAwYTRhMTU2YjJjNmJjY2NkYzZiOGFhOSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmgKQEAgLTYwLDExICs2MCwxMSBAQCBwdWJs aWM6CiAgICAgc3RhdGljIERPTURhdGFTdG9yZSogY3VycmVudCh2ODo6SXNvbGF0ZSopOwogCiAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KLSAgICBpbmxpbmUgdjg6OkhhbmRsZTx2ODo6T2JqZWN0 PiBnZXQoVCogb2JqZWN0KSBjb25zdAorICAgIGlubGluZSB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+ IGdldChUKiBvYmplY3QpCiAgICAgewogICAgICAgICBpZiAod3JhcHBlcklzU3RvcmVkSW5PYmpl Y3Qob2JqZWN0KSkKICAgICAgICAgICAgIHJldHVybiBnZXRXcmFwcGVyRnJvbU9iamVjdChvYmpl Y3QpOwotICAgICAgICByZXR1cm4gbV9kb21PYmplY3RNYXAtPmdldChvYmplY3QpOworICAgICAg ICByZXR1cm4gbV93cmFwcGVyTWFwLmdldChvYmplY3QpOwogICAgIH0KIAogICAgIHRlbXBsYXRl PHR5cGVuYW1lIFQ+CkBAIC03Miw3ICs3Miw3IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIGlm IChzZXRXcmFwcGVySW5PYmplY3Qob2JqZWN0LCB3cmFwcGVyKSkKICAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgbV9kb21PYmplY3RNYXAtPnNldChvYmplY3QsIHdyYXBwZXIpOworICAgICAg ICBtX3dyYXBwZXJNYXAuc2V0KG9iamVjdCwgd3JhcHBlcik7CiAgICAgfQogCiAgICAgdm9pZCBy ZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKikgY29uc3Q7CkBAIC0xMDcsNyArMTA3 LDcgQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgdm9pZCB3ZWFrQ2FsbGJhY2sodjg6OlBlcnNpc3Rl bnQ8djg6OlZhbHVlPiwgdm9pZCogY29udGV4dCk7CiAKICAgICBUeXBlIG1fdHlwZTsKLSAgICBP d25QdHI8RE9NV3JhcHBlck1hcDx2b2lkPiA+IG1fZG9tT2JqZWN0TWFwOworICAgIERPTVdyYXBw ZXJNYXA8dm9pZD4gbV93cmFwcGVyTWFwOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=