101689 2012-11-08 18:50:41 -0800 [BlackBerry] remove obsolete tokenizer settings 2012-11-09 07:32:50 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 762430 0 staikos 2012-11-08 18:50:41 -0800 WebPage has custom tweaks for the tokenizer that should not be there. Remove them. 762435 1 173173 staikos 2012-11-08 18:53:38 -0800 Created attachment 173173 Patch 762460 2 173173 rwlbuis 2012-11-08 19:34:01 -0800 Comment on attachment 173173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173173&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:-575 > - m_page->setCustomHTMLTokenizerTimeDelay(0.3); These are still in use : http://trac.webkit.org/browser/trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp Does this mean the default behavior is fine for us? 762488 3 staikos 2012-11-08 20:21:49 -0800 yes 762996 4 173173 yong.li.webkit 2012-11-09 07:27:56 -0800 Comment on attachment 173173 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173173&action=review >> Source/WebKit/blackberry/Api/WebPage.cpp:-575 >> - m_page->setCustomHTMLTokenizerTimeDelay(0.3); > > These are still in use : > > http://trac.webkit.org/browser/trunk/Source/WebCore/html/parser/HTMLParserScheduler.cpp > > Does this mean the default behavior is fine for us? I think so. I am surprised by the number "256". I believe it hurts... 763005 5 173173 webkit.review.bot 2012-11-09 07:32:47 -0800 Comment on attachment 173173 Patch Clearing flags on attachment: 173173 Committed r134067: <http://trac.webkit.org/changeset/134067> 763006 6 webkit.review.bot 2012-11-09 07:32:50 -0800 All reviewed patches have been landed. Closing bug. 173173 2012-11-08 18:53:38 -0800 2012-11-09 07:32:47 -0800 Patch 101689.patch text/plain 1438 staikos SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTMzOTg3KQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTExLTA4ICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUmVtb3ZlIG9ic29sZXRlIHRva2VuaXplciBzZXR0 aW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx Njg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl c2UgdG9rZW5pemVyIHNldHRpbmdzIGFyZSBvYnNvbGV0ZSBhbmQgc2hvdWxkIG5vdCBiZSBoZXJl LiAgUmVtb3ZlIHRoZW0uCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChC bGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjppbml0KToKKwogMjAxMi0xMS0wOCAg SmFrb2IgUGV0c292aXRzICA8anBldHNvdml0c0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XSBSZXBsYWNlIGNoZWNrZXJib2FyZCB3aXRoIHBhZ2UgYmFja2dyb3VuZCBjb2xvci4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMTMz OTg2KQorKysgU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNTcxLDkgKzU3MSw2IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OmluaXQoY29u c3QgQmxhY2tCZXIKICAgICBXZWJDb3JlOjpwcm92aWRlTmV0d29ya0luZm9UbyhtX3BhZ2UsIG5l dyBXZWJDb3JlOjpOZXR3b3JrSW5mb0NsaWVudEJsYWNrQmVycnkodGhpcykpOwogI2VuZGlmCiAK LSAgICBtX3BhZ2UtPnNldEN1c3RvbUhUTUxUb2tlbml6ZXJDaHVua1NpemUoMjU2KTsKLSAgICBt X3BhZ2UtPnNldEN1c3RvbUhUTUxUb2tlbml6ZXJUaW1lRGVsYXkoMC4zKTsKLQogICAgIG1fd2Vi U2V0dGluZ3MgPSBXZWJTZXR0aW5nczo6Y3JlYXRlRnJvbVN0YW5kYXJkU2V0dGluZ3MoKTsKICAg ICBtX3dlYlNldHRpbmdzLT5zZXRVc2VyQWdlbnRTdHJpbmcoZGVmYXVsdFVzZXJBZ2VudCgpKTsK ICAgICBtX3BhZ2UtPnNldERldmljZVNjYWxlRmFjdG9yKG1fd2ViU2V0dGluZ3MtPmRldmljZVBp eGVsUmF0aW8oKSk7Cg==