101687 2012-11-08 18:49:23 -0800 [EFL][WK2][AC] Random crashes in layout tests on the bot 2012-11-09 04:24:15 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 762426 0 yael 2012-11-08 18:49:23 -0800 Some crashes are seen on the bot. They could be a result of a race condition in which a load is committed before Evas sets the view size. In that case, we issue a call to update, but the size is still 0. A patch is coming. 17:58:20.492 12227 ASSERTION FAILED: !layerRect().isEmpty() 17:58:20.492 12227 /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp(173) : void WebCore::TextureMapperLayer::paintSelf(const WebCore::TextureMapperPaintOptions&) 17:58:20.492 12227 1 0x7f60aadcd453 WebCore::TextureMapperLayer::paintSelf(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 2 0x7f60aadcd709 WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 3 0x7f60aadce04b WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 4 0x7f60aadce17d WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 5 0x7f60aadcd875 WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 6 0x7f60aadce04b WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 7 0x7f60aadce17d WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 8 0x7f60aadcd875 WebCore::TextureMapperLayer::paintSelfAndChildren(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 9 0x7f60aadce04b WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 10 0x7f60aadce17d WebCore::TextureMapperLayer::paintRecursive(WebCore::TextureMapperPaintOptions const&) 17:58:20.492 12227 11 0x7f60aadcd271 WebCore::TextureMapperLayer::paint() 17:58:20.492 12227 12 0x7f60a7867543 WebKit::LayerTreeRenderer::paintToCurrentGLContext(WebCore::TransformationMatrix const&, float, WebCore::FloatRect const&, unsigned int) 17:58:20.492 12227 13 0x7f60a7991250 EwkViewImpl::displayTimerFired(WebCore::Timer<EwkViewImpl>*) 17:58:20.493 12227 14 0x7f60a7997e20 WebCore::Timer<EwkViewImpl>::fired() 17:58:20.493 12227 15 0x7f60aad41cba WebCore::ThreadTimers::sharedTimerFiredInternal() 17:58:20.493 12227 16 0x7f60aad41bdb WebCore::ThreadTimers::sharedTimerFired() 17:58:20.493 12227 17 0x7f60ab72ace5 17:58:20.493 12227 18 0x7f60a6b4933e _ecore_timer_expired_call 17:58:20.493 12227 19 0x7f60a6b4950b _ecore_timer_expired_timers_call 17:58:20.493 12227 20 0x7f60a6b46421 762431 1 173172 yael 2012-11-08 18:51:40 -0800 Created attachment 173172 Patch 762747 2 173172 kenneth 2012-11-09 02:18:31 -0800 Comment on attachment 173172 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173172&action=review > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:324 > + > + if (!(sd->view.w && sd->view.h)) > + return; > + comment please: // Guard for zero sized viewport. 762818 3 173262 naginenis 2012-11-09 04:17:33 -0800 Created attachment 173262 Patch Let's land this patch quickly to make the bots green. 762821 4 173262 rakuco 2012-11-09 04:24:06 -0800 Comment on attachment 173262 Patch Clearing flags on attachment: 173262 Committed r134049: <http://trac.webkit.org/changeset/134049> 762822 5 rakuco 2012-11-09 04:24:15 -0800 All reviewed patches have been landed. Closing bug. 173172 2012-11-08 18:51:40 -0800 2012-11-09 04:20:04 -0800 Patch 101687.patch text/plain 1589 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1w bC5jcHAJKHJldmlzaW9uIDEzMzkyMykKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL0V3a1ZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEzLDE0ICszMTMsMTggQEAK IAogdm9pZCBFd2tWaWV3SW1wbDo6dXBkYXRlKGNvbnN0IEludFJlY3QmIHJlY3QpCiB7CisgICAg RXdrX1ZpZXdfU21hcnRfRGF0YSogc2QgPSBzbWFydERhdGEoKTsKICNpZiBVU0UoQ09PUkRJTkFU RURfR1JBUEhJQ1MpCiAgICAgLy8gQ29vcmRpbmF0ZWQgZ3JhcGhpY2VzIG5lZWRzIHRvIHNjaGVk dWxlIGFuIGZ1bGwgdXBkYXRlLCBub3QKICAgICAvLyByZXBhaW50aW5nIG9mIGEgcmVnaW9uLiBV cGRhdGUgaW4gdGhlIGV2ZW50IGxvb3AuCiAgICAgVU5VU0VEX1BBUkFNKHJlY3QpOworCisgICAg aWYgKCEoc2QtPnZpZXcudyAmJiBzZC0+dmlldy5oKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAg aWYgKCFtX2Rpc3BsYXlUaW1lci5pc0FjdGl2ZSgpKQogICAgICAgICBtX2Rpc3BsYXlUaW1lci5z dGFydE9uZVNob3QoMCk7CiAjZWxzZQotICAgIEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNkID0gc21h cnREYXRhKCk7CiAgICAgaWYgKCFzZC0+aW1hZ2UpCiAgICAgICAgIHJldHVybjsKIApJbmRleDog U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwkocmV2aXNpb24gMTMzOTkyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMTEtMDggIFlhZWwgQWhhcm9uICA8 eWFlbC5haGFyb25AaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl1bQUNdIFJhbmRvbSBj cmFzaGVzIGluIGxheW91dCB0ZXN0cyBvbiB0aGUgYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2ODcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjdWxhdGl2ZSBmaXggZm9yIGEgY3Jhc2ggb24g dGhlIGJvdC4KKyAgICAgICAgSWYgZGlkQ29tbWl0TG9hZCgpIGlzIGNhbGxlZCBiZWZvcmUgdGhl IHZpZXcgc2l6ZSB3YXMgc2V0LCB3ZSB3aWxsIAorICAgICAgICB0cnkgdG8gcGFpbnQgYW4gZW1w dHkgYXJlYSwgYW5kIHRoYXQgd2lsbCBjcmFzaC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv ZWZsL0V3a1ZpZXdJbXBsLmNwcDoKKyAgICAgICAgKEV3a1ZpZXdJbXBsOjp1cGRhdGUpOgorCiAy MDEyLTExLTA4ICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAg IFtXSzJdIFVudXNlZCBwYXJhbWV0ZXJzIG9uIExheWVyVHJlZVJlbmRlcmVyLmNwcAo= 173262 2012-11-09 04:17:33 -0800 2012-11-09 04:24:06 -0800 Patch 101687.patch text/plain 1708 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3Y2U2ZmNiLi5iOTkyMTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTEtMDkgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25AaW50ZWwuY29tPgorCisg ICAgICAgIFtFRkxdW1dLMl1bQUNdIFJhbmRvbSBjcmFzaGVzIGluIGxheW91dCB0ZXN0cyBvbiB0 aGUgYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDE2ODcKKworICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K KworICAgICAgICBTcGVjdWxhdGl2ZSBmaXggZm9yIGEgY3Jhc2ggb24gdGhlIGJvdC4KKyAgICAg ICAgSWYgZGlkQ29tbWl0TG9hZCgpIGlzIGNhbGxlZCBiZWZvcmUgdGhlIHZpZXcgc2l6ZSB3YXMg c2V0LCB3ZSB3aWxsCisgICAgICAgIHRyeSB0byBwYWludCBhbiBlbXB0eSBhcmVhLCBhbmQgdGhh dCB3aWxsIGNyYXNoLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwu Y3BwOgorICAgICAgICAoRXdrVmlld0ltcGw6OnVwZGF0ZSk6CisKIDIwMTItMTEtMDggIEdyemVn b3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VG TF0gQWRkIGEgbWV0aG9kIHRvIHRoZSBUZXh0Q2hlY2tlckVuY2hhbnQgY2xhc3MgdG8gY2hlY2sg d2hldGhlciBhbnkgZGljdGlvbmFyeSBpcyBsb2FkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAppbmRleCA5ZDg3MzJlLi5mNWUzOGJlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3Bw CkBAIC0zMTQsMTQgKzMxNCwxOSBAQCB2b2lkIEV3a1ZpZXdJbXBsOjpkaXNwbGF5VGltZXJGaXJl ZChUaW1lcjxFd2tWaWV3SW1wbD4qKQogCiB2b2lkIEV3a1ZpZXdJbXBsOjp1cGRhdGUoY29uc3Qg SW50UmVjdCYgcmVjdCkKIHsKKyAgICBFd2tfVmlld19TbWFydF9EYXRhKiBzZCA9IHNtYXJ0RGF0 YSgpOwogI2lmIFVTRShDT09SRElOQVRFRF9HUkFQSElDUykKICAgICAvLyBDb29yZGluYXRlZCBn cmFwaGljZXMgbmVlZHMgdG8gc2NoZWR1bGUgYW4gZnVsbCB1cGRhdGUsIG5vdAogICAgIC8vIHJl cGFpbnRpbmcgb2YgYSByZWdpb24uIFVwZGF0ZSBpbiB0aGUgZXZlbnQgbG9vcC4KICAgICBVTlVT RURfUEFSQU0ocmVjdCk7CisKKyAgICAvLyBHdWFyZCBmb3IgemVybyBzaXplZCB2aWV3cG9ydC4K KyAgICBpZiAoIShzZC0+dmlldy53ICYmIHNkLT52aWV3LmgpKQorICAgICAgICByZXR1cm47CisK ICAgICBpZiAoIW1fZGlzcGxheVRpbWVyLmlzQWN0aXZlKCkpCiAgICAgICAgIG1fZGlzcGxheVRp bWVyLnN0YXJ0T25lU2hvdCgwKTsKICNlbHNlCi0gICAgRXdrX1ZpZXdfU21hcnRfRGF0YSogc2Qg PSBzbWFydERhdGEoKTsKICAgICBpZiAoIXNkLT5pbWFnZSkKICAgICAgICAgcmV0dXJuOwogCg==