101675 2012-11-08 17:40:09 -0800 [TexMap] Initialize m_compositedNativeImagePtr in GraphicsLayerTextureMapper. 2012-11-09 17:46:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dongseong.hwang dongseong.hwang noam webkit.review.bot oldest_to_newest 762378 0 dongseong.hwang 2012-11-08 17:40:09 -0800 Fix a potential bug in GraphicsLayerTextureMapper. If the member's uninitialized value equals image->nativeImageForCurrentFrame() by change, we can encounter undefined behavior. 762379 1 173160 dongseong.hwang 2012-11-08 17:41:55 -0800 Created attachment 173160 Patch 762472 2 173160 noam 2012-11-08 20:00:01 -0800 Comment on attachment 173160 Patch Any way to test this? 762555 3 dongseong.hwang 2012-11-08 21:59:53 -0800 (In reply to comment #2) > (From update of attachment 173160 [details]) > Any way to test this? I think it is hard because m_compositedNativeImagePtr is initialized to random value. m_compositedNativeImagePtr is used only in if (newNativeImagePtr == m_compositedNativeImagePtr) return; If we want to make a test, the test must have the ability to check the above code. Unfortunately, I can not imagine. 762998 4 173160 webkit.review.bot 2012-11-09 07:28:56 -0800 Comment on attachment 173160 Patch Rejecting attachment 173160 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: mit-queue/Source/WebKit/chromium/third_party/skia/src --revision 6360 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 6360. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14790103 763431 5 173391 dongseong.hwang 2012-11-09 16:17:30 -0800 Created attachment 173391 Patch 763435 6 dongseong.hwang 2012-11-09 16:18:23 -0800 Thanks for review! Could you r+ one more time? commit-queue failed flaky. 763502 7 173391 webkit.review.bot 2012-11-09 17:46:53 -0800 Comment on attachment 173391 Patch Clearing flags on attachment: 173391 Committed r134140: <http://trac.webkit.org/changeset/134140> 763503 8 webkit.review.bot 2012-11-09 17:46:57 -0800 All reviewed patches have been landed. Closing bug. 173160 2012-11-08 17:41:55 -0800 2012-11-09 16:17:27 -0800 Patch bug-101675-20121109103951.patch text/plain 2367 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmJiYzQ2ODkzZGExZmYz ZDJjYjhiMmUwYzU4MzYyZDNmZWEwZTNlZC4uN2QxYThhM2I0ZjNhZGExNTcxMGNlOTk0YjBlOTUw ZTc5YWRhMTI0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTExLTA4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIFtUZXhNYXBd IEluaXRpYWxpemUgbV9jb21wb3NpdGVkTmF0aXZlSW1hZ2VQdHIgaW4gR3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDE2NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggYSBwb3RlbnRpYWwgYnVnIGluIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLiBJ ZiB0aGUgbWVtYmVyJ3MgdW5pbml0aWFsaXplZAorICAgICAgICB2YWx1ZSBlcXVhbHMgaW1hZ2Ut Pm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkgYnkgY2hhbmdlLCB3ZSBjYW4gZW5jb3VudGVy CisgICAgICAgIHVuZGVmaW5lZCBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBw ZXIpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldENv bnRlbnRzVG9JbWFnZSk6CisKKzIwMTItMTEtMDggIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFA Y29tcGFueTEwMC5uZXQ+CisKICAgICAgICAgW1RleE1hcF0gUmVtb3ZlIGNvbnRlbnRzTGF5ZXIo KSBpbiBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci4KICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTY1OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5 ZXJUZXh0dXJlTWFwcGVyLmNwcAppbmRleCA0MTg5N2M2M2U4MTg1ZDk2ZTg1MGMzYWI2MjJmZjIw OWJlOTE2NmFlLi5mZGRiNzg5NzU2YTQ0NWQ3OTRlODgzODhhYWZhZmY0NmFlY2E2ODdlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NM YXllclRleHR1cmVNYXBwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKQEAgLTQ0LDYgKzQ0LDcg QEAgUGFzc093blB0cjxHcmFwaGljc0xheWVyPiBHcmFwaGljc0xheWVyOjpjcmVhdGUoR3JhcGhp Y3NMYXllckNsaWVudCogY2xpZW50KQogR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OkdyYXBo aWNzTGF5ZXJUZXh0dXJlTWFwcGVyKEdyYXBoaWNzTGF5ZXJDbGllbnQqIGNsaWVudCkKICAgICA6 IEdyYXBoaWNzTGF5ZXIoY2xpZW50KQogICAgICwgbV9sYXllcihhZG9wdFB0cihuZXcgVGV4dHVy ZU1hcHBlckxheWVyKCkpKQorICAgICwgbV9jb21wb3NpdGVkTmF0aXZlSW1hZ2VQdHIoMCkKICAg ICAsIG1fY2hhbmdlTWFzaygwKQogICAgICwgbV9uZWVkc0Rpc3BsYXkoZmFsc2UpCiAgICAgLCBt X2ZpeGVkVG9WaWV3cG9ydChmYWxzZSkKQEAgLTM1MSw4ICszNTIsMTAgQEAgdm9pZCBHcmFwaGlj c0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0Q29udGVudHNUb0ltYWdlKEltYWdlKiBpbWFnZSkKICAg ICAgICAgaWYgKCFtX2NvbXBvc2l0ZWRJbWFnZSkKICAgICAgICAgICAgIG1fY29tcG9zaXRlZElt YWdlID0gVGV4dHVyZU1hcHBlclRpbGVkQmFja2luZ1N0b3JlOjpjcmVhdGUoKTsKICAgICAgICAg bV9jb21wb3NpdGVkSW1hZ2UtPnNldENvbnRlbnRzVG9JbWFnZShpbWFnZSk7Ci0gICAgfSBlbHNl CisgICAgfSBlbHNlIHsKKyAgICAgICAgbV9jb21wb3NpdGVkTmF0aXZlSW1hZ2VQdHIgPSAwOwog ICAgICAgICBtX2NvbXBvc2l0ZWRJbWFnZSA9IDA7CisgICAgfQogCiAgICAgc2V0Q29udGVudHNU b01lZGlhKG1fY29tcG9zaXRlZEltYWdlLmdldCgpKTsKICAgICBub3RpZnlDaGFuZ2UoVGV4dHVy ZU1hcHBlckxheWVyOjpDb250ZW50Q2hhbmdlKTsK 173391 2012-11-09 16:17:30 -0800 2012-11-09 17:46:53 -0800 Patch bug-101675-20121110091522.patch text/plain 2303 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGFiYjYxMDIzNmY1ZGRi NDNjMmI1ZjFjZWM3NmU1ZWRmMTZlZjhkNS4uOWZiOWNlMTI3ZjcyZTkzMGIwNTI3NzAzMjJiYTY2 YjZmNzA0NmM3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTExLTA4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtUZXhNYXBd IEluaXRpYWxpemUgbV9jb21wb3NpdGVkTmF0aXZlSW1hZ2VQdHIgaW4gR3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDE2NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggYSBwb3RlbnRpYWwgYnVnIGluIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLiBJ ZiB0aGUgbWVtYmVyJ3MgdW5pbml0aWFsaXplZAorICAgICAgICB2YWx1ZSBlcXVhbHMgaW1hZ2Ut Pm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkgYnkgY2hhbmdlLCB3ZSBjYW4gZW5jb3VudGVy CisgICAgICAgIHVuZGVmaW5lZCBiZWhhdmlvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBw ZXIpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldENv bnRlbnRzVG9JbWFnZSk6CisKIDIwMTItMTEtMDkgIEFsZWMgRmxldHQgIDxhbGVjZmxldHRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogQ29tYmluZSBJREJCYWNraW5nU3RvcmUg YW5kIElEQkxldmVsREJCYWNraW5nU3RvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1 cmVNYXBwZXIuY3BwCmluZGV4IDQxODk3YzYzZTgxODVkOTZlODUwYzNhYjYyMmZmMjA5YmU5MTY2 YWUuLmZkZGI3ODk3NTZhNDQ1ZDc5NGU4ODM4OGFhZmFmZjQ2YWVjYTY4N2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4 dHVyZU1hcHBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcApAQCAtNDQsNiArNDQsNyBAQCBQYXNz T3duUHRyPEdyYXBoaWNzTGF5ZXI+IEdyYXBoaWNzTGF5ZXI6OmNyZWF0ZShHcmFwaGljc0xheWVy Q2xpZW50KiBjbGllbnQpCiBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6R3JhcGhpY3NMYXll clRleHR1cmVNYXBwZXIoR3JhcGhpY3NMYXllckNsaWVudCogY2xpZW50KQogICAgIDogR3JhcGhp Y3NMYXllcihjbGllbnQpCiAgICAgLCBtX2xheWVyKGFkb3B0UHRyKG5ldyBUZXh0dXJlTWFwcGVy TGF5ZXIoKSkpCisgICAgLCBtX2NvbXBvc2l0ZWROYXRpdmVJbWFnZVB0cigwKQogICAgICwgbV9j aGFuZ2VNYXNrKDApCiAgICAgLCBtX25lZWRzRGlzcGxheShmYWxzZSkKICAgICAsIG1fZml4ZWRU b1ZpZXdwb3J0KGZhbHNlKQpAQCAtMzUxLDggKzM1MiwxMCBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJU ZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50c1RvSW1hZ2UoSW1hZ2UqIGltYWdlKQogICAgICAgICBp ZiAoIW1fY29tcG9zaXRlZEltYWdlKQogICAgICAgICAgICAgbV9jb21wb3NpdGVkSW1hZ2UgPSBU ZXh0dXJlTWFwcGVyVGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZSgpOwogICAgICAgICBtX2NvbXBv c2l0ZWRJbWFnZS0+c2V0Q29udGVudHNUb0ltYWdlKGltYWdlKTsKLSAgICB9IGVsc2UKKyAgICB9 IGVsc2UgeworICAgICAgICBtX2NvbXBvc2l0ZWROYXRpdmVJbWFnZVB0ciA9IDA7CiAgICAgICAg IG1fY29tcG9zaXRlZEltYWdlID0gMDsKKyAgICB9CiAKICAgICBzZXRDb250ZW50c1RvTWVkaWEo bV9jb21wb3NpdGVkSW1hZ2UuZ2V0KCkpOwogICAgIG5vdGlmeUNoYW5nZShUZXh0dXJlTWFwcGVy TGF5ZXI6OkNvbnRlbnRDaGFuZ2UpOwo=