101665 2012-11-08 16:42:24 -0800 DFG should know that int == null is always false 2012-11-08 18:12:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 101680 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 762316 0 fpizlo 2012-11-08 16:42:24 -0800 Patch forthcoming. 762321 1 173146 fpizlo 2012-11-08 16:45:53 -0800 Created attachment 173146 the patch 762383 2 fpizlo 2012-11-08 17:58:29 -0800 Landed in http://trac.webkit.org/changeset/133990 762392 3 173146 darin 2012-11-08 18:06:04 -0800 Comment on attachment 173146 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=173146&action=review > Source/JavaScriptCore/ChangeLog:3 > + DFG should know that int == null is always false Seems more specific than I would have expected. Isn’t double == null also always false? And string == null? And lots of other cases like that? 762398 4 fpizlo 2012-11-08 18:11:48 -0800 (In reply to comment #3) > (From update of attachment 173146 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173146&action=review > > > Source/JavaScriptCore/ChangeLog:3 > > + DFG should know that int == null is always false > > Seems more specific than I would have expected. Isn’t double == null also always false? And string == null? And lots of other cases like that? You're right, this is too specific. On the other hand, I was playing it safe because even for int == null Gavin and I ended up scratching our heads over whether or not 0 is equal to null. Also, whereas we have test coverage for int == null being compiled correctly (V8/crypto), we don't have such coverage for the other cases. So, that patch will require somewhat more work since I don't want to add optimizations that aren't covered. I've opened a bug for this: https://bugs.webkit.org/show_bug.cgi?id=101680 173146 2012-11-08 16:45:53 -0800 2012-11-08 18:06:04 -0800 the patch intnull.patch text/plain 2656 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzOTczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTExLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZCBrbm93IHRoYXQgaW50ID09IG51bGwgaXMgYWx3YXlzIGZhbHNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2NjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFj dFN0YXRlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdFN0YXRlOjpleGVjdXRlKToK KwogMjAxMi0xMS0wNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg IERGRyBjb25zdGFudCBmb2xkaW5nIGFuZCBDRkcgc2ltcGxpZmljYXRpb24gc2hvdWxkIGJlIHNt YXJ0IGVub3VnaCB0byBrbm93IHRoYXQgaWYgYSBsb2dpY2FsIG9wJ3Mgb3BlcmFuZCBpcyBwcm92 ZW4gdG8gaGF2ZSBhIG5vbi1tYXNxdWVyYWRpbmcgc3RydWN0dXJlIHRoZW4gaXQgYWx3YXlzIGV2 YWx1YXRlcyB0byB0cnVlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3Ry YWN0U3RhdGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH QWJzdHJhY3RTdGF0ZS5jcHAJKHJldmlzaW9uIDEzMzk2MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY4OSwxMiAr Njg5LDEzIEBAIGJvb2wgQWJzdHJhY3RTdGF0ZTo6ZXhlY3V0ZSh1bnNpZ25lZCBpbmQKICAgICBj YXNlIENvbXBhcmVHcmVhdGVyOgogICAgIGNhc2UgQ29tcGFyZUdyZWF0ZXJFcToKICAgICBjYXNl IENvbXBhcmVFcTogeworICAgICAgICBib29sIGNvbnN0YW50V2FzU2V0ID0gZmFsc2U7CisKICAg ICAgICAgSlNWYWx1ZSBsZWZ0Q29uc3QgPSBmb3JOb2RlKG5vZGUuY2hpbGQxKCkpLnZhbHVlKCk7 CiAgICAgICAgIEpTVmFsdWUgcmlnaHRDb25zdCA9IGZvck5vZGUobm9kZS5jaGlsZDIoKSkudmFs dWUoKTsKICAgICAgICAgaWYgKGxlZnRDb25zdCAmJiByaWdodENvbnN0ICYmIGxlZnRDb25zdC5p c051bWJlcigpICYmIHJpZ2h0Q29uc3QuaXNOdW1iZXIoKSkgewogICAgICAgICAgICAgZG91Ymxl IGEgPSBsZWZ0Q29uc3QuYXNOdW1iZXIoKTsKICAgICAgICAgICAgIGRvdWJsZSBiID0gcmlnaHRD b25zdC5hc051bWJlcigpOwotICAgICAgICAgICAgYm9vbCBjb25zdGFudFdhc1NldDsKICAgICAg ICAgICAgIHN3aXRjaCAobm9kZS5vcCgpKSB7CiAgICAgICAgICAgICBjYXNlIENvbXBhcmVMZXNz OgogICAgICAgICAgICAgICAgIGNvbnN0YW50V2FzU2V0ID0gdHJ5U2V0Q29uc3RhbnQobm9kZUlu ZGV4LCBqc0Jvb2xlYW4oYSA8IGIpKTsKQEAgLTcxNiwxMSArNzE3LDIwIEBAIGJvb2wgQWJzdHJh Y3RTdGF0ZTo6ZXhlY3V0ZSh1bnNpZ25lZCBpbmQKICAgICAgICAgICAgICAgICBjb25zdGFudFdh c1NldCA9IGZhbHNlOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQotICAg ICAgICAgICAgaWYgKGNvbnN0YW50V2FzU2V0KSB7Ci0gICAgICAgICAgICAgICAgbV9mb3VuZENv bnN0YW50cyA9IHRydWU7Ci0gICAgICAgICAgICAgICAgbm9kZS5zZXRDYW5FeGl0KGZhbHNlKTsK LSAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgICAg ICAKKyAgICAgICAgaWYgKCFjb25zdGFudFdhc1NldCAmJiBub2RlLm9wKCkgPT0gQ29tcGFyZUVx KSB7CisgICAgICAgICAgICBTcGVjdWxhdGVkVHlwZSBsZWZ0VHlwZSA9IGZvck5vZGUobm9kZS5j aGlsZDEoKSkubV90eXBlOworICAgICAgICAgICAgU3BlY3VsYXRlZFR5cGUgcmlnaHRUeXBlID0g Zm9yTm9kZShub2RlLmNoaWxkMigpKS5tX3R5cGU7CisgICAgICAgICAgICBpZiAoKGlzSW50MzJT cGVjdWxhdGlvbihsZWZ0VHlwZSkgJiYgaXNPdGhlclNwZWN1bGF0aW9uKHJpZ2h0VHlwZSkpCisg ICAgICAgICAgICAgICAgfHwgKGlzT3RoZXJTcGVjdWxhdGlvbihsZWZ0VHlwZSkgJiYgaXNJbnQz MlNwZWN1bGF0aW9uKHJpZ2h0VHlwZSkpKQorICAgICAgICAgICAgICAgIGNvbnN0YW50V2FzU2V0 ID0gdHJ5U2V0Q29uc3RhbnQobm9kZUluZGV4LCBqc0Jvb2xlYW4oZmFsc2UpKTsKKyAgICAgICAg fQorICAgICAgICAKKyAgICAgICAgaWYgKGNvbnN0YW50V2FzU2V0KSB7CisgICAgICAgICAgICBt X2ZvdW5kQ29uc3RhbnRzID0gdHJ1ZTsKKyAgICAgICAgICAgIG5vZGUuc2V0Q2FuRXhpdChmYWxz ZSk7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgZm9y Tm9kZShub2RlSW5kZXgpLnNldChTcGVjQm9vbGVhbik7Cg==