101664 2012-11-08 16:24:53 -0800 Null check URL key entries into WebHistory hash table 2012-11-28 11:42:53 -0800 1 1 1 Unclassified WebKit History 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 roger_fong roger_fong beidson oldest_to_newest 762304 0 roger_fong 2012-11-08 16:24:53 -0800 This a workaround. Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown. 762306 1 173145 roger_fong 2012-11-08 16:30:58 -0800 Created attachment 173145 Patch 762312 2 173145 beidson 2012-11-08 16:35:30 -0800 Comment on attachment 173145 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173145&action=review > Source/WebKit/mac/ChangeLog:4 > + Null check URL key entries into WebHistory hash table. > + https://bugs.webkit.org/show_bug.cgi?id=101664 Can include the rdar: number here, too. > Source/WebKit/mac/ChangeLog:10 > + This a workaround. > + Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown > + so that navigation can continue as expected. Workaround for what? *I* know, but future readers of this ChangeLog who aren't me won't know. 762328 3 173149 roger_fong 2012-11-08 16:53:03 -0800 Created attachment 173149 Patch 762329 4 roger_fong 2012-11-08 16:53:39 -0800 (In reply to comment #3) > Created an attachment (id=173149) [details] > Patch fixed changelog 762358 5 roger_fong 2012-11-08 17:21:30 -0800 Committed: http://trac.webkit.org/changeset/133977 173145 2012-11-08 16:30:58 -0800 2012-11-08 16:53:02 -0800 Patch bug-101664-20121108162907.patch text/plain 1560 roger_fong U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjAwNWY4NTg2 YzY4ZDA1ZDlkZjZhYzBmNWIxMmU3OGIzZmY0NjNiMi4uM2U3MmJkNTIwNWU4YTk4NzIxODAyMTk3 M2NkZWFkOGMwMTJhMmYxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTExLTA4ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTnVs bCBjaGVjayBVUkwga2V5IGVudHJpZXMgaW50byBXZWJIaXN0b3J5IGhhc2ggdGFibGUuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2NjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGEgd29ya2Fy b3VuZC4KKyAgICAgICAgSWRlYWxseSB3ZSB3b3VsZCBmaWd1cmUgb3V0IHdoZXJlIHRoZSBudWxs IHZhbHVlcyBmb3IgdGhlIGtleSBhcmUgY29taW5nIGZyb20gYnV0IGZvciBub3cgd2UnbGwganVz dCBzZXQgaXQgdG8gIiIgdG8gcHJldmVudCB0aGUgZXhjZXB0aW9uIGZyb20gYmVpbmcgdGhyb3du CisgICAgICAgIHNvIHRoYXQgbmF2aWdhdGlvbiBjYW4gY29udGludWUgYXMgZXhwZWN0ZWQuCisK KyAgICAgICAgKiBIaXN0b3J5L1dlYkhpc3RvcnkubW06CisgICAgICAgICgtW1dlYkhpc3RvcnlQ cml2YXRlIHZpc2l0ZWRVUkw6d2l0aFRpdGxlOmluY3JlYXNlVmlzaXRDb3VudDpdKToKKwogMjAx Mi0xMS0wNyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVt b3ZlIGJ1aWxkLXdlYmtpdCBkZXBlbmRlbmN5IG9uIEphdmEgU0RLIGZvciBBcHBsZSBNYWMgV2Vi S2l0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5Lm1t IGIvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5Lm1tCmluZGV4IGU3ODFkMzJm ZDFkZTk1MGQ5MTRhZjQ4MzQ5NzY0MjBkZjU4N2RhZjcuLjU5MWNjMDRiMGE1ZDE0NmMwYTVjN2Iy YTQ1YjJkNWFjZGQwMTkzYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL0hpc3Rvcnkv V2ViSGlzdG9yeS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3Rvcnku bW0KQEAgLTI5Niw2ICsyOTYsOCBAQCBzdGF0aWMgaW5saW5lIFdlYkhpc3RvcnlEYXRlS2V5IGRh dGVLZXkoTlNUaW1lSW50ZXJ2YWwgZGF0ZSkKICAgICBBU1NFUlQodGl0bGUpOwogICAgIAogICAg IE5TU3RyaW5nICpVUkxTdHJpbmcgPSBbdXJsIF93ZWJfb3JpZ2luYWxEYXRhQXNTdHJpbmddOwor ICAgIGlmICghVVJMU3RyaW5nKQorICAgICAgICBVUkxTdHJpbmcgPSBAIiI7CiAgICAgV2ViSGlz dG9yeUl0ZW0gKmVudHJ5ID0gW19lbnRyaWVzQnlVUkwgb2JqZWN0Rm9yS2V5OlVSTFN0cmluZ107 CiAKICAgICBpZiAoZW50cnkpIHsK 173149 2012-11-08 16:53:03 -0800 2012-11-08 17:02:39 -0800 Patch bug-101664-20121108165112.patch text/plain 1798 roger_fong U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjAwNWY4NTg2 YzY4ZDA1ZDlkZjZhYzBmNWIxMmU3OGIzZmY0NjNiMi4uZDNiYzg2ODI3OGI0ZDFhY2VjYjRlYTFj MThkN2M5YWZiYWYyNjY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTExLTA4ICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTnVs bCBjaGVjayBVUkwga2V5IGVudHJpZXMgaW50byBXZWJIaXN0b3J5IGhhc2ggdGFibGUuIAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjY0CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMjQ0MDg1Mj4KKworICAgICAgICBTb21ldGltZXMgdGhlIF9l bnRyaWVzQnlVUkwgaGFzaCB0YWJsZSB1c2VkIHRvIGtlZXAgdHJhY2sgb2Ygd2ViIGhpc3Rvcnkg aXMgZXJyb25lb3VzbHkgcGFzc2VkIGluIG51bGwga2V5IGVudHJpZXMsIHdoaWNoIGNhdXNlcyBh biBleGNlcHRpb24gdG8gZmlyZS4KKyAgICAgICAgVGhpcyBwcmV2ZW50cyB0aGUgZGVzaXJlZCBw YWdlIG5hdmlnYXRpb24gZnJvbSB0YWtpbmcgZWZmZWN0LiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBm b3IgdGhlIHByb2JsZW0uCisgICAgICAgIElkZWFsbHkgd2Ugd291bGQgZmlndXJlIG91dCB3aGVy ZSB0aGUgbnVsbCB2YWx1ZXMgZm9yIHRoZSBrZXkgYXJlIGNvbWluZyBmcm9tIGJ1dCBmb3Igbm93 IHdlJ2xsIGp1c3Qgc2V0IGl0IHRvICIiIHRvIHByZXZlbnQgdGhlIGV4Y2VwdGlvbiBmcm9tIGJl aW5nIHRocm93bgorICAgICAgICBzbyB0aGF0IG5hdmlnYXRpb24gY2FuIGNvbnRpbnVlIGFzIGV4 cGVjdGVkLgorCisgICAgICAgICogSGlzdG9yeS9XZWJIaXN0b3J5Lm1tOgorICAgICAgICAoLVtX ZWJIaXN0b3J5UHJpdmF0ZSB2aXNpdGVkVVJMOndpdGhUaXRsZTppbmNyZWFzZVZpc2l0Q291bnQ6 XSk6CisKIDIwMTItMTEtMDcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBidWlsZC13ZWJraXQgZGVwZW5kZW5jeSBvbiBKYXZhIFNESyBmb3IgQXBw bGUgTWFjIFdlYktpdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0hpc3RvcnkvV2Vi SGlzdG9yeS5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL0hpc3RvcnkvV2ViSGlzdG9yeS5tbQppbmRl eCBlNzgxZDMyZmQxZGU5NTBkOTE0YWY0ODM0OTc2NDIwZGY1ODdkYWY3Li41OTFjYzA0YjBhNWQx NDZjMGE1YzdiMmE0NWIyZDVhY2RkMDE5M2I4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21h Yy9IaXN0b3J5L1dlYkhpc3RvcnkubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9X ZWJIaXN0b3J5Lm1tCkBAIC0yOTYsNiArMjk2LDggQEAgc3RhdGljIGlubGluZSBXZWJIaXN0b3J5 RGF0ZUtleSBkYXRlS2V5KE5TVGltZUludGVydmFsIGRhdGUpCiAgICAgQVNTRVJUKHRpdGxlKTsK ICAgICAKICAgICBOU1N0cmluZyAqVVJMU3RyaW5nID0gW3VybCBfd2ViX29yaWdpbmFsRGF0YUFz U3RyaW5nXTsKKyAgICBpZiAoIVVSTFN0cmluZykKKyAgICAgICAgVVJMU3RyaW5nID0gQCIiOwog ICAgIFdlYkhpc3RvcnlJdGVtICplbnRyeSA9IFtfZW50cmllc0J5VVJMIG9iamVjdEZvcktleTpV UkxTdHJpbmddOwogCiAgICAgaWYgKGVudHJ5KSB7Cg==