101663 2012-11-08 16:20:43 -0800 [BlackBerry] Use keyevents instead of editor commands for backspace 2012-11-12 13:26:58 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 762300 0 nima.ghanavatian 2012-11-08 16:20:43 -0800 This will allow JS to trigger on backspace. 764672 1 173688 nima.ghanavatian 2012-11-12 12:36:09 -0800 Created attachment 173688 Patch 764687 2 173688 rwlbuis 2012-11-12 12:43:53 -0800 Comment on attachment 173688 Patch Ok. 764744 3 173688 webkit.review.bot 2012-11-12 13:26:55 -0800 Comment on attachment 173688 Patch Clearing flags on attachment: 173688 Committed r134294: <http://trac.webkit.org/changeset/134294> 764745 4 webkit.review.bot 2012-11-12 13:26:58 -0800 All reviewed patches have been landed. Closing bug. 173688 2012-11-12 12:36:09 -0800 2012-11-12 13:26:55 -0800 Patch bug-101663-20121112152900.patch text/plain 4353 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBkOWVkMDA0NDU1OWFkODVhNDMxNmMwNTViN2MwYzBiODdmMzc1ZWI3Li4wNTYyNTVmMTk4 ZGIyZmVhNTljYTFlZTY0MDc3MDEyYjBlOWMyODA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0xMS0xMiAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVc2Uga2V5ZXZlbnRz IGluc3RlYWQgb2YgZWRpdG9yIGNvbW1hbmRzIGZvciBiYWNrc3BhY2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTY2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSMjI5Mzk1CisgICAgICAgIFNlbmRp bmcga2V5RXZlbnRzIGZvciBiYWNrc3BhY2UgYW5kIHN3aXRjaGluZyBmcm9tIEtleUNoYXIKKyAg ICAgICAgdG8gS2V5RG93biBzaW5jZSB3ZSBhcmUgc3RpbGwgcmVjZWl2aW5nIGFuIHVuYWR1bHRl cmVkIEtleVVwCisgICAgICAgIGZyb20gdGhlIGlucHV0IHNlcnZpY2UuIFRoaXMgd2FzIGNhdXNp bmcgdXMgdG8gZ2V0IHR3byBrZXlVcHMKKyAgICAgICAgZm9yIHJlZ3VsYXIga2V5cyBhbmQgbm8g a2V5IGRvd25zIGZvciBiYWNrc3BhY2Ugc2luY2UgaXQgd2FzCisgICAgICAgIHRyaWdnZXJpbmcg YW4gZWRpdG9yIGNvbW1hbmQgYW5kIGJ5cGFzc2luZyBKUyBsaXN0ZW5lcnMuCisKKyAgICAgICAg UmV2aWV3ZWQgaW50ZXJuYWxseSBieSBNaWtlIEZlbnRvbi4KKworICAgICAgICAqIFdlYktpdFN1 cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5w dXRIYW5kbGVyOjpoYW5kbGVLZXlib2FyZElucHV0KToKKyAgICAgICAgKEJsYWNrQmVycnk6Oldl YktpdDo6cmVsYXRpdmVSaWdodE9mZnNldCk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAo QmxhY2tCZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OmRlbGV0ZVRleHRSZWxhdGl2ZVRvQ3Vy c29yKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpzZXRUZXh0 KToKKwogMjAxMi0xMS0wNiAgTmltYSBHaGFuYXZhdGlhbiAgPG5naGFuYXZhdGlhbkByaW0uY29t PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBQcm92aWRlIHBpeGVsIGNvb3JkaW5hdGVzIHRvIElN RiByZWxhdGl2ZSB0byB0aGUgc2NyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCAwNzMyNjEwZjYwY2Nj NDAzNGM4MDhkNzk0ODI3Yzk3ODczYmQ1ODNhLi41MTMzNjdhMDdlZTdjYzExNTFlYTk1ZmUyMzEx MzI3OWYyNzM2ODVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTE2MzIsNyArMTYzMiw3IEBAIGJvb2wg SW5wdXRIYW5kbGVyOjpkZWxldGVTZWxlY3Rpb24oKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK ICAgICBBU1NFUlQoZnJhbWUtPmVkaXRvcigpKTsKLSAgICByZXR1cm4gZnJhbWUtPmVkaXRvcigp LT5jb21tYW5kKCJEZWxldGVCYWNrd2FyZCIpLmV4ZWN1dGUoKTsKKyAgICByZXR1cm4gaGFuZGxl S2V5Ym9hcmRJbnB1dChQbGF0Zm9ybTo6S2V5Ym9hcmRFdmVudChLRVlDT0RFX0JBQ0tTUEFDRSwg UGxhdGZvcm06OktleWJvYXJkRXZlbnQ6OktleURvd24sIDApLCBmYWxzZSAvKiBjaGFuZ2VJc1Bh cnRPZkNvbXBvc2l0aW9uICovKTsKIH0KIAogdm9pZCBJbnB1dEhhbmRsZXI6Omluc2VydFRleHQo Y29uc3QgV1RGOjpTdHJpbmcmIHN0cmluZykKQEAgLTE5NDcsNyArMTk0NywxMiBAQCBib29sIElu cHV0SGFuZGxlcjo6ZGVsZXRlVGV4dFJlbGF0aXZlVG9DdXJzb3IoaW50IGxlZnRPZmZzZXQsIGlu dCByaWdodE9mZnNldCkKICAgICBpbnQgY2FyZXRPZmZzZXQgPSBjYXJldFBvc2l0aW9uKCk7CiAg ICAgaW50IHN0YXJ0ID0gcmVsYXRpdmVMZWZ0T2Zmc2V0KGNhcmV0T2Zmc2V0LCBsZWZ0T2Zmc2V0 KTsKICAgICBpbnQgZW5kID0gcmVsYXRpdmVSaWdodE9mZnNldChjYXJldE9mZnNldCwgZWxlbWVu dFRleHQoKS5sZW5ndGgoKSwgcmlnaHRPZmZzZXQpOwotICAgIGlmICghZGVsZXRlVGV4dChzdGFy dCwgZW5kKSkKKworICAgIC8vIElmIHdlIGhhdmUgYmFja3NwYWNlIGluIGEgc2luZ2xlIGNoYXJh Y3Rlciwgc2VuZCB0aGlzIHRvIHdlYmtpdCBhcyBhIEtleWJvYXJkRXZlbnQuIE90aGVyd2lzZSwg Y2FsbCBkZWxldGVUZXh0LgorICAgIGlmIChsZWZ0T2Zmc2V0ID09IDEgJiYgIXJpZ2h0T2Zmc2V0 KSB7CisgICAgICAgIGlmICghaGFuZGxlS2V5Ym9hcmRJbnB1dChQbGF0Zm9ybTo6S2V5Ym9hcmRF dmVudChLRVlDT0RFX0JBQ0tTUEFDRSwgUGxhdGZvcm06OktleWJvYXJkRXZlbnQ6OktleURvd24s IDApLCB0cnVlIC8qIGNoYW5nZUlzUGFydE9mQ29tcG9zaXRpb24gKi8pKQorICAgICAgICAgICAg cmV0dXJuIGZhbHNlOworICAgIH0gZWxzZSBpZiAoIWRlbGV0ZVRleHQoc3RhcnQsIGVuZCkpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIFNjcm9sbCB0aGUgZmllbGQgaWYgbmVjZXNz YXJ5LiBUaGUgYXV0b21hdGljIHVwZGF0ZSBpcyBzdXBwcmVzc2VkCkBAIC0xOTY0LDYgKzE5Njks OSBAQCBib29sIElucHV0SGFuZGxlcjo6ZGVsZXRlVGV4dChpbnQgc3RhcnQsIGludCBlbmQpCiAK ICAgICBQcm9jZXNzaW5nQ2hhbmdlR3VhcmQgZ3VhcmQodGhpcyk7CiAKKyAgICBpZiAoZW5kIC0g c3RhcnQgPT0gMSkKKyAgICAgICAgcmV0dXJuIGhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06 OktleWJvYXJkRXZlbnQoS0VZQ09ERV9CQUNLU1BBQ0UsIFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50 OjpLZXlEb3duLCAwKSwgdHJ1ZSAvKiBjaGFuZ2VJc1BhcnRPZkNvbXBvc2l0aW9uICovKTsKKwog ICAgIGlmICghc2V0U2VsZWN0aW9uKHN0YXJ0LCBlbmQsIHRydWUgLypjaGFuZ2VJc1BhcnRPZkNv bXBvc2l0aW9uKi8pKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTIyMzYsNyArMjI0NCw3 IEBAIGJvb2wgSW5wdXRIYW5kbGVyOjpzZXRUZXh0KHNwYW5uYWJsZV9zdHJpbmdfdCogc3Bhbm5h YmxlU3RyaW5nKQogCiAgICAgICAgIGlmIChjb21wb3NpbmdUZXh0TGVuZ3RoIC0gdGV4dExlbmd0 aCA9PSAxKSB7CiAgICAgICAgICAgICBJbnB1dExvZyhMb2dMZXZlbEluZm8sICJJbnB1dEhhbmRs ZXI6OnNldFRleHQgTm8gc3BhbnMgaGF2ZSBjaGFuZ2VkLiBOZXcgdGV4dCBpcyBvbmUgY2hhcmFj dGVyIHNob3J0ZXIgdGhhbiB0aGUgb2xkLiBUcmVhdGluZyBhcyAnZGVsZXRlJy4iKTsKLSAgICAg ICAgICAgIHJldHVybiBlZGl0b3ItPmNvbW1hbmQoIkRlbGV0ZUJhY2t3YXJkIikuZXhlY3V0ZSgp OworICAgICAgICAgICAgcmV0dXJuIGhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06OktleWJv YXJkRXZlbnQoS0VZQ09ERV9CQUNLU1BBQ0UsIFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50OjpLZXlE b3duLCAwKSwgdHJ1ZSAvKiBjaGFuZ2VJc1BhcnRPZkNvbXBvc2l0aW9uICovKTsKICAgICAgICAg fQogICAgIH0KIApAQCAtMjI0Niw3ICsyMjU0LDcgQEAgYm9vbCBJbnB1dEhhbmRsZXI6OnNldFRl eHQoc3Bhbm5hYmxlX3N0cmluZ190KiBzcGFubmFibGVTdHJpbmcpCiAgICAgLy8gSWYgdGhlcmUg aXMgbm8gdGV4dCB0byBhZGQganVzdCBkZWxldGUuCiAgICAgaWYgKCF0ZXh0TGVuZ3RoKSB7CiAg ICAgICAgIGlmIChzZWxlY3Rpb25BY3RpdmUoKSkKLSAgICAgICAgICAgIHJldHVybiBlZGl0b3It PmNvbW1hbmQoIkRlbGV0ZUJhY2t3YXJkIikuZXhlY3V0ZSgpOworICAgICAgICAgICAgcmV0dXJu IGhhbmRsZUtleWJvYXJkSW5wdXQoUGxhdGZvcm06OktleWJvYXJkRXZlbnQoS0VZQ09ERV9CQUNL U1BBQ0UsIFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50OjpLZXlDaGFyLCAwKSwgdHJ1ZSAvKiBjaGFu Z2VJc1BhcnRPZkNvbXBvc2l0aW9uICovKTsKIAogICAgICAgICAvLyBOb3RoaW5nIHRvIGRvLgog ICAgICAgICByZXR1cm4gdHJ1ZTsK