101655 2012-11-08 15:23:43 -0800 [BlackBerry] Adding a sound to touch events on anchor elements 2012-11-09 14:34:07 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 762241 0 otcheung 2012-11-08 15:23:43 -0800 Adding an input click to touch events on anchor elements 762255 1 173138 otcheung 2012-11-08 15:42:19 -0800 Created attachment 173138 Patch 762412 2 173138 tonikitoo 2012-11-08 18:35:32 -0800 Comment on attachment 173138 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173138&action=review why instead of the client calling this Api, why not make TouchEventHandler to do it on single touch/mouse up? > Source/WebKit/blackberry/Api/WebPage.h:159 > + void playSoundOnAnchorElementTouchEvents(); bad naming imo something around "play sound if anchor is the target" would read better > Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:187 > +void TouchEventHandler::playSoundOnAnchorElementTouchEvents() const? 763059 3 173138 otcheung 2012-11-09 09:00:03 -0800 Comment on attachment 173138 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173138&action=review Hi Antonio! We tried playing the audio when we receive a mouseup event, but the problem is the delay we get from the timer in recognizing tap sequence is preventing instant feedback. That's why we need to trigger the sound manually when we get a valid click event in libwebview. >> Source/WebKit/blackberry/Api/WebPage.h:159 >> + void playSoundOnAnchorElementTouchEvents(); > > bad naming imo > > something around "play sound if anchor is the target" would read better agreed. playSoundIfAnchorIsTarget sounds better 763080 4 173325 otcheung 2012-11-09 09:18:29 -0800 Created attachment 173325 Patch 763169 5 tonikitoo 2012-11-09 11:03:17 -0800 (In reply to comment #3) > (From update of attachment 173138 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173138&action=review > > Hi Antonio! We tried playing the audio when we receive a mouseup event, but the problem is the delay we get from the timer in recognizing tap sequence is preventing instant feedback. That's why we need to trigger the sound manually when we get a valid click event in libwebview. Fair reason. 763172 6 173325 tonikitoo 2012-11-09 11:03:57 -0800 Comment on attachment 173325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173325&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:4168 > +void WebPage::playSoundIfAnchorIsTarget() const here too, please. 763179 7 173339 otcheung 2012-11-09 11:14:50 -0800 Created attachment 173339 Patch 763296 8 173339 webkit.review.bot 2012-11-09 14:03:59 -0800 Comment on attachment 173339 Patch Rejecting attachment 173339 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 'Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 Updating OpenSource From http://git.chromium.org/external/Webkit + 9031965...c362e10 master -> origin/master (forced update) Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 134105 = 9031965ca29f13cb1f737dc551fab02709cd71a8 last_rev is higher!: 134105 >= 134102 at /usr/lib/git-core/git-svn line 1523 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14788267 763303 9 173339 rwlbuis 2012-11-09 14:09:56 -0800 Comment on attachment 173339 Patch Retrying 763332 10 173339 webkit.review.bot 2012-11-09 14:34:04 -0800 Comment on attachment 173339 Patch Clearing flags on attachment: 173339 Committed r134117: <http://trac.webkit.org/changeset/134117> 763333 11 webkit.review.bot 2012-11-09 14:34:07 -0800 All reviewed patches have been landed. Closing bug. 173138 2012-11-08 15:42:19 -0800 2012-11-09 09:18:23 -0800 Patch bug-101655-20121108184028.patch text/plain 4307 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmMzZhNzg1NTNlMDM3MTI3OTg4OTc4NTk2ZjA3ZTg2OWViMWZiYTNjLi5lNjk1YmNlMzFi ZTlmNjJjZmM3NjRiYjg5ZTFlNDcyNTI0NTgxNjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMS0wOCAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBZGRpbmcgYSBzb3VuZCB0 byB0b3VjaCBldmVudHMgb24gYW5jaG9yIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2NTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgYXVkaW8gZmVlZGJhY2sgdG8gdG91Y2hl dmVudHMgb24gaHRtbCBhbmNob3IgZWxlbWVudHMuCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OnBsYXlTb3VuZE9uQW5j aG9yRWxlbWVudFRvdWNoRXZlbnRzKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogQXBp L1dlYlBhZ2UuaDoKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNw cDoKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlRvdWNo RXZlbnRIYW5kbGVyOjpwbGF5U291bmRPbkFuY2hvckVsZW1lbnRUb3VjaEV2ZW50cyk6CisgICAg ICAgICogV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5oOgorICAgICAgICAoVG91Y2hF dmVudEhhbmRsZXIpOgorCiAyMDEyLTExLTA2ICBPdHRvIERlcmVrIENoZXVuZyAgPG90Y2hldW5n QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZGluZyB3aW5kb3cuZXh0ZXJuYWwg dG8gb3VyIHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4 IGMwODcyNWZkMjE1MGE3NmNkOTJkYzc1NWY0ZjE3NTViY2JiODRhZjYuLmFiNWE3ODEzMzJjOTcw N2IxZDBhNGI2YjNiOTIxNWRiZTdkNjhjMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlLmNwcApAQCAtNDE2NSw2ICs0MTY1LDExIEBAIGJvb2wgV2ViUGFnZTo6dG91Y2hQ b2ludEFzTW91c2VFdmVudChjb25zdCBQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQsIGJvb2wg dXNlCiAgICAgcmV0dXJuIGQtPm1fdG91Y2hFdmVudEhhbmRsZXItPmhhbmRsZVRvdWNoUG9pbnQo dFBvaW50LCB1c2VGYXRGaW5nZXJzKTsKIH0KIAordm9pZCBXZWJQYWdlOjpwbGF5U291bmRPbkFu Y2hvckVsZW1lbnRUb3VjaEV2ZW50cygpCit7CisgICAgZC0+bV90b3VjaEV2ZW50SGFuZGxlci0+ cGxheVNvdW5kT25BbmNob3JFbGVtZW50VG91Y2hFdmVudHMoKTsKK30KKwogYm9vbCBXZWJQYWdl UHJpdmF0ZTo6ZGlzcGF0Y2hUb3VjaFBvaW50QXNNb3VzZUV2ZW50VG9GdWxsU2NyZWVuUGx1Z2lu KFBsdWdpblZpZXcqIHBsdWdpblZpZXcsIGNvbnN0IFBsYXRmb3JtOjpUb3VjaFBvaW50JiBwb2lu dCkKIHsKICAgICBOUEV2ZW50IG5wRXZlbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5oCmluZGV4IGFlNTlkOGY3YTVlOTkxYWZlNzJmNTM5MTEzZjI4OGYyZjQxNjg3NmMuLmEx MmQxYmViNDAwZDY0NWMxMjY5MWZkOGU0MTJlYzMwMmE3ZWU2MTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5oCkBAIC0xNTYsNiArMTU2LDggQEAgcHVibGljOgogICAgIHZv aWQgdG91Y2hFdmVudENhbmNlbCgpOwogICAgIGJvb2wgdG91Y2hQb2ludEFzTW91c2VFdmVudChj b25zdCBQbGF0Zm9ybTo6VG91Y2hQb2ludCYsIGJvb2wgdXNlRmF0RmluZ2VycyA9IHRydWUpOwog CisgICAgdm9pZCBwbGF5U291bmRPbkFuY2hvckVsZW1lbnRUb3VjaEV2ZW50cygpOworCiAgICAg Ly8gUmV0dXJucyB0cnVlIGlmIHRoZSBrZXkgc3Ryb2tlIHdhcyBoYW5kbGVkIGJ5IFdlYktpdC4K ICAgICBib29sIGtleUV2ZW50KGNvbnN0IFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50Jik7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZl bnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1Rv dWNoRXZlbnRIYW5kbGVyLmNwcAppbmRleCBhY2U3NmYxMmQxMTlkM2MxMGY4ODczNjU1YmZjN2I4 OGMwMDc0OTBiLi5mNGQwOGY0MGRjNWJkNTE1YzBjOWZjNTc0ZGUzNzRmZjZhNTMxMWVmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50 SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv VG91Y2hFdmVudEhhbmRsZXIuY3BwCkBAIC0xOSw2ICsxOSw3IEBACiAjaW5jbHVkZSAiY29uZmln LmgiCiAjaW5jbHVkZSAiVG91Y2hFdmVudEhhbmRsZXIuaCIKIAorI2luY2x1ZGUgIkJsYWNrQmVy cnlQbGF0Zm9ybVN5c3RlbVNvdW5kLmgiCiAjaW5jbHVkZSAiRE9NU3VwcG9ydC5oIgogI2luY2x1 ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiRG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmgiCkBA IC0xODIsNiArMTgzLDEzIEBAIHN0YXRpYyBib29sIGlzTWFpbkZyYW1lU2Nyb2xsYWJsZShjb25z dCBXZWJQYWdlUHJpdmF0ZSogcGFnZSkKICAgICByZXR1cm4gcGFnZS0+dmlld3BvcnRTaXplKCku d2lkdGgoKSA8IHBhZ2UtPmNvbnRlbnRzU2l6ZSgpLndpZHRoKCkgfHwgcGFnZS0+dmlld3BvcnRT aXplKCkuaGVpZ2h0KCkgPCBwYWdlLT5jb250ZW50c1NpemUoKS5oZWlnaHQoKTsKIH0KIAorCit2 b2lkIFRvdWNoRXZlbnRIYW5kbGVyOjpwbGF5U291bmRPbkFuY2hvckVsZW1lbnRUb3VjaEV2ZW50 cygpCit7CisgICAgaWYgKG1fbGFzdEZhdEZpbmdlcnNSZXN1bHQubm9kZSgpICYmIG1fbGFzdEZh dEZpbmdlcnNSZXN1bHQubm9kZSgpLT5pc0xpbmsoKSkKKyAgICAgICAgQmxhY2tCZXJyeTo6UGxh dGZvcm06OlN5c3RlbVNvdW5kOjppbnN0YW5jZSgpLT5wbGF5U291bmQoQmxhY2tCZXJyeTo6UGxh dGZvcm06OlN5c3RlbVNvdW5kVHlwZTo6SW5wdXRLZXlwcmVzcyk7Cit9CisKIGJvb2wgVG91Y2hF dmVudEhhbmRsZXI6OmhhbmRsZVRvdWNoUG9pbnQoUGxhdGZvcm06OlRvdWNoUG9pbnQmIHBvaW50 LCBib29sIHVzZUZhdEZpbmdlcnMpCiB7CiAgICAgLy8gRW5hYmxlIGlucHV0IG1vZGUgb24gYW55 IHRvdWNoIGV2ZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvVG91Y2hFdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmgKaW5kZXggYmNlMTg3ZGZhOWQ1YzU4YWIz ZWU5YTYzM2I3ZjVlNTQ5ZTFjMGM0OS4uODIzZDk5YjM0MmNlYjY1M2NiMzc5YmIwZmYyMjI1MzBi OWYwOTM2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvVG91Y2hFdmVudEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5oCkBAIC0zOSw2ICszOSw4IEBAIHB1YmxpYzoK ICAgICB2b2lkIHRvdWNoRXZlbnRDYW5jZWwoKTsKICAgICB2b2lkIHRvdWNoSG9sZEV2ZW50KCk7 CiAKKyAgICB2b2lkIHBsYXlTb3VuZE9uQW5jaG9yRWxlbWVudFRvdWNoRXZlbnRzKCk7CisKICAg ICBib29sIHNob3VsZFN1cHByZXNzTW91c2VEb3duT25Ub3VjaERvd24oKSBjb25zdDsKIAogICAg IGNvbnN0IEZhdEZpbmdlcnNSZXN1bHQmIGxhc3RGYXRGaW5nZXJzUmVzdWx0KCkgY29uc3QgeyBy ZXR1cm4gbV9sYXN0RmF0RmluZ2Vyc1Jlc3VsdDsgfQo= 173325 2012-11-09 09:18:29 -0800 2012-11-09 11:14:46 -0800 Patch bug-101655-20121109121636.patch text/plain 4443 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmMzZhNzg1NTNlMDM3MTI3OTg4OTc4NTk2ZjA3ZTg2OWViMWZiYTNjLi5mOTA0ZmMzMmRk ZGQwZjc2MjA1MjZiNDczOGJkYzlkMWNjMDhlYWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0xMS0wOSAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBZGRpbmcgYSBzb3VuZCB0 byB0b3VjaCBldmVudHMgb24gYW5jaG9yIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2NTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgYXVkaW8gZmVlZGJhY2sgdG8gdG91Y2hl dmVudHMgb24gaHRtbCBhbmNob3IgZWxlbWVudHMuCisKKyAgICAgICAgVGhlIGZlZWRiYWNrIGlz IGNhbGxlZCBkaXJlY3RseSBmcm9tIGNsaWVudCBpbnN0ZWFkIG9mIHVzaW5nIHRoZQorICAgICAg ICBtb3VzZXVwIGV2ZW50IHRvIGF2b2lkIHRoZSBkZWxheSBiZXR3ZWVuIHRvdWNoIHN0YXJ0IGFu ZCBlbmQgY2F1c2VkCisgICAgICAgIGJ5IHRoZSB0YXAgc2VxdWVuY2UgcmVjb2duaXplci4KKwor ICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 V2ViUGFnZTo6cGxheVNvdW5kSWZBbmNob3JJc1RhcmdldCk6CisgICAgICAgIChXZWJLaXQpOgor ICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9Ub3VjaEV2 ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpUb3VjaEV2ZW50SGFuZGxlcjo6cGxheVNvdW5kSWZBbmNob3JJc1RhcmdldCk6Cisg ICAgICAgICogV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5oOgorICAgICAgICAoVG91 Y2hFdmVudEhhbmRsZXIpOgorCiAyMDEyLTExLTA2ICBPdHRvIERlcmVrIENoZXVuZyAgPG90Y2hl dW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZGluZyB3aW5kb3cuZXh0ZXJu YWwgdG8gb3VyIHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmlu ZGV4IGMwODcyNWZkMjE1MGE3NmNkOTJkYzc1NWY0ZjE3NTViY2JiODRhZjYuLjRlYmVhZjlmZTAw ODFhNjU3NDMyMmRjYzUxNGVhY2I0YjgzMTg0Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcApAQCAtNDE2NSw2ICs0MTY1LDExIEBAIGJvb2wgV2ViUGFnZTo6dG91 Y2hQb2ludEFzTW91c2VFdmVudChjb25zdCBQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQsIGJv b2wgdXNlCiAgICAgcmV0dXJuIGQtPm1fdG91Y2hFdmVudEhhbmRsZXItPmhhbmRsZVRvdWNoUG9p bnQodFBvaW50LCB1c2VGYXRGaW5nZXJzKTsKIH0KIAordm9pZCBXZWJQYWdlOjpwbGF5U291bmRJ ZkFuY2hvcklzVGFyZ2V0KCkKK3sKKyAgICBkLT5tX3RvdWNoRXZlbnRIYW5kbGVyLT5wbGF5U291 bmRJZkFuY2hvcklzVGFyZ2V0KCk7Cit9CisKIGJvb2wgV2ViUGFnZVByaXZhdGU6OmRpc3BhdGNo VG91Y2hQb2ludEFzTW91c2VFdmVudFRvRnVsbFNjcmVlblBsdWdpbihQbHVnaW5WaWV3KiBwbHVn aW5WaWV3LCBjb25zdCBQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQpCiB7CiAgICAgTlBFdmVu dCBucEV2ZW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuaAppbmRleCBhZTU5 ZDhmN2E1ZTk5MWFmZTcyZjUzOTExM2YyODhmMmY0MTY4NzZjLi5jYWQ0YmVjNjhhNGE2ZWZmYjdm ODZlMTk4NTNhYTYwZjg5MDc1YjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBh Z2UuaApAQCAtMTU2LDYgKzE1Niw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHRvdWNoRXZlbnRDYW5j ZWwoKTsKICAgICBib29sIHRvdWNoUG9pbnRBc01vdXNlRXZlbnQoY29uc3QgUGxhdGZvcm06OlRv dWNoUG9pbnQmLCBib29sIHVzZUZhdEZpbmdlcnMgPSB0cnVlKTsKIAorICAgIHZvaWQgcGxheVNv dW5kSWZBbmNob3JJc1RhcmdldCgpOworCiAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHRoZSBrZXkg c3Ryb2tlIHdhcyBoYW5kbGVkIGJ5IFdlYktpdC4KICAgICBib29sIGtleUV2ZW50KGNvbnN0IFBs YXRmb3JtOjpLZXlib2FyZEV2ZW50Jik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcAppbmRleCBh Y2U3NmYxMmQxMTlkM2MxMGY4ODczNjU1YmZjN2I4OGMwMDc0OTBiLi4yMTU4MzQwYzBhY2MwOTJl M2U3YmMwZDQ4NDM0ZTlkYjg2MzY3ZWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvVG91Y2hFdmVudEhhbmRsZXIuY3BwCkBAIC0x OSw2ICsxOSw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiVG91Y2hFdmVudEhh bmRsZXIuaCIKIAorI2luY2x1ZGUgIkJsYWNrQmVycnlQbGF0Zm9ybVN5c3RlbVNvdW5kLmgiCiAj aW5jbHVkZSAiRE9NU3VwcG9ydC5oIgogI2luY2x1ZGUgIkRvY3VtZW50LmgiCiAjaW5jbHVkZSAi RG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmgiCkBAIC0xODIsNiArMTgzLDEzIEBAIHN0YXRpYyBi b29sIGlzTWFpbkZyYW1lU2Nyb2xsYWJsZShjb25zdCBXZWJQYWdlUHJpdmF0ZSogcGFnZSkKICAg ICByZXR1cm4gcGFnZS0+dmlld3BvcnRTaXplKCkud2lkdGgoKSA8IHBhZ2UtPmNvbnRlbnRzU2l6 ZSgpLndpZHRoKCkgfHwgcGFnZS0+dmlld3BvcnRTaXplKCkuaGVpZ2h0KCkgPCBwYWdlLT5jb250 ZW50c1NpemUoKS5oZWlnaHQoKTsKIH0KIAorCit2b2lkIFRvdWNoRXZlbnRIYW5kbGVyOjpwbGF5 U291bmRJZkFuY2hvcklzVGFyZ2V0KCkgY29uc3QKK3sKKyAgICBpZiAobV9sYXN0RmF0RmluZ2Vy c1Jlc3VsdC5ub2RlKCkgJiYgbV9sYXN0RmF0RmluZ2Vyc1Jlc3VsdC5ub2RlKCktPmlzTGluaygp KQorICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3lzdGVtU291bmQ6Omluc3RhbmNlKCkt PnBsYXlTb3VuZChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3lzdGVtU291bmRUeXBlOjpJbnB1dEtl eXByZXNzKTsKK30KKwogYm9vbCBUb3VjaEV2ZW50SGFuZGxlcjo6aGFuZGxlVG91Y2hQb2ludChQ bGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQsIGJvb2wgdXNlRmF0RmluZ2VycykKIHsKICAgICAv LyBFbmFibGUgaW5wdXQgbW9kZSBvbiBhbnkgdG91Y2ggZXZlbnQuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5oIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvVG91Y2hFdmVudEhhbmRsZXIu aAppbmRleCBiY2UxODdkZmE5ZDVjNThhYjNlZTlhNjMzYjdmNWU1NDllMWMwYzQ5Li5hNzg4ODFm MTJjNTcxYTcyMjU2NDY5MjRkZGIwYzc2ZDU2ZWNlMzY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmgK QEAgLTM5LDYgKzM5LDggQEAgcHVibGljOgogICAgIHZvaWQgdG91Y2hFdmVudENhbmNlbCgpOwog ICAgIHZvaWQgdG91Y2hIb2xkRXZlbnQoKTsKIAorICAgIHZvaWQgcGxheVNvdW5kSWZBbmNob3JJ c1RhcmdldCgpIGNvbnN0OworCiAgICAgYm9vbCBzaG91bGRTdXBwcmVzc01vdXNlRG93bk9uVG91 Y2hEb3duKCkgY29uc3Q7CiAKICAgICBjb25zdCBGYXRGaW5nZXJzUmVzdWx0JiBsYXN0RmF0Rmlu Z2Vyc1Jlc3VsdCgpIGNvbnN0IHsgcmV0dXJuIG1fbGFzdEZhdEZpbmdlcnNSZXN1bHQ7IH0K 173339 2012-11-09 11:14:50 -0800 2012-11-09 14:34:03 -0800 Patch bug-101655-20121109141257.patch text/plain 4455 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmMzZhNzg1NTNlMDM3MTI3OTg4OTc4NTk2ZjA3ZTg2OWViMWZiYTNjLi5mOTA0ZmMzMmRk ZGQwZjc2MjA1MjZiNDczOGJkYzlkMWNjMDhlYWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0xMS0wOSAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBZGRpbmcgYSBzb3VuZCB0 byB0b3VjaCBldmVudHMgb24gYW5jaG9yIGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2NTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgYXVkaW8gZmVlZGJhY2sgdG8gdG91Y2hl dmVudHMgb24gaHRtbCBhbmNob3IgZWxlbWVudHMuCisKKyAgICAgICAgVGhlIGZlZWRiYWNrIGlz IGNhbGxlZCBkaXJlY3RseSBmcm9tIGNsaWVudCBpbnN0ZWFkIG9mIHVzaW5nIHRoZQorICAgICAg ICBtb3VzZXVwIGV2ZW50IHRvIGF2b2lkIHRoZSBkZWxheSBiZXR3ZWVuIHRvdWNoIHN0YXJ0IGFu ZCBlbmQgY2F1c2VkCisgICAgICAgIGJ5IHRoZSB0YXAgc2VxdWVuY2UgcmVjb2duaXplci4KKwor ICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 V2ViUGFnZTo6cGxheVNvdW5kSWZBbmNob3JJc1RhcmdldCk6CisgICAgICAgIChXZWJLaXQpOgor ICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisgICAgICAgICogV2ViS2l0U3VwcG9ydC9Ub3VjaEV2 ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpUb3VjaEV2ZW50SGFuZGxlcjo6cGxheVNvdW5kSWZBbmNob3JJc1RhcmdldCk6Cisg ICAgICAgICogV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5oOgorICAgICAgICAoVG91 Y2hFdmVudEhhbmRsZXIpOgorCiAyMDEyLTExLTA2ICBPdHRvIERlcmVrIENoZXVuZyAgPG90Y2hl dW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZGluZyB3aW5kb3cuZXh0ZXJu YWwgdG8gb3VyIHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmlu ZGV4IGMwODcyNWZkMjE1MGE3NmNkOTJkYzc1NWY0ZjE3NTViY2JiODRhZjYuLjc2N2NkZDU2M2Vk MzlhNTlkOGE1MmJlYjM0NjljZjAyZGFlYTc2NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcApAQCAtNDE2NSw2ICs0MTY1LDExIEBAIGJvb2wgV2ViUGFnZTo6dG91 Y2hQb2ludEFzTW91c2VFdmVudChjb25zdCBQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQsIGJv b2wgdXNlCiAgICAgcmV0dXJuIGQtPm1fdG91Y2hFdmVudEhhbmRsZXItPmhhbmRsZVRvdWNoUG9p bnQodFBvaW50LCB1c2VGYXRGaW5nZXJzKTsKIH0KIAordm9pZCBXZWJQYWdlOjpwbGF5U291bmRJ ZkFuY2hvcklzVGFyZ2V0KCkgY29uc3QKK3sKKyAgICBkLT5tX3RvdWNoRXZlbnRIYW5kbGVyLT5w bGF5U291bmRJZkFuY2hvcklzVGFyZ2V0KCk7Cit9CisKIGJvb2wgV2ViUGFnZVByaXZhdGU6OmRp c3BhdGNoVG91Y2hQb2ludEFzTW91c2VFdmVudFRvRnVsbFNjcmVlblBsdWdpbihQbHVnaW5WaWV3 KiBwbHVnaW5WaWV3LCBjb25zdCBQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQpCiB7CiAgICAg TlBFdmVudCBucEV2ZW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuaAppbmRl eCBhZTU5ZDhmN2E1ZTk5MWFmZTcyZjUzOTExM2YyODhmMmY0MTY4NzZjLi5lZTc1YzBkYTJmMTAy ZjgzNzUzZWNkOWM3YTkyMTE1MGI1ZGM2MzExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L1dlYlBhZ2UuaApAQCAtMTU2LDYgKzE1Niw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHRvdWNoRXZl bnRDYW5jZWwoKTsKICAgICBib29sIHRvdWNoUG9pbnRBc01vdXNlRXZlbnQoY29uc3QgUGxhdGZv cm06OlRvdWNoUG9pbnQmLCBib29sIHVzZUZhdEZpbmdlcnMgPSB0cnVlKTsKIAorICAgIHZvaWQg cGxheVNvdW5kSWZBbmNob3JJc1RhcmdldCgpIGNvbnN0OworCiAgICAgLy8gUmV0dXJucyB0cnVl IGlmIHRoZSBrZXkgc3Ryb2tlIHdhcyBoYW5kbGVkIGJ5IFdlYktpdC4KICAgICBib29sIGtleUV2 ZW50KGNvbnN0IFBsYXRmb3JtOjpLZXlib2FyZEV2ZW50Jik7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVy LmNwcAppbmRleCBhY2U3NmYxMmQxMTlkM2MxMGY4ODczNjU1YmZjN2I4OGMwMDc0OTBiLi4yMTU4 MzQwYzBhY2MwOTJlM2U3YmMwZDQ4NDM0ZTlkYjg2MzY3ZWUxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxlci5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvVG91Y2hFdmVudEhhbmRs ZXIuY3BwCkBAIC0xOSw2ICsxOSw3IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAi VG91Y2hFdmVudEhhbmRsZXIuaCIKIAorI2luY2x1ZGUgIkJsYWNrQmVycnlQbGF0Zm9ybVN5c3Rl bVNvdW5kLmgiCiAjaW5jbHVkZSAiRE9NU3VwcG9ydC5oIgogI2luY2x1ZGUgIkRvY3VtZW50Lmgi CiAjaW5jbHVkZSAiRG9jdW1lbnRNYXJrZXJDb250cm9sbGVyLmgiCkBAIC0xODIsNiArMTgzLDEz IEBAIHN0YXRpYyBib29sIGlzTWFpbkZyYW1lU2Nyb2xsYWJsZShjb25zdCBXZWJQYWdlUHJpdmF0 ZSogcGFnZSkKICAgICByZXR1cm4gcGFnZS0+dmlld3BvcnRTaXplKCkud2lkdGgoKSA8IHBhZ2Ut PmNvbnRlbnRzU2l6ZSgpLndpZHRoKCkgfHwgcGFnZS0+dmlld3BvcnRTaXplKCkuaGVpZ2h0KCkg PCBwYWdlLT5jb250ZW50c1NpemUoKS5oZWlnaHQoKTsKIH0KIAorCit2b2lkIFRvdWNoRXZlbnRI YW5kbGVyOjpwbGF5U291bmRJZkFuY2hvcklzVGFyZ2V0KCkgY29uc3QKK3sKKyAgICBpZiAobV9s YXN0RmF0RmluZ2Vyc1Jlc3VsdC5ub2RlKCkgJiYgbV9sYXN0RmF0RmluZ2Vyc1Jlc3VsdC5ub2Rl KCktPmlzTGluaygpKQorICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3lzdGVtU291bmQ6 Omluc3RhbmNlKCktPnBsYXlTb3VuZChCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3lzdGVtU291bmRU eXBlOjpJbnB1dEtleXByZXNzKTsKK30KKwogYm9vbCBUb3VjaEV2ZW50SGFuZGxlcjo6aGFuZGxl VG91Y2hQb2ludChQbGF0Zm9ybTo6VG91Y2hQb2ludCYgcG9pbnQsIGJvb2wgdXNlRmF0RmluZ2Vy cykKIHsKICAgICAvLyBFbmFibGUgaW5wdXQgbW9kZSBvbiBhbnkgdG91Y2ggZXZlbnQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50 SGFuZGxlci5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvVG91Y2hF dmVudEhhbmRsZXIuaAppbmRleCBiY2UxODdkZmE5ZDVjNThhYjNlZTlhNjMzYjdmNWU1NDllMWMw YzQ5Li5hNzg4ODFmMTJjNTcxYTcyMjU2NDY5MjRkZGIwYzc2ZDU2ZWNlMzY5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50SGFuZGxl ci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZl bnRIYW5kbGVyLmgKQEAgLTM5LDYgKzM5LDggQEAgcHVibGljOgogICAgIHZvaWQgdG91Y2hFdmVu dENhbmNlbCgpOwogICAgIHZvaWQgdG91Y2hIb2xkRXZlbnQoKTsKIAorICAgIHZvaWQgcGxheVNv dW5kSWZBbmNob3JJc1RhcmdldCgpIGNvbnN0OworCiAgICAgYm9vbCBzaG91bGRTdXBwcmVzc01v dXNlRG93bk9uVG91Y2hEb3duKCkgY29uc3Q7CiAKICAgICBjb25zdCBGYXRGaW5nZXJzUmVzdWx0 JiBsYXN0RmF0RmluZ2Vyc1Jlc3VsdCgpIGNvbnN0IHsgcmV0dXJuIG1fbGFzdEZhdEZpbmdlcnNS ZXN1bHQ7IH0K