101652 2012-11-08 15:11:52 -0800 [BlackBerry] Replace checkerboard with page background color 2012-11-08 17:25:51 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 762226 0 jpetsovits 2012-11-08 15:11:52 -0800 Seems the trend is to go to solid color instead of a more distinguishable checkerboard pattern. It was decided that we should follow suit. In order to do this, here's a new member variable for BackingStore because when blitting, we can't access the page background color in a threadsafe way. Solid background color fill is still only used for public builds. Developers and beta testers should still see checkerboard and do something about it. Also tracked as RIM PR 188235. Patch below. 762233 1 173132 jpetsovits 2012-11-08 15:16:57 -0800 Created attachment 173132 Patch 762361 2 173132 webkit.review.bot 2012-11-08 17:25:48 -0800 Comment on attachment 173132 Patch Clearing flags on attachment: 173132 Committed r133979: <http://trac.webkit.org/changeset/133979> 762362 3 webkit.review.bot 2012-11-08 17:25:51 -0800 All reviewed patches have been landed. Closing bug. 173132 2012-11-08 15:16:57 -0800 2012-11-08 17:25:47 -0800 Patch bug-101652-20121108181458.patch text/plain 6961 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBmZTdjNmMxNDhkYjIxZmZmMGI5YzVhZjE0NjUzN2JiYzNjOGUyZGY1Li42ZTgyMjkyMGJk NmFkZmU2YTQwZjZmNjY3YTIzYzQ1NDFiMDAyOWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMi0xMS0wOCAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZXBsYWNlIGNoZWNrZXJi b2FyZCB3aXRoIHBhZ2UgYmFja2dyb3VuZCBjb2xvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTY1MgorICAgICAgICBSSU0gUFIgMTg4MjM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gb3JkZXIg dG8gZG8gdGhpcywgd2UgaW50cm9kdWNlIGEgbmV3IG1lbWJlciB2YXJpYWJsZSBmb3IKKyAgICAg ICAgQmFja2luZ1N0b3JlIGJlY2F1c2Ugd2hlbiBibGl0dGluZywgd2UgY2FuJ3QgYWNjZXNzIHRo ZQorICAgICAgICBwYWdlIGJhY2tncm91bmQgY29sb3IgaW4gYSB0aHJlYWRzYWZlIHdheS4KKwor ICAgICAgICBTb2xpZCBiYWNrZ3JvdW5kIGNvbG9yIGZpbGwgaXMgc3RpbGwgb25seSB1c2VkIGZv ciBwdWJsaWMgYnVpbGRzLgorICAgICAgICBEZXZlbG9wZXJzIGFuZCBiZXRhIHRlc3RlcnMgc2hv dWxkIHN0aWxsIHNlZSBjaGVja2VyYm9hcmQgYW5kCisgICAgICAgIGRvIHNvbWV0aGluZyBhYm91 dCBpdC4KKworICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpCYWNraW5nU3RvcmVQcml2YXRlKToK KyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6ZmlsbFdp bmRvdyk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6 OndlYlBhZ2VCYWNrZ3JvdW5kQ29sb3JVc2VySW50ZXJmYWNlVGhyZWFkKToKKyAgICAgICAgKFdl YktpdCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6 OnNldFdlYlBhZ2VCYWNrZ3JvdW5kQ29sb3IpOgorICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmVf cC5oOgorICAgICAgICAoQmFja2luZ1N0b3JlUHJpdmF0ZSk6CisgICAgICAgICogQXBpL1dlYlBh Z2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6c2V0 TG9hZFN0YXRlKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6 OmRpZENoYW5nZVNldHRpbmdzKToKKwogMjAxMi0xMS0wNyAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBKYW5pdG9yOiBSZW1vdmUg dW51c2VkIG1faXNWYWxpZCBib29sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0Jh Y2tpbmdTdG9yZS5jcHAKaW5kZXggNjFiOTBjYzI0MTVmYTlhZDc3ODYzMmUwODViZmNlODVhZGQ3 MGEzNS4uMGYwNzhmNWUzZDcxZmYzZTNlMzk4ZWFkYzg5MjdmODNkZmZhZTkyZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcApAQCAtMjA2LDYgKzIw Niw3IEBAIEJhY2tpbmdTdG9yZVByaXZhdGU6OkJhY2tpbmdTdG9yZVByaXZhdGUoKQogICAgICwg bV9yZW5kZXJRdWV1ZShhZG9wdFB0cihuZXcgUmVuZGVyUXVldWUodGhpcykpKQogICAgICwgbV9k ZWZlcnNCbGl0KHRydWUpCiAgICAgLCBtX2hhc0JsaXRKb2JzKGZhbHNlKQorICAgICwgbV93ZWJQ YWdlQmFja2dyb3VuZENvbG9yKFdlYkNvcmU6OkNvbG9yOjp3aGl0ZSkKICAgICAsIG1fY3VycmVu dFdpbmRvd0JhY2tCdWZmZXIoMCkKICAgICAsIG1fcHJlZmVycmVkVGlsZU1hdHJpeERpbWVuc2lv bihWZXJ0aWNhbCkKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCkBAIC0yMzY2LDkg KzIzNjcsMzggQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpmaWxsV2luZG93KFBsYXRmb3Jt OjpHcmFwaGljczo6RmlsbFBhdHRlcm4gcGF0dGVybiwKICAgICAgICAgICAgICJFbXB0eSB3aW5k b3cgYnVmZmVyLCBjb3VsZG4ndCBmaWxsV2luZG93Iik7CiAgICAgfQogCisgICAgaWYgKHBhdHRl cm4gPT0gQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpDaGVja2VyYm9hcmRQYXR0ZXJu ICYmIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTZXR0aW5nczo6aXNQdWJsaWNCdWlsZCgpKSB7Cisg ICAgICAgIC8vIEZvciBwdWJsaWMgYnVpbGRzLCBjb252ZXkgdGhlIGltcHJlc3Npb24gb2YgbGVz cyBjaGVja2VyYm9hcmQuCisgICAgICAgIC8vIEZvciBkZXZlbG9wZXIgYnVpbGRzLCBrZWVwIHRo ZSBjaGVja2VyYm9hcmQgdG8gZ2V0IGl0IGZpeGVkIGJldHRlci4KKyAgICAgICAgQmxhY2tCZXJy eTo6UGxhdGZvcm06OkdyYXBoaWNzOjpjbGVhckJ1ZmZlcihkc3RCdWZmZXIsIGRzdFJlY3QsCisg ICAgICAgICAgICBtX3dlYlBhZ2VCYWNrZ3JvdW5kQ29sb3IucmVkKCksIG1fd2ViUGFnZUJhY2tn cm91bmRDb2xvci5ncmVlbigpLAorICAgICAgICAgICAgbV93ZWJQYWdlQmFja2dyb3VuZENvbG9y LmJsdWUoKSwgbV93ZWJQYWdlQmFja2dyb3VuZENvbG9yLmFscGhhKCkpOworICAgICAgICByZXR1 cm47CisgICAgfQorCiAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpmaWxsQnVm ZmVyKGRzdEJ1ZmZlciwgcGF0dGVybiwgZHN0UmVjdCwgY29udGVudHNPcmlnaW4sIGNvbnRlbnRz U2NhbGUpOwogfQogCitXZWJDb3JlOjpDb2xvciBCYWNraW5nU3RvcmVQcml2YXRlOjp3ZWJQYWdl QmFja2dyb3VuZENvbG9yVXNlckludGVyZmFjZVRocmVhZCgpIGNvbnN0Cit7CisgICAgQVNTRVJU KEJsYWNrQmVycnk6OlBsYXRmb3JtOjp1c2VySW50ZXJmYWNlVGhyZWFkTWVzc2FnZUNsaWVudCgp LT5pc0N1cnJlbnRUaHJlYWQoKSk7CisgICAgcmV0dXJuIG1fd2ViUGFnZUJhY2tncm91bmRDb2xv cjsKK30KKwordm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpzZXRXZWJQYWdlQmFja2dyb3VuZENv bG9yKGNvbnN0IFdlYkNvcmU6OkNvbG9yJiBjb2xvcikKK3sKKyAgICBpZiAoIUJsYWNrQmVycnk6 OlBsYXRmb3JtOjp1c2VySW50ZXJmYWNlVGhyZWFkTWVzc2FnZUNsaWVudCgpLT5pc0N1cnJlbnRU aHJlYWQoKSkgeworICAgICAgICB0eXBlZGVmIHZvaWQgKEJsYWNrQmVycnk6OldlYktpdDo6QmFj a2luZ1N0b3JlUHJpdmF0ZTo6KkZ1bmN0aW9uVHlwZSkoY29uc3QgV2ViQ29yZTo6Q29sb3ImKTsK KworICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6dXNlckludGVyZmFjZVRocmVhZE1lc3Nh Z2VDbGllbnQoKS0+ZGlzcGF0Y2hNZXNzYWdlKAorICAgICAgICAgICAgQmxhY2tCZXJyeTo6UGxh dGZvcm06OmNyZWF0ZU1ldGhvZENhbGxNZXNzYWdlPEZ1bmN0aW9uVHlwZSwgQmFja2luZ1N0b3Jl UHJpdmF0ZSwgV2ViQ29yZTo6Q29sb3I+KAorICAgICAgICAgICAgICAgICZCYWNraW5nU3RvcmVQ cml2YXRlOjpzZXRXZWJQYWdlQmFja2dyb3VuZENvbG9yLCB0aGlzLCBjb2xvcikpOworICAgICAg ICByZXR1cm47CisgICAgfQorCisgICAgbV93ZWJQYWdlQmFja2dyb3VuZENvbG9yID0gY29sb3I7 Cit9CisKIHZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6aW52YWxpZGF0ZVdpbmRvdygpCiB7CiAg ICAgLy8gR3JhYiBhIHJlY3QgYXBwcm9wcmlhdGUgZm9yIHRoZSBjdXJyZW50IHRocmVhZC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlX3AuaCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlX3AuaAppbmRleCA4ZTUy YTEyYWVlODU0M2E2N2E0YzExNzQ1MTRlZjMzZmU0ZGU5YTU1Li5kMmZkOTVjYzA5MDExMWU4YTFi NDUwYzUxNDE4N2IxZWU2MTNhODliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL0JhY2tpbmdTdG9yZV9wLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9CYWNraW5nU3RvcmVfcC5oCkBAIC0yMCw2ICsyMCw3IEBACiAjZGVmaW5lIEJhY2tpbmdTdG9y ZV9wX2gKIAogI2luY2x1ZGUgIkJhY2tpbmdTdG9yZS5oIgorI2luY2x1ZGUgIkNvbG9yLmgiCiAj aW5jbHVkZSAiUmVuZGVyUXVldWUuaCIKICNpbmNsdWRlICJUaWxlSW5kZXguaCIKICNpbmNsdWRl ICJUaWxlSW5kZXhIYXNoLmgiCkBAIC0zMTksNiArMzIwLDkgQEAgcHVibGljOgogICAgIHZvaWQg YmxpdFRvV2luZG93KGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0JiBkc3RSZWN0LCBjb25zdCBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OkJ1ZmZlciogc3JjQnVmZmVyLCBjb25zdCBQbGF0 Zm9ybTo6SW50UmVjdCYgc3JjUmVjdCwgYm9vbCBibGVuZCwgdW5zaWduZWQgY2hhciBnbG9iYWxB bHBoYSk7CiAgICAgdm9pZCBmaWxsV2luZG93KFBsYXRmb3JtOjpHcmFwaGljczo6RmlsbFBhdHRl cm4sIGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0JiBkc3RSZWN0LCBjb25zdCBQbGF0Zm9ybTo6SW50 UG9pbnQmIGNvbnRlbnRzT3JpZ2luLCBkb3VibGUgY29udGVudHNTY2FsZSk7CiAKKyAgICBXZWJD b3JlOjpDb2xvciB3ZWJQYWdlQmFja2dyb3VuZENvbG9yVXNlckludGVyZmFjZVRocmVhZCgpIGNv bnN0OyAvLyB1c2UgV2ViU2V0dGluZ3M6OmJhY2tncm91bmRDb2xvcigpIGZvciB0aGUgV2ViS2l0 IHRocmVhZAorICAgIHZvaWQgc2V0V2ViUGFnZUJhY2tncm91bmRDb2xvcihjb25zdCBXZWJDb3Jl OjpDb2xvciYpOworCiAgICAgdm9pZCBpbnZhbGlkYXRlV2luZG93KCk7CiAgICAgdm9pZCBpbnZh bGlkYXRlV2luZG93KGNvbnN0IFBsYXRmb3JtOjpJbnRSZWN0JiBkc3QpOwogICAgIHZvaWQgY2xl YXJXaW5kb3coY29uc3QgUGxhdGZvcm06OkludFJlY3QmLCB1bnNpZ25lZCBjaGFyIHJlZCwgdW5z aWduZWQgY2hhciBncmVlbiwgdW5zaWduZWQgY2hhciBibHVlLCB1bnNpZ25lZCBjaGFyIGFscGhh ID0gMjU1KTsKQEAgLTM2Myw2ICszNjcsOCBAQCBwdWJsaWM6CiAgICAgYm9vbCBtX2RlZmVyc0Js aXQ7CiAgICAgYm9vbCBtX2hhc0JsaXRKb2JzOwogCisgICAgV2ViQ29yZTo6Q29sb3IgbV93ZWJQ YWdlQmFja2dyb3VuZENvbG9yOyAvLyBmb3IgdXNlciBpbnRlcmZhY2UgdGhyZWFkIG9wZXJhdGlv bnMgc3VjaCBhcyBibGl0dGluZworCiAgICAgbXV0YWJsZSB1bnNpZ25lZCBtX2Zyb250U3RhdGU7 CiAgICAgbXV0YWJsZSB1bnNpZ25lZCBtX2JhY2tTdGF0ZTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggYTJiMzU0YTVjY2JkYTQ5MDAxMDI2ODg2YWQ0NDUz ZWYzZDMxOGUwOC4uYWFmNTczZGI1NDMzYjFjNmQwOWQ3ZmRkOTEwODM2MTZhMTY4MWM5ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0xMDMzLDYgKzEwMzMs MTEgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6c2V0TG9hZFN0YXRlKExvYWRTdGF0ZSBzdGF0ZSkK ICAgICBpZiAoc3RhdGUgPT0gRmluaXNoZWQgJiYgbV9tYWluRnJhbWUgJiYgbV9tYWluRnJhbWUt PmRvY3VtZW50KCkpCiAgICAgICAgIG1fbWFpbkZyYW1lLT5kb2N1bWVudCgpLT51cGRhdGVTdHls ZUlmTmVlZGVkKCk7CiAKKyAgICAvLyBEaXNwYXRjaCB0aGUgYmFja2luZ3N0b3JlIGJhY2tncm91 bmQgY29sb3IgYXQgaW1wb3J0YW50IHN0YXRlIGNoYW5nZXMuCisgICAgbV9iYWNraW5nU3RvcmUt PmQtPnNldFdlYlBhZ2VCYWNrZ3JvdW5kQ29sb3IobV9tYWluRnJhbWUgJiYgbV9tYWluRnJhbWUt PnZpZXcoKQorICAgICAgICA/IG1fbWFpbkZyYW1lLT52aWV3KCktPmRvY3VtZW50QmFja2dyb3Vu ZENvbG9yKCkKKyAgICAgICAgOiBtX3dlYlNldHRpbmdzLT5iYWNrZ3JvdW5kQ29sb3IoKSk7CisK ICAgICBtX2xvYWRTdGF0ZSA9IHN0YXRlOwogCiAjaWYgREVCVUdfV0VCUEFHRV9MT0FECkBAIC01 ODQ5LDYgKzU4NTQsMTEgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6ZGlkQ2hhbmdlU2V0dGluZ3Mo V2ViU2V0dGluZ3MqIHdlYlNldHRpbmdzKQogICAgICAgICBQbGF0Zm9ybTo6dXNlckludGVyZmFj ZVRocmVhZE1lc3NhZ2VDbGllbnQoKS0+ZGlzcGF0Y2hNZXNzYWdlKAogICAgICAgICAgICAgY3Jl YXRlTWV0aG9kQ2FsbE1lc3NhZ2UoJldlYlBhZ2VQcml2YXRlOjpzZXRDb21wb3NpdG9yQmFja2dy b3VuZENvbG9yLCB0aGlzLCBiYWNrZ3JvdW5kQ29sb3IpKTsKICAgICB9CisgICAgaWYgKG1fYmFj a2luZ1N0b3JlKSB7CisgICAgICAgIG1fYmFja2luZ1N0b3JlLT5kLT5zZXRXZWJQYWdlQmFja2dy b3VuZENvbG9yKG1fbWFpbkZyYW1lICYmIG1fbWFpbkZyYW1lLT52aWV3KCkKKyAgICAgICAgICAg ID8gbV9tYWluRnJhbWUtPnZpZXcoKS0+ZG9jdW1lbnRCYWNrZ3JvdW5kQ29sb3IoKQorICAgICAg ICAgICAgOiB3ZWJTZXR0aW5ncy0+YmFja2dyb3VuZENvbG9yKCkpOworICAgIH0KIAogICAgIG1f cGFnZS0+c2V0RGV2aWNlU2NhbGVGYWN0b3Iod2ViU2V0dGluZ3MtPmRldmljZVBpeGVsUmF0aW8o KSk7CiB9Cg==