101637 2012-11-08 13:18:52 -0800 Remove ReadWriteLock 2012-11-19 15:48:01 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned benjamin darin hyatt levin+threading webkit.review.bot oldest_to_newest 762107 0 laszlo.gombos 2012-11-08 13:18:52 -0800 It seems ReadWriteLock is not used and it is only implemented for some environments so it requires some #if maintenance. Perhaps we should remove it (or find some use for it). 762119 1 laszlo.gombos 2012-11-08 13:31:45 -0800 A related discussion from 3 years ago suggests the possibility of removing this class as well - https://bugs.webkit.org/show_bug.cgi?id=30713#c4 762144 2 173111 laszlo.gombos 2012-11-08 13:48:08 -0800 Created attachment 173111 1st try 765784 3 173111 darin 2012-11-13 10:38:13 -0800 Comment on attachment 173111 1st try Should be fine. 771117 4 173111 webkit.review.bot 2012-11-19 15:47:58 -0800 Comment on attachment 173111 1st try Clearing flags on attachment: 173111 Committed r135206: <http://trac.webkit.org/changeset/135206> 771118 5 webkit.review.bot 2012-11-19 15:48:01 -0800 All reviewed patches have been landed. Closing bug. 173111 2012-11-08 13:48:08 -0800 2012-11-19 15:47:58 -0800 1st try 101637.patch text/plain 4814 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzM5MzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTA4ICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVtb3ZlIFJlYWRXcml0ZUxvY2sKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTYzNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBSZWFkV3Jp dGVMb2NrIGFzIGl0IGRvZXMgbm90IHNlZW1zIHRvIGJlIHVzZWQuCisKKyAgICAgICAgKiB3dGYv UGxhdGZvcm0uaDogUmVtb3ZlIHRoZSBkZWZpbml0aW9uIG9mIEhBVkVfUFRIUkVBRF9SV0xPQ0su CisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nUHJpbWl0aXZlcy5oOiBSZW1vdmUgdGhlIFBsYXRm b3JtUmVhZFdyaXRlTG9jayB0eXBlIAorICAgICAgICBhbmQgdGhlIFJlYWRXcml0ZUxvY2sgY2xh c3MuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwOiBSZW1vdmUgdGhlIGlt cGxlbWVudGF0aW9uIG9mCisgICAgICAgIHRoZSBSZWFkV3JpdGVMb2NrIGNsYXNzIHVzaW5nIHB0 aHJlYWRzLgorCiAyMDEyLTExLTA4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgogCiAgICAgICAgIEhhc2hBbmRVVEY4Q2hhcmFjdGVyc1RyYW5zbGF0b3Igc2hvdWxkIGNyZWF0 ZSBhbiA4IGJpdCBzdHJpbmcgaWYgcG9zc2libGUKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BsYXRm b3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24g MTMzOTAxKQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAt NTUzLDcgKzU1Myw2IEBACiAjZW5kaWYKICNkZWZpbmUgV1RGX1VTRV9DRiAxCiAjZGVmaW5lIFdU Rl9VU0VfUFRIUkVBRFMgMQotI2RlZmluZSBIQVZFX1BUSFJFQURfUldMT0NLIDEKICNkZWZpbmUg SEFWRV9SRUFETElORSAxCiAjZGVmaW5lIEhBVkVfUlVOTE9PUF9USU1FUiAxCiAjZGVmaW5lIEVO QUJMRV9GVUxMU0NSRUVOX0FQSSAxCkBAIC01NzMsNyArNTcyLDYgQEAKICNpZiBQTEFURk9STShD SFJPTUlVTSkgJiYgT1MoREFSV0lOKQogI2RlZmluZSBXVEZfVVNFX0NGIDEKICNkZWZpbmUgV1RG X1VTRV9QVEhSRUFEUyAxCi0jZGVmaW5lIEhBVkVfUFRIUkVBRF9SV0xPQ0sgMQogCiAjZGVmaW5l IFdURl9VU0VfV0tfU0NST0xMQkFSX1BBSU5URVIgMQogI2VuZGlmCkBAIC02MDAsNyArNTk4LDYg QEAKICNkZWZpbmUgRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUyAxCiAjZGVmaW5lIEVOQUJMRV9S RVBBSU5UX1RIUk9UVExJTkcgMQogI2RlZmluZSBFTkFCTEVfV0VCX0FSQ0hJVkUgMQotI2RlZmlu ZSBIQVZFX1BUSFJFQURfUldMT0NLIDEKICNkZWZpbmUgSEFWRV9SRUFETElORSAxCiAjZGVmaW5l IFdURl9VU0VfQ0YgMQogI2RlZmluZSBXVEZfVVNFX0NGTkVUV09SSyAxCkBAIC02NTcsNyArNjU0 LDYgQEAKIAogI2lmIE9TKFVOSVgpICYmIChQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFFUKSkK ICNkZWZpbmUgV1RGX1VTRV9QVEhSRUFEUyAxCi0jZGVmaW5lIEhBVkVfUFRIUkVBRF9SV0xPQ0sg MQogI2VuZGlmCiAKICNpZiAhZGVmaW5lZChIQVZFX0FDQ0VTU0lCSUxJVFkpCkluZGV4OiBTb3Vy Y2UvV1RGL3d0Zi9UaHJlYWRpbmdQcmltaXRpdmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dU Ri93dGYvVGhyZWFkaW5nUHJpbWl0aXZlcy5oCShyZXZpc2lvbiAxMzM5MDEpCisrKyBTb3VyY2Uv V1RGL3d0Zi9UaHJlYWRpbmdQcmltaXRpdmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTUwLDE4ICs1 MCwxMiBAQCBuYW1lc3BhY2UgV1RGIHsKIAogI2lmIFVTRShQVEhSRUFEUykKIHR5cGVkZWYgcHRo cmVhZF9tdXRleF90IFBsYXRmb3JtTXV0ZXg7Ci0jaWYgSEFWRShQVEhSRUFEX1JXTE9DSykKLXR5 cGVkZWYgcHRocmVhZF9yd2xvY2tfdCBQbGF0Zm9ybVJlYWRXcml0ZUxvY2s7Ci0jZWxzZQotdHlw ZWRlZiB2b2lkKiBQbGF0Zm9ybVJlYWRXcml0ZUxvY2s7Ci0jZW5kaWYKIHR5cGVkZWYgcHRocmVh ZF9jb25kX3QgUGxhdGZvcm1Db25kaXRpb247CiAjZWxpZiBPUyhXSU5ET1dTKQogc3RydWN0IFBs YXRmb3JtTXV0ZXggewogICAgIENSSVRJQ0FMX1NFQ1RJT04gbV9pbnRlcm5hbE11dGV4OwogICAg IHNpemVfdCBtX3JlY3Vyc2lvbkNvdW50OwogfTsKLXR5cGVkZWYgdm9pZCogUGxhdGZvcm1SZWFk V3JpdGVMb2NrOyAvLyBGSVhNRTogSW1wbGVtZW50Lgogc3RydWN0IFBsYXRmb3JtQ29uZGl0aW9u IHsKICAgICBzaXplX3QgbV93YWl0ZXJzR29uZTsKICAgICBzaXplX3QgbV93YWl0ZXJzQmxvY2tl ZDsKQEAgLTc1LDcgKzY5LDYgQEAgc3RydWN0IFBsYXRmb3JtQ29uZGl0aW9uIHsKIH07CiAjZWxz ZQogdHlwZWRlZiB2b2lkKiBQbGF0Zm9ybU11dGV4OwotdHlwZWRlZiB2b2lkKiBQbGF0Zm9ybVJl YWRXcml0ZUxvY2s7CiB0eXBlZGVmIHZvaWQqIFBsYXRmb3JtQ29uZGl0aW9uOwogI2VuZGlmCiAg ICAgCkBAIC0xMTQsMjQgKzEwNyw2IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2xvY2tlZDsKIH07 CiAKLWNsYXNzIFJlYWRXcml0ZUxvY2sgewotICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFJlYWRX cml0ZUxvY2spOwotcHVibGljOgotICAgIFJlYWRXcml0ZUxvY2soKTsKLSAgICB+UmVhZFdyaXRl TG9jaygpOwotCi0gICAgdm9pZCByZWFkTG9jaygpOwotICAgIGJvb2wgdHJ5UmVhZExvY2soKTsK LQotICAgIHZvaWQgd3JpdGVMb2NrKCk7Ci0gICAgYm9vbCB0cnlXcml0ZUxvY2soKTsKLSAgICAK LSAgICB2b2lkIHVubG9jaygpOwotCi1wcml2YXRlOgotICAgIFBsYXRmb3JtUmVhZFdyaXRlTG9j ayBtX3JlYWRXcml0ZUxvY2s7Ci19OwotCiBjbGFzcyBUaHJlYWRDb25kaXRpb24gewogICAgIFdU Rl9NQUtFX05PTkNPUFlBQkxFKFRocmVhZENvbmRpdGlvbik7CiBwdWJsaWM6CkluZGV4OiBTb3Vy Y2UvV1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dU Ri93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCShyZXZpc2lvbiAxMzM5MDEpCisrKyBTb3VyY2Uv V1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2NCw2MiAr MzY0LDYgQEAgdm9pZCBNdXRleDo6dW5sb2NrKCkKICAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwg IXJlc3VsdCk7CiB9CiAKLSNpZiBIQVZFKFBUSFJFQURfUldMT0NLKQotUmVhZFdyaXRlTG9jazo6 UmVhZFdyaXRlTG9jaygpCi17Ci0gICAgcHRocmVhZF9yd2xvY2tfaW5pdCgmbV9yZWFkV3JpdGVM b2NrLCBOVUxMKTsKLX0KLQotUmVhZFdyaXRlTG9jazo6flJlYWRXcml0ZUxvY2soKQotewotICAg IHB0aHJlYWRfcndsb2NrX2Rlc3Ryb3koJm1fcmVhZFdyaXRlTG9jayk7Ci19Ci0KLXZvaWQgUmVh ZFdyaXRlTG9jazo6cmVhZExvY2soKQotewotICAgIGludCByZXN1bHQgPSBwdGhyZWFkX3J3bG9j a19yZGxvY2soJm1fcmVhZFdyaXRlTG9jayk7Ci0gICAgQVNTRVJUX1VOVVNFRChyZXN1bHQsICFy ZXN1bHQpOwotfQotCi1ib29sIFJlYWRXcml0ZUxvY2s6OnRyeVJlYWRMb2NrKCkKLXsKLSAgICBp bnQgcmVzdWx0ID0gcHRocmVhZF9yd2xvY2tfdHJ5cmRsb2NrKCZtX3JlYWRXcml0ZUxvY2spOwot Ci0gICAgaWYgKHJlc3VsdCA9PSAwKQotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAocmVz dWx0ID09IEVCVVNZIHx8IHJlc3VsdCA9PSBFQUdBSU4pCi0gICAgICAgIHJldHVybiBmYWxzZTsK LQotICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIHJldHVybiBmYWxzZTsKLX0KLQotdm9p ZCBSZWFkV3JpdGVMb2NrOjp3cml0ZUxvY2soKQotewotICAgIGludCByZXN1bHQgPSBwdGhyZWFk X3J3bG9ja193cmxvY2soJm1fcmVhZFdyaXRlTG9jayk7Ci0gICAgQVNTRVJUX1VOVVNFRChyZXN1 bHQsICFyZXN1bHQpOwotfQotCi1ib29sIFJlYWRXcml0ZUxvY2s6OnRyeVdyaXRlTG9jaygpCi17 Ci0gICAgaW50IHJlc3VsdCA9IHB0aHJlYWRfcndsb2NrX3RyeXdybG9jaygmbV9yZWFkV3JpdGVM b2NrKTsKLQotICAgIGlmIChyZXN1bHQgPT0gMCkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAg aWYgKHJlc3VsdCA9PSBFQlVTWSB8fCByZXN1bHQgPT0gRUFHQUlOKQotICAgICAgICByZXR1cm4g ZmFsc2U7Ci0KLSAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICByZXR1cm4gZmFsc2U7Ci19 Ci0KLXZvaWQgUmVhZFdyaXRlTG9jazo6dW5sb2NrKCkKLXsKLSAgICBpbnQgcmVzdWx0ID0gcHRo cmVhZF9yd2xvY2tfdW5sb2NrKCZtX3JlYWRXcml0ZUxvY2spOwotICAgIEFTU0VSVF9VTlVTRUQo cmVzdWx0LCAhcmVzdWx0KTsKLX0KLSNlbmRpZiAgLy8gSEFWRShQVEhSRUFEX1JXTE9DSykKLQog VGhyZWFkQ29uZGl0aW9uOjpUaHJlYWRDb25kaXRpb24oKQogeyAKICAgICBwdGhyZWFkX2NvbmRf aW5pdCgmbV9jb25kaXRpb24sIE5VTEwpOwo=