101635 2012-11-08 13:15:54 -0800 [CMake] Remove the definition of WTF_PLATFORM_WIN from the build system 2013-01-24 00:47:49 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 laszlo.gombos s.choi cdumez dw.im gyuyoung.kim paroga rakuco s.choi webkit.review.bot oldest_to_newest 762101 0 laszlo.gombos 2012-11-08 13:15:54 -0800 It seems to me that WTF_PLATFORM_WIN defined twice; in CMake build-system in cmake/OptionsWindows.cmake and in Source/WTF/wtf/Platform.h. I would find it more future-proof to have it only defined in common C++ code in Platform.h. Related discussion in bug 101482. 805882 1 182473 s.choi 2013-01-12 09:45:12 -0800 Created attachment 182473 Patch 806439 2 s.choi 2013-01-14 10:05:05 -0800 This super simple patch seemed to be faced with some kind of build error on Windows port. Any clue? I don't personally have windows build system. 806450 3 cdumez 2013-01-14 10:27:45 -0800 (In reply to comment #2) > This super simple patch seemed to be faced with some kind of build error on Windows port. Any clue? I don't personally have windows build system. This is unrelated to the patch. The win-ews bot is in a bad state. Otherwise, the bubble would be red (not purple). 806539 4 s.choi 2013-01-14 13:03:20 -0800 I guessed the win-ews is in a bad state, but wanted to doubly check. Okay, then I am trying to put it back to the review & commit queue. 806612 5 182473 laszlo.gombos 2013-01-14 14:13:07 -0800 Comment on attachment 182473 Patch Looks good to me. I would like to hear from Patrick Gansterer or someone else from the WinCE port that they support this change before this can land. 815024 6 s.choi 2013-01-23 20:53:21 -0800 (In reply to comment #5) > (From update of attachment 182473 [details]) > Looks good to me. I would like to hear from Patrick Gansterer or someone else from the WinCE port that they support this change before this can land. paroga doesn't seem to be in the IRC channel so often, nor do I seem to find anyone for WinCE port from http://trac.webkit.org/wiki/WebKit%20Team. Any advice? 815025 7 182473 gyuyoung.kim 2013-01-23 20:56:26 -0800 Comment on attachment 182473 Patch You are not committer. Do not set cp+. 815066 8 gyuyoung.kim 2013-01-23 21:55:24 -0800 If there is no comment from wince folks by tomorrow, I'd like to land this patch. 815180 9 182473 paroga 2013-01-24 00:34:00 -0800 Comment on attachment 182473 Patch (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 182473 [details] [details]) > > Looks good to me. I would like to hear from Patrick Gansterer or someone else from the WinCE port that they support this change before this can land. > > paroga doesn't seem to be in the IRC channel so often, nor do I seem to find anyone for WinCE port from http://trac.webkit.org/wiki/WebKit%20Team. I'm the "WinCE team". ;-) Sorry for the long long delay, but it's not easy to find the time for WebKit if it's not your full time job. :-( 815185 10 s.choi 2013-01-24 00:37:46 -0800 (In reply to comment #7) > (From update of attachment 182473 [details]) > You are not committer. Do not set cp+. Oops! My bad - I meant it to set cq? 815192 11 182473 webkit.review.bot 2013-01-24 00:47:44 -0800 Comment on attachment 182473 Patch Clearing flags on attachment: 182473 Committed r140662: <http://trac.webkit.org/changeset/140662> 815193 12 webkit.review.bot 2013-01-24 00:47:49 -0800 All reviewed patches have been landed. Closing bug. 182473 2013-01-12 09:45:12 -0800 2013-01-24 00:47:44 -0800 Patch bug-101635-20130113024213.patch text/plain 1295 s.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dpbmRvd3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbmRvd3MuY21ha2UKaW5k ZXggY2MyOWM4MDMzMDNlYTA3NzQ3M2Y2OTU4NDU2MmE1NzFjOGM0OTBlNi4uYzkzMmUxMDU5NTRk MDcwZmRmODMxYmI0NmI2ODA4NmNjZGFhNTE0YSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09w dGlvbnNXaW5kb3dzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luZG93cy5jbWFr ZQpAQCAtMSw2ICsxLDMgQEAKLWFkZF9kZWZpbml0aW9ucygtRFdURl9QTEFURk9STV9XSU49MSkK LXNldChXVEZfUExBVEZPUk1fV0lOIDEpCi0KIGFkZF9kZWZpbml0aW9ucygtRF9IQVNfRVhDRVBU SU9OUz0wIC1ETk9NSU5NQVggLURVTklDT0RFKQogCiBpbmNsdWRlX2RpcmVjdG9yaWVzKCR7SkFW QVNDUklQVENPUkVfRElSfS9vcy13aW4zMikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBmNzk5NGU3NTgzODk5N2FmODM4ZDI0ZGRkOGFmMDZlZDZhNDE4NTdmLi5mMjFk OTZhZDljN2E4OWQyZDEzNGFmM2I1NTVmYWMxODE5MjcyNDExIDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDEtMTIgIFNvby1IeXVu IENob2kgIDxzLmNob2lAaGFja2Vyc2xhYi5ldT4KKworICAgICAgICBbQ01ha2VdIFJlbW92ZSB0 aGUgZGVmaW5pdGlvbiBvZiBXVEZfUExBVEZPUk1fV0lOIGZyb20gdGhlIGJ1aWxkIHN5c3RlbQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjM1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV1RGX1BMQVRG T1JNX1dJTiBkZWZpbmVkIHR3aWNlOiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbmRvd3MuY21ha2Ug YW5kIGluCisgICAgICAgIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmguCisgICAgICAgIEl0IHdv dWxkIGJlIG1vcmUgZnV0dXJlLXByb29mIHRvIGhhdmUgaXQgb25seSBkZWZpbmVkIGluIGNvbW1v biBDKysgY29kZSBpbgorICAgICAgICBQbGF0Zm9ybS5oLgorCisgICAgICAgICogU291cmNlL2Nt YWtlL09wdGlvbnNXaW5kb3dzLmNtYWtlOgorCiAyMDEzLTAxLTExICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBVcGRhdGUg TkVXUyBhbmQgY29uZmlndXJlLmFjIGZvciAxLjExLjQgcmVsZWFzZQo=