101629 2012-11-08 11:43:42 -0800 [chromium] Adding a number of layers in layer tree to WebRenderingStats. 2012-11-27 06:20:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 0 hartmanng webkit-unassigned abarth dglazkov fishd jamesr nduca tkent+wkapi webkit.review.bot oldest_to_newest 762012 0 hartmanng 2012-11-08 11:43:42 -0800 [chromium] Adding a number of layers in layer tree to WebRenderingStats. 762014 1 173084 hartmanng 2012-11-08 11:44:16 -0800 Created attachment 173084 Patch 762015 2 hartmanng 2012-11-08 11:44:39 -0800 jamesr@ Please take a look 762022 3 webkit.review.bot 2012-11-08 11:49:00 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 762269 4 jamesr 2012-11-08 15:55:24 -0800 Do we need this? Can't it just go through the chromium repo? 762458 5 nduca 2012-11-08 19:26:20 -0800 Not yet, because the struct is passed by value instead of as a ptr. That prevents a static cast back to the cc type. We were going to fix this, but we've been holding off because we're planning on doing something completely different for stats [sending stats via inspector]. 763155 6 jamesr 2012-11-09 10:44:44 -0800 (In reply to comment #5) > Not yet, because the struct is passed by value instead of as a ptr. That prevents a static cast back to the cc type. Where? The only places I see this struct being used in WebKit are by const reference. > > We were going to fix this, but we've been holding off because we're planning on doing something completely different for stats [sending stats via inspector]. 173084 2012-11-08 11:44:16 -0800 2012-11-13 14:06:10 -0800 Patch bug-101629-20121108144225.patch text/plain 1969 hartmanng U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA4YmQ1N2UyNjIyYmZj MGZjNGFmN2Q5MTM0MGVlYmU4YWYzYTk3MzFjLi4yN2E0ZTA1ZDk3MDNkZTkxNTFiYzJjMzExYmZm NjkzMTBjMTBjYzZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMS0wOCAg R2xlbm4gSGFydG1hbm4gIDxoYXJ0bWFubmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJv bWl1bV0gQWRkaW5nIGEgbnVtYmVyIG9mIGxheWVycyBpbiBsYXllciB0cmVlIHRvIFdlYlJlbmRl cmluZ1N0YXRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTAxNjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViUmVuZGVyaW5nU3RhdHMuaDoKKyAgICAgICAgKFdlYlJl bmRlcmluZ1N0YXRzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUmVuZGVyaW5nU3RhdHM6OldlYlJl bmRlcmluZ1N0YXRzKToKKyAgICAgICAgKFdlYktpdDo6V2ViUmVuZGVyaW5nU3RhdHM6OmVudW1l cmF0ZUZpZWxkcyk6CisKIDIwMTItMTEtMDggIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CiAKICAgICAgICAgQWRkIHByb3BlcnRpZXMgZm9yIHdlZWsvbW9udGggcGlja2VyIGlu IERhdGVUaW1lQ2hvb3NlckltcGw6OndyaXRlRG9jdW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUmVuZGVyaW5nU3RhdHMuaCBiL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUmVuZGVyaW5nU3RhdHMuaAppbmRleCAyODJlODI2MDA5 NmVjZDVhZGM0MDdhNGY2MDZlMGJiYTI3N2QwOGQyLi4zNjEyZGM5ZDE5NjhjYTA3OGQzMjE3ODM0 ZmYyODExMzc2YzkyNWI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVi bGljL1dlYlJlbmRlcmluZ1N0YXRzLmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oCkBAIC00MCw2ICs0MCw3IEBAIHN0cnVjdCBXZWJSZW5k ZXJpbmdTdGF0cyB7CiAgICAgc2l6ZV90IHRvdGFsUGl4ZWxzUmFzdGVyaXplZDsKICAgICBzaXpl X3QgbnVtSW1wbFRocmVhZFNjcm9sbHM7CiAgICAgc2l6ZV90IG51bU1haW5UaHJlYWRTY3JvbGxz OworICAgIHNpemVfdCBudW1MYXllcnNJbkxheWVyVHJlZTsKIAogICAgIFdlYlJlbmRlcmluZ1N0 YXRzKCkKICAgICAgICAgOiBudW1BbmltYXRpb25GcmFtZXMoMCkKQEAgLTUzLDYgKzU0LDcgQEAg c3RydWN0IFdlYlJlbmRlcmluZ1N0YXRzIHsKICAgICAgICAgLCB0b3RhbFBpeGVsc1Jhc3Rlcml6 ZWQoMCkKICAgICAgICAgLCBudW1JbXBsVGhyZWFkU2Nyb2xscygwKQogICAgICAgICAsIG51bU1h aW5UaHJlYWRTY3JvbGxzKDApCisgICAgICAgICwgbnVtTGF5ZXJzSW5MYXllclRyZWUoMCkKICAg ICB7CiAgICAgfQogCkBAIC04Miw2ICs4NCw3IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7 CiAgICAgICAgIGVudW1lcmF0b3ItPmFkZEludCgidG90YWxQaXhlbHNSYXN0ZXJpemVkIiwgdG90 YWxQaXhlbHNSYXN0ZXJpemVkKTsKICAgICAgICAgZW51bWVyYXRvci0+YWRkSW50KCJudW1JbXBs VGhyZWFkU2Nyb2xscyIsIG51bUltcGxUaHJlYWRTY3JvbGxzKTsKICAgICAgICAgZW51bWVyYXRv ci0+YWRkSW50KCJudW1NYWluVGhyZWFkU2Nyb2xscyIsIG51bU1haW5UaHJlYWRTY3JvbGxzKTsK KyAgICAgICAgZW51bWVyYXRvci0+YWRkSW50KCJudW1MYXllcnNJbkxheWVyVHJlZSIsIG51bUxh eWVyc0luTGF5ZXJUcmVlKTsKICAgICB9CiB9OwogCg==