101617 2012-11-08 09:31:51 -0800 REGRESSION(r133892): Compile failures on mac, android, linux (Requested by jsbell|gardener on #webkit). 2012-11-08 09:54:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101470 1 webkit.review.bot dcarney dcarney haraken hayato jsbell oldest_to_newest 761879 0 webkit.review.bot 2012-11-08 09:31:51 -0800 http://trac.webkit.org/changeset/133892 broke the build: Compile failures on mac, android, linux (Requested by jsbell|gardener on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 761881 1 173057 webkit.review.bot 2012-11-08 09:32:30 -0800 Created attachment 173057 ROLLOUT of r133892 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 761883 2 jsbell 2012-11-08 09:34:09 -0800 First instance of the failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/1328 http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/3533 http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/16362 Typical errors from the build logs: In file included from ../bindings/v8/ScriptState.h:34: ../bindings/v8/DOMWrapperWorld.h:83:16:error: member function 'isIsolatedWorld' not viable: 'this' argument has type 'const WebCore::DOMWrapperWorld', but function is not marked const ASSERT(isIsolatedWorld()); 761885 3 173057 jsbell 2012-11-08 09:35:32 -0800 Comment on attachment 173057 ROLLOUT of r133892 Clearing flags on attachment: 173057 Committed r133909: <http://trac.webkit.org/changeset/133909> 761886 4 jsbell 2012-11-08 09:35:34 -0800 All reviewed patches have been landed. Closing bug. 173057 2012-11-08 09:32:30 -0800 2012-11-08 09:35:31 -0800 ROLLOUT of r133892 bug-101617-20121108173851.patch text/plain 3748 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE4OThmNTFjYzllNWNk ZGUzOGQ5OGE4ZWFhNWFkNGQ3NDllZjUwNy4uMWFkZDliOGZjMzE0OTJjNGJiZWU2ODgwMDhlOThm NzgzZTJiZjkyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTA4ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTMzODkyLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMzM4OTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMTYxNworCisgICAgICAgIENvbXBpbGUgZmFpbHVyZXMgb24gbWFjLCBhbmRy b2lkLCBsaW51eCAoUmVxdWVzdGVkIGJ5CisgICAgICAgIGpzYmVsbHxnYXJkZW5lciBvbiAjd2Vi a2l0KS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpET01EYXRhU3RvcmU6OmN1cnJlbnQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4 L0RPTVdyYXBwZXJXb3JsZC5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkOjpk b21EYXRhU3RvcmUpOgorICAgICAgICAoV2ViQ29yZTo6RE9NV3JhcHBlcldvcmxkOjpET01XcmFw cGVyV29ybGQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oOgorICAgICAg ICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpnZXRDYWNoZWRXcmFwcGVyKToKKwogMjAxMi0xMS0w OCAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBbQ2FudmFzXSBVSSBpdGVyYXRpb25zOiBpbWFnZSBvbiB0aGUgdG9wLCBhdXRv IHJlcGxheQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YVN0 b3JlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGFTdG9yZS5jcHAKaW5k ZXggODY5ZDUxMzk4MjdhYjg3YjM5NzhjMWY5MjE5MjBkMzdiMWY3MzYzOS4uNTk3ZTMxNDM0M2Zj ZDlmNmE4YzdlNDk0ZWI5ZmRkMmM0YTQzMDNiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvRE9NRGF0YVN0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9ET01EYXRhU3RvcmUuY3BwCkBAIC01NCwxNCArNTQsMTQgQEAgRE9NRGF0YVN0b3JlOjp+ RE9NRGF0YVN0b3JlKCkKIAogRE9NRGF0YVN0b3JlKiBET01EYXRhU3RvcmU6OmN1cnJlbnQodjg6 Oklzb2xhdGUqIGlzb2xhdGUpCiB7Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChET01EYXRhU3Rv cmUsIG1haW5Xb3JsZERPTURhdGFTdG9yZSwgKE1haW5Xb3JsZCkpOworICAgIERFRklORV9TVEFU SUNfTE9DQUwoRE9NRGF0YVN0b3JlLCBkZWZhdWx0U3RvcmUsIChNYWluV29ybGQpKTsKICAgICBW OFBlcklzb2xhdGVEYXRhKiBkYXRhID0gaXNvbGF0ZSA/IFY4UGVySXNvbGF0ZURhdGE6OmZyb20o aXNvbGF0ZSkgOiBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCk7CiAgICAgaWYgKFVOTElLRUxZ KCEhZGF0YS0+ZG9tRGF0YVN0b3JlKCkpKQogICAgICAgICByZXR1cm4gZGF0YS0+ZG9tRGF0YVN0 b3JlKCk7CiAgICAgVjhET01XaW5kb3dTaGVsbCogY29udGV4dCA9IFY4RE9NV2luZG93U2hlbGw6 OmdldEVudGVyZWQoKTsKICAgICBpZiAoVU5MSUtFTFkoISFjb250ZXh0KSkKLSAgICAgICAgcmV0 dXJuIGNvbnRleHQtPndvcmxkKCktPmlzb2xhdGVkV29ybGRET01EYXRhU3RvcmUoKTsKLSAgICBy ZXR1cm4gJm1haW5Xb3JsZERPTURhdGFTdG9yZTsKKyAgICAgICAgcmV0dXJuIGNvbnRleHQtPndv cmxkKCktPmRvbURhdGFTdG9yZSgpOworICAgIHJldHVybiAmZGVmYXVsdFN0b3JlOwogfQogCiB2 b2lkIERPTURhdGFTdG9yZTo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyogbWVt b3J5T2JqZWN0SW5mbykgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L0RPTVdyYXBwZXJXb3JsZC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3Jh cHBlcldvcmxkLmgKaW5kZXggMGFiZTc4YmUzOWU4YzczNmQyMWViZmE1ZjljOGMzMmQ1ZmMzMWQ1 Yy4uNWRmMzA1ODE1ZDI0ZmJkNDY4YzhmMTAzMjk3YWM1OGI5ZGEyMmIzYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmgKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxkLmgKQEAgLTc4LDkgKzc4LDkgQEAg cHVibGljOgogICAgIGJvb2wgaXNJc29sYXRlZFdvcmxkKCkgeyByZXR1cm4gaXNJc29sYXRlZFdv cmxkSWQobV93b3JsZElkKTsgfQogICAgIGludCB3b3JsZElkKCkgY29uc3QgeyByZXR1cm4gbV93 b3JsZElkOyB9CiAgICAgaW50IGV4dGVuc2lvbkdyb3VwKCkgY29uc3QgeyByZXR1cm4gbV9leHRl bnNpb25Hcm91cDsgfQotICAgIERPTURhdGFTdG9yZSogaXNvbGF0ZWRXb3JsZERPTURhdGFTdG9y ZSgpIGNvbnN0CisgICAgRE9NRGF0YVN0b3JlKiBkb21EYXRhU3RvcmUoKSBjb25zdAogICAgIHsK LSAgICAgICAgQVNTRVJUKGlzSXNvbGF0ZWRXb3JsZCgpKTsKKyAgICAgICAgQVNTRVJUKG1fd29y bGRJZCAhPSB1bmluaXRpYWxpemVkV29ybGRJZCk7CiAgICAgICAgIHJldHVybiBtX2RvbURhdGFT dG9yZS5nZXQoKTsKICAgICB9CiAgICAgdm9pZCBkZXJlZigpCkBAIC05OCw3ICs5OCw3IEBAIHBy aXZhdGU6CiAgICAgICAgIDogbV93b3JsZElkKHdvcmxkSWQpCiAgICAgICAgICwgbV9leHRlbnNp b25Hcm91cChleHRlbnNpb25Hcm91cCkKICAgICB7Ci0gICAgICAgIGlmIChpc0lzb2xhdGVkV29y bGQoKSkKKyAgICAgICAgaWYgKHdvcmxkSWQgIT0gdW5pbml0aWFsaXplZFdvcmxkSWQpCiAgICAg ICAgICAgICBtX2RvbURhdGFTdG9yZSA9IGFkb3B0UHRyKG5ldyBET01EYXRhU3RvcmUoRE9NRGF0 YVN0b3JlOjpJc29sYXRlZFdvcmxkKSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4RE9NV3JhcHBlci5oCmluZGV4IGUwNDI0ZTgxNzNmNjZhZjZjZTMxNjgzOTUzZGZhMGVi NWI3MTQ2ODcuLmFiNmMyY2Q0ODViNzY4OWRlMmM5OTNjMTc3OGE2NjE1MjljZGYyZTQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCkBAIC0xMjIsNyArMTIyLDcg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgaWYgKExJS0VMWSghY29udGV4dCkp CiAgICAgICAgICAgICAgICAgcmV0dXJuIG5vZGUtPndyYXBwZXIoKTsKIAotICAgICAgICAgICAg cmV0dXJuIGNvbnRleHQtPndvcmxkKCktPmlzb2xhdGVkV29ybGRET01EYXRhU3RvcmUoKS0+Z2V0 KG5vZGUpOworICAgICAgICAgICAgcmV0dXJuIGNvbnRleHQtPndvcmxkKCktPmRvbURhdGFTdG9y ZSgpLT5nZXQobm9kZSk7CiAgICAgICAgIH0KIAogICAgIHByaXZhdGU6Cg==