101613 2012-11-08 08:53:09 -0800 Introduce WebScreenInfo.deviceScaleFactor 2012-11-08 12:04:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyostil skyostil abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 761845 0 skyostil 2012-11-08 08:53:09 -0800 Introduce WebScreenInfo.deviceScaleFactor 761849 1 173054 skyostil 2012-11-08 08:57:29 -0800 Created attachment 173054 Patch 761854 2 webkit.review.bot 2012-11-08 09:00:13 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 761855 3 skyostil 2012-11-08 09:00:53 -0800 Please see http://codereview.chromium.org/11348033/#msg23 for the rationale. 761948 4 abarth 2012-11-08 10:35:33 -0800 > 3. [WebKit] Remove WebCore::screen{Horizontal,Vertical}DPI() and use WebScreenInfo::deviceScaleFactor in ChromeClientImpl::dispatchViewportPropertiesDidChange. ^^^ That's very exciting. 761950 5 173054 abarth 2012-11-08 10:36:41 -0800 Comment on attachment 173054 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173054&action=review > Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm:98 > float deviceDPI = 160 * deviceScaleFactor(view); Should we avoid calling deviceScaleFactor twice? 761957 6 skyostil 2012-11-08 10:42:52 -0800 (In reply to comment #5) > Should we avoid calling deviceScaleFactor twice? I was going to do that in step 5 when horizontal/verticalDPI go away for good. 761980 7 173054 webkit.review.bot 2012-11-08 11:03:46 -0800 Comment on attachment 173054 Patch Rejecting attachment 173054 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: omium/TestExpectations Failed to merge in the changes. Patch failed at 0001 Multiple Layout Tests (e.g. fast/repaint/japanese-rl-selection-clear.html) is failing after r133840. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14764668 762035 8 173054 webkit.review.bot 2012-11-08 12:04:27 -0800 Comment on attachment 173054 Patch Clearing flags on attachment: 173054 Committed r133927: <http://trac.webkit.org/changeset/133927> 762036 9 webkit.review.bot 2012-11-08 12:04:33 -0800 All reviewed patches have been landed. Closing bug. 173054 2012-11-08 08:57:29 -0800 2012-11-08 12:04:27 -0800 Patch bug-101613-20121108165538.patch text/plain 4270 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAzYTNmODVhZGFmZTcy MTA4Y2NiMGFmYzQ2OWUwYjBkNGVmMjg5Y2QzLi42YzM0YjlkYjhkN2I0ZWE1MjY0OWIwNDM4Zjlk YjAyZTg1ZTk2MGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMS0wOCAg U2FtaSBLeW9zdGlsYSAgPHNreW9zdGlsQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbnRyb2R1 Y2UgV2ViU2NyZWVuSW5mby5kZXZpY2VTY2FsZUZhY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW50cm9kdWNlIHRoZSBXZWJTY3JlZW5JbmZvLmRl dmljZVNjYWxlRmFjdG9yIHByb3BlcnR5LCB3aGljaCBzcGVjaWZpZXMgdGhlCisgICAgICAgIHJh dGlvIGJldHdlZW4gcGh5c2ljYWwgYW5kIGxvZ2ljYWwgcGl4ZWxzLiBUaGlzIGlzIHRoZSBmaXJz dCBzdGVwIGluIHJlcGxhY2luZworICAgICAgICBob3Jpem9udGFsRFBJL3ZlcnRpY2FsRFBJIGlu IGZhdm9yIG9mIHRoZSBkZXZpY2VTY2FsZUZhY3Rvci4KKworICAgICAgICBGb3Igbm93LCB0aGlz IHZhbHVlIGlzIG9ubHkgaW5pdGlhbGl6ZWQgb24gTWFjLCBiZWNhdXNlIHRoZSBvdGhlciBwb3J0 cyB0aGF0CisgICAgICAgIHVzZSBpdCBpbml0aWFsaXplIHRoZSB2YWx1ZSBpbiBDaHJvbWl1bSwg d2hlcmVhcyBXaW5kb3dzIGFuZCBYMTEgZGVmYXVsdCB0byBhCisgICAgICAgIGZhY3RvciBvZiAx LiBUaGUgdmFsdWUgb24gTWFjIGlzIHRydW5jYXRlZCB0byBhbiBpbnRlZ2VyIHRvIG1hdGNoIHRo ZQorICAgICAgICBleHBlY3RhdGlvbiBpbiBDaHJvbWl1bSdzIFJlbmRlcldpZGdldC4KKworICAg ICAgICAqIGNocm9taXVtL3B1YmxpYy9XZWJTY3JlZW5JbmZvLmg6CisgICAgICAgIChXZWJTY3Jl ZW5JbmZvKToKKyAgICAgICAgKFdlYktpdDo6V2ViU2NyZWVuSW5mbzo6V2ViU2NyZWVuSW5mbyk6 CisKIDIwMTItMTEtMDcgIFl1c3VmIE96dXlzYWwgIDx5dXN1Zm9AZ29vZ2xlLmNvbT4KIAogICAg ICAgICBBZGQgQVBJIGZvciB0b3VjaEV2ZW50SGFuZGxlclJlZ2lvbiB0byBXZWJMYXllcgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCAyY2I0ZWM1YWUzNzY2Mzg0NWM3M2VhZjgzZWI2MzIz YzBiMGY3ODYyLi40NWE0ODZmODJkYzhhYTI5NjZkYjMzNjhkOTJmZjc0M2ExN2NhMTMwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTA4ICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEludHJvZHVjZSBX ZWJTY3JlZW5JbmZvLmRldmljZVNjYWxlRmFjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE2MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbnRyb2R1Y2UgdGhlIFdlYlNjcmVlbkluZm8uZGV2aWNl U2NhbGVGYWN0b3IgcHJvcGVydHksIHdoaWNoIHNwZWNpZmllcyB0aGUKKyAgICAgICAgcmF0aW8g YmV0d2VlbiBwaHlzaWNhbCBhbmQgbG9naWNhbCBwaXhlbHMuIFRoaXMgaXMgdGhlIGZpcnN0IHN0 ZXAgaW4gcmVwbGFjaW5nCisgICAgICAgIGhvcml6b250YWxEUEkvdmVydGljYWxEUEkgaW4gZmF2 b3Igb2YgdGhlIGRldmljZVNjYWxlRmFjdG9yLgorCisgICAgICAgIEZvciBub3csIHRoaXMgdmFs dWUgaXMgb25seSBpbml0aWFsaXplZCBvbiBNYWMsIGJlY2F1c2UgdGhlIG90aGVyIHBvcnRzIHRo YXQKKyAgICAgICAgdXNlIGl0IGluaXRpYWxpemUgdGhlIHZhbHVlIGluIENocm9taXVtLCB3aGVy ZWFzIFdpbmRvd3MgYW5kIFgxMSBkZWZhdWx0IHRvIGEKKyAgICAgICAgZmFjdG9yIG9mIDEuIFRo ZSB2YWx1ZSBvbiBNYWMgaXMgdHJ1bmNhdGVkIHRvIGFuIGludGVnZXIgdG8gbWF0Y2ggdGhlCisg ICAgICAgIGV4cGVjdGF0aW9uIGluIENocm9taXVtJ3MgUmVuZGVyV2lkZ2V0LgorCisgICAgICAg ICogc3JjL21hYy9XZWJTY3JlZW5JbmZvRmFjdG9yeS5tbToKKyAgICAgICAgKFdlYktpdDo6V2Vi U2NyZWVuSW5mb0ZhY3Rvcnk6OnNjcmVlbkluZm8pOgorCiAyMDEyLTExLTA3ICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1Y4XSBXZSBzaG91bGQgaGlkZSB0aGUg RE9NV3JhcHBlck1hcHMgaW5zaWRlIERPTURhdGFTdG9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1Bs YXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJTY3JlZW5JbmZvLmggYi9Tb3VyY2UvUGxhdGZvcm0v Y2hyb21pdW0vcHVibGljL1dlYlNjcmVlbkluZm8uaAppbmRleCA0YWMxOTlkMDk4MzgzNmI1YWU3 NTAyMmIwMThhNmMwY2Q4YjNhM2RjLi40YWYxYzU1NjkxMzQ0ZTk0YmMzZTc4M2U1MjhjMDZhODNh MWMxYTEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlNj cmVlbkluZm8uaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlNjcmVl bkluZm8uaApAQCAtMzYsMTIgKzM2LDE2IEBACiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogc3RydWN0 IFdlYlNjcmVlbkluZm8gewotICAgIC8vIFRoZSBob3Jpem9udGFsIHNjcmVlbiBkcGkuCisgICAg Ly8gVGhlIGhvcml6b250YWwgc2NyZWVuIGRwaSAoZGVwcmVjYXRlZCkuCiAgICAgaW50IGhvcml6 b250YWxEUEk7CiAKLSAgICAvLyBUaGUgdmVydGljYWwgc2NyZWVuIGRwaS4KKyAgICAvLyBUaGUg dmVydGljYWwgc2NyZWVuIGRwaSAoZGVwcmVjYXRlZCkuCiAgICAgaW50IHZlcnRpY2FsRFBJOwog CisgICAgLy8gRGV2aWNlIHNjYWxlIGZhY3Rvci4gU3BlY2lmaWVzIHRoZSByYXRpbyBiZXR3ZWVu IHBoeXNpY2FsIGFuZCBsb2dpY2FsCisgICAgLy8gcGl4ZWxzLgorICAgIGZsb2F0IGRldmljZVNj YWxlRmFjdG9yOworCiAgICAgLy8gVGhlIHNjcmVlbiBkZXB0aCBpbiBiaXRzIHBlciBwaXhlbAog ICAgIGludCBkZXB0aDsKIApAQCAtNzIsNiArNzYsNyBAQCBzdHJ1Y3QgV2ViU2NyZWVuSW5mbyB7 CiAgICAgV2ViU2NyZWVuSW5mbygpCiAgICAgICAgIDogaG9yaXpvbnRhbERQSSgwKQogICAgICAg ICAsIHZlcnRpY2FsRFBJKDApCisgICAgICAgICwgZGV2aWNlU2NhbGVGYWN0b3IoMSkKICAgICAg ICAgLCBkZXB0aCgwKQogICAgICAgICAsIGRlcHRoUGVyQ29tcG9uZW50KDApCiAgICAgICAgICwg aXNNb25vY2hyb21lKGZhbHNlKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL21hYy9XZWJTY3JlZW5JbmZvRmFjdG9yeS5tbSBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL21hYy9XZWJTY3JlZW5JbmZvRmFjdG9yeS5tbQppbmRleCBmMjQ2YmNmMmM3MzIyYTE5 MWZiZDUyMDJkMWFkOTgzYTcxYWJiYTMzLi4wMDNjOGViNmVjYjNmYjk3ZGVlYjcyYjllZGNjZDBh MDQ2YjE0MWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2Vi U2NyZWVuSW5mb0ZhY3RvcnkubW0KKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFj L1dlYlNjcmVlbkluZm9GYWN0b3J5Lm1tCkBAIC05OCw2ICs5OCw3IEBAIFdlYlNjcmVlbkluZm8g V2ViU2NyZWVuSW5mb0ZhY3Rvcnk6OnNjcmVlbkluZm8oTlNWaWV3KiB2aWV3KQogICAgIGZsb2F0 IGRldmljZURQSSA9IDE2MCAqIGRldmljZVNjYWxlRmFjdG9yKHZpZXcpOwogICAgIHJlc3VsdHMu aG9yaXpvbnRhbERQSSA9IGRldmljZURQSTsKICAgICByZXN1bHRzLnZlcnRpY2FsRFBJID0gZGV2 aWNlRFBJOworICAgIHJlc3VsdHMuZGV2aWNlU2NhbGVGYWN0b3IgPSBzdGF0aWNfY2FzdDxpbnQ+ KGRldmljZVNjYWxlRmFjdG9yKHZpZXcpKTsKIAogICAgIHJlc3VsdHMuZGVwdGggPSBOU0JpdHNQ ZXJQaXhlbEZyb21EZXB0aChbc2NyZWVuIGRlcHRoXSk7CiAgICAgcmVzdWx0cy5kZXB0aFBlckNv bXBvbmVudCA9IE5TQml0c1BlclNhbXBsZUZyb21EZXB0aChbc2NyZWVuIGRlcHRoXSk7Cg==