101610 2012-11-08 08:32:38 -0800 [BlackBerry] Janitor: Remove unused m_isValid bool 2012-11-08 12:08:36 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 761824 0 jpetsovits 2012-11-08 08:32:38 -0800 It's not used anywhere, but as we have a constructor that creates an invalid TileIndex, let's add another method to check validity - now a correct check. On top of that, make the stylebot happy by reducing "unsigned int" to just "unsigned". Patch below. 761827 1 173050 jpetsovits 2012-11-08 08:35:46 -0800 Created attachment 173050 Patch 761841 2 173050 rwlbuis 2012-11-08 08:48:15 -0800 Comment on attachment 173050 Patch LGTM. 762039 3 173050 webkit.review.bot 2012-11-08 12:08:32 -0800 Comment on attachment 173050 Patch Clearing flags on attachment: 173050 Committed r133928: <http://trac.webkit.org/changeset/133928> 762040 4 webkit.review.bot 2012-11-08 12:08:36 -0800 All reviewed patches have been landed. Closing bug. 173050 2012-11-08 08:35:46 -0800 2012-11-08 12:08:31 -0800 Patch bug-101610-20121108113348.patch text/plain 3052 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBlN2U2NTMyMWYzYzYyZDQ4MDYzZTVhN2M1YjRiNDhjNGFjYTFkMTVlLi5mZTdjNmMxNDhk YjIxZmZmMGI5YzVhZjE0NjUzN2JiYzNjOGUyZGY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMi0xMS0wNyAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBKYW5pdG9yOiBSZW1vdmUg dW51c2VkIG1faXNWYWxpZCBib29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDE2MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJdCdzIG5vdCB1c2VkIGFueXdoZXJlLCBidXQgYXMgd2UgaGF2ZSBhIGNv bnN0cnVjdG9yCisgICAgICAgIHRoYXQgY3JlYXRlcyBhbiBpbnZhbGlkIFRpbGVJbmRleCwgbGV0 J3MgYWRkIGFub3RoZXIKKyAgICAgICAgbWV0aG9kIHRvIGNoZWNrIHZhbGlkaXR5IC0gbm93IGEg Y29ycmVjdCBjaGVjay4KKworICAgICAgICBPbiB0b3Agb2YgdGhhdCwgbWFrZSB0aGUgc3R5bGVi b3QgaGFwcHkgYnkgcmVkdWNpbmcKKyAgICAgICAgInVuc2lnbmVkIGludCIgdG8ganVzdCAidW5z aWduZWQiLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9UaWxlSW5kZXguaDoKKyAgICAgICAg KEJsYWNrQmVycnk6OldlYktpdDo6VGlsZUluZGV4OjpUaWxlSW5kZXgpOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpUaWxlSW5kZXg6OmkpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2Vi S2l0OjpUaWxlSW5kZXg6OmopOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpUaWxlSW5k ZXg6OnNldEluZGV4KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6VGlsZUluZGV4Ojpp c1ZhbGlkKToKKyAgICAgICAgKFRpbGVJbmRleCk6CisKIDIwMTItMTEtMDggIEpha29iIFBldHNv dml0cyAgPGpwZXRzb3ZpdHNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gUmV3b3Jr IHRoZSBBUEkgdG8gdXNlIGRvY3VtZW50IGNvb3JkaW5hdGVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9UaWxlSW5kZXguaCBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RpbGVJbmRleC5oCmluZGV4IDMxNDk4NDdjOTFm MWUxNmYxODFkOGE1ZDE3ZjQ0ZTMzMmM3NGQ1YTcuLjUxZDVlZjEzNTY4MzQ4NzkwNmNmMWJmOGFl N2M4ZTJkZGM5Mjc1OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L1RpbGVJbmRleC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L1RpbGVJbmRleC5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAo QykgMjAwOSwgMjAxMCwgMjAxMSBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZC4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOSwgMjAxMCwgMjAxMSwgMjAxMiBSZXNl YXJjaCBJbiBNb3Rpb24gTGltaXRlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBUaGlz IGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29y CiAgKiBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwg UHVibGljCkBAIC0yNywyNSArMjcsMzAgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBjbGFzcyBUaWxl SW5kZXggewogcHVibGljOgogICAgIFRpbGVJbmRleCgpCi0gICAgICAgIDogbV9pKHN0ZDo6bnVt ZXJpY19saW1pdHM8dW5zaWduZWQgaW50Pjo6bWF4KCkpCi0gICAgICAgICwgbV9qKHN0ZDo6bnVt ZXJpY19saW1pdHM8dW5zaWduZWQgaW50Pjo6bWF4KCkpIHsgfQotICAgIFRpbGVJbmRleCh1bnNp Z25lZCBpbnQgaSwgdW5zaWduZWQgaW50IGopCisgICAgICAgIDogbV9pKHN0ZDo6bnVtZXJpY19s aW1pdHM8dW5zaWduZWQ+OjptYXgoKSkKKyAgICAgICAgLCBtX2ooc3RkOjpudW1lcmljX2xpbWl0 czx1bnNpZ25lZD46Om1heCgpKSB7IH0KKyAgICBUaWxlSW5kZXgodW5zaWduZWQgaSwgdW5zaWdu ZWQgaikKICAgICAgICAgOiBtX2koaSkKICAgICAgICAgLCBtX2ooaikgeyB9CiAgICAgflRpbGVJ bmRleCgpIHsgfQogCi0gICAgdW5zaWduZWQgaW50IGkoKSBjb25zdCB7IHJldHVybiBtX2k7IH0K LSAgICB1bnNpZ25lZCBpbnQgaigpIGNvbnN0IHsgcmV0dXJuIG1fajsgfQotICAgIHZvaWQgc2V0 SW5kZXgodW5zaWduZWQgaW50IGksIHVuc2lnbmVkIGludCBqKQorICAgIHVuc2lnbmVkIGkoKSBj b25zdCB7IHJldHVybiBtX2k7IH0KKyAgICB1bnNpZ25lZCBqKCkgY29uc3QgeyByZXR1cm4gbV9q OyB9CisgICAgdm9pZCBzZXRJbmRleCh1bnNpZ25lZCBpLCB1bnNpZ25lZCBqKQogICAgIHsKICAg ICAgICAgbV9pID0gaTsKICAgICAgICAgbV9qID0gajsKICAgICB9CiAKKyAgICBib29sIGlzVmFs aWQoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIG1faSAhPSBzdGQ6Om51bWVyaWNfbGlt aXRzPHVuc2lnbmVkPjo6bWF4KCkKKyAgICAgICAgICAgICYmIG1faiAhPSBzdGQ6Om51bWVyaWNf bGltaXRzPHVuc2lnbmVkPjo6bWF4KCk7CisgICAgfQorCiBwcml2YXRlOgotICAgIGJvb2wgbV9p c1ZhbGlkOwotICAgIHVuc2lnbmVkIGludCBtX2k7Ci0gICAgdW5zaWduZWQgaW50IG1fajsKKyAg ICB1bnNpZ25lZCBtX2k7CisgICAgdW5zaWduZWQgbV9qOwogfTsKIAogaW5saW5lIGJvb2wgb3Bl cmF0b3I9PShjb25zdCBCbGFja0JlcnJ5OjpXZWJLaXQ6OlRpbGVJbmRleCYgYSwgY29uc3QgQmxh Y2tCZXJyeTo6V2ViS2l0OjpUaWxlSW5kZXgmIGIpCg==