101607 2012-11-08 08:04:03 -0800 Web Inspector: stop using cursorCoords in CodeMirrorTextEditor 2012-11-08 22:46:59 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 janx janx apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 761809 0 janx 2012-11-08 08:04:03 -0800 In CodeMirror v3, the API changed, and the method instance.cursorCoords(start) doesn't return what we expect anymore. We should use instance.getCursor(start) instead. 761813 1 janx 2012-11-08 08:10:26 -0800 (In reply to comment #6 bug 99319) > (From update of attachment 173038 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173038&action=review > > > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:-57 > > - CodeMirror.on(this._codeMirror, "change", this._change.bind(this)); > > Why this was wrong? It seems to work for me. Using the global `CodeMirror.on(instance, event)` function C-style is not wrong, but I think that the `instance.on(event)` variant is less confusing. 761816 2 173048 janx 2012-11-08 08:15:19 -0800 Created attachment 173048 Patch 761877 3 173048 webkit.review.bot 2012-11-08 09:30:59 -0800 Comment on attachment 173048 Patch Rejecting attachment 173048 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14770257 761884 4 173058 janx 2012-11-08 09:35:05 -0800 Created attachment 173058 Patch 762589 5 173058 webkit.review.bot 2012-11-08 22:46:55 -0800 Comment on attachment 173058 Patch Clearing flags on attachment: 173058 Committed r134014: <http://trac.webkit.org/changeset/134014> 762590 6 webkit.review.bot 2012-11-08 22:46:59 -0800 All reviewed patches have been landed. Closing bug. 173048 2012-11-08 08:15:19 -0800 2012-11-08 09:34:54 -0800 Patch bug-101607-20121109001329.patch text/plain 2602 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U4ZTIyNTkwM2ViZDVl ODk3YWUyOGExNjM1MDA5NWRiZGM2ODc5OC4uYjhjNmY2MGFmMGJmOTkyNjMwMjdhNjdmYzBmOGU2 OGY2MjQwMTFmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTA4ICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBzdG9w IHVzaW5nIGN1cnNvckNvb3JkcyBpbiBDb2RlTWlycm9yVGV4dEVkaXRvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjA3CisKKyAgICAgICAgQVBJ IGNoYW5nZXMgY29tcGxldGluZyBtaWdyYXRpb24gdG8gdjMuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWly cm9yVGV4dEVkaXRvci5wcm90b3R5cGUucmV2ZWFsTGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuQ29kZU1pcnJvclRleHRFZGl0b3IucHJvdG90eXBlLnNlbGVjdGlvbik6CisKIDIwMTItMTEt MDggIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW5u ZWNlc3Nhcnkgc2F2ZS9yZXN0b3JlIGluIFNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0 RWRpdG9yLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9y VGV4dEVkaXRvci5qcwppbmRleCA3YWYzMDQ2NzliYzQwN2Y5ZTkwMjYwODgyMDEzZGRhYTgxNWEw MGQ1Li5mZjYxYmRiZjA0NzQzOTE3Yzc3MDU4ODMwNDk0MjZmM2Y2ZGQ5MWFiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9y LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRl eHRFZGl0b3IuanMKQEAgLTU0LDggKzU0LDkgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0 RWRpdG9yID0gZnVuY3Rpb24odXJsLCBkZWxlZ2F0ZSkKICAgICAgICAgbGluZU51bWJlcnM6IHRy dWUsCiAgICAgICAgIGd1dHRlcnM6IFsiQ29kZU1pcnJvci1saW5lbnVtYmVycyIsICJicmVha3Bv aW50cyJdCiAgICAgfSk7Ci0gICAgQ29kZU1pcnJvci5vbih0aGlzLl9jb2RlTWlycm9yLCAiY2hh bmdlIiwgdGhpcy5fY2hhbmdlLmJpbmQodGhpcykpOwotICAgIENvZGVNaXJyb3Iub24odGhpcy5f Y29kZU1pcnJvciwgImd1dHRlckNsaWNrIiwgdGhpcy5fZ3V0dGVyQ2xpY2suYmluZCh0aGlzKSk7 CisKKyAgICB0aGlzLl9jb2RlTWlycm9yLm9uKCJjaGFuZ2UiLCB0aGlzLl9jaGFuZ2UuYmluZCh0 aGlzKSk7CisgICAgdGhpcy5fY29kZU1pcnJvci5vbigiZ3V0dGVyQ2xpY2siLCB0aGlzLl9ndXR0 ZXJDbGljay5iaW5kKHRoaXMpKTsKIAogICAgIHRoaXMuX2xhc3RSYW5nZSA9IHRoaXMucmFuZ2Uo KTsKIApAQCAtMTE3LDggKzExOCw3IEBAIFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRv ci5wcm90b3R5cGUgPSB7CiAgICAgcmV2ZWFsTGluZTogZnVuY3Rpb24obGluZU51bWJlcikKICAg ICB7CiAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iuc2V0Q3Vyc29yKHsgbGluZTogbGluZU51bWJl ciwgY2g6IDAgfSk7Ci0gICAgICAgIHZhciBjb29yZHMgPSB0aGlzLl9jb2RlTWlycm9yLmN1cnNv ckNvb3JkcygpOwotICAgICAgICB0aGlzLl9jb2RlTWlycm9yLnNjcm9sbFRvKGNvb3Jkcy54LCBj b29yZHMueSk7CisgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iuc2Nyb2xsSW50b1ZpZXcoKTsKICAg ICB9LAogCiAgICAgX2d1dHRlckNsaWNrOiBmdW5jdGlvbihpbnN0YW5jZSwgbGluZU51bWJlciwg Z3V0dGVyLCBldmVudCkKQEAgLTI3Niw4ICsyNzYsOCBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJv clRleHRFZGl0b3IucHJvdG90eXBlID0gewogICAgICAqLwogICAgIHNlbGVjdGlvbjogZnVuY3Rp b24odGV4dFJhbmdlKQogICAgIHsKLSAgICAgICAgdmFyIHN0YXJ0ID0gdGhpcy5fY29kZU1pcnJv ci5jdXJzb3JDb29yZHModHJ1ZSk7Ci0gICAgICAgIHZhciBlbmQgPSB0aGlzLl9jb2RlTWlycm9y LmN1cnNvckNvb3JkcyhmYWxzZSk7CisgICAgICAgIHZhciBzdGFydCA9IHRoaXMuX2NvZGVNaXJy b3IuZ2V0Q3Vyc29yKHRydWUpOworICAgICAgICB2YXIgZW5kID0gdGhpcy5fY29kZU1pcnJvci5n ZXRDdXJzb3IoZmFsc2UpOwogCiAgICAgICAgIGlmIChzdGFydC5saW5lID4gZW5kLmxpbmUgfHwg KHN0YXJ0LmxpbmUgPT0gZW5kLmxpbmUgJiYgc3RhcnQuY2ggPiBlbmQuY2gpKQogICAgICAgICAg ICAgcmV0dXJuIHRoaXMuX3RvUmFuZ2UoZW5kLCBzdGFydCk7Cg== 173058 2012-11-08 09:35:05 -0800 2012-11-08 22:46:55 -0800 Patch bug-101607-20121109013313.patch text/plain 2641 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U4ZTIyNTkwM2ViZDVl ODk3YWUyOGExNjM1MDA5NWRiZGM2ODc5OC4uZTdmY2Y3ZGJlNGIxNWZjMWMzNGYyOTI2YmNjYjEz YzY0NTRjMDJhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA4ICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBzdG9w IHVzaW5nIGN1cnNvckNvb3JkcyBpbiBDb2RlTWlycm9yVGV4dEVkaXRvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVBJIGNoYW5nZXMgY29tcGxldGlu ZyBtaWdyYXRpb24gdG8gdjMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVN aXJyb3JUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0 RWRpdG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90 b3R5cGUucmV2ZWFsTGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRF ZGl0b3IucHJvdG90eXBlLnNlbGVjdGlvbik6CisKIDIwMTItMTEtMDggIFBoaWxpcCBSb2dlcnMg IDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkgc2F2ZS9yZXN0 b3JlIGluIFNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcwppbmRl eCA3YWYzMDQ2NzliYzQwN2Y5ZTkwMjYwODgyMDEzZGRhYTgxNWEwMGQ1Li5mZjYxYmRiZjA0NzQz OTE3Yzc3MDU4ODMwNDk0MjZmM2Y2ZGQ5MWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMKQEAgLTU0 LDggKzU0LDkgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yID0gZnVuY3Rpb24o dXJsLCBkZWxlZ2F0ZSkKICAgICAgICAgbGluZU51bWJlcnM6IHRydWUsCiAgICAgICAgIGd1dHRl cnM6IFsiQ29kZU1pcnJvci1saW5lbnVtYmVycyIsICJicmVha3BvaW50cyJdCiAgICAgfSk7Ci0g ICAgQ29kZU1pcnJvci5vbih0aGlzLl9jb2RlTWlycm9yLCAiY2hhbmdlIiwgdGhpcy5fY2hhbmdl LmJpbmQodGhpcykpOwotICAgIENvZGVNaXJyb3Iub24odGhpcy5fY29kZU1pcnJvciwgImd1dHRl ckNsaWNrIiwgdGhpcy5fZ3V0dGVyQ2xpY2suYmluZCh0aGlzKSk7CisKKyAgICB0aGlzLl9jb2Rl TWlycm9yLm9uKCJjaGFuZ2UiLCB0aGlzLl9jaGFuZ2UuYmluZCh0aGlzKSk7CisgICAgdGhpcy5f Y29kZU1pcnJvci5vbigiZ3V0dGVyQ2xpY2siLCB0aGlzLl9ndXR0ZXJDbGljay5iaW5kKHRoaXMp KTsKIAogICAgIHRoaXMuX2xhc3RSYW5nZSA9IHRoaXMucmFuZ2UoKTsKIApAQCAtMTE3LDggKzEx OCw3IEBAIFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90b3R5cGUgPSB7CiAg ICAgcmV2ZWFsTGluZTogZnVuY3Rpb24obGluZU51bWJlcikKICAgICB7CiAgICAgICAgIHRoaXMu X2NvZGVNaXJyb3Iuc2V0Q3Vyc29yKHsgbGluZTogbGluZU51bWJlciwgY2g6IDAgfSk7Ci0gICAg ICAgIHZhciBjb29yZHMgPSB0aGlzLl9jb2RlTWlycm9yLmN1cnNvckNvb3JkcygpOwotICAgICAg ICB0aGlzLl9jb2RlTWlycm9yLnNjcm9sbFRvKGNvb3Jkcy54LCBjb29yZHMueSk7CisgICAgICAg IHRoaXMuX2NvZGVNaXJyb3Iuc2Nyb2xsSW50b1ZpZXcoKTsKICAgICB9LAogCiAgICAgX2d1dHRl ckNsaWNrOiBmdW5jdGlvbihpbnN0YW5jZSwgbGluZU51bWJlciwgZ3V0dGVyLCBldmVudCkKQEAg LTI3Niw4ICsyNzYsOCBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0b3IucHJvdG90 eXBlID0gewogICAgICAqLwogICAgIHNlbGVjdGlvbjogZnVuY3Rpb24odGV4dFJhbmdlKQogICAg IHsKLSAgICAgICAgdmFyIHN0YXJ0ID0gdGhpcy5fY29kZU1pcnJvci5jdXJzb3JDb29yZHModHJ1 ZSk7Ci0gICAgICAgIHZhciBlbmQgPSB0aGlzLl9jb2RlTWlycm9yLmN1cnNvckNvb3JkcyhmYWxz ZSk7CisgICAgICAgIHZhciBzdGFydCA9IHRoaXMuX2NvZGVNaXJyb3IuZ2V0Q3Vyc29yKHRydWUp OworICAgICAgICB2YXIgZW5kID0gdGhpcy5fY29kZU1pcnJvci5nZXRDdXJzb3IoZmFsc2UpOwog CiAgICAgICAgIGlmIChzdGFydC5saW5lID4gZW5kLmxpbmUgfHwgKHN0YXJ0LmxpbmUgPT0gZW5k LmxpbmUgJiYgc3RhcnQuY2ggPiBlbmQuY2gpKQogICAgICAgICAgICAgcmV0dXJuIHRoaXMuX3Rv UmFuZ2UoZW5kLCBzdGFydCk7Cg==