101599 2012-11-08 06:49:45 -0800 [Qt] API test tst_qwebinspector crashes 2012-11-08 07:55:09 -0800 1 1 1 Unclassified WebKit WebKit Qt 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101595 1 allan.jensen allan.jensen hausmann jturcotte oldest_to_newest 761739 0 allan.jensen 2012-11-08 06:49:45 -0800 The test tst_qwebinspector crashes when it tries to detach an inspector that is internal only. Seems to be a compiler error, but the call-path is somewhat convoluted and cleaning it up fixes the bug. 761743 1 173035 allan.jensen 2012-11-08 06:56:40 -0800 Created attachment 173035 Patch 761775 2 allan.jensen 2012-11-08 07:33:21 -0800 Committed r133899: <http://trac.webkit.org/changeset/133899> 761778 3 jturcotte 2012-11-08 07:38:02 -0800 Sigh... bug #101575 761803 4 allan.jensen 2012-11-08 07:55:09 -0800 (In reply to comment #3) > Sigh... bug #101575 Ahh, great to see you figured out why the inspector reappeared after being deleted. Hopefully both patches will be useful and this is just a clean-up of the call-path then. 173035 2012-11-08 06:56:40 -0800 2012-11-08 07:21:07 -0800 Patch bug-101599-20121108155426.patch text/plain 6115 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDc3YzhkMTIwNTA5 NDYyZDk2MmM2OTY1ZWY2OWU2Njk2ZDk5ZTJiYmYuLmI2ZWYyMDdkNTgwZWU0OWU5NTEwYTVjZjc1 MGQwYjgxMWY1M2E5ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjYgQEAKIDIwMTItMTEt MDggIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CiAKKyAg ICAgICAgW1F0XSBBUEkgdGVzdCB0c3RfcXdlYmluc3BlY3RvciBjcmFzaGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE1OTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWxldGUgdGhlIGludGVybmFs IGluc3BlY3RvciBmcm9tIHF3ZWJwYWdlIGRlc3RydWN0b3IgdGhlIGluc3RlYWQgb2YgY2F1c2lu ZyByZWN1cnNpb25zCisgICAgICAgIGJldHdlZW4gUVdlYlBhZ2VQcml2YXRlOjpzZXRJbnNwZWN0 b3IgYW5kIFFXZWJJbnNwZWN0b3I6OnNldFBhZ2UuCisKKyAgICAgICAgQWxzbyBzZXBhcmF0ZSB0 aGUgdGhyZWUgdGVzdHMgaW4gdHN0X1FXZWJJbnNwZWN0b3IgdG8gYmV0dGVyIHRlbGwgd2hpY2gg b25lIGlzIGZhaWxpbmcuCisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAo UVdlYlBhZ2VQcml2YXRlOjp+UVdlYlBhZ2VQcml2YXRlKToKKyAgICAgICAgKFFXZWJQYWdlUHJp dmF0ZTo6c2V0SW5zcGVjdG9yKToKKyAgICAgICAgKiB0ZXN0cy9xd2ViaW5zcGVjdG9yL3RzdF9x d2ViaW5zcGVjdG9yLmNwcDoKKyAgICAgICAgKHRzdF9RV2ViSW5zcGVjdG9yKToKKyAgICAgICAg KHRzdF9RV2ViSW5zcGVjdG9yOjphdHRhY2hBbmREZXN0cm95UGFnZUZpcnN0KToKKyAgICAgICAg KHRzdF9RV2ViSW5zcGVjdG9yOjphdHRhY2hBbmREZXN0cm95SW5zcGVjdG9yRmlyc3QpOgorICAg ICAgICAodHN0X1FXZWJJbnNwZWN0b3I6OmF0dGFjaEFuZERlc3Ryb3lJbnRlcm5hbEluc3BlY3Rv cik6CisKKzIwMTItMTEtMDggIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBk aWdpYS5jb20+CisKICAgICAgICAgRGlzYW1iaWd1YXRlIGlubmVyRnJhbWVQb2ludCBhbmQgbWFp bkZyYW1lUG9pbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4MTM5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNw cCBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRleCA4MzkxYjFhOTdlNTIx MzM1ZjEyOTUxODY3NTMwOTc3MTVlNmMzOTEyLi4wMjM4M2FjNjc0MTU4NDkwNGQ4MmNhMGQ3ODJl Yzk2NzI4OWRlODg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCkBAIC0zNzgsMTEgKzM3 OCw2IEBAIFFXZWJQYWdlUHJpdmF0ZTo6UVdlYlBhZ2VQcml2YXRlKFFXZWJQYWdlICpxcSkKIAog UVdlYlBhZ2VQcml2YXRlOjp+UVdlYlBhZ2VQcml2YXRlKCkKIHsKLSAgICBpZiAoaW5zcGVjdG9y ICYmIGluc3BlY3RvcklzSW50ZXJuYWxPbmx5KSB7Ci0gICAgICAgIC8vIFNpbmNlIHdlIGhhdmUg dG8gZGVsZXRlIGFuIGludGVybmFsIGluc3BlY3RvciwKLSAgICAgICAgLy8gY2FsbCBzZXRJbnNw ZWN0b3IoMCkgZGlyZWN0bHkgdG8gcHJldmVudCBwb3RlbnRpYWwgY3Jhc2hlcwotICAgICAgICBz ZXRJbnNwZWN0b3IoMCk7Ci0gICAgfQogI2lmbmRlZiBRVF9OT19DT05URVhUTUVOVQogICAgIGRl bGV0ZSBjdXJyZW50Q29udGV4dE1lbnUuZGF0YSgpOwogI2VuZGlmCkBAIC0zOTIsOCArMzg3LDEz IEBAIFFXZWJQYWdlUHJpdmF0ZTo6flFXZWJQYWdlUHJpdmF0ZSgpCiAgICAgZGVsZXRlIHNldHRp bmdzOwogICAgIGRlbGV0ZSBwYWdlOwogICAgIAotICAgIGlmIChpbnNwZWN0b3IpCi0gICAgICAg IGluc3BlY3Rvci0+c2V0UGFnZSgwKTsKKyAgICBpZiAoaW5zcGVjdG9yKSB7CisgICAgICAgIC8v IElmIHRoZSBpbnNwZWN0b3IgaXMgb3VycywgZGVsZXRlIGl0LCBvdGhlcndpc2UganVzdCBkZXRh Y2ggZnJvbSBpdC4KKyAgICAgICAgaWYgKGluc3BlY3RvcklzSW50ZXJuYWxPbmx5KQorICAgICAg ICAgICAgZGVsZXRlIGluc3BlY3RvcjsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgaW5zcGVj dG9yLT5zZXRQYWdlKDApOworICAgIH0KIAogI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSB8fCBF TkFCTEUoTEVHQUNZX05PVElGSUNBVElPTlMpCiAgICAgTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xp ZW50UXQ6Om5vdGlmaWNhdGlvblByZXNlbnRlcigpLT5yZW1vdmVDbGllbnQoKTsKQEAgLTE0NjYs MTMgKzE0NjYsNiBAQCB2b2lkIFFXZWJQYWdlUHJpdmF0ZTo6c2V0SW5zcGVjdG9yKFFXZWJJbnNw ZWN0b3IqIGluc3ApCiAgICAgaWYgKGluc3BlY3RvcikKICAgICAgICAgaW5zcGVjdG9yLT5kLT5z ZXRGcm9udGVuZCgwKTsKIAotICAgIGlmIChpbnNwZWN0b3JJc0ludGVybmFsT25seSkgewotICAg ICAgICBRV2ViSW5zcGVjdG9yKiBpbnNwVG9EZWxldGUgPSBpbnNwZWN0b3I7Ci0gICAgICAgIGlu c3BlY3RvciA9IDA7Ci0gICAgICAgIGluc3BlY3RvcklzSW50ZXJuYWxPbmx5ID0gZmFsc2U7Ci0g ICAgICAgIGRlbGV0ZSBpbnNwVG9EZWxldGU7ICAgIC8vIERlbGV0ZSBhZnRlciB0byBwcmV2ZW50 IGluZmluaXRlIHJlY3Vyc2lvbgotICAgIH0KLQogICAgIGluc3BlY3RvciA9IGluc3A7CiAKICAg ICAvLyBHaXZlIGluc3BlY3RvciBmcm9udGVuZCB3ZWIgdmlldyBpZiBwcmV2aW91c2x5IGNyZWF0 ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmluc3BlY3Rvci90c3Rf cXdlYmluc3BlY3Rvci5jcHAgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJpbnNwZWN0b3Iv dHN0X3F3ZWJpbnNwZWN0b3IuY3BwCmluZGV4IDE4MWZkYWM0NTY4NGI0NTVmMjhhNTExZDM0NmY5 ZWE3YmVhY2ZkNGQuLjM3ZTYyZjY3Yjg0YWFjMjY3NjFjMmFjNDY5ZGI0NTllMDA0MzRlNzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYmluc3BlY3Rvci90c3RfcXdlYmlu c3BlY3Rvci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViaW5zcGVjdG9yL3Rz dF9xd2ViaW5zcGVjdG9yLmNwcApAQCAtMjgsMzkgKzI4LDQ2IEBAIGNsYXNzIHRzdF9RV2ViSW5z cGVjdG9yIDogcHVibGljIFFPYmplY3QgewogICAgIFFfT0JKRUNUCiAKIHByaXZhdGUgUV9TTE9U UzoKLSAgICB2b2lkIGF0dGFjaEFuZERlc3Ryb3koKTsKKyAgICB2b2lkIGF0dGFjaEFuZERlc3Ry b3lQYWdlRmlyc3QoKTsKKyAgICB2b2lkIGF0dGFjaEFuZERlc3Ryb3lJbnNwZWN0b3JGaXJzdCgp OworICAgIHZvaWQgYXR0YWNoQW5kRGVzdHJveUludGVybmFsSW5zcGVjdG9yKCk7CiB9OwogCi12 b2lkIHRzdF9RV2ViSW5zcGVjdG9yOjphdHRhY2hBbmREZXN0cm95KCkKK3ZvaWQgdHN0X1FXZWJJ bnNwZWN0b3I6OmF0dGFjaEFuZERlc3Ryb3lQYWdlRmlyc3QoKQogewotICAgIHsgICAvLyBFeHRl cm5hbCBpbnNwZWN0b3IgKyBtYW51YWwgZGVzdHJ1Y3Rpb24gb2YgcGFnZSBmaXJzdAotICAgICAg ICBRV2ViUGFnZSogcGFnZSA9IG5ldyBRV2ViUGFnZSgpOwotICAgICAgICBwYWdlLT5zZXR0aW5n cygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpEZXZlbG9wZXJFeHRyYXNFbmFibGVkLCB0 cnVlKTsKLSAgICAgICAgUVdlYkluc3BlY3RvciogaW5zcGVjdG9yID0gbmV3IFFXZWJJbnNwZWN0 b3IoKTsKLSAgICAgICAgaW5zcGVjdG9yLT5zZXRQYWdlKHBhZ2UpOwotICAgICAgICBwYWdlLT51 cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFjdGlvbnMoUVBvaW50KDAsIDApKTsKLSAgICAgICAgcGFn ZS0+dHJpZ2dlckFjdGlvbihRV2ViUGFnZTo6SW5zcGVjdEVsZW1lbnQpOworICAgIC8vIEV4dGVy bmFsIGluc3BlY3RvciArIG1hbnVhbCBkZXN0cnVjdGlvbiBvZiBwYWdlIGZpcnN0CisgICAgUVdl YlBhZ2UqIHBhZ2UgPSBuZXcgUVdlYlBhZ2UoKTsKKyAgICBwYWdlLT5zZXR0aW5ncygpLT5zZXRB dHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpEZXZlbG9wZXJFeHRyYXNFbmFibGVkLCB0cnVlKTsKKyAg ICBRV2ViSW5zcGVjdG9yKiBpbnNwZWN0b3IgPSBuZXcgUVdlYkluc3BlY3RvcigpOworICAgIGlu c3BlY3Rvci0+c2V0UGFnZShwYWdlKTsKKyAgICBwYWdlLT51cGRhdGVQb3NpdGlvbkRlcGVuZGVu dEFjdGlvbnMoUVBvaW50KDAsIDApKTsKKyAgICBwYWdlLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdl OjpJbnNwZWN0RWxlbWVudCk7CiAKLSAgICAgICAgZGVsZXRlIHBhZ2U7Ci0gICAgICAgIGRlbGV0 ZSBpbnNwZWN0b3I7Ci0gICAgfQotICAgIHsgICAvLyBFeHRlcm5hbCBpbnNwZWN0b3IgKyBtYW51 YWwgZGVzdHJ1Y3Rpb24gb2YgaW5zcGVjdG9yIGZpcnN0Ci0gICAgICAgIFFXZWJQYWdlKiBwYWdl ID0gbmV3IFFXZWJQYWdlKCk7Ci0gICAgICAgIHBhZ2UtPnNldHRpbmdzKCktPnNldEF0dHJpYnV0 ZShRV2ViU2V0dGluZ3M6OkRldmVsb3BlckV4dHJhc0VuYWJsZWQsIHRydWUpOwotICAgICAgICBR V2ViSW5zcGVjdG9yKiBpbnNwZWN0b3IgPSBuZXcgUVdlYkluc3BlY3RvcigpOwotICAgICAgICBp bnNwZWN0b3ItPnNldFBhZ2UocGFnZSk7Ci0gICAgICAgIHBhZ2UtPnVwZGF0ZVBvc2l0aW9uRGVw ZW5kZW50QWN0aW9ucyhRUG9pbnQoMCwgMCkpOwotICAgICAgICBwYWdlLT50cmlnZ2VyQWN0aW9u KFFXZWJQYWdlOjpJbnNwZWN0RWxlbWVudCk7CisgICAgZGVsZXRlIHBhZ2U7CisgICAgZGVsZXRl IGluc3BlY3RvcjsKK30KKwordm9pZCB0c3RfUVdlYkluc3BlY3Rvcjo6YXR0YWNoQW5kRGVzdHJv eUluc3BlY3RvckZpcnN0KCkKK3sKKyAgICAvLyBFeHRlcm5hbCBpbnNwZWN0b3IgKyBtYW51YWwg ZGVzdHJ1Y3Rpb24gb2YgaW5zcGVjdG9yIGZpcnN0CisgICAgUVdlYlBhZ2UqIHBhZ2UgPSBuZXcg UVdlYlBhZ2UoKTsKKyAgICBwYWdlLT5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRp bmdzOjpEZXZlbG9wZXJFeHRyYXNFbmFibGVkLCB0cnVlKTsKKyAgICBRV2ViSW5zcGVjdG9yKiBp bnNwZWN0b3IgPSBuZXcgUVdlYkluc3BlY3RvcigpOworICAgIGluc3BlY3Rvci0+c2V0UGFnZShw YWdlKTsKKyAgICBwYWdlLT51cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFjdGlvbnMoUVBvaW50KDAs IDApKTsKKyAgICBwYWdlLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpJbnNwZWN0RWxlbWVudCk7 CiAKLSAgICAgICAgZGVsZXRlIGluc3BlY3RvcjsKLSAgICAgICAgZGVsZXRlIHBhZ2U7Ci0gICAg fQotICAgIHsgICAvLyBJbnRlcm5hbCBpbnNwZWN0b3IKLSAgICAgICAgUVdlYlBhZ2UgcGFnZTsK LSAgICAgICAgcGFnZS5zZXR0aW5ncygpLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpEZXZl bG9wZXJFeHRyYXNFbmFibGVkLCB0cnVlKTsKLSAgICAgICAgcGFnZS51cGRhdGVQb3NpdGlvbkRl cGVuZGVudEFjdGlvbnMoUVBvaW50KDAsIDApKTsKLSAgICAgICAgcGFnZS50cmlnZ2VyQWN0aW9u KFFXZWJQYWdlOjpJbnNwZWN0RWxlbWVudCk7Ci0gICAgfQorICAgIGRlbGV0ZSBpbnNwZWN0b3I7 CisgICAgZGVsZXRlIHBhZ2U7Cit9CisKK3ZvaWQgdHN0X1FXZWJJbnNwZWN0b3I6OmF0dGFjaEFu ZERlc3Ryb3lJbnRlcm5hbEluc3BlY3RvcigpCit7CisgICAgLy8gSW50ZXJuYWwgaW5zcGVjdG9y CisgICAgUVdlYlBhZ2UgcGFnZTsKKyAgICBwYWdlLnNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShR V2ViU2V0dGluZ3M6OkRldmVsb3BlckV4dHJhc0VuYWJsZWQsIHRydWUpOworICAgIHBhZ2UudXBk YXRlUG9zaXRpb25EZXBlbmRlbnRBY3Rpb25zKFFQb2ludCgwLCAwKSk7CisgICAgcGFnZS50cmln Z2VyQWN0aW9uKFFXZWJQYWdlOjpJbnNwZWN0RWxlbWVudCk7CiB9CiAKIFFURVNUX01BSU4odHN0 X1FXZWJJbnNwZWN0b3IpCg==