101595 2012-11-08 06:00:03 -0800 Regression(r107593) Crash in ContextMenuController::addInspectElementItem() 2012-11-09 03:29:02 -0800 1 1 1 Unclassified WebKit WebKit Qt 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101599 1 allan.jensen allan.jensen bweinstein hausmann jturcotte timothy webkit.review.bot oldest_to_newest 761707 0 allan.jensen 2012-11-08 06:00:03 -0800 ContextMenuController::addInspectElementItem will if the contextMenu has been cleared first try to access it anyway causing a nullpoint access. This crashes tst_qwebinspector 761712 1 173026 allan.jensen 2012-11-08 06:02:28 -0800 Created attachment 173026 Patch 761789 2 jturcotte 2012-11-08 07:42:58 -0800 *** Bug 101574 has been marked as a duplicate of this bug. *** 761794 3 jturcotte 2012-11-08 07:44:57 -0800 I have most of the WebKit1 tests fixed except 1 WebGL test and 1 QWebElement test still failing. I'm in the process of uploading the work so please tell me if you want to pick anything to avoid duplicate efforts. 761812 4 allan.jensen 2012-11-08 08:09:55 -0800 (In reply to comment #3) > I have most of the WebKit1 tests fixed except 1 WebGL test and 1 QWebElement test still failing. I'm in the process of uploading the work so please tell me if you want to pick anything to avoid duplicate efforts. Sorry about that, great minds think alike, I guess. I was actually coming from this because I was fixing the API tests failing in QtWebKit2.3, I will now stick to those that only fail there then. 761819 5 jturcotte 2012-11-08 08:16:47 -0800 (In reply to comment #4) > (In reply to comment #3) > > I have most of the WebKit1 tests fixed except 1 WebGL test and 1 QWebElement test still failing. I'm in the process of uploading the work so please tell me if you want to pick anything to avoid duplicate efforts. > > Sorry about that, great minds think alike, I guess. I was actually coming from this because I was fixing the API tests failing in QtWebKit2.3, I will now stick to those that only fail there then. Most of them probably apply to trunk as well. If you can wait 2-3 days until you can see the rest of what I have it would be nice. Those tests have been failing for more than 1 year after all. 761826 6 allan.jensen 2012-11-08 08:33:40 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > I have most of the WebKit1 tests fixed except 1 WebGL test and 1 QWebElement test still failing. I'm in the process of uploading the work so please tell me if you want to pick anything to avoid duplicate efforts. > > > > Sorry about that, great minds think alike, I guess. I was actually coming from this because I was fixing the API tests failing in QtWebKit2.3, I will now stick to those that only fail there then. > > Most of them probably apply to trunk as well. If you can wait 2-3 days until you can see the rest of what I have it would be nice. Those tests have been failing for more than 1 year after all. Will do. 761901 7 173026 webkit.review.bot 2012-11-08 10:04:52 -0800 Comment on attachment 173026 Patch Rejecting attachment 173026 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: re/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Unreviewed chromium mac rebaseline for r101497. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14770266 762797 8 allan.jensen 2012-11-09 03:29:02 -0800 Committed r134044: <http://trac.webkit.org/changeset/134044> 173026 2012-11-08 06:02:28 -0800 2012-11-08 10:04:52 -0800 Patch bug-101595-20121108150014.patch text/plain 1797 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA4NTYwYWZhMzQ0YmQ0 MTYyZDg1YjBmZDk5ODRkMTFlM2RiNDY0Ni4uYWYxZDhiMjAzZGU0OTU5NDAwYjI2YjFiNzQ4YTVk YTg1NGQ0N2Y5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTExLTA4ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIFJl Z3Jlc3Npb24ocjEwNzU5MykgQ3Jhc2ggaW4gQ29udGV4dE1lbnVDb250cm9sbGVyOjphZGRJbnNw ZWN0RWxlbWVudEl0ZW0oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxNTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSWYgdGhlIGNvbnRleHRNZW51IGlzIGEgbnVsbCBwb2ludGVyIHRyZWF0IGl0IGFz IGVtcHR5LCBhcHBlbmRJdGVtIHdpbGwgbGF0ZXIKKyAgICAgICAgY3JlYXRlIGl0IGlmIG5lY2Vz c2FyeS4KKworICAgICAgICAqIHBhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNvbnRleHRNZW51Q29udHJvbGxlcjo6YWRkSW5zcGVjdEVsZW1lbnRJdGVt KToKKworMjAxMi0xMS0wOCAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRp Z2lhLmNvbT4KKwogICAgICAgICBEaXNhbWJpZ3VhdGUgaW5uZXJGcmFtZVBvaW50IGFuZCBtYWlu RnJhbWVQb2ludAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTgxMzkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNv bnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIu Y3BwCmluZGV4IDc0Yzg1ODM1ZmJlMGQ5N2QzYmEyZDdmZTQ3ZDQ4ZGM3MDljYTczNTIuLjc5Nzk3 MWQwZjU2Yzk1MjRlMDI0NDhjZmRkYzRiOWU1ZWRmYTE2OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvQ29udGV4dE1lbnVDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0NvbnRleHRNZW51Q29udHJvbGxlci5jcHAKQEAgLTEwOTksOSArMTA5OSw5IEBAIHZv aWQgQ29udGV4dE1lbnVDb250cm9sbGVyOjphZGRJbnNwZWN0RWxlbWVudEl0ZW0oKQogCiAgICAg Q29udGV4dE1lbnVJdGVtIEluc3BlY3RFbGVtZW50SXRlbShBY3Rpb25UeXBlLCBDb250ZXh0TWVu dUl0ZW1UYWdJbnNwZWN0RWxlbWVudCwgY29udGV4dE1lbnVJdGVtVGFnSW5zcGVjdEVsZW1lbnQo KSk7CiAjaWYgVVNFKENST1NTX1BMQVRGT1JNX0NPTlRFWFRfTUVOVVMpCi0gICAgaWYgKCFtX2Nv bnRleHRNZW51LT5pdGVtcygpLmlzRW1wdHkoKSkKKyAgICBpZiAobV9jb250ZXh0TWVudSAmJiAh bV9jb250ZXh0TWVudS0+aXRlbXMoKS5pc0VtcHR5KCkpCiAjZWxzZQotICAgIGlmIChtX2NvbnRl eHRNZW51LT5pdGVtQ291bnQoKSkKKyAgICBpZiAobV9jb250ZXh0TWVudSAmJiBtX2NvbnRleHRN ZW51LT5pdGVtQ291bnQoKSkKICNlbmRpZgogICAgICAgICBhcHBlbmRJdGVtKCpzZXBhcmF0b3JJ dGVtKCksIG1fY29udGV4dE1lbnUuZ2V0KCkpOwogICAgIGFwcGVuZEl0ZW0oSW5zcGVjdEVsZW1l bnRJdGVtLCBtX2NvbnRleHRNZW51LmdldCgpKTsK