10159 2006-07-30 06:09:27 -0700 REGRESSION: delegate returning no menu elements crashes webkit 2006-07-31 20:48:14 -0700 1 1 1 Unclassified WebKit WebKit API 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix, Regression P1 Normal --- 1 duncan webkit-unassigned oldest_to_newest 51140 0 duncan 2006-07-30 06:09:27 -0700 svn r14845 has a fix for <rdar://problem/4498606> REGRESSION (417.8-420+): 3 missing items (but extra separators) in context menu in Mail message body However if the context menu delegate returns no items, as in: - (NSArray *)webView:(WebView *)sender contextMenuItemsForElement:(NSDictionary *)element defaultMenuItems:(NSArray *)defaultMenuItems { return [NSArray array]; } the patch above crashes because it doesn't check for zero menu items. The fix is trivial, attaching the patch. 51141 1 9762 duncan 2006-07-30 06:11:41 -0700 Created attachment 9762 Patch 51146 2 9762 darin 2006-07-30 09:27:41 -0700 Comment on attachment 9762 Patch Change looks great. Needs a test case and a change log entry. 51179 3 9769 duncan 2006-07-31 00:35:12 -0700 Created attachment 9769 Patch with changelog No automated test, because there's no way to programmatically open a context menu, no manual test because there's no way to customize the context menu delegate. 51186 4 9769 darin 2006-07-31 01:40:53 -0700 Comment on attachment 9769 Patch with changelog r=me 51268 5 timothy 2006-07-31 20:48:14 -0700 Landed in r15726. 9762 2006-07-30 06:11:41 -0700 2006-07-31 00:35:12 -0700 Patch patch.txt text/plain 1042 duncan SW5kZXg6IFdlYlZpZXcvV2ViVmlldy5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYlZpZXcvV2ViVmlldy5t ICAgKHJldmlzaW9uIDE1Njk5KQorKysgV2ViVmlldy9XZWJWaWV3Lm0gICAod29ya2luZyBjb3B5 KQpAQCAtNzIxLDcgKzcyMSw3IEBACiAgICAgICAgICAgICAvLyBpdGVtcy4gVGhpcyBzaG91bGRu J3QgYWZmZWN0IGFueSBjbGllbnRzIG90aGVyIHRoYW4gTWFpbCBzaW5jZSB0aGUgdGFncyBmb3Ig dGhlIHRocmVlIGl0ZW1zCiAgICAgICAgICAgICAvLyB3ZXJlIG5vdCBwdWJsaWMgQVBJLiBXZSBj YW4gcmVtb3ZlIHRoaXMgY29kZSB3aGVuIHdlIG5vIGxvbmdlciBzdXBwb3J0IHByZXZpb3VzbHkt YnVpbHQgdmVyc2lvbnMKICAgICAgICAgICAgIC8vIG9mIE1haWwgb24gVGlnZXIuIFNlZSA0NDk4 NjA2IGZvciBtb3JlIGRldGFpbHMuCi0gICAgICAgICAgICBpZiAoKFtbZGVmYXVsdE1lbnVJdGVt cyBvYmplY3RBdEluZGV4OjBdIHRhZ10gPT0gV2ViTWVudUl0ZW1UYWdTZWFyY2hJblNwb3RsaWdo dCkgJiYgKFtbbWVudUl0ZW1zIG9iamVjdEF0SW5kZXg6MF0gaXNTZXBhcmF0b3JJdGVtXSkpIHsK KyAgICAgICAgICAgIGlmIChbbWVudUl0ZW1zIGNvdW50XSAmJiAoW1tkZWZhdWx0TWVudUl0ZW1z IG9iamVjdEF0SW5kZXg6MF0gdGFnXSA9PSBXZWJNZW51SXRlbVRhZ1NlYXJjaEluU3BvdGxpZ2h0 KSAmJiAoW1ttZW51SXRlbXMgb2JqZWN0QXRJbmRleDowXSBpc1NlcGFyYXRvckl0ZW1dKSkgewog ICAgICAgICAgICAgICAgIEFTU0VSVChbW21lbnVJdGVtcyBvYmplY3RBdEluZGV4OjFdIGlzU2Vw YXJhdG9ySXRlbV0pOwogICAgICAgICAgICAgICAgIEFTU0VSVChbW2RlZmF1bHRNZW51SXRlbXMg b2JqZWN0QXRJbmRleDoxXSB0YWddID09IFdlYk1lbnVJdGVtVGFnU2VhcmNoV2ViKTsKICAgICAg ICAgICAgICAgICBBU1NFUlQoW1tkZWZhdWx0TWVudUl0ZW1zIG9iamVjdEF0SW5kZXg6Ml0gaXNT ZXBhcmF0b3JJdGVtXSk7Cg== 9769 2006-07-31 00:35:12 -0700 2006-07-31 01:40:53 -0700 Patch with changelog patch.txt text/plain 1873 duncan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzA1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDYtMDct MzEgIER1bmNhbiBXaWxjb3ggIDxkdW5jYW5AbWNsaW5rLml0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIDxodHRwOi8vYnVnemlsbGEub3Bl bmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU5PgorICAgICAgICAiUkVHUkVTU0lPTjog ZGVsZWdhdGUgcmV0dXJuaW5nIG5vIG1lbnUgZWxlbWVudHMgY3Jhc2hlcyB3ZWJraXQiCisKKyAg ICAgICAgTm8gYXV0b21hdGVkIHRlc3QsIGJlY2F1c2UgdGhlcmUncyBubyB3YXkgdG8gcHJvZ3Jh bW1hdGljYWxseSBvcGVuIGEgY29udGV4dCBtZW51LAorICAgICAgICBubyBtYW51YWwgdGVzdCBi ZWNhdXNlIHRoZXJlJ3Mgbm8gd2F5IHRvIGN1c3RvbWl6ZSB0aGUgY29udGV4dCBtZW51IGRlbGVn YXRlLgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm06CisgICAgICAgICgtW1dlYlZpZXcg X21lbnVGb3JFbGVtZW50OmRlZmF1bHRJdGVtczpdKTogTWFrZSBzdXJlIHRoZSBjb250ZXh0IG1l bnUgcmV0dXJuZWQKKyAgICAgICAgc29tZSBtZW51IGl0ZW1zIGJlZm9yZSBhY2Nlc3NpbmcgdGhl IGZpcnN0IG9uZS4KKwogMjAwNi0wNy0zMCAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhhdGNoZXIuCkluZGV4OiBXZWJWaWV3L1dlYlZp ZXcubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJWaWV3L1dlYlZpZXcubQkocmV2aXNpb24gMTU2OTkpCisr KyBXZWJWaWV3L1dlYlZpZXcubQkod29ya2luZyBjb3B5KQpAQCAtNzIxLDcgKzcyMSw3IEBACiAg ICAgICAgICAgICAvLyBpdGVtcy4gVGhpcyBzaG91bGRuJ3QgYWZmZWN0IGFueSBjbGllbnRzIG90 aGVyIHRoYW4gTWFpbCBzaW5jZSB0aGUgdGFncyBmb3IgdGhlIHRocmVlIGl0ZW1zCiAgICAgICAg ICAgICAvLyB3ZXJlIG5vdCBwdWJsaWMgQVBJLiBXZSBjYW4gcmVtb3ZlIHRoaXMgY29kZSB3aGVu IHdlIG5vIGxvbmdlciBzdXBwb3J0IHByZXZpb3VzbHktYnVpbHQgdmVyc2lvbnMKICAgICAgICAg ICAgIC8vIG9mIE1haWwgb24gVGlnZXIuIFNlZSA0NDk4NjA2IGZvciBtb3JlIGRldGFpbHMuCi0g ICAgICAgICAgICBpZiAoKFtbZGVmYXVsdE1lbnVJdGVtcyBvYmplY3RBdEluZGV4OjBdIHRhZ10g PT0gV2ViTWVudUl0ZW1UYWdTZWFyY2hJblNwb3RsaWdodCkgJiYgKFtbbWVudUl0ZW1zIG9iamVj dEF0SW5kZXg6MF0gaXNTZXBhcmF0b3JJdGVtXSkpIHsKKyAgICAgICAgICAgIGlmIChbbWVudUl0 ZW1zIGNvdW50XSAmJiAoW1tkZWZhdWx0TWVudUl0ZW1zIG9iamVjdEF0SW5kZXg6MF0gdGFnXSA9 PSBXZWJNZW51SXRlbVRhZ1NlYXJjaEluU3BvdGxpZ2h0KSAmJiAoW1ttZW51SXRlbXMgb2JqZWN0 QXRJbmRleDowXSBpc1NlcGFyYXRvckl0ZW1dKSkgewogICAgICAgICAgICAgICAgIEFTU0VSVChb W21lbnVJdGVtcyBvYmplY3RBdEluZGV4OjFdIGlzU2VwYXJhdG9ySXRlbV0pOwogICAgICAgICAg ICAgICAgIEFTU0VSVChbW2RlZmF1bHRNZW51SXRlbXMgb2JqZWN0QXRJbmRleDoxXSB0YWddID09 IFdlYk1lbnVJdGVtVGFnU2VhcmNoV2ViKTsKICAgICAgICAgICAgICAgICBBU1NFUlQoW1tkZWZh dWx0TWVudUl0ZW1zIG9iamVjdEF0SW5kZXg6Ml0gaXNTZXBhcmF0b3JJdGVtXSk7Cg==