101586 2012-11-08 04:37:32 -0800 MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop 2012-11-12 00:32:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw abarth eric.carlson feature-media-reviews hta webkit.review.bot oldest_to_newest 761643 0 tommyw 2012-11-08 04:37:32 -0800 MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop 761653 1 173013 tommyw 2012-11-08 04:44:01 -0800 Created attachment 173013 Patch 761661 2 tommyw 2012-11-08 04:50:54 -0800 Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new API some WebCore objects might be cleaned away which is not allowed at this stage. 763183 3 173013 abarth 2012-11-09 11:19:17 -0800 Comment on attachment 173013 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173013&action=review > Source/WebCore/ChangeLog:12 > + This behaviour is not possible to test unfortunately in webkit. Do we have tests in Chromium to cover this issue? 763200 4 173013 webkit.review.bot 2012-11-09 11:39:31 -0800 Comment on attachment 173013 Patch Clearing flags on attachment: 173013 Committed r134093: <http://trac.webkit.org/changeset/134093> 763201 5 webkit.review.bot 2012-11-09 11:39:34 -0800 All reviewed patches have been landed. Closing bug. 764128 6 173013 tommyw 2012-11-12 00:32:37 -0800 Comment on attachment 173013 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173013&action=review >> Source/WebCore/ChangeLog:12 >> + This behaviour is not possible to test unfortunately in webkit. > > Do we have tests in Chromium to cover this issue? No, but we (the WebRTC team) have our own bots that run pyautotests and some fuzzer tests. Our SETs is working on having these tests integrated into the main chromium tree. 173013 2012-11-08 04:44:01 -0800 2012-11-12 00:32:37 -0800 Patch bug-101586-20121108134210.patch text/plain 1761 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTVjZmIwYTFlODQzOGYz ODk3ZTYyMzEwOThjYmYwZWE2ZDI0YmM3OC4uZGVlYjFhMDAxYjZjMjdiNzc4NjJhY2UxMzE5ZWVm YTIxYTk1NDJiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTA4ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogRG9uJ3QgdHJpZ2dlciBhbnkgb2JqZWN0IGRlbGV0aW9uIGR1cmluZyBSVENQZWVyQ29u bmVjdGlvbjo6c3RvcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAxNTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU3RvcCBjYWxsaW5nIHN0b3Agb24gdGhlIFJUQ1BlZXJDb25uZWN0aW9uSGFuZGxlciwg YW5kIGRvbid0IGRlbGV0ZSBpdCwgd2hlbgorICAgICAgICBBY3RpdmVET01PYmplY3Q6OnN0b3Ag aXMgY2FsbGVkIG9uIFJUQ1BlZXJDb25uZWN0aW9uLiBEdWUgdG8gdGhlIGFzeW5jIG5hdHVyZSBv ZiB0aGUgbmV3CisgICAgICAgIEFQSSBzb21lIFdlYkNvcmUgb2JqZWN0cyBtaWdodCBiZSBjbGVh bmVkIGF3YXkgd2hpY2ggaXMgbm90IGFsbG93ZWQgYXQgdGhpcyBzdGFnZS4KKworICAgICAgICBU aGlzIGJlaGF2aW91ciBpcyBub3QgcG9zc2libGUgdG8gdGVzdCB1bmZvcnR1bmF0ZWx5IGluIHdl YmtpdC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OnN0b3ApOgorCiAyMDEy LTExLTA3ICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZW1vdmUgc3VwcG9ydCBmb3IgImRlc2t0b3Atd2lkdGgiIGluIHRoZSB2aWV3 cG9ydCBtZXRhIHRhZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0 cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNwcAppbmRleCA0NjEyZTFmYzgxYTQ0ZGU3MjAzYWQ4 Y2YwMGM2MmY1ZGFhYmRlOWY3Li5iNzgxYmJkZmYxMWRjYmMxY2JmMTg0NTM0YTc1ZmRlZmUwZDY3 NmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1Bl ZXJDb25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L1JUQ1BlZXJDb25uZWN0aW9uLmNwcApAQCAtNTIzLDExICs1MjMsNiBAQCBTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBSVENQZWVyQ29ubmVjdGlvbjo6c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpIGNv bnN0CiAKIHZvaWQgUlRDUGVlckNvbm5lY3Rpb246OnN0b3AoKQogewotICAgIGlmIChtX3JlYWR5 U3RhdGUgIT0gUmVhZHlTdGF0ZUNsb3NlZCkKLSAgICAgICAgbV9wZWVySGFuZGxlci0+c3RvcCgp OwotCi0gICAgbV9wZWVySGFuZGxlci5jbGVhcigpOwotCiAgICAgbV9pY2VTdGF0ZSA9IEljZVN0 YXRlQ2xvc2VkOwogICAgIG1fcmVhZHlTdGF0ZSA9IFJlYWR5U3RhdGVDbG9zZWQ7CiAK