<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>101581</bug_id>
          
          <creation_ts>2012-11-08 03:33:43 -0800</creation_ts>
          <short_desc>[GTK] Do not use &apos;ls&apos; to list IDL files in EXTRA_DIST</short_desc>
          <delta_ts>2012-11-09 09:10:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Xan Lopez">xan.lopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>761587</commentid>
    <comment_count>0</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2012-11-08 03:33:43 -0800</bug_when>
    <thetext>There&apos;s really no need to do so, and it will fail in a noisy way when a file is not present:

ls: cannot access ../../Source/WebCore/editing/*.idl: No such file or directory

Instead just use normal wildcards with $(wildcard). Patch attached, verified that make dist still works with it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>761592</commentid>
    <comment_count>1</comment_count>
      <attachid>172993</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2012-11-08 03:36:39 -0800</bug_when>
    <thetext>Created attachment 172993
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763045</commentid>
    <comment_count>2</comment_count>
      <attachid>172993</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2012-11-09 08:45:22 -0800</bug_when>
    <thetext>Comment on attachment 172993
Patch

Okay. It&apos;s also a good idea to remove the editing directory from the list. The warning usually indicates the files were moved and the directory now shouldn&apos;t be listed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763065</commentid>
    <comment_count>3</comment_count>
      <attachid>172993</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2012-11-09 09:10:02 -0800</bug_when>
    <thetext>Comment on attachment 172993
Patch

Pushed with the requested changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>763066</commentid>
    <comment_count>4</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2012-11-09 09:10:09 -0800</bug_when>
    <thetext>Closing.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>172993</attachid>
            <date>2012-11-08 03:36:39 -0800</date>
            <delta_ts>2012-11-09 09:10:02 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>wildcard.diff</filename>
            <type>text/plain</type>
            <size>5263</size>
            <attacher name="Xan Lopez">xan.lopez</attacher>
            
              <data encoding="base64">RnJvbSA1YWEzZGZkNTQzZmJlYjZkMzMzZTJiYTkyZDI4MDM0NjE2MTEwMDg3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBpZ2FsaWEuY29tPgpEYXRlOiBUaHUs
IDggTm92IDIwMTIgMTI6MzM6MzQgKzAxMDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTExLTA4ICBY
YW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KCiAgICAgICAgW0dUS10gRG8gbm90IHVzZSAn
bHMnIHRvIGxpc3QgSURMIGZpbGVzIGluIEVYVFJBX0RJU1QKICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNTgxCgogICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgoKICAgICAgICBVc2Ugbm9ybWFsIEdOVSBNYWtlIHdpbGRjYXJkcyBpbnN0
ZWFkIG9mICdscycgdG8gbGlzdCBmaWxlcyBpbgogICAgICAgIEVYVFJBX0RJU1QsIGl0J3Mgc2Fm
ZXIgYW5kIG1vcmUgc3RyYWlnaHRmb3J3YXJkLgoKICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiBk
aXR0by4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICB8ICAgMTIgKysrKysrKysK
IFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtIHwgICA1OCArKysrKysrKysrKysrKysrKysr
Ky0tLS0tLS0tLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyks
IDI5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi
L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkZTE5YTlmLi45NTZkYmEwIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTEtMDggIFhhbiBMb3BleiAgPHhsb3BlekBpZ2Fs
aWEuY29tPgorCisgICAgICAgIFtHVEtdIERvIG5vdCB1c2UgJ2xzJyB0byBsaXN0IElETCBmaWxl
cyBpbiBFWFRSQV9ESVNUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xMDE1ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBVc2Ugbm9ybWFsIEdOVSBNYWtlIHdpbGRjYXJkcyBpbnN0ZWFkIG9mICdscycgdG8g
bGlzdCBmaWxlcyBpbgorICAgICAgICBFWFRSQV9ESVNULCBpdCdzIHNhZmVyIGFuZCBtb3JlIHN0
cmFpZ2h0Zm9yd2FyZC4KKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiBkaXR0by4KKwogMjAx
Mi0xMS0wOCAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdhcm4g
d2hlbiBwYXJzaW5nIGFuIGludmFsaWQgWC1GcmFtZS1PcHRpb25zIGhlYWRlci4KZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYkNvcmUvR05VbWFr
ZWZpbGUuYW0KaW5kZXggZTY2YmYwNS4uYjA1OGMzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KQEAg
LTcxOCwzNSArNzE4LDM1IEBAIGxpYldlYkNvcmVHdGtfbGFfQ1BQRkxBR1MgPSBcCiAJJChYVF9D
RkxBR1MpCiAKIEVYVFJBX0RJU1QgKz0gXAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9X
ZWJDb3JlL01vZHVsZXMvZmlsZXN5c3RlbS8qLmlkbCkgXAotCSQoc2hlbGwgbHMgJChzcmNkaXIp
L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2FtZXBhZC8qLmlkbCkgXAotCSQoc2hlbGwgbHMgJChz
cmNkaXIpL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vKi5pZGwpIFwKLQkkKHNo
ZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi8qLmlkbCkg
XAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3Vy
Y2UvKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz
L21lZGlhc3RyZWFtLyouaWRsKSBcCi0JJChzaGVsbCBscyAkKHNyY2RpcikvU291cmNlL1dlYkNv
cmUvTW9kdWxlcy9uYXZpZ2F0b3Jjb250ZW50dXRpbHMvKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQo
c3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvKi5pZGwpIFwKLQkk
KHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3F1b3RhLyouaWRsKSBc
Ci0JJChzaGVsbCBscyAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby8q
LmlkbCkgXAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi
ZGF0YWJhc2UvKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9N
b2R1bGVzL3dlYnNvY2tldHMvKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2Uv
V2ViQ29yZS9jc3MvKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29y
ZS9kb20vKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9lZGl0
aW5nLyouaWRsKSBcCi0JJChzaGVsbCBscyAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvZmlsZWFw
aS8qLmlkbCkgXAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu
dmFzLyouaWRsKSBcCi0JJChzaGVsbCBscyAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvaHRtbC9z
aGFkb3cvKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9odG1s
L3RyYWNrLyouaWRsKSBcCi0JJChzaGVsbCBscyAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvaHRt
bC8qLmlkbCkgXAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv
ci8qLmlkbCkgXAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9h
cHBjYWNoZS8qLmlkbCkgXAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3Bh
Z2UvKi5pZGwpIFwKLQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5z
LyouaWRsKSBcCi0JJChzaGVsbCBscyAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvc3RvcmFnZS8q
LmlkbCkgXAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3N2Zy8qLmlkbCkg
XAotCSQoc2hlbGwgbHMgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvKi5pZGwpIFwK
LQkkKHNoZWxsIGxzICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzLyouaWRsKSBcCi0J
JChzaGVsbCBscyAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUveG1sLyouaWRsKSBcCisJJCh3aWxk
Y2FyZCAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtLyouaWRsKSBc
CisJJCh3aWxkY2FyZCAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nYW1lcGFkLyou
aWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2RpcikvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nZW9s
b2NhdGlvbi8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL01v
ZHVsZXMvaW5kZXhlZGRiLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2RpcikvU291cmNlL1dl
YkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNkaXIp
L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vKi5pZGwpIFwKKwkkKHdpbGRjYXJk
ICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25hdmlnYXRvcmNvbnRlbnR1dGlscy8q
LmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90
aWZpY2F0aW9ucy8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3Jl
L01vZHVsZXMvcXVvdGEvKi5pZGwpIFwKKwkkKHdpbGRjYXJkICQoc3JjZGlyKS9Tb3VyY2UvV2Vi
Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2RpcikvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFzZS8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChz
cmNkaXIpL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vic29ja2V0cy8qLmlkbCkgXAorCSQod2ls
ZGNhcmQgJChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL2Nzcy8qLmlkbCkgXAorCSQod2lsZGNhcmQg
JChzcmNkaXIpL1NvdXJjZS9XZWJDb3JlL2RvbS8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNk
aXIpL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvKi5pZGwpIFwKKwkkKHdpbGRjYXJkICQoc3JjZGly
KS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2Rpcikv
U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvKi5pZGwpIFwKKwkkKHdpbGRjYXJkICQoc3JjZGly
KS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNk
aXIpL1NvdXJjZS9XZWJDb3JlL2h0bWwvdHJhY2svKi5pZGwpIFwKKwkkKHdpbGRjYXJkICQoc3Jj
ZGlyKS9Tb3VyY2UvV2ViQ29yZS9odG1sLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2Rpcikv
U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2Rpcikv
U291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNy
Y2RpcikvU291cmNlL1dlYkNvcmUvcGFnZS8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNkaXIp
L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvKi5pZGwpIFwKKwkkKHdpbGRjYXJkICQoc3JjZGlyKS9T
b3VyY2UvV2ViQ29yZS9zdG9yYWdlLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2RpcikvU291
cmNlL1dlYkNvcmUvc3ZnLyouaWRsKSBcCisJJCh3aWxkY2FyZCAkKHNyY2RpcikvU291cmNlL1dl
YkNvcmUvdGVzdGluZy8qLmlkbCkgXAorCSQod2lsZGNhcmQgJChzcmNkaXIpL1NvdXJjZS9XZWJD
b3JlL3dvcmtlcnMvKi5pZGwpIFwKKwkkKHdpbGRjYXJkICQoc3JjZGlyKS9Tb3VyY2UvV2ViQ29y
ZS94bWwvKi5pZGwpIFwKIAlTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvZ2xz
bGFuZy5sIFwKIAlTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvZ2xzbGFuZy55
IFwKIAlTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0
LnBtIFwKLS0gCjEuNy43LjYKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>