101580 2012-11-08 03:30:06 -0800 [Qt] deleteAllCookies() SQL statement is incorrect SQL 2012-12-13 02:28:46 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103890 0 antti.harju webkit-unassigned allan.jensen jturcotte webkit.review.bot oldest_to_newest 761582 0 antti.harju 2012-11-08 03:30:06 -0800 "DELETE * FROM cookies" should be "DELETE FROM cookies" I'll post a patch. 761604 1 172997 antti.harju 2012-11-08 03:44:17 -0800 Created attachment 172997 Patch 781412 2 172997 allan.jensen 2012-12-03 06:54:23 -0800 Comment on attachment 172997 Patch That looks right to me. 781419 3 allan.jensen 2012-12-03 07:04:19 -0800 (In reply to comment #2) > (From update of attachment 172997 [details]) > That looks right to me. Perhaps set r? on your patch? 789528 4 172997 jturcotte 2012-12-12 07:39:27 -0800 Comment on attachment 172997 Patch Overall comments 789538 5 172997 webkit.review.bot 2012-12-12 07:44:20 -0800 Comment on attachment 172997 Patch Rejecting attachment 172997 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/qt/CookieJarQt.cpp Hunk #1 FAILED at 242. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/qt/CookieJarQt.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Jocelyn Tu..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15272790 789555 6 jturcotte 2012-12-12 07:58:14 -0800 Please rebase the patch, it seems like the code moved to Source/WebCore/platform/network/qt/CookieJarQt.cpp. 790435 7 allan.jensen 2012-12-13 02:28:46 -0800 Committed r137578: <http://trac.webkit.org/changeset/137578> 172997 2012-11-08 03:44:17 -0800 2012-12-12 07:44:20 -0800 Patch bug-101580.patch text/plain 1144 antti.harju ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NDM0MmQwLi40MzY5YjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMTEtMDggIEFudHRpIEhhcmp1ICA8YW50dGkuaGFyanVAaXhvbm9zLmNvbT4KKwor ICAgICAgICBbUXRdIEZpeCBkZWxldGVBbGxDb29raWVzKCkgaW52YWxpZCBTUUwgc3RhdGVtZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE1ODAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL3F0L0Nvb2tpZUphclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZENvb2tpZUph clF0OjpkZWxldGVBbGxDb29raWVzKToKKwogMjAxMi0xMS0wOCAgWmVubyBBbGJpc3NlciAgPHpl bm9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBHcmFwaGljc1N1cmZhY2VHTFggbmVlZHMgdG8gcXVl cnkgdGhlIGRyYXdhYmxlIGZvciBZSW52ZXJzaW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vcXQvQ29va2llSmFyUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v cXQvQ29va2llSmFyUXQuY3BwCmluZGV4IDY4NjY1YjMuLjI4NWQxMmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0Nvb2tpZUphclF0LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9xdC9Db29raWVKYXJRdC5jcHAKQEAgLTI0Miw3ICsyNDIsNyBAQCB2b2lk IFNoYXJlZENvb2tpZUphclF0OjpkZWxldGVBbGxDb29raWVzKCkKICAgICAgICAgcmV0dXJuOwog CiAgICAgUVNxbFF1ZXJ5IHNxbFF1ZXJ5KG1fZGF0YWJhc2UpOwotICAgIHNxbFF1ZXJ5LnByZXBh cmUoUUxhdGluMVN0cmluZygiREVMRVRFICogRlJPTSBjb29raWVzIikpOworICAgIHNxbFF1ZXJ5 LnByZXBhcmUoUUxhdGluMVN0cmluZygiREVMRVRFIEZST00gY29va2llcyIpKTsKICAgICBzcWxR dWVyeS5leGVjKCk7CiAgICAgc2V0QWxsQ29va2llcyhRTGlzdDxRTmV0d29ya0Nvb2tpZT4oKSk7 CiB9Cg==