101578 2012-11-08 03:25:17 -0800 Web Inspector: Add meaningful error message when request content was evicted from inspector cache. 2012-11-09 02:07:17 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vsevik vsevik apavlov bengr caseq keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 761569 0 vsevik 2012-11-08 03:25:17 -0800 Patch to follow 761579 1 172990 vsevik 2012-11-08 03:28:44 -0800 Created attachment 172990 Patch 761581 2 172990 caseq 2012-11-08 03:29:34 -0800 Comment on attachment 172990 Patch LGTM 762737 3 172990 webkit.review.bot 2012-11-09 02:07:13 -0800 Comment on attachment 172990 Patch Clearing flags on attachment: 172990 Committed r134037: <http://trac.webkit.org/changeset/134037> 762738 4 webkit.review.bot 2012-11-09 02:07:17 -0800 All reviewed patches have been landed. Closing bug. 172990 2012-11-08 03:28:44 -0800 2012-11-09 02:07:13 -0800 Patch bug-101578-20121108152653.patch text/plain 7353 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhjNjFkZGQ4YTNhNWUx ZjdkZWU1OWIyNjYxN2M4NjkyZjBiZGI1Ni4uYzk2YmQ2MDRkMWNlZjNiNDdiN2E0ZjY1MTI2YzY3 Yjg1NTYzZjgwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTExLTA4ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZCBtZWFuaW5nZnVsIGVycm9yIG1lc3NhZ2Ugd2hlbiByZXF1ZXN0IGNvbnRlbnQgd2Fz IGV2aWN0ZWQgZnJvbSBpbnNwZWN0b3IgY2FjaGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDE1NzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBzcGVjaWZpYyBlcnJvciBtZXNzYWdlIHdoZW4g cmVxdWVzdCBjb250ZW50IHdhcyBldmljdGVkIGZyb20gaW5zcGVjdG9yIGNhY2hlLgorICAgICAg ICBSZXBsYWNlZCBwdXJnZSB3aXRoIGV2aWN0IGluIGZpZWxkcy9tZXRob2RzIG5hbWVzLgorCisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yUmVzb3VyY2VBZ2VudDo6Z2V0UmVzcG9uc2VCb2R5KToKKyAgICAg ICAgKiBpbnNwZWN0b3IvTmV0d29ya1Jlc291cmNlc0RhdGEuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TmV0d29ya1Jlc291cmNlc0RhdGE6OlJlc291cmNlRGF0YTo6UmVzb3VyY2VEYXRhKToKKyAg ICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtSZXNvdXJjZXNEYXRhOjpSZXNvdXJjZURhdGE6OmV2aWN0 Q29udGVudCk6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrUmVzb3VyY2VzRGF0YTo6c2V0UmVz b3VyY2VDb250ZW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtSZXNvdXJjZXNEYXRhOjpt YXliZUFkZFJlc291cmNlRGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrUmVzb3VyY2Vz RGF0YTo6bWF5YmVEZWNvZGVEYXRhVG9Db250ZW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdv cmtSZXNvdXJjZXNEYXRhOjplbnN1cmVOb0RhdGFGb3JSZXF1ZXN0SWQpOgorICAgICAgICAoV2Vi Q29yZTo6TmV0d29ya1Jlc291cmNlc0RhdGE6OmVuc3VyZUZyZWVTcGFjZSk6CisgICAgICAgICog aW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpOZXR3 b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3VyY2VEYXRhOjppc0NvbnRlbnRFdmljdGVkKToKKyAgICAg ICAgKFJlc291cmNlRGF0YSk6CisKIDIwMTItMTEtMDcgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZp a0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWlncmF0ZSBpbnNwZWN0 b3IgSW5kZXhlZERCIHN1cHBvcnQgdG8gZnJvbnRlbmQgQVBJLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwCmluZGV4IDMzM2NmZTE0 YzNjNTU2ZjA0YTllNjMyMDRjNmNjMTRkZmMyYjI3YjYuLmQ5Y2MxNDhiNzEyZDU2NGY1ZjM5M2Y5 OTk2YmIwMjMyZDgyMGQ1NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHAKQEAgLTYwMCw2ICs2MDAsMTEgQEAgdm9pZCBJbnNw ZWN0b3JSZXNvdXJjZUFnZW50OjpnZXRSZXNwb25zZUJvZHkoRXJyb3JTdHJpbmcqIGVycm9yU3Ry aW5nLCBjb25zdCBTdHIKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChyZXNvdXJj ZURhdGEtPmlzQ29udGVudEV2aWN0ZWQoKSkgeworICAgICAgICAqZXJyb3JTdHJpbmcgPSAiUmVx dWVzdCBjb250ZW50IHdhcyBldmljdGVkIGZyb20gaW5zcGVjdG9yIGNhY2hlIjsKKyAgICAgICAg cmV0dXJuOworICAgIH0KKwogICAgIGlmIChyZXNvdXJjZURhdGEtPmJ1ZmZlcigpICYmICFyZXNv dXJjZURhdGEtPnRleHRFbmNvZGluZ05hbWUoKS5pc051bGwoKSkgewogICAgICAgICAqYmFzZTY0 RW5jb2RlZCA9IGZhbHNlOwogICAgICAgICBpZiAoSW5zcGVjdG9yUGFnZUFnZW50OjpzaGFyZWRC dWZmZXJDb250ZW50KHJlc291cmNlRGF0YS0+YnVmZmVyKCksIHJlc291cmNlRGF0YS0+dGV4dEVu Y29kaW5nTmFtZSgpLCAqYmFzZTY0RW5jb2RlZCwgY29udGVudCkpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0d29ya1Jlc291cmNlc0RhdGEuY3BwIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmNwcAppbmRleCAxYTU3Y2IwYTkx NDI0Mjg4NTYwNjk0YjQ3NDE3YmMzNzQ1NDJhNzJjLi5lNjU4MDRlMGYxYTI2M2QzYzcwNTRiZTlk YTMyMzY4ZDlmZTY4YThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0 d29ya1Jlc291cmNlc0RhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9OZXR3 b3JrUmVzb3VyY2VzRGF0YS5jcHAKQEAgLTgxLDcgKzgxLDcgQEAgTmV0d29ya1Jlc291cmNlc0Rh dGE6OlJlc291cmNlRGF0YTo6UmVzb3VyY2VEYXRhKGNvbnN0IFN0cmluZyYgcmVxdWVzdElkLCBj b25zdAogICAgIDogbV9yZXF1ZXN0SWQocmVxdWVzdElkKQogICAgICwgbV9sb2FkZXJJZChsb2Fk ZXJJZCkKICAgICAsIG1fYmFzZTY0RW5jb2RlZChmYWxzZSkKLSAgICAsIG1faXNDb250ZW50UHVy Z2VkKGZhbHNlKQorICAgICwgbV9pc0NvbnRlbnRFdmljdGVkKGZhbHNlKQogICAgICwgbV90eXBl KEluc3BlY3RvclBhZ2VBZ2VudDo6T3RoZXJSZXNvdXJjZSkKICAgICAsIG1fY2FjaGVkUmVzb3Vy Y2UoMCkKIHsKQEAgLTExNyw5ICsxMTcsOSBAQCB1bnNpZ25lZCBOZXR3b3JrUmVzb3VyY2VzRGF0 YTo6UmVzb3VyY2VEYXRhOjpyZW1vdmVDb250ZW50KCkKICAgICByZXR1cm4gcmVzdWx0OwogfQog Ci11bnNpZ25lZCBOZXR3b3JrUmVzb3VyY2VzRGF0YTo6UmVzb3VyY2VEYXRhOjpwdXJnZUNvbnRl bnQoKQordW5zaWduZWQgTmV0d29ya1Jlc291cmNlc0RhdGE6OlJlc291cmNlRGF0YTo6ZXZpY3RD b250ZW50KCkKIHsKLSAgICBtX2lzQ29udGVudFB1cmdlZCA9IHRydWU7CisgICAgbV9pc0NvbnRl bnRFdmljdGVkID0gdHJ1ZTsKICAgICByZXR1cm4gcmVtb3ZlQ29udGVudCgpOwogfQogCkBAIC0y MzIsOSArMjMyLDkgQEAgdm9pZCBOZXR3b3JrUmVzb3VyY2VzRGF0YTo6c2V0UmVzb3VyY2VDb250 ZW50KGNvbnN0IFN0cmluZyYgcmVxdWVzdElkLCBjb25zdCBTdHIKICAgICBzaXplX3QgZGF0YUxl bmd0aCA9IGNvbnRlbnRTaXplSW5CeXRlcyhjb250ZW50KTsKICAgICBpZiAoZGF0YUxlbmd0aCA+ IG1fbWF4aW11bVNpbmdsZVJlc291cmNlQ29udGVudFNpemUpCiAgICAgICAgIHJldHVybjsKLSAg ICBpZiAocmVzb3VyY2VEYXRhLT5pc0NvbnRlbnRQdXJnZWQoKSkKKyAgICBpZiAocmVzb3VyY2VE YXRhLT5pc0NvbnRlbnRFdmljdGVkKCkpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoZW5zdXJl RnJlZVNwYWNlKGRhdGFMZW5ndGgpICYmICFyZXNvdXJjZURhdGEtPmlzQ29udGVudFB1cmdlZCgp KSB7CisgICAgaWYgKGVuc3VyZUZyZWVTcGFjZShkYXRhTGVuZ3RoKSAmJiAhcmVzb3VyY2VEYXRh LT5pc0NvbnRlbnRFdmljdGVkKCkpIHsKICAgICAgICAgLy8gV2UgY2FuIG5vdCBiZSBzdXJlIHRo YXQgd2UgZGlkbid0IHRyeSB0byBzYXZlIHRoaXMgcmVxdWVzdCBkYXRhIHdoaWxlIGl0IHdhcyBs b2FkaW5nLCBzbyByZW1vdmUgaXQsIGlmIGFueS4KICAgICAgICAgaWYgKHJlc291cmNlRGF0YS0+ aGFzQ29udGVudCgpKQogICAgICAgICAgICAgbV9jb250ZW50U2l6ZSAtPSByZXNvdXJjZURhdGEt PnJlbW92ZUNvbnRlbnQoKTsKQEAgLTI1MiwxMCArMjUyLDEwIEBAIHZvaWQgTmV0d29ya1Jlc291 cmNlc0RhdGE6Om1heWJlQWRkUmVzb3VyY2VEYXRhKGNvbnN0IFN0cmluZyYgcmVxdWVzdElkLCBj b25zdCBjCiAgICAgaWYgKCFyZXNvdXJjZURhdGEtPmRlY29kZXIoKSkKICAgICAgICAgcmV0dXJu OwogICAgIGlmIChyZXNvdXJjZURhdGEtPmRhdGFMZW5ndGgoKSArIGRhdGFMZW5ndGggPiBtX21h eGltdW1TaW5nbGVSZXNvdXJjZUNvbnRlbnRTaXplKQotICAgICAgICBtX2NvbnRlbnRTaXplIC09 IHJlc291cmNlRGF0YS0+cHVyZ2VDb250ZW50KCk7Ci0gICAgaWYgKHJlc291cmNlRGF0YS0+aXND b250ZW50UHVyZ2VkKCkpCisgICAgICAgIG1fY29udGVudFNpemUgLT0gcmVzb3VyY2VEYXRhLT5l dmljdENvbnRlbnQoKTsKKyAgICBpZiAocmVzb3VyY2VEYXRhLT5pc0NvbnRlbnRFdmljdGVkKCkp CiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoZW5zdXJlRnJlZVNwYWNlKGRhdGFMZW5ndGgpICYm ICFyZXNvdXJjZURhdGEtPmlzQ29udGVudFB1cmdlZCgpKSB7CisgICAgaWYgKGVuc3VyZUZyZWVT cGFjZShkYXRhTGVuZ3RoKSAmJiAhcmVzb3VyY2VEYXRhLT5pc0NvbnRlbnRFdmljdGVkKCkpIHsK ICAgICAgICAgbV9yZXF1ZXN0SWRzRGVxdWUuYXBwZW5kKHJlcXVlc3RJZCk7CiAgICAgICAgIHJl c291cmNlRGF0YS0+YXBwZW5kRGF0YShkYXRhLCBkYXRhTGVuZ3RoKTsKICAgICAgICAgbV9jb250 ZW50U2l6ZSArPSBkYXRhTGVuZ3RoOwpAQCAtMjcyLDcgKzI3Miw3IEBAIHZvaWQgTmV0d29ya1Jl c291cmNlc0RhdGE6Om1heWJlRGVjb2RlRGF0YVRvQ29udGVudChjb25zdCBTdHJpbmcmIHJlcXVl c3RJZCkKICAgICBtX2NvbnRlbnRTaXplICs9IHJlc291cmNlRGF0YS0+ZGVjb2RlRGF0YVRvQ29u dGVudCgpOwogICAgIHNpemVfdCBkYXRhTGVuZ3RoID0gY29udGVudFNpemVJbkJ5dGVzKHJlc291 cmNlRGF0YS0+Y29udGVudCgpKTsKICAgICBpZiAoZGF0YUxlbmd0aCA+IG1fbWF4aW11bVNpbmds ZVJlc291cmNlQ29udGVudFNpemUpCi0gICAgICAgIG1fY29udGVudFNpemUgLT0gcmVzb3VyY2VE YXRhLT5wdXJnZUNvbnRlbnQoKTsKKyAgICAgICAgbV9jb250ZW50U2l6ZSAtPSByZXNvdXJjZURh dGEtPmV2aWN0Q29udGVudCgpOwogfQogCiB2b2lkIE5ldHdvcmtSZXNvdXJjZXNEYXRhOjphZGRD YWNoZWRSZXNvdXJjZShjb25zdCBTdHJpbmcmIHJlcXVlc3RJZCwgQ2FjaGVkUmVzb3VyY2UqIGNh Y2hlZFJlc291cmNlKQpAQCAtMzg4LDcgKzM4OCw3IEBAIHZvaWQgTmV0d29ya1Jlc291cmNlc0Rh dGE6OmVuc3VyZU5vRGF0YUZvclJlcXVlc3RJZChjb25zdCBTdHJpbmcmIHJlcXVlc3RJZCkKICAg ICBSZXNvdXJjZURhdGEqIHJlc291cmNlRGF0YSA9IG1fcmVxdWVzdElkVG9SZXNvdXJjZURhdGFN YXAuZ2V0KHJlcXVlc3RJZCk7CiAgICAgaWYgKHJlc291cmNlRGF0YSkgewogICAgICAgICBpZiAo cmVzb3VyY2VEYXRhLT5oYXNDb250ZW50KCkgfHwgcmVzb3VyY2VEYXRhLT5oYXNEYXRhKCkpCi0g ICAgICAgICAgICBtX2NvbnRlbnRTaXplIC09IHJlc291cmNlRGF0YS0+cHVyZ2VDb250ZW50KCk7 CisgICAgICAgICAgICBtX2NvbnRlbnRTaXplIC09IHJlc291cmNlRGF0YS0+ZXZpY3RDb250ZW50 KCk7CiAgICAgICAgIGRlbGV0ZSByZXNvdXJjZURhdGE7CiAgICAgICAgIG1fcmVxdWVzdElkVG9S ZXNvdXJjZURhdGFNYXAucmVtb3ZlKHJlcXVlc3RJZCk7CiAgICAgfQpAQCAtNDAzLDcgKzQwMyw3 IEBAIGJvb2wgTmV0d29ya1Jlc291cmNlc0RhdGE6OmVuc3VyZUZyZWVTcGFjZShzaXplX3Qgc2l6 ZSkKICAgICAgICAgU3RyaW5nIHJlcXVlc3RJZCA9IG1fcmVxdWVzdElkc0RlcXVlLnRha2VGaXJz dCgpOwogICAgICAgICBSZXNvdXJjZURhdGEqIHJlc291cmNlRGF0YSA9IG1fcmVxdWVzdElkVG9S ZXNvdXJjZURhdGFNYXAuZ2V0KHJlcXVlc3RJZCk7CiAgICAgICAgIGlmIChyZXNvdXJjZURhdGEp Ci0gICAgICAgICAgICBtX2NvbnRlbnRTaXplIC09IHJlc291cmNlRGF0YS0+cHVyZ2VDb250ZW50 KCk7CisgICAgICAgICAgICBtX2NvbnRlbnRTaXplIC09IHJlc291cmNlRGF0YS0+ZXZpY3RDb250 ZW50KCk7CiAgICAgfQogICAgIHJldHVybiB0cnVlOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL05ldHdvcmtSZXNvdXJjZXNEYXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvTmV0d29ya1Jlc291cmNlc0RhdGEuaAppbmRleCA0MTM0MGEzZDg5ZWVlNmNhZWFk NGFjOTFlODM1ZGMyYTgxNDY5M2JiLi40MmNhNmQ5MDZlYzI2YTNkYTllMzEzNDY0ZmNmZmY0YmMy YjQ1MzVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0d29ya1Jlc291 cmNlc0RhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvTmV0d29ya1Jlc291cmNl c0RhdGEuaApAQCAtOTQsOCArOTQsOCBAQCBwdWJsaWM6CiAgICAgICAgIGJvb2wgYmFzZTY0RW5j b2RlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYmFzZTY0RW5jb2RlZDsgfQogCiAgICAgICAgIHVuc2ln bmVkIHJlbW92ZUNvbnRlbnQoKTsKLSAgICAgICAgYm9vbCBpc0NvbnRlbnRQdXJnZWQoKSBjb25z dCB7IHJldHVybiBtX2lzQ29udGVudFB1cmdlZDsgfQotICAgICAgICB1bnNpZ25lZCBwdXJnZUNv bnRlbnQoKTsKKyAgICAgICAgYm9vbCBpc0NvbnRlbnRFdmljdGVkKCkgY29uc3QgeyByZXR1cm4g bV9pc0NvbnRlbnRFdmljdGVkOyB9CisgICAgICAgIHVuc2lnbmVkIGV2aWN0Q29udGVudCgpOwog CiAgICAgICAgIEluc3BlY3RvclBhZ2VBZ2VudDo6UmVzb3VyY2VUeXBlIHR5cGUoKSBjb25zdCB7 IHJldHVybiBtX3R5cGU7IH0KICAgICAgICAgdm9pZCBzZXRUeXBlKEluc3BlY3RvclBhZ2VBZ2Vu dDo6UmVzb3VyY2VUeXBlIHR5cGUpIHsgbV90eXBlID0gdHlwZTsgfQpAQCAtMTM0LDcgKzEzNCw3 IEBAIHB1YmxpYzoKICAgICAgICAgUmVmUHRyPFhIUlJlcGxheURhdGE+IG1feGhyUmVwbGF5RGF0 YTsKICAgICAgICAgYm9vbCBtX2Jhc2U2NEVuY29kZWQ7CiAgICAgICAgIFJlZlB0cjxTaGFyZWRC dWZmZXI+IG1fZGF0YUJ1ZmZlcjsKLSAgICAgICAgYm9vbCBtX2lzQ29udGVudFB1cmdlZDsKKyAg ICAgICAgYm9vbCBtX2lzQ29udGVudEV2aWN0ZWQ7CiAgICAgICAgIEluc3BlY3RvclBhZ2VBZ2Vu dDo6UmVzb3VyY2VUeXBlIG1fdHlwZTsKICAgICAgICAgaW50IG1faHR0cFN0YXR1c0NvZGU7CiAK