101577 2012-11-08 03:19:17 -0800 Unused parameters on GraphicsLayerUpdater.cpp 2012-11-08 05:35:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim haraken simon.fraser webkit.review.bot oldest_to_newest 761563 0 ktf.kim 2012-11-08 03:19:17 -0800 There are build warnings when !USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:36:1: warning: unused parameter ‘displayID’ [-Wunused-parameter] Source/WebCore/platform/graphics/GraphicsLayerUpdater.cpp:63:6: warning: unused parameter ‘displayID’ [-Wunused-parameter] Use UNUSED_PARAM macro for removing -Wunused-parameter warnings. 761588 1 172992 ktf.kim 2012-11-08 03:34:16 -0800 Created attachment 172992 Patch 761623 2 172992 haraken 2012-11-08 04:08:24 -0800 Comment on attachment 172992 Patch Looks OK 761690 3 172992 webkit.review.bot 2012-11-08 05:35:49 -0800 Comment on attachment 172992 Patch Clearing flags on attachment: 172992 Committed r133889: <http://trac.webkit.org/changeset/133889> 761691 4 webkit.review.bot 2012-11-08 05:35:52 -0800 All reviewed patches have been landed. Closing bug. 172992 2012-11-08 03:34:16 -0800 2012-11-08 05:35:49 -0800 Patch bug-101577-20121108203228.patch text/plain 1965 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUxOWE5ZjYxMzg4NDdk ZmUwM2VlYjlhMWM5N2UxZTE4ZTY2YmY4Ny4uN2M0ZDg4OGNlYjY0NWYyOWNlNzIzNWVkM2ExMDNm YzZkZDQ2MzIxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTA4ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFVudXNlZCBwYXJhbWV0 ZXJzIG9uIEdyYXBoaWNzTGF5ZXJVcGRhdGVyLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBhcmFtZXRlciAnZGlzcGxheUlEJyBpcyBub3Qg dXNlZCB3aGVuICFVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfRElTUExBWV9NT05JVE9SKQor ICAgICAgICBVc2UgVU5VU0VEX1BBUkFNIG1hY3JvIGZvciByZW1vdmluZyAtV3VudXNlZC1wYXJh bWV0ZXIgd2FybmluZ3MKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5 ZXJVcGRhdGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJVcGRhdGVyOjpH cmFwaGljc0xheWVyVXBkYXRlcik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyVXBk YXRlcjo6c2NyZWVuRGlkQ2hhbmdlKToKKwogMjAxMi0xMS0wOCAgTWlrZSBXZXN0ICA8bWt3c3RA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdhcm4gd2hlbiBwYXJzaW5nIGFuIGludmFsaWQgWC1G cmFtZS1PcHRpb25zIGhlYWRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJVcGRhdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJVcGRhdGVyLmNwcAppbmRleCAyZWI2NTY5MjRhMjYz M2RmNTAwYjRiNmQxNTRkYzE1NTY5ZDM0OTJhLi5iM2M5NDM2NDQ2MTUyMTVhYWFlYWJjNzJiMGIz NmQzN2QyOGEzNDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HcmFwaGljc0xheWVyVXBkYXRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NMYXllclVwZGF0ZXIuY3BwCkBAIC00MSw2ICs0MSw4IEBAIEdyYXBo aWNzTGF5ZXJVcGRhdGVyOjpHcmFwaGljc0xheWVyVXBkYXRlcihHcmFwaGljc0xheWVyVXBkYXRl ckNsaWVudCogY2xpZW50LCBQCiAgICAgRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6c2hh cmVkTWFuYWdlcigpLT5yZWdpc3RlckNsaWVudCh0aGlzKTsKICAgICBEaXNwbGF5UmVmcmVzaE1v bml0b3JNYW5hZ2VyOjpzaGFyZWRNYW5hZ2VyKCktPndpbmRvd1NjcmVlbkRpZENoYW5nZShkaXNw bGF5SUQsIHRoaXMpOwogICAgIERpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXI6OnNoYXJlZE1h bmFnZXIoKS0+c2NoZWR1bGVBbmltYXRpb24odGhpcyk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJB TShkaXNwbGF5SUQpOwogI2VuZGlmCiB9CiAKQEAgLTY0LDYgKzY2LDggQEAgdm9pZCBHcmFwaGlj c0xheWVyVXBkYXRlcjo6c2NyZWVuRGlkQ2hhbmdlKFBsYXRmb3JtRGlzcGxheUlEIGRpc3BsYXlJ RCkKIHsKICNpZiBVU0UoUkVRVUVTVF9BTklNQVRJT05fRlJBTUVfRElTUExBWV9NT05JVE9SKQog ICAgIERpc3BsYXlSZWZyZXNoTW9uaXRvck1hbmFnZXI6OnNoYXJlZE1hbmFnZXIoKS0+d2luZG93 U2NyZWVuRGlkQ2hhbmdlKGRpc3BsYXlJRCwgdGhpcyk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJB TShkaXNwbGF5SUQpOwogI2VuZGlmCiB9CiAK