101570 2012-11-08 02:47:25 -0800 [EFL] Add a method to the TextCheckerEnchant class to check whether any dictionary is loaded 2012-11-08 23:36:45 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski cgarcia gyuyoung.kim laszlo.gombos lucas.de.marchi mario rakuco webkit.review.bot oldest_to_newest 761528 0 g.czajkowski 2012-11-08 02:47:25 -0800 Expose a new method to check whether a vector of loaded languages is empty. WK2-EFL needs it to set the default language (if the client didn't set any) when spelling setting is being enabled. This change allows to do not get vector of dictionaries to just check its size. 761530 1 172972 g.czajkowski 2012-11-08 02:49:50 -0800 Created attachment 172972 proposed patch 761692 2 172972 gustavo 2012-11-08 05:41:23 -0800 Comment on attachment 172972 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172972&action=review Mostly a readability/hackability change, so I'll be nit-picky and say languagesLoaded sounds to me like it would return the languages that have been loaded. Also, I'd prefer maintaining the "dictionary" terminology, so perhaps hasDictionary? > Source/WebCore/ChangeLog:11 > + spelling setting is being enabled. This change allows to do not get > + vector of dictionaries to just check its size. This last sentence is a bit broken. How about "This change makes it more convenient to check whether the dictionaries vector is empty."? 761715 3 173027 g.czajkowski 2012-11-08 06:04:38 -0800 Created attachment 173027 apply Gustavo's suggestions 762622 4 173027 webkit.review.bot 2012-11-08 23:36:41 -0800 Comment on attachment 173027 apply Gustavo's suggestions Clearing flags on attachment: 173027 Committed r134021: <http://trac.webkit.org/changeset/134021> 762623 5 webkit.review.bot 2012-11-08 23:36:45 -0800 All reviewed patches have been landed. Closing bug. 172972 2012-11-08 02:49:50 -0800 2012-11-08 06:04:38 -0800 proposed patch spelling-check_whether_vector_is_empty.patch text/plain 6357 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZDNiNjEwLi40YTllMTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTItMTEtMDcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIGEgbWV0aG9kIHRvIHRoZSBUZXh0Q2hlY2tlckVu Y2hhbnQgY2xhc3MgdG8gY2hlY2sgd2hldGhlciBhbnkgZGljdGlvbmFyeSBpcyBsb2FkZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU3MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9zZSBhIG5l dyBtZXRob2QgdG8gY2hlY2sgd2hldGhlciBhIHZlY3RvciBvZiBsb2FkZWQgbGFuZ3VhZ2VzIGlz IGVtcHR5LgorICAgICAgICBXSzItRUZMIG5lZWRzIGl0IHRvIHNldCB0aGUgZGVmYXVsdCBsYW5n dWFnZSAoaWYgdGhlIGNsaWVudCBkaWRuJ3Qgc2V0IGFueSkgd2hlbgorICAgICAgICBzcGVsbGlu ZyBzZXR0aW5nIGlzIGJlaW5nIGVuYWJsZWQuIFRoaXMgY2hhbmdlIGFsbG93cyB0byBkbyBub3Qg Z2V0CisgICAgICAgIHZlY3RvciBvZiBkaWN0aW9uYXJpZXMgdG8ganVzdCBjaGVjayBpdHMgc2l6 ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAg ICAqIHBsYXRmb3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwOgorICAgICAg ICAoVGV4dENoZWNrZXJFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcpOgorICAgICAgICAo VGV4dENoZWNrZXJFbmNoYW50OjpnZXRHdWVzc2VzRm9yV29yZCk6CisgICAgICAgIChUZXh0Q2hl Y2tlckVuY2hhbnQ6OmxvYWRlZFNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMpOgorICAgICAgICBBIG5l d2x5IGV4cG9zZWQgbWV0aG9kIGlzIHVzZWQgaW50ZXJuYWxseSB0b28uCisKKyAgICAgICAgKiBw bGF0Zm9ybS90ZXh0L2VuY2hhbnQvVGV4dENoZWNrZXJFbmNoYW50Lmg6CisgICAgICAgIChXZWJD b3JlOjpUZXh0Q2hlY2tlckVuY2hhbnQ6Omxhbmd1YWdlc0xvYWRlZCk6CisgICAgICAgIElubGlu ZSBtZXRob2QgbGFuZ3VhZ2VzTG9hZGVkKCkuCisKIDIwMTItMTEtMDcgIERhbiBDYXJuZXkgIDxk Y2FybmV5QGdvb2dsZS5jb20+CiAKICAgICAgICAgW1Y4XSBDbGVhbnVwIFY4RE9NV3JhcHBlcjo6 Z2V0Q2FjaGVkV3JhcHBlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9lbmNoYW50L1RleHRDaGVja2VyRW5jaGFudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS90ZXh0L2VuY2hhbnQvVGV4dENoZWNrZXJFbmNoYW50LmNwcAppbmRleCAyODYzM2YxLi5hMDlm NWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2VuY2hhbnQvVGV4 dENoZWNrZXJFbmNoYW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2Vu Y2hhbnQvVGV4dENoZWNrZXJFbmNoYW50LmNwcApAQCAtNzIsNyArNzIsNyBAQCB2b2lkIFRleHRD aGVja2VyRW5jaGFudDo6Y2hlY2tTcGVsbGluZ09mU3RyaW5nKGNvbnN0IFN0cmluZyYgc3RyaW5n LCBpbnQmIG1pc3NwZQogICAgIG1pc3NwZWxsaW5nTG9jYXRpb24gPSAtMTsKICAgICBtaXNzcGVs bGluZ0xlbmd0aCA9IDA7CiAKLSAgICBpZiAobV9lbmNoYW50RGljdGlvbmFyaWVzLmlzRW1wdHko KSkKKyAgICBpZiAoIWxhbmd1YWdlc0xvYWRlZCgpKQogICAgICAgICByZXR1cm47CiAKICAgICBz aXplX3QgbnVtYmVyT2ZDaGFyYWN0ZXJzID0gc3RyaW5nLmxlbmd0aCgpOwpAQCAtMTIxLDcgKzEy MSw3IEBAIHZvaWQgVGV4dENoZWNrZXJFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcoY29u c3QgU3RyaW5nJiBzdHJpbmcsIGludCYgbWlzc3BlCiBWZWN0b3I8U3RyaW5nPiBUZXh0Q2hlY2tl ckVuY2hhbnQ6OmdldEd1ZXNzZXNGb3JXb3JkKGNvbnN0IFN0cmluZyYgd29yZCkKIHsKICAgICBW ZWN0b3I8U3RyaW5nPiBndWVzc2VzOwotICAgIGlmIChtX2VuY2hhbnREaWN0aW9uYXJpZXMuaXNF bXB0eSgpKQorICAgIGlmICghbGFuZ3VhZ2VzTG9hZGVkKCkpCiAgICAgICAgIHJldHVybiBndWVz c2VzOwogCiAgICAgZm9yIChWZWN0b3I8RW5jaGFudERpY3QqPjo6Y29uc3RfaXRlcmF0b3IgaXRl ciA9IG1fZW5jaGFudERpY3Rpb25hcmllcy5iZWdpbigpOyBpdGVyICE9IG1fZW5jaGFudERpY3Rp b25hcmllcy5lbmQoKTsgKytpdGVyKSB7CkBAIC0xODAsNyArMTgwLDcgQEAgdm9pZCBUZXh0Q2hl Y2tlckVuY2hhbnQ6OnVwZGF0ZVNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMoY29uc3QgVmVjdG9yPFN0 cmluZz4mIGxhbmcKIFZlY3RvcjxTdHJpbmc+IFRleHRDaGVja2VyRW5jaGFudDo6bG9hZGVkU3Bl bGxDaGVja2luZ0xhbmd1YWdlcygpIGNvbnN0CiB7CiAgICAgVmVjdG9yPFN0cmluZz4gbGFuZ3Vh Z2VzOwotICAgIGlmIChtX2VuY2hhbnREaWN0aW9uYXJpZXMuaXNFbXB0eSgpKQorICAgIGlmICgh bGFuZ3VhZ2VzTG9hZGVkKCkpCiAgICAgICAgIHJldHVybiBsYW5ndWFnZXM7CiAKICAgICAvLyBH ZXQgYSBWZWN0b3I8Q1N0cmluZz4gd2l0aCB0aGUgbGlzdCBvZiBsYW5ndWFnZXMgaW4gdXNlLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9lbmNoYW50L1RleHRDaGVj a2VyRW5jaGFudC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9lbmNoYW50L1RleHRD aGVja2VyRW5jaGFudC5oCmluZGV4IDc4N2Y4YmYuLjhhZGY4NGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2VuY2hhbnQvVGV4dENoZWNrZXJFbmNoYW50 LmgKQEAgLTQzLDYgKzQzLDcgQEAgcHVibGljOgogICAgIFZlY3RvcjxTdHJpbmc+IGdldEd1ZXNz ZXNGb3JXb3JkKGNvbnN0IFN0cmluZyYpOwogICAgIHZvaWQgdXBkYXRlU3BlbGxDaGVja2luZ0xh bmd1YWdlcyhjb25zdCBWZWN0b3I8U3RyaW5nPiYgbGFuZ3VhZ2VzKTsKICAgICBWZWN0b3I8U3Ry aW5nPiBsb2FkZWRTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKCkgY29uc3Q7CisgICAgYm9vbCBsYW5n dWFnZXNMb2FkZWQoKSBjb25zdCB7IHJldHVybiAhbV9lbmNoYW50RGljdGlvbmFyaWVzLmlzRW1w dHkoKTsgfQogICAgIFZlY3RvcjxTdHJpbmc+IGF2YWlsYWJsZVNwZWxsQ2hlY2tpbmdMYW5ndWFn ZXMoKSBjb25zdDsKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlM2MxYmRmLi43YWFmMThmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTItMTEtMDcgIEdyemVnb3J6IEN6YWprb3dz a2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF0gQWRkIGEgbWV0 aG9kIHRvIHRoZSBUZXh0Q2hlY2tlckVuY2hhbnQgY2xhc3MgdG8gY2hlY2sgd2hldGhlciBhbnkg ZGljdGlvbmFyeSBpcyBsb2FkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMTU3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRvIGRvIG5vdCBnZXQgdGhlIHZlY3RvciBvZiBsb2FkZWQgbGFuZ3VhZ2Vz LCBXZWJLaXQyLUVGTCBjYWxscworICAgICAgICBUZXh0Q2hlY2tlckVuY2hhbnQ6Omxhbmd1YWdl c0xvYWRlZCgpIG1ldGhvZCB0byBjaGVjayB3aGV0aGVyCisgICAgICAgIHRoZSB2ZWN0b3IgaXMg ZW1wdHkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwOgor ICAgICAgICAoZXdrX3NldHRpbmdzX2NvbnRpbnVvdXNfc3BlbGxfY2hlY2tpbmdfZW5hYmxlZF9z ZXQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a190ZXh0X2NoZWNrZXIuY3BwOgor ICAgICAgICAoRXdrX1RleHRfQ2hlY2tlcjo6bGFuZ3VhZ2VzTG9hZGVkKToKKyAgICAgICAgKEV3 a19UZXh0X0NoZWNrZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a190ZXh0X2No ZWNrZXJfcHJpdmF0ZS5oOgorICAgICAgICAoRXdrX1RleHRfQ2hlY2tlcik6CisKKzIwMTItMTEt MDcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CisKICAg ICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyB0byB0dXJuIG9uICdzZXRDb250aW51b3VzU3Bl bGxDaGVja2luZ0VuYWJsZWQnCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MzYxMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3NldHRpbmdzLmNwcAppbmRleCAwYjUwODNmLi5lYjFmNTY1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5jcHAKQEAgLTIyNSw3 ICsyMjUsNyBAQCB2b2lkIGV3a19zZXR0aW5nc19jb250aW51b3VzX3NwZWxsX2NoZWNraW5nX2Vu YWJsZWRfc2V0KEVpbmFfQm9vbCBlbmFibGUpCiAgICAgICAgIFdLVGV4dENoZWNrZXJDb250aW51 b3VzU3BlbGxDaGVja2luZ0VuYWJsZWRTdGF0ZUNoYW5nZWQoZW5hYmxlKTsKIAogICAgICAgICAv LyBTZXRzIHRoZSBkZWZhdWx0IGxhbmd1YWdlIGlmIHVzZXIgZGlkbid0IHNwZWNpZnkgYW55Lgot ICAgICAgICBpZiAoZW5hYmxlICYmIEV3a19UZXh0X0NoZWNrZXI6OmxvYWRlZFNwZWxsQ2hlY2tp bmdMYW5ndWFnZXMoKS5pc0VtcHR5KCkpCisgICAgICAgIGlmIChlbmFibGUgJiYgIUV3a19UZXh0 X0NoZWNrZXI6Omxhbmd1YWdlc0xvYWRlZCgpKQogICAgICAgICAgICAgc3BlbGxDaGVja2luZ0xh bmd1YWdlc1NldChWZWN0b3I8U3RyaW5nPigpKTsKIAogICAgICAgICBpZiAoZXdrVGV4dENoZWNr ZXJTZXR0aW5ncy5vbkNvbnRpbnVvdXNTcGVsbENoZWNraW5nKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdGV4dF9jaGVja2VyLmNwcAppbmRleCBlMTVi OGZjLi5hYzEyOTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9ld2tfdGV4dF9jaGVja2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdGV4dF9jaGVja2VyLmNwcApAQCAtMTYyLDYgKzE2MiwxMSBAQCBWZWN0b3I8U3Ry aW5nPiBsb2FkZWRTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKCkKICAgICByZXR1cm4gdGV4dENoZWNr ZXJFbmNoYW50KCktPmxvYWRlZFNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMoKTsKIH0KIAorYm9vbCBs YW5ndWFnZXNMb2FkZWQoKQoreworICAgIHJldHVybiB0ZXh0Q2hlY2tlckVuY2hhbnQoKS0+bGFu Z3VhZ2VzTG9hZGVkKCk7Cit9CisKIC8qKgogICogSW5pdGlhbGl6ZXMgc3BlbGxjaGVjayBmZWF0 dXJlLgogICoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a190ZXh0X2NoZWNrZXJfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX3RleHRfY2hlY2tlcl9wcml2YXRlLmgKaW5kZXggNDYyZDMxNC4uOWYxY2JmZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tl cl9wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Rl eHRfY2hlY2tlcl9wcml2YXRlLmgKQEAgLTM5LDYgKzM5LDcgQEAgdm9pZCBpbml0aWFsaXplKCk7 CiBWZWN0b3I8U3RyaW5nPiBhdmFpbGFibGVTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKCk7CiB2b2lk IHVwZGF0ZVNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMoY29uc3QgVmVjdG9yPFN0cmluZz4mIGxhbmd1 YWdlcyk7CiBWZWN0b3I8U3RyaW5nPiBsb2FkZWRTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKCk7Citi b29sIGxhbmd1YWdlc0xvYWRlZCgpOwogCiB9CiAK 173027 2012-11-08 06:04:38 -0800 2012-11-08 23:36:41 -0800 apply Gustavo's suggestions spelling-check_whether_vector_is_empty_2.patch text/plain 6361 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZDNiNjEwLi5kYmI3NDRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTItMTEtMDcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0VGTF0gQWRkIGEgbWV0aG9kIHRvIHRoZSBUZXh0Q2hlY2tlckVu Y2hhbnQgY2xhc3MgdG8gY2hlY2sgd2hldGhlciBhbnkgZGljdGlvbmFyeSBpcyBsb2FkZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU3MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cG9zZSBhIG5l dyBtZXRob2QgdG8gY2hlY2sgd2hldGhlciBhIHZlY3RvciBvZiBsb2FkZWQgbGFuZ3VhZ2VzIGlz IGVtcHR5LgorICAgICAgICBXSzItRUZMIG5lZWRzIGl0IHRvIHNldCB0aGUgZGVmYXVsdCBsYW5n dWFnZSAoaWYgdGhlIGNsaWVudCBkaWRuJ3Qgc2V0IGFueSkgd2hlbgorICAgICAgICBzcGVsbGlu ZyBzZXR0aW5nIGlzIGJlaW5nIGVuYWJsZWQuIFRoaXMgY2hhbmdlIG1ha2VzIGl0IG1vcmUgY29u dmVuaWVudCB0byBjaGVjaworICAgICAgICB3aGV0aGVyIHRoZSBkaWN0aW9uYXJpZXMgdmVjdG9y IGlzIGVtcHR5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgor CisgICAgICAgICogcGxhdGZvcm0vdGV4dC9lbmNoYW50L1RleHRDaGVja2VyRW5jaGFudC5jcHA6 CisgICAgICAgIChUZXh0Q2hlY2tlckVuY2hhbnQ6OmNoZWNrU3BlbGxpbmdPZlN0cmluZyk6Cisg ICAgICAgIChUZXh0Q2hlY2tlckVuY2hhbnQ6OmdldEd1ZXNzZXNGb3JXb3JkKToKKyAgICAgICAg KFRleHRDaGVja2VyRW5jaGFudDo6bG9hZGVkU3BlbGxDaGVja2luZ0xhbmd1YWdlcyk6CisgICAg ICAgIEEgbmV3bHkgZXhwb3NlZCBtZXRob2QgaXMgdXNlZCBpbnRlcm5hbGx5IHRvby4KKworICAg ICAgICAqIHBsYXRmb3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlRleHRDaGVja2VyRW5jaGFudDo6aGFzRGljdGlvbmFyeSk6CisgICAgICAg IEFkZCBhbiBpbmxpbmUgaGFzRGljdGlvbmFyeSgpIG1ldGhvZC4KKwogMjAxMi0xMS0wNyAgRGFu IENhcm5leSAgPGRjYXJuZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbVjhdIENsZWFudXAgVjhE T01XcmFwcGVyOjpnZXRDYWNoZWRXcmFwcGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS90ZXh0L2VuY2hhbnQvVGV4dENoZWNrZXJFbmNoYW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwCmluZGV4IDI4 NjMzZjEuLmY5YjMwZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv ZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwCkBAIC03Miw3ICs3Miw3IEBA IHZvaWQgVGV4dENoZWNrZXJFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcoY29uc3QgU3Ry aW5nJiBzdHJpbmcsIGludCYgbWlzc3BlCiAgICAgbWlzc3BlbGxpbmdMb2NhdGlvbiA9IC0xOwog ICAgIG1pc3NwZWxsaW5nTGVuZ3RoID0gMDsKIAotICAgIGlmIChtX2VuY2hhbnREaWN0aW9uYXJp ZXMuaXNFbXB0eSgpKQorICAgIGlmICghaGFzRGljdGlvbmFyeSgpKQogICAgICAgICByZXR1cm47 CiAKICAgICBzaXplX3QgbnVtYmVyT2ZDaGFyYWN0ZXJzID0gc3RyaW5nLmxlbmd0aCgpOwpAQCAt MTIxLDcgKzEyMSw3IEBAIHZvaWQgVGV4dENoZWNrZXJFbmNoYW50OjpjaGVja1NwZWxsaW5nT2ZT dHJpbmcoY29uc3QgU3RyaW5nJiBzdHJpbmcsIGludCYgbWlzc3BlCiBWZWN0b3I8U3RyaW5nPiBU ZXh0Q2hlY2tlckVuY2hhbnQ6OmdldEd1ZXNzZXNGb3JXb3JkKGNvbnN0IFN0cmluZyYgd29yZCkK IHsKICAgICBWZWN0b3I8U3RyaW5nPiBndWVzc2VzOwotICAgIGlmIChtX2VuY2hhbnREaWN0aW9u YXJpZXMuaXNFbXB0eSgpKQorICAgIGlmICghaGFzRGljdGlvbmFyeSgpKQogICAgICAgICByZXR1 cm4gZ3Vlc3NlczsKIAogICAgIGZvciAoVmVjdG9yPEVuY2hhbnREaWN0Kj46OmNvbnN0X2l0ZXJh dG9yIGl0ZXIgPSBtX2VuY2hhbnREaWN0aW9uYXJpZXMuYmVnaW4oKTsgaXRlciAhPSBtX2VuY2hh bnREaWN0aW9uYXJpZXMuZW5kKCk7ICsraXRlcikgewpAQCAtMTgwLDcgKzE4MCw3IEBAIHZvaWQg VGV4dENoZWNrZXJFbmNoYW50Ojp1cGRhdGVTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKGNvbnN0IFZl Y3RvcjxTdHJpbmc+JiBsYW5nCiBWZWN0b3I8U3RyaW5nPiBUZXh0Q2hlY2tlckVuY2hhbnQ6Omxv YWRlZFNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMoKSBjb25zdAogewogICAgIFZlY3RvcjxTdHJpbmc+ IGxhbmd1YWdlczsKLSAgICBpZiAobV9lbmNoYW50RGljdGlvbmFyaWVzLmlzRW1wdHkoKSkKKyAg ICBpZiAoIWhhc0RpY3Rpb25hcnkoKSkKICAgICAgICAgcmV0dXJuIGxhbmd1YWdlczsKIAogICAg IC8vIEdldCBhIFZlY3RvcjxDU3RyaW5nPiB3aXRoIHRoZSBsaXN0IG9mIGxhbmd1YWdlcyBpbiB1 c2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2VuY2hhbnQvVGV4 dENoZWNrZXJFbmNoYW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2VuY2hhbnQv VGV4dENoZWNrZXJFbmNoYW50LmgKaW5kZXggNzg3ZjhiZi4uMGZlMmNhYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9lbmNoYW50L1RleHRDaGVja2VyRW5jaGFudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVu Y2hhbnQuaApAQCAtNDMsNiArNDMsNyBAQCBwdWJsaWM6CiAgICAgVmVjdG9yPFN0cmluZz4gZ2V0 R3Vlc3Nlc0ZvcldvcmQoY29uc3QgU3RyaW5nJik7CiAgICAgdm9pZCB1cGRhdGVTcGVsbENoZWNr aW5nTGFuZ3VhZ2VzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBsYW5ndWFnZXMpOwogICAgIFZlY3Rv cjxTdHJpbmc+IGxvYWRlZFNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMoKSBjb25zdDsKKyAgICBib29s IGhhc0RpY3Rpb25hcnkoKSBjb25zdCB7IHJldHVybiAhbV9lbmNoYW50RGljdGlvbmFyaWVzLmlz RW1wdHkoKTsgfQogICAgIFZlY3RvcjxTdHJpbmc+IGF2YWlsYWJsZVNwZWxsQ2hlY2tpbmdMYW5n dWFnZXMoKSBjb25zdDsKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBlM2MxYmRmLi4zZTc5MGU2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTItMTEtMDcgIEdyemVnb3J6IEN6YWpr b3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW0VGTF0gQWRkIGEg bWV0aG9kIHRvIHRoZSBUZXh0Q2hlY2tlckVuY2hhbnQgY2xhc3MgdG8gY2hlY2sgd2hldGhlciBh bnkgZGljdGlvbmFyeSBpcyBsb2FkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMTU3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRvIGRvIG5vdCBnZXQgdGhlIHZlY3RvciBvZiBsb2FkZWQgbGFuZ3Vh Z2VzLCBXZWJLaXQyLUVGTCBjYWxscworICAgICAgICBUZXh0Q2hlY2tlckVuY2hhbnQ6Omhhc0Rp Y3Rpb25hcnkoKSBtZXRob2QgdG8gY2hlY2sgd2hldGhlciB0aGUKKyAgICAgICAgZGljdGlvbmFy aWVzIHZlY3RvciBpcyBlbXB0eS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a19z ZXR0aW5ncy5jcHA6CisgICAgICAgIChld2tfc2V0dGluZ3NfY29udGludW91c19zcGVsbF9jaGVj a2luZ19lbmFibGVkX3NldCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRf Y2hlY2tlci5jcHA6CisgICAgICAgIChFd2tfVGV4dF9DaGVja2VyOjpoYXNEaWN0aW9uYXJ5KToK KyAgICAgICAgKEV3a19UZXh0X0NoZWNrZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZs L2V3a190ZXh0X2NoZWNrZXJfcHJpdmF0ZS5oOgorICAgICAgICAoRXdrX1RleHRfQ2hlY2tlcik6 CisKKzIwMTItMTEtMDcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKICAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBuZWVkcyB0byB0dXJuIG9uICdzZXRD b250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQnCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzYxMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3MuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3NldHRpbmdzLmNwcAppbmRleCAwYjUwODNmLi40OTlmNDI0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfc2V0dGluZ3Mu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19zZXR0aW5ncy5j cHAKQEAgLTIyNSw3ICsyMjUsNyBAQCB2b2lkIGV3a19zZXR0aW5nc19jb250aW51b3VzX3NwZWxs X2NoZWNraW5nX2VuYWJsZWRfc2V0KEVpbmFfQm9vbCBlbmFibGUpCiAgICAgICAgIFdLVGV4dENo ZWNrZXJDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWRTdGF0ZUNoYW5nZWQoZW5hYmxlKTsK IAogICAgICAgICAvLyBTZXRzIHRoZSBkZWZhdWx0IGxhbmd1YWdlIGlmIHVzZXIgZGlkbid0IHNw ZWNpZnkgYW55LgotICAgICAgICBpZiAoZW5hYmxlICYmIEV3a19UZXh0X0NoZWNrZXI6OmxvYWRl ZFNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMoKS5pc0VtcHR5KCkpCisgICAgICAgIGlmIChlbmFibGUg JiYgIUV3a19UZXh0X0NoZWNrZXI6Omhhc0RpY3Rpb25hcnkoKSkKICAgICAgICAgICAgIHNwZWxs Q2hlY2tpbmdMYW5ndWFnZXNTZXQoVmVjdG9yPFN0cmluZz4oKSk7CiAKICAgICAgICAgaWYgKGV3 a1RleHRDaGVja2VyU2V0dGluZ3Mub25Db250aW51b3VzU3BlbGxDaGVja2luZykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a190ZXh0X2NoZWNrZXIuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAK aW5kZXggZTE1YjhmYy4uY2U1NDZkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlci5jcHAKQEAgLTE2Miw2ICsxNjIsMTEgQEAg VmVjdG9yPFN0cmluZz4gbG9hZGVkU3BlbGxDaGVja2luZ0xhbmd1YWdlcygpCiAgICAgcmV0dXJu IHRleHRDaGVja2VyRW5jaGFudCgpLT5sb2FkZWRTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKCk7CiB9 CiAKK2Jvb2wgaGFzRGljdGlvbmFyeSgpCit7CisgICAgcmV0dXJuIHRleHRDaGVja2VyRW5jaGFu dCgpLT5oYXNEaWN0aW9uYXJ5KCk7Cit9CisKIC8qKgogICogSW5pdGlhbGl6ZXMgc3BlbGxjaGVj ayBmZWF0dXJlLgogICoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a190ZXh0X2NoZWNrZXJfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3RleHRfY2hlY2tlcl9wcml2YXRlLmgKaW5kZXggNDYyZDMxNC4uNmM0NzMw ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3RleHRf Y2hlY2tlcl9wcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3RleHRfY2hlY2tlcl9wcml2YXRlLmgKQEAgLTM5LDYgKzM5LDcgQEAgdm9pZCBpbml0aWFs aXplKCk7CiBWZWN0b3I8U3RyaW5nPiBhdmFpbGFibGVTcGVsbENoZWNraW5nTGFuZ3VhZ2VzKCk7 CiB2b2lkIHVwZGF0ZVNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMoY29uc3QgVmVjdG9yPFN0cmluZz4m IGxhbmd1YWdlcyk7CiBWZWN0b3I8U3RyaW5nPiBsb2FkZWRTcGVsbENoZWNraW5nTGFuZ3VhZ2Vz KCk7Citib29sIGhhc0RpY3Rpb25hcnkoKTsKIAogfQogCg==