101568 2012-11-08 02:33:54 -0800 [BlackBerry] need to call closePopup at setValueAndClosePopup 2012-11-08 20:16:03 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 logingx webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 761512 0 logingx 2012-11-08 02:33:54 -0800 When early return occurs, we need to call closePopup function. 761551 1 172981 logingx 2012-11-08 03:09:14 -0800 Created attachment 172981 Patch 761651 2 172981 mifenton 2012-11-08 04:41:35 -0800 Comment on attachment 172981 Patch Looks good to me, Rob? 761772 3 172981 rwlbuis 2012-11-08 07:31:27 -0800 Comment on attachment 172981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172981&action=review Code looks good but ChangeLog should be better. > Source/WebKit/blackberry/ChangeLog:10 > + Internally reviewed by Charles Wei. Please also state PR and internal reviewer. I think the description could be better, since in the PR it states there is a freeze/crash which I can't see in this description. 762380 4 173161 logingx 2012-11-08 17:48:52 -0800 Created attachment 173161 Patch 762479 5 173161 webkit.review.bot 2012-11-08 20:16:00 -0800 Comment on attachment 173161 Patch Clearing flags on attachment: 173161 Committed r133999: <http://trac.webkit.org/changeset/133999> 762480 6 webkit.review.bot 2012-11-08 20:16:03 -0800 All reviewed patches have been landed. Closing bug. 172981 2012-11-08 03:09:14 -0800 2012-11-08 17:48:43 -0800 Patch bug-101568-20121108190722.patch text/plain 1869 logingx U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5ZmRlOGFmOGZmYThhYmZiMWE1MjI3ZWIwODBkYjk3ZmJlN2JhMDFhLi43ZTNiOTQyM2U1 MjNjZjM3M2E2NjQ5OWFjZWMwMmQ4NTVlOGFmZjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMS0wOCAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1 YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBuZWVkIHRvIGNh bGwgY2xvc2VQb3B1cCBhdCBzZXRWYWx1ZUFuZENsb3NlUG9wdXAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU2OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gZWFybHkgcmV0dXJuIG9jY3Vycywg d2UgbmVlZCB0byBjYWxsIGNsb3NlUG9wdXAKKyAgICAgICAgYXQgc2V0VmFsdWVBbmRDbG9zZVBv cHVwIGZ1bmN0aW9uLgorICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IENoYXJsZXMgV2Vp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0IGNhc2UsIHNpbmNlIG5vIGJlaGF2aW9yIGNoYW5nZWQu CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U2VsZWN0UG9wdXBDbGllbnQ6OnNldFZhbHVlQW5kQ2xvc2VQb3B1cCk6CisK IDIwMTItMTEtMDcgIFJvYiBCdWlzICA8cmJ1aXNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gUmVtb3ZlIHNldFVzZXJTdHlsZVNoZWV0U3RyaW5nL3VzZXJTdHlsZVNoZWV0U3RyaW5n CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2Vs ZWN0UG9wdXBDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBw b3J0L1NlbGVjdFBvcHVwQ2xpZW50LmNwcAppbmRleCBiMzdiNWU2Njg1NDM5MWYxMzg5MDcyNzA0 MmE0N2UzZDdhMGQxYjAxLi5iMWFmNmZhNjM4ZDM3NTdkYmE1MzZhNzc3NjBlYzJjNDBkNGM1NGMz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2Vs ZWN0UG9wdXBDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9TZWxlY3RQb3B1cENsaWVudC5jcHAKQEAgLTE3Myw4ICsxNzMsMTEgQEAgdm9pZCBT ZWxlY3RQb3B1cENsaWVudDo6c2V0VmFsdWVBbmRDbG9zZVBvcHVwKGludCwgY29uc3QgU3RyaW5n JiBzdHJpbmdWYWx1ZSkKIAogICAgICAgICBjb25zdCBWZWN0b3I8SFRNTEVsZW1lbnQqPiYgaXRl bXMgPSBtX2VsZW1lbnQtPmxpc3RJdGVtcygpOwogCi0gICAgICAgIGlmIChpdGVtcy5zaXplKCkg IT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQgaW50PihtX3NpemUpKQorICAgICAgICAvLyBJZiBlbGVt ZW50IGNoYW5nZWQgYWZ0ZXIgc2VsZWN0IFVJIHNob3dlZCwgZG8gbm90aGluZyBidXQgY2xvc2VQ b3B1cCgpLgorICAgICAgICBpZiAoaXRlbXMuc2l6ZSgpICE9IHN0YXRpY19jYXN0PHVuc2lnbmVk PihtX3NpemUpKSB7CisgICAgICAgICAgICBjbG9zZVBvcHVwKCk7CiAgICAgICAgICAgICByZXR1 cm47CisgICAgICAgIH0KIAogICAgICAgICBIVE1MT3B0aW9uRWxlbWVudCogb3B0aW9uOwogICAg ICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9zaXplOyBpKyspIHsK 173161 2012-11-08 17:48:52 -0800 2012-11-08 20:15:59 -0800 Patch bug-101568-20121109094659.patch text/plain 2031 logingx U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzOTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3ZTcwN2M2M2JhNDczZmRhMGI4ZGQzYzE4OGMxMzM1OWIwNDhlOWMyLi4xNzdjYWU2NTA2 NjJiZDEyMjk0NmExYTBhOTNhN2U3MmFiM2FhYmU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMS0wOCAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1 YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBuZWVkIHRvIGNh bGwgY2xvc2VQb3B1cCBhdCBzZXRWYWx1ZUFuZENsb3NlUG9wdXAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU2OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gZWFybHkgcmV0dXJuIG9jY3Vycywg d2UgbmVlZCB0byBjYWxsIGNsb3NlUG9wdXAKKyAgICAgICAgYXQgc2V0VmFsdWVBbmRDbG9zZVBv cHVwIGZ1bmN0aW9uLiBTZWUgdGhlIGNvbW1lbnRzCisgICAgICAgIGluIFdlYkNvcmUvcGFnZS9Q YWdlUG9wdXBDbGllbnQuaC4gSWYgd2UgaGF2ZSBub3QgaXQsCisgICAgICAgIFdlYmtpdCB0aHJl YWQgaXMgaGVsZCBhbmQgYnJvd3NlciB3aWxsIGJlIHVucmVzcG9uc2l2ZSAKKyAgICAgICAgaW4g QmxhY2tCZXJyeSBwb3J0LgorICAgICAgICAKKyAgICAgICAgUklNIFBSIDIzMjk2MgorICAgICAg ICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IENoYXJsZXMgV2VpLgorCisgICAgICAgICogV2ViQ29y ZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0 UG9wdXBDbGllbnQ6OnNldFZhbHVlQW5kQ2xvc2VQb3B1cCk6CisKIDIwMTItMTEtMDggIEpha29i IFBldHNvdml0cyAgPGpwZXRzb3ZpdHNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0g UmVwbGFjZSBjaGVja2VyYm9hcmQgd2l0aCBwYWdlIGJhY2tncm91bmQgY29sb3IuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBD bGllbnQuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1NlbGVj dFBvcHVwQ2xpZW50LmNwcAppbmRleCBiMzdiNWU2Njg1NDM5MWYxMzg5MDcyNzA0MmE0N2UzZDdh MGQxYjAxLi5iMWFmNmZhNjM4ZDM3NTdkYmE1MzZhNzc3NjBlYzJjNDBkNGM1NGMzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBD bGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9T ZWxlY3RQb3B1cENsaWVudC5jcHAKQEAgLTE3Myw4ICsxNzMsMTEgQEAgdm9pZCBTZWxlY3RQb3B1 cENsaWVudDo6c2V0VmFsdWVBbmRDbG9zZVBvcHVwKGludCwgY29uc3QgU3RyaW5nJiBzdHJpbmdW YWx1ZSkKIAogICAgICAgICBjb25zdCBWZWN0b3I8SFRNTEVsZW1lbnQqPiYgaXRlbXMgPSBtX2Vs ZW1lbnQtPmxpc3RJdGVtcygpOwogCi0gICAgICAgIGlmIChpdGVtcy5zaXplKCkgIT0gc3RhdGlj X2Nhc3Q8dW5zaWduZWQgaW50PihtX3NpemUpKQorICAgICAgICAvLyBJZiBlbGVtZW50IGNoYW5n ZWQgYWZ0ZXIgc2VsZWN0IFVJIHNob3dlZCwgZG8gbm90aGluZyBidXQgY2xvc2VQb3B1cCgpLgor ICAgICAgICBpZiAoaXRlbXMuc2l6ZSgpICE9IHN0YXRpY19jYXN0PHVuc2lnbmVkPihtX3NpemUp KSB7CisgICAgICAgICAgICBjbG9zZVBvcHVwKCk7CiAgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0KIAogICAgICAgICBIVE1MT3B0aW9uRWxlbWVudCogb3B0aW9uOwogICAgICAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9zaXplOyBpKyspIHsK