101567 2012-11-08 02:25:05 -0800 [EFL][WK2] Use explicit constructor in BatteryProvider, DownloadManagerEfl, NetworkInfoProvider 2012-11-08 03:56:14 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 761502 0 jinwoo7.song 2012-11-08 02:25:05 -0800 Added explicit keyword in constructors of BatteryProvider, DownloadManagerEfl, and NetworkInfoProvider in order to avoid implicit type conversion. 761507 1 172968 jinwoo7.song 2012-11-08 02:26:58 -0800 Created attachment 172968 Patch 761508 2 172968 haraken 2012-11-08 02:29:51 -0800 Comment on attachment 172968 Patch OK 761613 3 172968 webkit.review.bot 2012-11-08 03:56:08 -0800 Comment on attachment 172968 Patch Clearing flags on attachment: 172968 Committed r133879: <http://trac.webkit.org/changeset/133879> 761614 4 webkit.review.bot 2012-11-08 03:56:14 -0800 All reviewed patches have been landed. Closing bug. 172968 2012-11-08 02:26:58 -0800 2012-11-08 03:56:08 -0800 Patch bug-101567-20121108192502.patch text/plain 2877 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTZkMDM2ZTE3NWU1ZDkw MDY5OGZkZjkxNTc0MTg5ZmMxOWQwNTQxMS4uZGQ3MjdlNzgyYzEwNWE3OTZmMmRmZmI4ZGU1MjU5 NGRiZjVhMzllNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTA4ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IFVzZSBleHBsaWNpdCBjb25zdHJ1Y3RvciBpbiBCYXR0ZXJ5UHJvdmlkZXIsIERvd25sb2FkTWFu YWdlckVmbCwgTmV0d29ya0luZm9Qcm92aWRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNTY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgZXhwbGljaXQga2V5d29yZCBpbiBjb25zdHJ1Y3Rv cnMgb2YgQmF0dGVyeVByb3ZpZGVyLCBEb3dubG9hZE1hbmFnZXJFZmwsCisgICAgICAgIGFuZCBO ZXR3b3JrSW5mb1Byb3ZpZGVyIGluIG9yZGVyIHRvIGF2b2lkIGltcGxpY2l0IHR5cGUgY29udmVy c2lvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvQmF0dGVyeVByb3ZpZGVyLmg6CisgICAg ICAgIChCYXR0ZXJ5UHJvdmlkZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvRG93bmxvYWRN YW5hZ2VyRWZsLmg6CisgICAgICAgIChEb3dubG9hZE1hbmFnZXJFZmwpOgorICAgICAgICAqIFVJ UHJvY2Vzcy9lZmwvTmV0d29ya0luZm9Qcm92aWRlci5oOgorICAgICAgICAoTmV0d29ya0luZm9Q cm92aWRlcik6CisKIDIwMTItMTEtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYktpdFdlYlZpZXcgZG9lc24ndCBub3RpZnkg b2YgZmF2aWNvbiBjaGFuZ2VzIGZvciBrbm93biBmYXZpY29ucyBidXQgbmV3IHBhZ2VzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL0JhdHRlcnlQcm92aWRlci5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9CYXR0ZXJ5UHJvdmlkZXIuaAppbmRleCBiODI5 ZDdlZDViYzZhYmY0MTgwYTQxZTFjOTYzNzQ5YTIzM2I4OTNmLi45MTJmNjBlN2MxZTlmNDMyZDgx YWVlZjBiZTk5MzliYzE3MjViNjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvZWZsL0JhdHRlcnlQcm92aWRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9l ZmwvQmF0dGVyeVByb3ZpZGVyLmgKQEAgLTQ2LDcgKzQ2LDcgQEAgcHVibGljOgogICAgIHZvaWQg c3RvcFVwZGF0aW5nKCk7CiAKIHByaXZhdGU6Ci0gICAgQmF0dGVyeVByb3ZpZGVyKFdLQ29udGV4 dFJlZik7CisgICAgZXhwbGljaXQgQmF0dGVyeVByb3ZpZGVyKFdLQ29udGV4dFJlZik7CiAKICAg ICAvLyBCYXR0ZXJ5UHJvdmlkZXJFZmxDbGllbnQgaW50ZXJmYWNlLgogICAgIHZpcnR1YWwgdm9p ZCBkaWRDaGFuZ2VCYXR0ZXJ5U3RhdHVzKGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBQ YXNzUmVmUHRyPFdlYkNvcmU6OkJhdHRlcnlTdGF0dXM+KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9lZmwvRG93bmxvYWRNYW5hZ2VyRWZsLmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZWZsL0Rvd25sb2FkTWFuYWdlckVmbC5oCmluZGV4IGRmYzYyN2E2MjdlZTJk NGFlOWNlZDRlNDdkZTMyYTliMjljZjhmZDUuLjc3NTE2NDI4Yjk1YjJkYzQ2MTZjZmU1MjE4MzRl OGEyOTA0YjY0NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvRG93 bmxvYWRNYW5hZ2VyRWZsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9Eb3du bG9hZE1hbmFnZXJFZmwuaApAQCAtNDYsNyArNDYsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCByZWdp c3RlckRvd25sb2FkKERvd25sb2FkUHJveHkqLCBFd2tWaWV3SW1wbCopOwogCiBwcml2YXRlOgot ICAgIERvd25sb2FkTWFuYWdlckVmbChFd2tDb250ZXh0Kik7CisgICAgZXhwbGljaXQgRG93bmxv YWRNYW5hZ2VyRWZsKEV3a0NvbnRleHQqKTsKIAogICAgIEV3a0Rvd25sb2FkSm9iKiBkb3dubG9h ZEpvYih1aW50NjRfdCBpZCkgY29uc3Q7CiAgICAgdm9pZCB1bnJlZ2lzdGVyRG93bmxvYWRKb2Io dWludDY0X3QgaWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9O ZXR3b3JrSW5mb1Byb3ZpZGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL05ldHdv cmtJbmZvUHJvdmlkZXIuaAppbmRleCA1NzYzMTE5M2Y3NmZmMzExNjgyN2YyYzhmNjBjMjg5NmIz NWZkMmQ2Li43OTBhMDI3NGJiMjhkNzA2ZjZiM2RhM2JiMzc2ZTRlZTU0ZTRiNzYyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL05ldHdvcmtJbmZvUHJvdmlkZXIuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL05ldHdvcmtJbmZvUHJvdmlkZXIuaApA QCAtNDksNyArNDksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHN0b3BVcGRhdGluZygp OwogCiBwcml2YXRlOgotICAgIE5ldHdvcmtJbmZvUHJvdmlkZXIoV0tDb250ZXh0UmVmKTsKKyAg ICBleHBsaWNpdCBOZXR3b3JrSW5mb1Byb3ZpZGVyKFdLQ29udGV4dFJlZik7CiAKICAgICBXS1Jl dGFpblB0cjxXS0NvbnRleHRSZWY+IG1fd2tDb250ZXh0OwogICAgIFdlYkNvcmU6Ok5ldHdvcmtJ bmZvUHJvdmlkZXJFZmwgbV9wcm92aWRlcjsK