101566 2012-11-08 02:05:05 -0800 [EFL] about:blank should display the blank page 2012-11-08 22:39:52 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez gyuyoung.kim kangil.han lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 761494 0 naginenis 2012-11-08 02:05:05 -0800 about:blank should display the blank page in MiniBrowser/EWebLauncher instead of showing an error page with http://about:blank. 761515 1 172970 naginenis 2012-11-08 02:36:41 -0800 Created attachment 172970 Patch 761696 2 172970 laszlo.gombos 2012-11-08 05:51:45 -0800 Comment on attachment 172970 Patch r=me. 761797 3 172970 cdumez 2012-11-08 07:49:05 -0800 Comment on attachment 172970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172970&action=review > Tools/EWebLauncher/url_utils.c:42 > + if (has_scheme(arg) || !strcasecmp(arg, "about:blank")) Why case sensitive? 761810 4 cdumez 2012-11-08 08:09:28 -0800 (In reply to comment #3) > (From update of attachment 172970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172970&action=review > > > Tools/EWebLauncher/url_utils.c:42 > > + if (has_scheme(arg) || !strcasecmp(arg, "about:blank")) > > Why case sensitive? Please disregard my comment. I misread. 761890 5 172970 webkit.review.bot 2012-11-08 09:45:36 -0800 Comment on attachment 172970 Patch Rejecting attachment 172970 from commit-queue. New failing tests: fast/repaint/selection-after-delete.html Full output: http://queues.webkit.org/results/14765548 762381 6 kangil.han 2012-11-08 17:50:17 -0800 (In reply to comment #5) > (From update of attachment 172970 [details]) > Rejecting attachment 172970 [details] from commit-queue. > > New failing tests: > fast/repaint/selection-after-delete.html > Full output: http://queues.webkit.org/results/14765548 I don't understand this failing. babu just touches EWebLauncher. :) Would someone please try cq+ again? 762574 7 172970 ryuan.choi 2012-11-08 22:30:46 -0800 Comment on attachment 172970 Patch I will, let's try once more. 762580 8 172970 webkit.review.bot 2012-11-08 22:39:48 -0800 Comment on attachment 172970 Patch Clearing flags on attachment: 172970 Committed r134013: <http://trac.webkit.org/changeset/134013> 762581 9 webkit.review.bot 2012-11-08 22:39:52 -0800 All reviewed patches have been landed. Closing bug. 172970 2012-11-08 02:36:41 -0800 2012-11-08 22:39:48 -0800 Patch 101566.patch text/plain 1160 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiMjMy ODJhLi5lYzhkZDhjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTEtMDggIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gYWJvdXQ6Ymxh bmsgc2hvdWxkIGRpc3BsYXkgdGhlIGJsYW5rIHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTU2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNoZWNrIHRvIHJldHVybiBlYXJseSB3aXRo b3V0IHByZXBlbmRpbmcgaHR0cDovLyBzY2hlbWUsIGlmIHRoZQorICAgICAgICBVUkwgaXMgJ2Fi b3V0OmJsYW5rJy4KKworICAgICAgICAqIEVXZWJMYXVuY2hlci91cmxfdXRpbHMuYzoKKyAgICAg ICAgKHVybF9mcm9tX3VzZXJfaW5wdXQpOgorCiAyMDEyLTExLTA4ICBZYWVsIEFoYXJvbiAgPHlh ZWwuYWhhcm9uQGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBUdXJuIG9uIFdURl9VU0VfVElM RURfQkFDS0lOR19TVE9SRSBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Ub29scy9FV2ViTGF1bmNo ZXIvdXJsX3V0aWxzLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvdXJsX3V0aWxzLmMKaW5kZXggZmQ5 MmYxNC4uZDhjZjdjYiAxMDA2NDQKLS0tIGEvVG9vbHMvRVdlYkxhdW5jaGVyL3VybF91dGlscy5j CisrKyBiL1Rvb2xzL0VXZWJMYXVuY2hlci91cmxfdXRpbHMuYwpAQCAtMzksNyArMzksNyBAQCBj aGFyICoKIHVybF9mcm9tX3VzZXJfaW5wdXQoY29uc3QgY2hhciAqYXJnKQogewogICAgIC8qIElm IGl0IGlzIGFscmVhZHkgYSBVUkwsIHJldHVybiB0aGUgYXJndW1lbnQgYXMgaXMuICovCi0gICAg aWYgKGhhc19zY2hlbWUoYXJnKSkKKyAgICBpZiAoaGFzX3NjaGVtZShhcmcpIHx8ICFzdHJjYXNl Y21wKGFyZywgImFib3V0OmJsYW5rIikpCiAgICAgICAgIHJldHVybiBzdHJkdXAoYXJnKTsKIAog ICAgIEVpbmFfU3RyYnVmICpidWYgPSBlaW5hX3N0cmJ1Zl9tYW5hZ2VfbmV3KGVpbmFfZmlsZV9w YXRoX3Nhbml0aXplKGFyZykpOwo=