101549 2012-11-07 23:18:57 -0800 [EFL][WK2][AC] Fixed layers are shaking when scrolling 2012-11-09 12:30:42 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 hurnjoo.lee webkit-unassigned gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco webkit.review.bot yael oldest_to_newest 761371 0 hurnjoo.lee 2012-11-07 23:18:57 -0800 At the time of adjusting positions for fixed layers, the locations of fixed layers are calculated incorrectly because the contentsSize is empty. 761375 1 172936 hurnjoo.lee 2012-11-07 23:25:47 -0800 Created attachment 172936 proposed patch 761714 2 172936 webkit.review.bot 2012-11-08 06:03:26 -0800 Comment on attachment 172936 proposed patch Rejecting attachment 172936 from commit-queue. New failing tests: fast/repaint/selection-after-delete.html Full output: http://queues.webkit.org/results/14771173 761736 3 172936 yael 2012-11-08 06:46:16 -0800 Comment on attachment 172936 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172936&action=review > Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp:83 > + drawingArea()->layerTreeCoordinatorProxy()->setContentsSize(contentsSize); Isn't PageViewportController already setting the contentsSize? Per https://bugs.webkit.org/show_bug.cgi?id=99850#c7 the viewport client should not be calling this explicitly. 762102 4 yael 2012-11-08 13:16:09 -0800 (In reply to comment #0) > At the time of adjusting positions for fixed layers, the locations of > fixed layers are calculated incorrectly because the contentsSize is empty. Do you have a test case for this? I'd like to take a look at this. Thanks. 762496 5 hurnjoo.lee 2012-11-08 20:44:12 -0800 (In reply to comment #3) > (From update of attachment 172936 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172936&action=review > > > Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp:83 > > + drawingArea()->layerTreeCoordinatorProxy()->setContentsSize(contentsSize); > > Isn't PageViewportController already setting the contentsSize? > Per https://bugs.webkit.org/show_bug.cgi?id=99850#c7 the viewport client should not be calling this explicitly. Yes, PageViewportController is setting its own the contentSize already but LayerTreeRenderer's contentsSize is never set. In Qt port, set LayerTreeRenderer's contentsSize at PageViewportControllerClientQt::didChangeContentsSize. 762506 6 173190 hurnjoo.lee 2012-11-08 20:58:26 -0800 Created attachment 173190 test case 762509 7 hurnjoo.lee 2012-11-08 21:02:14 -0800 (In reply to comment #4) > (In reply to comment #0) > > At the time of adjusting positions for fixed layers, the locations of > > fixed layers are calculated incorrectly because the contentsSize is empty. > > Do you have a test case for this? I'd like to take a look at this. > Thanks. I've attached test case. Also you can test on sites. http://jquerymobile.com/demos/1.1.0/docs/toolbars/bars-fixed.html http://www.noobcube.com/wp-content/uploads/demos/062709-fixed-header-footer/demo/ 763192 8 172936 yael 2012-11-09 11:30:38 -0800 Comment on attachment 172936 proposed patch Sorry it took me so long to get to this. You are right, in the Qt port the same call is being made indirectly. I'll try to cq the patch because the ews error did not seem related to your change. 763236 9 172936 webkit.review.bot 2012-11-09 12:30:38 -0800 Comment on attachment 172936 proposed patch Clearing flags on attachment: 172936 Committed r134098: <http://trac.webkit.org/changeset/134098> 763237 10 webkit.review.bot 2012-11-09 12:30:42 -0800 All reviewed patches have been landed. Closing bug. 172936 2012-11-07 23:25:47 -0800 2012-11-09 12:30:38 -0800 proposed patch 101549.patch text/plain 1751 hurnjoo.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwOTUxZWZiLi4wNjU3ZjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTEtMDcgIEh1cm5qb28gTGVlICA8aHVybmpvby5sZWVAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF1bV0syXVtBQ10gRml4ZWQgbGF5ZXJzIGFyZSBzaGFraW5nIHdoZW4gc2Ny b2xsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDE1NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB dCB0aGUgdGltZSBvZiBhZGp1c3RpbmcgcG9zaXRpb25zIGZvciBmaXhlZCBsYXllcnMsIHRoZSBs b2NhdGlvbnMgb2YKKyAgICAgICAgZml4ZWQgbGF5ZXJzIGFyZSBjYWxjdWxhdGVkIGluY29ycmVj dGx5IGJlY2F1c2UgdGhlIGNvbnRlbnRzU2l6ZSBpcyBlbXB0eS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9lZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmw6OmRpZENoYW5nZUNvbnRlbnRz U2l6ZSk6IENhbGwgdGhlCisgICAgICAgIHNldENvbnRlbnRzU2l6ZSBmdW5jdGlvbiBpbiBMYXll clRyZWVDb29yZGluYXRvclByb3h5IGluIG9yZGVyIHRvIGNhbGN1bGF0ZQorICAgICAgICB0aGUg bG9jYXRpb25zIG9mIGZpeGVkIGxheWVycyBjb3JyZWN0bHkuCisKIDIwMTItMTEtMDcgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIxMzM4NDEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvZWZsL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsLmNwcApp bmRleCA2NTAwNmMyLi5iYTg5ZTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvZWZsL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbC5jcHAK QEAgLTc4LDggKzc4LDkgQEAgdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsOjpz ZXRWaXNpYmxlQ29udGVudHNSZWN0KGNvbnN0IEludFBvaW50JiBuZXcKICAgICBtX2NvbnRyb2xs ZXItPmRpZENoYW5nZUNvbnRlbnRzVmlzaWJpbGl0eShtX3Njcm9sbFBvc2l0aW9uLCBtX3NjYWxl RmFjdG9yLCB0cmFqZWN0b3J5KTsKIH0KIAotdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xp ZW50RWZsOjpkaWRDaGFuZ2VDb250ZW50c1NpemUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYpCit2 b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmw6OmRpZENoYW5nZUNvbnRlbnRzU2l6 ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBjb250ZW50c1NpemUpCiB7CisgICAgZHJhd2luZ0Fy ZWEoKS0+bGF5ZXJUcmVlQ29vcmRpbmF0b3JQcm94eSgpLT5zZXRDb250ZW50c1NpemUoY29udGVu dHNTaXplKTsKICAgICBtX3ZpZXdJbXBsLT51cGRhdGUoKTsKIH0KIAo= 173190 2012-11-08 20:58:26 -0800 2012-11-08 20:58:26 -0800 test case fixed_test.html text/html 279 hurnjoo.lee PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCjxzdHlsZT4NCmJvZHkgew0KICB3aWR0aDoxMjgwcHg7 DQogIGhlaWdodDozMDAwcHg7DQp9DQojdGVzdGRpdiB7DQogIHdpZHRoOjEwMCU7DQogIGhlaWdo dDoxMzZweDsNCglwb3NpdGlvbjpmaXhlZDsNCgliYWNrZ3JvdW5kLWNvbG9yOmJsdWU7DQoJei1p bmRleDoxMDsNCgl0b3A6IDEwMHB4Ow0KCWxlZnQ6IDBweDsNCn0NCjwvc3R5bGU+DQo8Ym9keT4N CiAgPGRpdiBpZD0ndGVzdGRpdic+DQogIDwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K